All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Peter Rosin <peda@axentia.se>
Cc: linux-kernel@vger.kernel.org,
	Nicolas Ferre <nicolas.ferre@microchip.com>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Russell King <linux@armlinux.org.uk>,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 1/3] ARM: dts: at91: nattis: use up-to-date mtd partitions
Date: Tue, 16 Jan 2018 17:30:15 +0100	[thread overview]
Message-ID: <20180116163015.GG2678@piout.net> (raw)
In-Reply-To: <20180116160835.27943-2-peda@axentia.se>

Hi,

On 16/01/2018 at 17:08:33 +0100, Peter Rosin wrote:
> The nattis currently relies on the cmdline to correctly configure the
> MTD partition table, and the one given in the device tree is simply
> ignored. Which is fortunate, since the device tree partition table is
> bonkers and does not match reality.
> 

Shouldn't it be simply removed then?

> So, in order to avoid confusion, fix the device tree partition table
> to match what is expected (i.e. what is normally provided on the cmdline).
> In particular, the rootfs partition should be mtd6.
> 
> Fixes: 0e4323899973 ("ARM: dts: at91: add devicetree for the Axentia Nattis with Natte power")
> Signed-off-by: Peter Rosin <peda@axentia.se>
> ---
>  arch/arm/boot/dts/at91-nattis-2-natte-2.dts | 25 +++++++++++++++----------
>  1 file changed, 15 insertions(+), 10 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/at91-nattis-2-natte-2.dts b/arch/arm/boot/dts/at91-nattis-2-natte-2.dts
> index 3ea1d26e1c68..4882bd6d38c1 100644
> --- a/arch/arm/boot/dts/at91-nattis-2-natte-2.dts
> +++ b/arch/arm/boot/dts/at91-nattis-2-natte-2.dts
> @@ -216,24 +216,29 @@
>  			reg = <0x0 0x40000>;
>  		};
>  
> -		bootloader@40000 {
> -			label = "bootloader";
> -			reg = <0x40000 0x80000>;
> +		barebox@40000 {
> +			label = "barebox";
> +			reg = <0x40000 0x60000>;
>  		};
>  
> -		bootloaderenv@c0000 {
> -			label = "bootloader env";
> -			reg = <0xc0000 0xc0000>;
> +		bareboxenv@c0000 {
> +			label = "bareboxenv";
> +			reg = <0xc0000 0x40000>;
>  		};
>  
> -		dtb@180000 {
> -			label = "device tree";
> -			reg = <0x180000 0x80000>;
> +		bareboxenv2@100000 {
> +			label = "bareboxenv2";
> +			reg = <0x100000 0x40000>;
> +		};
> +
> +		oftree@180000 {
> +			label = "oftree";
> +			reg = <0x180000 0x20000>;
>  		};
>  
>  		kernel@200000 {
>  			label = "kernel";
> -			reg = <0x200000 0x600000>;
> +			reg = <0x200000 0x500000>;
>  		};
>  
>  		rootfs@800000 {
> -- 
> 2.11.0
> 

-- 
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

WARNING: multiple messages have this Message-ID (diff)
From: Alexandre Belloni <alexandre.belloni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
To: Peter Rosin <peda-koto5C5qi+TLoDKTGw+V6w@public.gmane.org>
Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Nicolas Ferre
	<nicolas.ferre-UWL1GkI3JZL3oGB3hsPCZA@public.gmane.org>,
	Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
	Russell King <linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org>,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 1/3] ARM: dts: at91: nattis: use up-to-date mtd partitions
Date: Tue, 16 Jan 2018 17:30:15 +0100	[thread overview]
Message-ID: <20180116163015.GG2678@piout.net> (raw)
In-Reply-To: <20180116160835.27943-2-peda-koto5C5qi+TLoDKTGw+V6w@public.gmane.org>

Hi,

On 16/01/2018 at 17:08:33 +0100, Peter Rosin wrote:
> The nattis currently relies on the cmdline to correctly configure the
> MTD partition table, and the one given in the device tree is simply
> ignored. Which is fortunate, since the device tree partition table is
> bonkers and does not match reality.
> 

Shouldn't it be simply removed then?

> So, in order to avoid confusion, fix the device tree partition table
> to match what is expected (i.e. what is normally provided on the cmdline).
> In particular, the rootfs partition should be mtd6.
> 
> Fixes: 0e4323899973 ("ARM: dts: at91: add devicetree for the Axentia Nattis with Natte power")
> Signed-off-by: Peter Rosin <peda-koto5C5qi+TLoDKTGw+V6w@public.gmane.org>
> ---
>  arch/arm/boot/dts/at91-nattis-2-natte-2.dts | 25 +++++++++++++++----------
>  1 file changed, 15 insertions(+), 10 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/at91-nattis-2-natte-2.dts b/arch/arm/boot/dts/at91-nattis-2-natte-2.dts
> index 3ea1d26e1c68..4882bd6d38c1 100644
> --- a/arch/arm/boot/dts/at91-nattis-2-natte-2.dts
> +++ b/arch/arm/boot/dts/at91-nattis-2-natte-2.dts
> @@ -216,24 +216,29 @@
>  			reg = <0x0 0x40000>;
>  		};
>  
> -		bootloader@40000 {
> -			label = "bootloader";
> -			reg = <0x40000 0x80000>;
> +		barebox@40000 {
> +			label = "barebox";
> +			reg = <0x40000 0x60000>;
>  		};
>  
> -		bootloaderenv@c0000 {
> -			label = "bootloader env";
> -			reg = <0xc0000 0xc0000>;
> +		bareboxenv@c0000 {
> +			label = "bareboxenv";
> +			reg = <0xc0000 0x40000>;
>  		};
>  
> -		dtb@180000 {
> -			label = "device tree";
> -			reg = <0x180000 0x80000>;
> +		bareboxenv2@100000 {
> +			label = "bareboxenv2";
> +			reg = <0x100000 0x40000>;
> +		};
> +
> +		oftree@180000 {
> +			label = "oftree";
> +			reg = <0x180000 0x20000>;
>  		};
>  
>  		kernel@200000 {
>  			label = "kernel";
> -			reg = <0x200000 0x600000>;
> +			reg = <0x200000 0x500000>;
>  		};
>  
>  		rootfs@800000 {
> -- 
> 2.11.0
> 

-- 
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2018-01-16 16:30 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-16 16:08 [PATCH 0/3] Device tree fixes for Axentia TSE-850 and Nattis Peter Rosin
2018-01-16 16:08 ` Peter Rosin
2018-01-16 16:08 ` [PATCH 1/3] ARM: dts: at91: nattis: use up-to-date mtd partitions Peter Rosin
2018-01-16 16:08   ` Peter Rosin
2018-01-16 16:30   ` Alexandre Belloni [this message]
2018-01-16 16:30     ` Alexandre Belloni
2018-01-16 22:17     ` Peter Rosin
2018-01-16 22:17       ` Peter Rosin
2018-01-16 16:08 ` [PATCH 2/3] ARM: dts: at91: nattis: add lvds-encoder Peter Rosin
2018-01-16 16:08 ` [PATCH 3/3] ARM: dts: at91: tse850: make the sound dai cell count explicit Peter Rosin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180116163015.GG2678@piout.net \
    --to=alexandre.belloni@free-electrons.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=mark.rutland@arm.com \
    --cc=nicolas.ferre@microchip.com \
    --cc=peda@axentia.se \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.