* Re: [PATCH for-4.15] ssb: Disable PCI host for PCI_DRIVERS_GENERIC
2018-01-15 21:17 [PATCH for-4.15] ssb: Disable PCI host for PCI_DRIVERS_GENERIC James Hogan
@ 2018-01-16 3:11 ` Guenter Roeck
2018-01-16 15:22 ` [for-4.15] " Kalle Valo
` (3 subsequent siblings)
4 siblings, 0 replies; 11+ messages in thread
From: Guenter Roeck @ 2018-01-16 3:11 UTC (permalink / raw)
To: James Hogan, Michael Buesch, linux-wireless, linux-mips, Ralf Baechle
Cc: Paul Burton, Matt Redfearn
On 01/15/2018 01:17 PM, James Hogan wrote:
> Since commit d41e6858ba58 ("MIPS: Kconfig: Set default MIPS system type
> as generic") changed the default MIPS platform to the "generic"
> platform, which uses PCI_DRIVERS_GENERIC instead of PCI_DRIVERS_LEGACY,
> various files in drivers/ssb/ have failed to build.
>
> This is particularly due to the existence of struct pci_controller being
> dependent on PCI_DRIVERS_LEGACY since commit c5611df96804 ("MIPS: PCI:
> Introduce CONFIG_PCI_DRIVERS_LEGACY"), so add that dependency to Kconfig
> to prevent these files being built for the "generic" platform including
> all{yes,mod}config builds.
>
> Fixes: c5611df96804 ("MIPS: PCI: Introduce CONFIG_PCI_DRIVERS_LEGACY")
> Signed-off-by: James Hogan <jhogan@kernel.org>
> Cc: Michael Buesch <m@bues.ch>
> Cc: Ralf Baechle <ralf@linux-mips.org>
> Cc: Paul Burton <paul.burton@mips.com>
> Cc: Matt Redfearn <matt.redfearn@imgtec.com>
> Cc: Guenter Roeck <linux@roeck-us.net>
> Cc: linux-wireless@vger.kernel.org
> Cc: linux-mips@linux-mips.org
Tested-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/ssb/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/ssb/Kconfig b/drivers/ssb/Kconfig
> index d8e4219c2324..71c73766ee22 100644
> --- a/drivers/ssb/Kconfig
> +++ b/drivers/ssb/Kconfig
> @@ -32,7 +32,7 @@ config SSB_BLOCKIO
>
> config SSB_PCIHOST_POSSIBLE
> bool
> - depends on SSB && (PCI = y || PCI = SSB)
> + depends on SSB && (PCI = y || PCI = SSB) && PCI_DRIVERS_LEGACY
> default y
>
> config SSB_PCIHOST
>
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [for-4.15] ssb: Disable PCI host for PCI_DRIVERS_GENERIC
2018-01-15 21:17 [PATCH for-4.15] ssb: Disable PCI host for PCI_DRIVERS_GENERIC James Hogan
2018-01-16 3:11 ` Guenter Roeck
@ 2018-01-16 15:22 ` Kalle Valo
2018-01-16 15:22 ` Kalle Valo
` (2 subsequent siblings)
4 siblings, 0 replies; 11+ messages in thread
From: Kalle Valo @ 2018-01-16 15:22 UTC (permalink / raw)
To: James Hogan
Cc: Michael Buesch, linux-wireless, linux-mips, Ralf Baechle,
James Hogan, Paul Burton, Matt Redfearn, Guenter Roeck
James Hogan <jhogan@kernel.org> wrote:
> Since commit d41e6858ba58 ("MIPS: Kconfig: Set default MIPS system type
> as generic") changed the default MIPS platform to the "generic"
> platform, which uses PCI_DRIVERS_GENERIC instead of PCI_DRIVERS_LEGACY,
> various files in drivers/ssb/ have failed to build.
>
> This is particularly due to the existence of struct pci_controller being
> dependent on PCI_DRIVERS_LEGACY since commit c5611df96804 ("MIPS: PCI:
> Introduce CONFIG_PCI_DRIVERS_LEGACY"), so add that dependency to Kconfig
> to prevent these files being built for the "generic" platform including
> all{yes,mod}config builds.
>
> Fixes: c5611df96804 ("MIPS: PCI: Introduce CONFIG_PCI_DRIVERS_LEGACY")
> Signed-off-by: James Hogan <jhogan@kernel.org>
> Cc: Michael Buesch <m@bues.ch>
> Cc: Ralf Baechle <ralf@linux-mips.org>
> Cc: Paul Burton <paul.burton@mips.com>
> Cc: Matt Redfearn <matt.redfearn@imgtec.com>
> Cc: Guenter Roeck <linux@roeck-us.net>
> Cc: linux-wireless@vger.kernel.org
> Cc: linux-mips@linux-mips.org
> Tested-by: Guenter Roeck <linux@roeck-us.net>
I'm planning to push this to 4.15 but not sure if there's enough time.
--
https://patchwork.kernel.org/patch/10165371/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [for-4.15] ssb: Disable PCI host for PCI_DRIVERS_GENERIC
@ 2018-01-16 15:22 ` Kalle Valo
0 siblings, 0 replies; 11+ messages in thread
From: Kalle Valo @ 2018-01-16 15:22 UTC (permalink / raw)
To: James Hogan
Cc: Michael Buesch, linux-wireless, linux-mips, Ralf Baechle,
James Hogan, Paul Burton, Matt Redfearn, Guenter Roeck
James Hogan <jhogan@kernel.org> wrote:
> Since commit d41e6858ba58 ("MIPS: Kconfig: Set default MIPS system type
> as generic") changed the default MIPS platform to the "generic"
> platform, which uses PCI_DRIVERS_GENERIC instead of PCI_DRIVERS_LEGACY,
> various files in drivers/ssb/ have failed to build.
>
> This is particularly due to the existence of struct pci_controller being
> dependent on PCI_DRIVERS_LEGACY since commit c5611df96804 ("MIPS: PCI:
> Introduce CONFIG_PCI_DRIVERS_LEGACY"), so add that dependency to Kconfig
> to prevent these files being built for the "generic" platform including
> all{yes,mod}config builds.
>
> Fixes: c5611df96804 ("MIPS: PCI: Introduce CONFIG_PCI_DRIVERS_LEGACY")
> Signed-off-by: James Hogan <jhogan@kernel.org>
> Cc: Michael Buesch <m@bues.ch>
> Cc: Ralf Baechle <ralf@linux-mips.org>
> Cc: Paul Burton <paul.burton@mips.com>
> Cc: Matt Redfearn <matt.redfearn@imgtec.com>
> Cc: Guenter Roeck <linux@roeck-us.net>
> Cc: linux-wireless@vger.kernel.org
> Cc: linux-mips@linux-mips.org
> Tested-by: Guenter Roeck <linux@roeck-us.net>
I'm planning to push this to 4.15 but not sure if there's enough time.
--
https://patchwork.kernel.org/patch/10165371/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [for-4.15] ssb: Disable PCI host for PCI_DRIVERS_GENERIC
@ 2018-01-16 15:22 ` Kalle Valo
0 siblings, 0 replies; 11+ messages in thread
From: Kalle Valo @ 2018-01-16 15:22 UTC (permalink / raw)
To: James Hogan
Cc: Michael Buesch, linux-wireless, linux-mips, Ralf Baechle,
Paul Burton, Matt Redfearn, Guenter Roeck
James Hogan <jhogan@kernel.org> wrote:
> Since commit d41e6858ba58 ("MIPS: Kconfig: Set default MIPS system type
> as generic") changed the default MIPS platform to the "generic"
> platform, which uses PCI_DRIVERS_GENERIC instead of PCI_DRIVERS_LEGACY,
> various files in drivers/ssb/ have failed to build.
>
> This is particularly due to the existence of struct pci_controller being
> dependent on PCI_DRIVERS_LEGACY since commit c5611df96804 ("MIPS: PCI:
> Introduce CONFIG_PCI_DRIVERS_LEGACY"), so add that dependency to Kconfig
> to prevent these files being built for the "generic" platform including
> all{yes,mod}config builds.
>
> Fixes: c5611df96804 ("MIPS: PCI: Introduce CONFIG_PCI_DRIVERS_LEGACY")
> Signed-off-by: James Hogan <jhogan@kernel.org>
> Cc: Michael Buesch <m@bues.ch>
> Cc: Ralf Baechle <ralf@linux-mips.org>
> Cc: Paul Burton <paul.burton@mips.com>
> Cc: Matt Redfearn <matt.redfearn@imgtec.com>
> Cc: Guenter Roeck <linux@roeck-us.net>
> Cc: linux-wireless@vger.kernel.org
> Cc: linux-mips@linux-mips.org
> Tested-by: Guenter Roeck <linux@roeck-us.net>
I'm planning to push this to 4.15 but not sure if there's enough time.
--
https://patchwork.kernel.org/patch/10165371/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [for-4.15] ssb: Disable PCI host for PCI_DRIVERS_GENERIC
@ 2018-01-16 19:16 ` Kalle Valo
0 siblings, 0 replies; 11+ messages in thread
From: Kalle Valo @ 2018-01-16 19:16 UTC (permalink / raw)
To: James Hogan
Cc: Michael Buesch, linux-wireless, linux-mips, Ralf Baechle,
James Hogan, Paul Burton, Matt Redfearn, Guenter Roeck
James Hogan <jhogan@kernel.org> wrote:
> Since commit d41e6858ba58 ("MIPS: Kconfig: Set default MIPS system type
> as generic") changed the default MIPS platform to the "generic"
> platform, which uses PCI_DRIVERS_GENERIC instead of PCI_DRIVERS_LEGACY,
> various files in drivers/ssb/ have failed to build.
>
> This is particularly due to the existence of struct pci_controller being
> dependent on PCI_DRIVERS_LEGACY since commit c5611df96804 ("MIPS: PCI:
> Introduce CONFIG_PCI_DRIVERS_LEGACY"), so add that dependency to Kconfig
> to prevent these files being built for the "generic" platform including
> all{yes,mod}config builds.
>
> Fixes: c5611df96804 ("MIPS: PCI: Introduce CONFIG_PCI_DRIVERS_LEGACY")
> Signed-off-by: James Hogan <jhogan@kernel.org>
> Cc: Michael Buesch <m@bues.ch>
> Cc: Ralf Baechle <ralf@linux-mips.org>
> Cc: Paul Burton <paul.burton@mips.com>
> Cc: Matt Redfearn <matt.redfearn@imgtec.com>
> Cc: Guenter Roeck <linux@roeck-us.net>
> Cc: linux-wireless@vger.kernel.org
> Cc: linux-mips@linux-mips.org
> Tested-by: Guenter Roeck <linux@roeck-us.net>
Patch applied to wireless-drivers.git, thanks.
58eae1416b80 ssb: Disable PCI host for PCI_DRIVERS_GENERIC
--
https://patchwork.kernel.org/patch/10165371/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [for-4.15] ssb: Disable PCI host for PCI_DRIVERS_GENERIC
@ 2018-01-16 19:16 ` Kalle Valo
0 siblings, 0 replies; 11+ messages in thread
From: Kalle Valo @ 2018-01-16 19:16 UTC (permalink / raw)
To: James Hogan
Cc: Michael Buesch, linux-wireless, linux-mips, Ralf Baechle,
Paul Burton, Matt Redfearn, Guenter Roeck
James Hogan <jhogan@kernel.org> wrote:
> Since commit d41e6858ba58 ("MIPS: Kconfig: Set default MIPS system type
> as generic") changed the default MIPS platform to the "generic"
> platform, which uses PCI_DRIVERS_GENERIC instead of PCI_DRIVERS_LEGACY,
> various files in drivers/ssb/ have failed to build.
>
> This is particularly due to the existence of struct pci_controller being
> dependent on PCI_DRIVERS_LEGACY since commit c5611df96804 ("MIPS: PCI:
> Introduce CONFIG_PCI_DRIVERS_LEGACY"), so add that dependency to Kconfig
> to prevent these files being built for the "generic" platform including
> all{yes,mod}config builds.
>
> Fixes: c5611df96804 ("MIPS: PCI: Introduce CONFIG_PCI_DRIVERS_LEGACY")
> Signed-off-by: James Hogan <jhogan@kernel.org>
> Cc: Michael Buesch <m@bues.ch>
> Cc: Ralf Baechle <ralf@linux-mips.org>
> Cc: Paul Burton <paul.burton@mips.com>
> Cc: Matt Redfearn <matt.redfearn@imgtec.com>
> Cc: Guenter Roeck <linux@roeck-us.net>
> Cc: linux-wireless@vger.kernel.org
> Cc: linux-mips@linux-mips.org
> Tested-by: Guenter Roeck <linux@roeck-us.net>
Patch applied to wireless-drivers.git, thanks.
58eae1416b80 ssb: Disable PCI host for PCI_DRIVERS_GENERIC
--
https://patchwork.kernel.org/patch/10165371/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [for-4.15] ssb: Disable PCI host for PCI_DRIVERS_GENERIC
2018-01-16 19:16 ` Kalle Valo
(?)
@ 2018-01-27 9:08 ` Andreas Schwab
2018-01-27 9:15 ` James Hogan
-1 siblings, 1 reply; 11+ messages in thread
From: Andreas Schwab @ 2018-01-27 9:08 UTC (permalink / raw)
To: Kalle Valo
Cc: James Hogan, Michael Buesch, linux-wireless, linux-mips,
Ralf Baechle, Paul Burton, Matt Redfearn, Guenter Roeck
On Jan 16 2018, Kalle Valo <kvalo@codeaurora.org> wrote:
> 58eae1416b80 ssb: Disable PCI host for PCI_DRIVERS_GENERIC
That breaks wireless on PowerMac! There is nothing MIPS-specific about
SSB.
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [for-4.15] ssb: Disable PCI host for PCI_DRIVERS_GENERIC
@ 2018-01-27 9:15 ` James Hogan
0 siblings, 0 replies; 11+ messages in thread
From: James Hogan @ 2018-01-27 9:15 UTC (permalink / raw)
To: Andreas Schwab
Cc: Kalle Valo, Michael Buesch, linux-wireless, linux-mips,
Ralf Baechle, Paul Burton, Matt Redfearn, Guenter Roeck
On Sat, Jan 27, 2018 at 10:08:56AM +0100, Andreas Schwab wrote:
> On Jan 16 2018, Kalle Valo <kvalo@codeaurora.org> wrote:
>
> > 58eae1416b80 ssb: Disable PCI host for PCI_DRIVERS_GENERIC
>
> That breaks wireless on PowerMac! There is nothing MIPS-specific about
> SSB.
Yes, really sorry about that. There is a patch here:
https://patchwork.kernel.org/patch/10185397/
Cheers
James
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [for-4.15] ssb: Disable PCI host for PCI_DRIVERS_GENERIC
@ 2018-01-27 9:15 ` James Hogan
0 siblings, 0 replies; 11+ messages in thread
From: James Hogan @ 2018-01-27 9:15 UTC (permalink / raw)
To: Andreas Schwab
Cc: Kalle Valo, Michael Buesch, linux-wireless, linux-mips,
Ralf Baechle, Paul Burton, Matt Redfearn, Guenter Roeck
On Sat, Jan 27, 2018 at 10:08:56AM +0100, Andreas Schwab wrote:
> On Jan 16 2018, Kalle Valo <kvalo@codeaurora.org> wrote:
>
> > 58eae1416b80 ssb: Disable PCI host for PCI_DRIVERS_GENERIC
>
> That breaks wireless on PowerMac! There is nothing MIPS-specific about
> SSB.
Yes, really sorry about that. There is a patch here:
https://patchwork.kernel.org/patch/10185397/
Cheers
James
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [for-4.15] ssb: Disable PCI host for PCI_DRIVERS_GENERIC
2018-01-15 21:17 [PATCH for-4.15] ssb: Disable PCI host for PCI_DRIVERS_GENERIC James Hogan
` (3 preceding siblings ...)
2018-01-16 19:16 ` Kalle Valo
@ 2018-01-16 19:16 ` Kalle Valo
4 siblings, 0 replies; 11+ messages in thread
From: Kalle Valo @ 2018-01-16 19:16 UTC (permalink / raw)
To: James Hogan
Cc: Michael Buesch, linux-wireless, linux-mips, Ralf Baechle,
James Hogan, Paul Burton, Matt Redfearn, Guenter Roeck
James Hogan <jhogan@kernel.org> wrote:
> Since commit d41e6858ba58 ("MIPS: Kconfig: Set default MIPS system type
> as generic") changed the default MIPS platform to the "generic"
> platform, which uses PCI_DRIVERS_GENERIC instead of PCI_DRIVERS_LEGACY,
> various files in drivers/ssb/ have failed to build.
>
> This is particularly due to the existence of struct pci_controller being
> dependent on PCI_DRIVERS_LEGACY since commit c5611df96804 ("MIPS: PCI:
> Introduce CONFIG_PCI_DRIVERS_LEGACY"), so add that dependency to Kconfig
> to prevent these files being built for the "generic" platform including
> all{yes,mod}config builds.
>
> Fixes: c5611df96804 ("MIPS: PCI: Introduce CONFIG_PCI_DRIVERS_LEGACY")
> Signed-off-by: James Hogan <jhogan@kernel.org>
> Cc: Michael Buesch <m@bues.ch>
> Cc: Ralf Baechle <ralf@linux-mips.org>
> Cc: Paul Burton <paul.burton@mips.com>
> Cc: Matt Redfearn <matt.redfearn@imgtec.com>
> Cc: Guenter Roeck <linux@roeck-us.net>
> Cc: linux-wireless@vger.kernel.org
> Cc: linux-mips@linux-mips.org
> Tested-by: Guenter Roeck <linux@roeck-us.net>
Patch applied to wireless-drivers.git, thanks.
58eae1416b80 ssb: Disable PCI host for PCI_DRIVERS_GENERIC
--
https://patchwork.kernel.org/patch/10165371/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 11+ messages in thread