* [PATCH 1/2] iommu/msm: Claim bus ops on probe @ 2018-01-08 18:42 ` Robin Murphy 0 siblings, 0 replies; 18+ messages in thread From: Robin Murphy @ 2018-01-08 18:42 UTC (permalink / raw) To: alex.williamson-H+wXaHxf7aLQT0dZR+AlfA, joro-zLv9SwRftAIdnm+yROfE0A Cc: srinivas.kandagatla-QSEj5FYQhm4dnm+yROfE0A, iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r Since the MSM IOMMU driver now probes via DT exclusively rather than platform data, dependent masters should be deferred until the IOMMU itself is ready. Thus we can do away with the early initialisation hook to unconditionally claim the bus ops, and instead do that only once an IOMMU is actually probed. Furthermore, this should also make the driver safe for multiplatform kernels on non-MSM SoCs. Signed-off-by: Robin Murphy <robin.murphy-5wv7dgnIgG8@public.gmane.org> --- drivers/iommu/msm_iommu.c | 16 +++------------- 1 file changed, 3 insertions(+), 13 deletions(-) diff --git a/drivers/iommu/msm_iommu.c b/drivers/iommu/msm_iommu.c index 04f4d51ffacb..dda1ce87a070 100644 --- a/drivers/iommu/msm_iommu.c +++ b/drivers/iommu/msm_iommu.c @@ -823,6 +823,8 @@ static int msm_iommu_probe(struct platform_device *pdev) goto fail; } + bus_set_iommu(&platform_bus_type, &msm_iommu_ops); + pr_info("device mapped at %p, irq %d with %d ctx banks\n", iommu->base, iommu->irq, iommu->ncb); @@ -875,19 +877,7 @@ static void __exit msm_iommu_driver_exit(void) subsys_initcall(msm_iommu_driver_init); module_exit(msm_iommu_driver_exit); -static int __init msm_iommu_init(void) -{ - bus_set_iommu(&platform_bus_type, &msm_iommu_ops); - return 0; -} - -static int __init msm_iommu_of_setup(struct device_node *np) -{ - msm_iommu_init(); - return 0; -} - -IOMMU_OF_DECLARE(msm_iommu_of, "qcom,apq8064-iommu", msm_iommu_of_setup); +IOMMU_OF_DECLARE(msm_iommu_of, "qcom,apq8064-iommu", NULL); MODULE_LICENSE("GPL v2"); MODULE_AUTHOR("Stepan Moskovchenko <stepanm-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>"); -- 2.13.4.dirty ^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH 1/2] iommu/msm: Claim bus ops on probe @ 2018-01-08 18:42 ` Robin Murphy 0 siblings, 0 replies; 18+ messages in thread From: Robin Murphy @ 2018-01-08 18:42 UTC (permalink / raw) To: linux-arm-kernel Since the MSM IOMMU driver now probes via DT exclusively rather than platform data, dependent masters should be deferred until the IOMMU itself is ready. Thus we can do away with the early initialisation hook to unconditionally claim the bus ops, and instead do that only once an IOMMU is actually probed. Furthermore, this should also make the driver safe for multiplatform kernels on non-MSM SoCs. Signed-off-by: Robin Murphy <robin.murphy@arm.com> --- drivers/iommu/msm_iommu.c | 16 +++------------- 1 file changed, 3 insertions(+), 13 deletions(-) diff --git a/drivers/iommu/msm_iommu.c b/drivers/iommu/msm_iommu.c index 04f4d51ffacb..dda1ce87a070 100644 --- a/drivers/iommu/msm_iommu.c +++ b/drivers/iommu/msm_iommu.c @@ -823,6 +823,8 @@ static int msm_iommu_probe(struct platform_device *pdev) goto fail; } + bus_set_iommu(&platform_bus_type, &msm_iommu_ops); + pr_info("device mapped at %p, irq %d with %d ctx banks\n", iommu->base, iommu->irq, iommu->ncb); @@ -875,19 +877,7 @@ static void __exit msm_iommu_driver_exit(void) subsys_initcall(msm_iommu_driver_init); module_exit(msm_iommu_driver_exit); -static int __init msm_iommu_init(void) -{ - bus_set_iommu(&platform_bus_type, &msm_iommu_ops); - return 0; -} - -static int __init msm_iommu_of_setup(struct device_node *np) -{ - msm_iommu_init(); - return 0; -} - -IOMMU_OF_DECLARE(msm_iommu_of, "qcom,apq8064-iommu", msm_iommu_of_setup); +IOMMU_OF_DECLARE(msm_iommu_of, "qcom,apq8064-iommu", NULL); MODULE_LICENSE("GPL v2"); MODULE_AUTHOR("Stepan Moskovchenko <stepanm@codeaurora.org>"); -- 2.13.4.dirty ^ permalink raw reply related [flat|nested] 18+ messages in thread
[parent not found: <f1a506337bf602c54f4d6d417c14ca556a5f3674.1515436860.git.robin.murphy-5wv7dgnIgG8@public.gmane.org>]
* [PATCH 2/2] iommu: Clean up of_iommu_init_fn 2018-01-08 18:42 ` Robin Murphy @ 2018-01-08 18:42 ` Robin Murphy -1 siblings, 0 replies; 18+ messages in thread From: Robin Murphy @ 2018-01-08 18:42 UTC (permalink / raw) To: alex.williamson-H+wXaHxf7aLQT0dZR+AlfA, joro-zLv9SwRftAIdnm+yROfE0A Cc: srinivas.kandagatla-QSEj5FYQhm4dnm+yROfE0A, iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r Now that no more drivers rely on arbitrary early initialisation via an of_iommu_init_fn hook, let's clean up the redundant remnants. The IOMMU_OF_DECLARE() macro needs to remain for now, as the probe-deferral mechanism has no other nice way to detect built-in drivers before they have registered themselves, such that it can make the right decision. Signed-off-by: Robin Murphy <robin.murphy-5wv7dgnIgG8@public.gmane.org> --- drivers/iommu/arm-smmu-v3.c | 2 +- drivers/iommu/arm-smmu.c | 12 ++++++------ drivers/iommu/exynos-iommu.c | 2 +- drivers/iommu/msm_iommu.c | 2 +- drivers/iommu/of_iommu.c | 16 ---------------- drivers/iommu/qcom_iommu.c | 2 +- include/linux/of_iommu.h | 5 +---- 7 files changed, 11 insertions(+), 30 deletions(-) diff --git a/drivers/iommu/arm-smmu-v3.c b/drivers/iommu/arm-smmu-v3.c index 57c92aa3122e..1abbf42a8bd5 100644 --- a/drivers/iommu/arm-smmu-v3.c +++ b/drivers/iommu/arm-smmu-v3.c @@ -3009,7 +3009,7 @@ static struct platform_driver arm_smmu_driver = { }; module_platform_driver(arm_smmu_driver); -IOMMU_OF_DECLARE(arm_smmuv3, "arm,smmu-v3", NULL); +IOMMU_OF_DECLARE(arm_smmuv3, "arm,smmu-v3"); MODULE_DESCRIPTION("IOMMU API for ARM architected SMMUv3 implementations"); MODULE_AUTHOR("Will Deacon <will.deacon-5wv7dgnIgG8@public.gmane.org>"); diff --git a/drivers/iommu/arm-smmu.c b/drivers/iommu/arm-smmu.c index 3bdb799d3b4b..56147a2be3d0 100644 --- a/drivers/iommu/arm-smmu.c +++ b/drivers/iommu/arm-smmu.c @@ -2208,12 +2208,12 @@ static struct platform_driver arm_smmu_driver = { }; module_platform_driver(arm_smmu_driver); -IOMMU_OF_DECLARE(arm_smmuv1, "arm,smmu-v1", NULL); -IOMMU_OF_DECLARE(arm_smmuv2, "arm,smmu-v2", NULL); -IOMMU_OF_DECLARE(arm_mmu400, "arm,mmu-400", NULL); -IOMMU_OF_DECLARE(arm_mmu401, "arm,mmu-401", NULL); -IOMMU_OF_DECLARE(arm_mmu500, "arm,mmu-500", NULL); -IOMMU_OF_DECLARE(cavium_smmuv2, "cavium,smmu-v2", NULL); +IOMMU_OF_DECLARE(arm_smmuv1, "arm,smmu-v1"); +IOMMU_OF_DECLARE(arm_smmuv2, "arm,smmu-v2"); +IOMMU_OF_DECLARE(arm_mmu400, "arm,mmu-400"); +IOMMU_OF_DECLARE(arm_mmu401, "arm,mmu-401"); +IOMMU_OF_DECLARE(arm_mmu500, "arm,mmu-500"); +IOMMU_OF_DECLARE(cavium_smmuv2, "cavium,smmu-v2"); MODULE_DESCRIPTION("IOMMU API for ARM architected SMMU implementations"); MODULE_AUTHOR("Will Deacon <will.deacon-5wv7dgnIgG8@public.gmane.org>"); diff --git a/drivers/iommu/exynos-iommu.c b/drivers/iommu/exynos-iommu.c index f596fcc32898..6a96a4c42153 100644 --- a/drivers/iommu/exynos-iommu.c +++ b/drivers/iommu/exynos-iommu.c @@ -1385,4 +1385,4 @@ static int __init exynos_iommu_init(void) } core_initcall(exynos_iommu_init); -IOMMU_OF_DECLARE(exynos_iommu_of, "samsung,exynos-sysmmu", NULL); +IOMMU_OF_DECLARE(exynos_iommu_of, "samsung,exynos-sysmmu"); diff --git a/drivers/iommu/msm_iommu.c b/drivers/iommu/msm_iommu.c index dda1ce87a070..0d3350463a3f 100644 --- a/drivers/iommu/msm_iommu.c +++ b/drivers/iommu/msm_iommu.c @@ -877,7 +877,7 @@ static void __exit msm_iommu_driver_exit(void) subsys_initcall(msm_iommu_driver_init); module_exit(msm_iommu_driver_exit); -IOMMU_OF_DECLARE(msm_iommu_of, "qcom,apq8064-iommu", NULL); +IOMMU_OF_DECLARE(msm_iommu_of, "qcom,apq8064-iommu"); MODULE_LICENSE("GPL v2"); MODULE_AUTHOR("Stepan Moskovchenko <stepanm-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>"); diff --git a/drivers/iommu/of_iommu.c b/drivers/iommu/of_iommu.c index 50947ebb6d17..5c36a8b7656a 100644 --- a/drivers/iommu/of_iommu.c +++ b/drivers/iommu/of_iommu.c @@ -231,19 +231,3 @@ const struct iommu_ops *of_iommu_configure(struct device *dev, return ops; } - -static int __init of_iommu_init(void) -{ - struct device_node *np; - const struct of_device_id *match, *matches = &__iommu_of_table; - - for_each_matching_node_and_match(np, matches, &match) { - const of_iommu_init_fn init_fn = match->data; - - if (init_fn && init_fn(np)) - pr_err("Failed to initialise IOMMU %pOF\n", np); - } - - return 0; -} -postcore_initcall_sync(of_iommu_init); diff --git a/drivers/iommu/qcom_iommu.c b/drivers/iommu/qcom_iommu.c index c8a587d034b0..37ecc49deab8 100644 --- a/drivers/iommu/qcom_iommu.c +++ b/drivers/iommu/qcom_iommu.c @@ -924,7 +924,7 @@ static void __exit qcom_iommu_exit(void) module_init(qcom_iommu_init); module_exit(qcom_iommu_exit); -IOMMU_OF_DECLARE(qcom_iommu_dev, "qcom,msm-iommu-v1", NULL); +IOMMU_OF_DECLARE(qcom_iommu_dev, "qcom,msm-iommu-v1"); MODULE_DESCRIPTION("IOMMU API for QCOM IOMMU v1 implementations"); MODULE_LICENSE("GPL v2"); diff --git a/include/linux/of_iommu.h b/include/linux/of_iommu.h index 13394ac83c66..0cac59db95bc 100644 --- a/include/linux/of_iommu.h +++ b/include/linux/of_iommu.h @@ -33,9 +33,6 @@ static inline const struct iommu_ops *of_iommu_configure(struct device *dev, extern struct of_device_id __iommu_of_table; -typedef int (*of_iommu_init_fn)(struct device_node *); - -#define IOMMU_OF_DECLARE(name, compat, fn) \ - _OF_DECLARE(iommu, name, compat, fn, of_iommu_init_fn) +#define IOMMU_OF_DECLARE(name, compat) OF_DECLARE_1(iommu, name, compat, NULL) #endif /* __OF_IOMMU_H */ -- 2.13.4.dirty ^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH 2/2] iommu: Clean up of_iommu_init_fn @ 2018-01-08 18:42 ` Robin Murphy 0 siblings, 0 replies; 18+ messages in thread From: Robin Murphy @ 2018-01-08 18:42 UTC (permalink / raw) To: linux-arm-kernel Now that no more drivers rely on arbitrary early initialisation via an of_iommu_init_fn hook, let's clean up the redundant remnants. The IOMMU_OF_DECLARE() macro needs to remain for now, as the probe-deferral mechanism has no other nice way to detect built-in drivers before they have registered themselves, such that it can make the right decision. Signed-off-by: Robin Murphy <robin.murphy@arm.com> --- drivers/iommu/arm-smmu-v3.c | 2 +- drivers/iommu/arm-smmu.c | 12 ++++++------ drivers/iommu/exynos-iommu.c | 2 +- drivers/iommu/msm_iommu.c | 2 +- drivers/iommu/of_iommu.c | 16 ---------------- drivers/iommu/qcom_iommu.c | 2 +- include/linux/of_iommu.h | 5 +---- 7 files changed, 11 insertions(+), 30 deletions(-) diff --git a/drivers/iommu/arm-smmu-v3.c b/drivers/iommu/arm-smmu-v3.c index 57c92aa3122e..1abbf42a8bd5 100644 --- a/drivers/iommu/arm-smmu-v3.c +++ b/drivers/iommu/arm-smmu-v3.c @@ -3009,7 +3009,7 @@ static struct platform_driver arm_smmu_driver = { }; module_platform_driver(arm_smmu_driver); -IOMMU_OF_DECLARE(arm_smmuv3, "arm,smmu-v3", NULL); +IOMMU_OF_DECLARE(arm_smmuv3, "arm,smmu-v3"); MODULE_DESCRIPTION("IOMMU API for ARM architected SMMUv3 implementations"); MODULE_AUTHOR("Will Deacon <will.deacon@arm.com>"); diff --git a/drivers/iommu/arm-smmu.c b/drivers/iommu/arm-smmu.c index 3bdb799d3b4b..56147a2be3d0 100644 --- a/drivers/iommu/arm-smmu.c +++ b/drivers/iommu/arm-smmu.c @@ -2208,12 +2208,12 @@ static struct platform_driver arm_smmu_driver = { }; module_platform_driver(arm_smmu_driver); -IOMMU_OF_DECLARE(arm_smmuv1, "arm,smmu-v1", NULL); -IOMMU_OF_DECLARE(arm_smmuv2, "arm,smmu-v2", NULL); -IOMMU_OF_DECLARE(arm_mmu400, "arm,mmu-400", NULL); -IOMMU_OF_DECLARE(arm_mmu401, "arm,mmu-401", NULL); -IOMMU_OF_DECLARE(arm_mmu500, "arm,mmu-500", NULL); -IOMMU_OF_DECLARE(cavium_smmuv2, "cavium,smmu-v2", NULL); +IOMMU_OF_DECLARE(arm_smmuv1, "arm,smmu-v1"); +IOMMU_OF_DECLARE(arm_smmuv2, "arm,smmu-v2"); +IOMMU_OF_DECLARE(arm_mmu400, "arm,mmu-400"); +IOMMU_OF_DECLARE(arm_mmu401, "arm,mmu-401"); +IOMMU_OF_DECLARE(arm_mmu500, "arm,mmu-500"); +IOMMU_OF_DECLARE(cavium_smmuv2, "cavium,smmu-v2"); MODULE_DESCRIPTION("IOMMU API for ARM architected SMMU implementations"); MODULE_AUTHOR("Will Deacon <will.deacon@arm.com>"); diff --git a/drivers/iommu/exynos-iommu.c b/drivers/iommu/exynos-iommu.c index f596fcc32898..6a96a4c42153 100644 --- a/drivers/iommu/exynos-iommu.c +++ b/drivers/iommu/exynos-iommu.c @@ -1385,4 +1385,4 @@ static int __init exynos_iommu_init(void) } core_initcall(exynos_iommu_init); -IOMMU_OF_DECLARE(exynos_iommu_of, "samsung,exynos-sysmmu", NULL); +IOMMU_OF_DECLARE(exynos_iommu_of, "samsung,exynos-sysmmu"); diff --git a/drivers/iommu/msm_iommu.c b/drivers/iommu/msm_iommu.c index dda1ce87a070..0d3350463a3f 100644 --- a/drivers/iommu/msm_iommu.c +++ b/drivers/iommu/msm_iommu.c @@ -877,7 +877,7 @@ static void __exit msm_iommu_driver_exit(void) subsys_initcall(msm_iommu_driver_init); module_exit(msm_iommu_driver_exit); -IOMMU_OF_DECLARE(msm_iommu_of, "qcom,apq8064-iommu", NULL); +IOMMU_OF_DECLARE(msm_iommu_of, "qcom,apq8064-iommu"); MODULE_LICENSE("GPL v2"); MODULE_AUTHOR("Stepan Moskovchenko <stepanm@codeaurora.org>"); diff --git a/drivers/iommu/of_iommu.c b/drivers/iommu/of_iommu.c index 50947ebb6d17..5c36a8b7656a 100644 --- a/drivers/iommu/of_iommu.c +++ b/drivers/iommu/of_iommu.c @@ -231,19 +231,3 @@ const struct iommu_ops *of_iommu_configure(struct device *dev, return ops; } - -static int __init of_iommu_init(void) -{ - struct device_node *np; - const struct of_device_id *match, *matches = &__iommu_of_table; - - for_each_matching_node_and_match(np, matches, &match) { - const of_iommu_init_fn init_fn = match->data; - - if (init_fn && init_fn(np)) - pr_err("Failed to initialise IOMMU %pOF\n", np); - } - - return 0; -} -postcore_initcall_sync(of_iommu_init); diff --git a/drivers/iommu/qcom_iommu.c b/drivers/iommu/qcom_iommu.c index c8a587d034b0..37ecc49deab8 100644 --- a/drivers/iommu/qcom_iommu.c +++ b/drivers/iommu/qcom_iommu.c @@ -924,7 +924,7 @@ static void __exit qcom_iommu_exit(void) module_init(qcom_iommu_init); module_exit(qcom_iommu_exit); -IOMMU_OF_DECLARE(qcom_iommu_dev, "qcom,msm-iommu-v1", NULL); +IOMMU_OF_DECLARE(qcom_iommu_dev, "qcom,msm-iommu-v1"); MODULE_DESCRIPTION("IOMMU API for QCOM IOMMU v1 implementations"); MODULE_LICENSE("GPL v2"); diff --git a/include/linux/of_iommu.h b/include/linux/of_iommu.h index 13394ac83c66..0cac59db95bc 100644 --- a/include/linux/of_iommu.h +++ b/include/linux/of_iommu.h @@ -33,9 +33,6 @@ static inline const struct iommu_ops *of_iommu_configure(struct device *dev, extern struct of_device_id __iommu_of_table; -typedef int (*of_iommu_init_fn)(struct device_node *); - -#define IOMMU_OF_DECLARE(name, compat, fn) \ - _OF_DECLARE(iommu, name, compat, fn, of_iommu_init_fn) +#define IOMMU_OF_DECLARE(name, compat) OF_DECLARE_1(iommu, name, compat, NULL) #endif /* __OF_IOMMU_H */ -- 2.13.4.dirty ^ permalink raw reply related [flat|nested] 18+ messages in thread
[parent not found: <1eb597bb451da7e723b83369d5dc6ee478e802f5.1515436860.git.robin.murphy-5wv7dgnIgG8@public.gmane.org>]
* Re: [PATCH 2/2] iommu: Clean up of_iommu_init_fn 2018-01-08 18:42 ` Robin Murphy @ 2018-01-09 6:19 ` Sricharan R -1 siblings, 0 replies; 18+ messages in thread From: Sricharan R @ 2018-01-09 6:19 UTC (permalink / raw) To: Robin Murphy, alex.williamson-H+wXaHxf7aLQT0dZR+AlfA, joro-zLv9SwRftAIdnm+yROfE0A Cc: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA, srinivas.kandagatla-QSEj5FYQhm4dnm+yROfE0A, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r On 1/9/2018 12:12 AM, Robin Murphy wrote: > Now that no more drivers rely on arbitrary early initialisation via an > of_iommu_init_fn hook, let's clean up the redundant remnants. The > IOMMU_OF_DECLARE() macro needs to remain for now, as the probe-deferral > mechanism has no other nice way to detect built-in drivers before they > have registered themselves, such that it can make the right decision. > > Signed-off-by: Robin Murphy <robin.murphy-5wv7dgnIgG8@public.gmane.org> > --- > drivers/iommu/arm-smmu-v3.c | 2 +- > drivers/iommu/arm-smmu.c | 12 ++++++------ > drivers/iommu/exynos-iommu.c | 2 +- > drivers/iommu/msm_iommu.c | 2 +- > drivers/iommu/of_iommu.c | 16 ---------------- > drivers/iommu/qcom_iommu.c | 2 +- > include/linux/of_iommu.h | 5 +---- > 7 files changed, 11 insertions(+), 30 deletions(-) > > diff --git a/drivers/iommu/arm-smmu-v3.c b/drivers/iommu/arm-smmu-v3.c > index 57c92aa3122e..1abbf42a8bd5 100644 > --- a/drivers/iommu/arm-smmu-v3.c > +++ b/drivers/iommu/arm-smmu-v3.c > @@ -3009,7 +3009,7 @@ static struct platform_driver arm_smmu_driver = { > }; > module_platform_driver(arm_smmu_driver); > > -IOMMU_OF_DECLARE(arm_smmuv3, "arm,smmu-v3", NULL); > +IOMMU_OF_DECLARE(arm_smmuv3, "arm,smmu-v3"); > > MODULE_DESCRIPTION("IOMMU API for ARM architected SMMUv3 implementations"); > MODULE_AUTHOR("Will Deacon <will.deacon-5wv7dgnIgG8@public.gmane.org>"); > diff --git a/drivers/iommu/arm-smmu.c b/drivers/iommu/arm-smmu.c > index 3bdb799d3b4b..56147a2be3d0 100644 > --- a/drivers/iommu/arm-smmu.c > +++ b/drivers/iommu/arm-smmu.c > @@ -2208,12 +2208,12 @@ static struct platform_driver arm_smmu_driver = { > }; > module_platform_driver(arm_smmu_driver); > > -IOMMU_OF_DECLARE(arm_smmuv1, "arm,smmu-v1", NULL); > -IOMMU_OF_DECLARE(arm_smmuv2, "arm,smmu-v2", NULL); > -IOMMU_OF_DECLARE(arm_mmu400, "arm,mmu-400", NULL); > -IOMMU_OF_DECLARE(arm_mmu401, "arm,mmu-401", NULL); > -IOMMU_OF_DECLARE(arm_mmu500, "arm,mmu-500", NULL); > -IOMMU_OF_DECLARE(cavium_smmuv2, "cavium,smmu-v2", NULL); > +IOMMU_OF_DECLARE(arm_smmuv1, "arm,smmu-v1"); > +IOMMU_OF_DECLARE(arm_smmuv2, "arm,smmu-v2"); > +IOMMU_OF_DECLARE(arm_mmu400, "arm,mmu-400"); > +IOMMU_OF_DECLARE(arm_mmu401, "arm,mmu-401"); > +IOMMU_OF_DECLARE(arm_mmu500, "arm,mmu-500"); > +IOMMU_OF_DECLARE(cavium_smmuv2, "cavium,smmu-v2"); > > MODULE_DESCRIPTION("IOMMU API for ARM architected SMMU implementations"); > MODULE_AUTHOR("Will Deacon <will.deacon-5wv7dgnIgG8@public.gmane.org>"); > diff --git a/drivers/iommu/exynos-iommu.c b/drivers/iommu/exynos-iommu.c > index f596fcc32898..6a96a4c42153 100644 > --- a/drivers/iommu/exynos-iommu.c > +++ b/drivers/iommu/exynos-iommu.c > @@ -1385,4 +1385,4 @@ static int __init exynos_iommu_init(void) > } > core_initcall(exynos_iommu_init); > > -IOMMU_OF_DECLARE(exynos_iommu_of, "samsung,exynos-sysmmu", NULL); > +IOMMU_OF_DECLARE(exynos_iommu_of, "samsung,exynos-sysmmu"); > diff --git a/drivers/iommu/msm_iommu.c b/drivers/iommu/msm_iommu.c > index dda1ce87a070..0d3350463a3f 100644 > --- a/drivers/iommu/msm_iommu.c > +++ b/drivers/iommu/msm_iommu.c > @@ -877,7 +877,7 @@ static void __exit msm_iommu_driver_exit(void) > subsys_initcall(msm_iommu_driver_init); > module_exit(msm_iommu_driver_exit); > > -IOMMU_OF_DECLARE(msm_iommu_of, "qcom,apq8064-iommu", NULL); > +IOMMU_OF_DECLARE(msm_iommu_of, "qcom,apq8064-iommu"); > > MODULE_LICENSE("GPL v2"); > MODULE_AUTHOR("Stepan Moskovchenko <stepanm-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>"); > diff --git a/drivers/iommu/of_iommu.c b/drivers/iommu/of_iommu.c > index 50947ebb6d17..5c36a8b7656a 100644 > --- a/drivers/iommu/of_iommu.c > +++ b/drivers/iommu/of_iommu.c > @@ -231,19 +231,3 @@ const struct iommu_ops *of_iommu_configure(struct device *dev, > > return ops; > } > - > -static int __init of_iommu_init(void) > -{ > - struct device_node *np; > - const struct of_device_id *match, *matches = &__iommu_of_table; > - > - for_each_matching_node_and_match(np, matches, &match) { > - const of_iommu_init_fn init_fn = match->data; > - > - if (init_fn && init_fn(np)) > - pr_err("Failed to initialise IOMMU %pOF\n", np); > - } > - > - return 0; > -} > -postcore_initcall_sync(of_iommu_init); > diff --git a/drivers/iommu/qcom_iommu.c b/drivers/iommu/qcom_iommu.c > index c8a587d034b0..37ecc49deab8 100644 > --- a/drivers/iommu/qcom_iommu.c > +++ b/drivers/iommu/qcom_iommu.c > @@ -924,7 +924,7 @@ static void __exit qcom_iommu_exit(void) > module_init(qcom_iommu_init); > module_exit(qcom_iommu_exit); > > -IOMMU_OF_DECLARE(qcom_iommu_dev, "qcom,msm-iommu-v1", NULL); > +IOMMU_OF_DECLARE(qcom_iommu_dev, "qcom,msm-iommu-v1"); > > MODULE_DESCRIPTION("IOMMU API for QCOM IOMMU v1 implementations"); > MODULE_LICENSE("GPL v2"); > diff --git a/include/linux/of_iommu.h b/include/linux/of_iommu.h > index 13394ac83c66..0cac59db95bc 100644 > --- a/include/linux/of_iommu.h > +++ b/include/linux/of_iommu.h > @@ -33,9 +33,6 @@ static inline const struct iommu_ops *of_iommu_configure(struct device *dev, > > extern struct of_device_id __iommu_of_table; > > -typedef int (*of_iommu_init_fn)(struct device_node *); > - > -#define IOMMU_OF_DECLARE(name, compat, fn) \ > - _OF_DECLARE(iommu, name, compat, fn, of_iommu_init_fn) > +#define IOMMU_OF_DECLARE(name, compat) OF_DECLARE_1(iommu, name, compat, NULL) > > #endif /* __OF_IOMMU_H */ > Reviewed-by: Sricharan R <sricharan-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> Regards, Sricharan -- "QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation ^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH 2/2] iommu: Clean up of_iommu_init_fn @ 2018-01-09 6:19 ` Sricharan R 0 siblings, 0 replies; 18+ messages in thread From: Sricharan R @ 2018-01-09 6:19 UTC (permalink / raw) To: linux-arm-kernel On 1/9/2018 12:12 AM, Robin Murphy wrote: > Now that no more drivers rely on arbitrary early initialisation via an > of_iommu_init_fn hook, let's clean up the redundant remnants. The > IOMMU_OF_DECLARE() macro needs to remain for now, as the probe-deferral > mechanism has no other nice way to detect built-in drivers before they > have registered themselves, such that it can make the right decision. > > Signed-off-by: Robin Murphy <robin.murphy@arm.com> > --- > drivers/iommu/arm-smmu-v3.c | 2 +- > drivers/iommu/arm-smmu.c | 12 ++++++------ > drivers/iommu/exynos-iommu.c | 2 +- > drivers/iommu/msm_iommu.c | 2 +- > drivers/iommu/of_iommu.c | 16 ---------------- > drivers/iommu/qcom_iommu.c | 2 +- > include/linux/of_iommu.h | 5 +---- > 7 files changed, 11 insertions(+), 30 deletions(-) > > diff --git a/drivers/iommu/arm-smmu-v3.c b/drivers/iommu/arm-smmu-v3.c > index 57c92aa3122e..1abbf42a8bd5 100644 > --- a/drivers/iommu/arm-smmu-v3.c > +++ b/drivers/iommu/arm-smmu-v3.c > @@ -3009,7 +3009,7 @@ static struct platform_driver arm_smmu_driver = { > }; > module_platform_driver(arm_smmu_driver); > > -IOMMU_OF_DECLARE(arm_smmuv3, "arm,smmu-v3", NULL); > +IOMMU_OF_DECLARE(arm_smmuv3, "arm,smmu-v3"); > > MODULE_DESCRIPTION("IOMMU API for ARM architected SMMUv3 implementations"); > MODULE_AUTHOR("Will Deacon <will.deacon@arm.com>"); > diff --git a/drivers/iommu/arm-smmu.c b/drivers/iommu/arm-smmu.c > index 3bdb799d3b4b..56147a2be3d0 100644 > --- a/drivers/iommu/arm-smmu.c > +++ b/drivers/iommu/arm-smmu.c > @@ -2208,12 +2208,12 @@ static struct platform_driver arm_smmu_driver = { > }; > module_platform_driver(arm_smmu_driver); > > -IOMMU_OF_DECLARE(arm_smmuv1, "arm,smmu-v1", NULL); > -IOMMU_OF_DECLARE(arm_smmuv2, "arm,smmu-v2", NULL); > -IOMMU_OF_DECLARE(arm_mmu400, "arm,mmu-400", NULL); > -IOMMU_OF_DECLARE(arm_mmu401, "arm,mmu-401", NULL); > -IOMMU_OF_DECLARE(arm_mmu500, "arm,mmu-500", NULL); > -IOMMU_OF_DECLARE(cavium_smmuv2, "cavium,smmu-v2", NULL); > +IOMMU_OF_DECLARE(arm_smmuv1, "arm,smmu-v1"); > +IOMMU_OF_DECLARE(arm_smmuv2, "arm,smmu-v2"); > +IOMMU_OF_DECLARE(arm_mmu400, "arm,mmu-400"); > +IOMMU_OF_DECLARE(arm_mmu401, "arm,mmu-401"); > +IOMMU_OF_DECLARE(arm_mmu500, "arm,mmu-500"); > +IOMMU_OF_DECLARE(cavium_smmuv2, "cavium,smmu-v2"); > > MODULE_DESCRIPTION("IOMMU API for ARM architected SMMU implementations"); > MODULE_AUTHOR("Will Deacon <will.deacon@arm.com>"); > diff --git a/drivers/iommu/exynos-iommu.c b/drivers/iommu/exynos-iommu.c > index f596fcc32898..6a96a4c42153 100644 > --- a/drivers/iommu/exynos-iommu.c > +++ b/drivers/iommu/exynos-iommu.c > @@ -1385,4 +1385,4 @@ static int __init exynos_iommu_init(void) > } > core_initcall(exynos_iommu_init); > > -IOMMU_OF_DECLARE(exynos_iommu_of, "samsung,exynos-sysmmu", NULL); > +IOMMU_OF_DECLARE(exynos_iommu_of, "samsung,exynos-sysmmu"); > diff --git a/drivers/iommu/msm_iommu.c b/drivers/iommu/msm_iommu.c > index dda1ce87a070..0d3350463a3f 100644 > --- a/drivers/iommu/msm_iommu.c > +++ b/drivers/iommu/msm_iommu.c > @@ -877,7 +877,7 @@ static void __exit msm_iommu_driver_exit(void) > subsys_initcall(msm_iommu_driver_init); > module_exit(msm_iommu_driver_exit); > > -IOMMU_OF_DECLARE(msm_iommu_of, "qcom,apq8064-iommu", NULL); > +IOMMU_OF_DECLARE(msm_iommu_of, "qcom,apq8064-iommu"); > > MODULE_LICENSE("GPL v2"); > MODULE_AUTHOR("Stepan Moskovchenko <stepanm@codeaurora.org>"); > diff --git a/drivers/iommu/of_iommu.c b/drivers/iommu/of_iommu.c > index 50947ebb6d17..5c36a8b7656a 100644 > --- a/drivers/iommu/of_iommu.c > +++ b/drivers/iommu/of_iommu.c > @@ -231,19 +231,3 @@ const struct iommu_ops *of_iommu_configure(struct device *dev, > > return ops; > } > - > -static int __init of_iommu_init(void) > -{ > - struct device_node *np; > - const struct of_device_id *match, *matches = &__iommu_of_table; > - > - for_each_matching_node_and_match(np, matches, &match) { > - const of_iommu_init_fn init_fn = match->data; > - > - if (init_fn && init_fn(np)) > - pr_err("Failed to initialise IOMMU %pOF\n", np); > - } > - > - return 0; > -} > -postcore_initcall_sync(of_iommu_init); > diff --git a/drivers/iommu/qcom_iommu.c b/drivers/iommu/qcom_iommu.c > index c8a587d034b0..37ecc49deab8 100644 > --- a/drivers/iommu/qcom_iommu.c > +++ b/drivers/iommu/qcom_iommu.c > @@ -924,7 +924,7 @@ static void __exit qcom_iommu_exit(void) > module_init(qcom_iommu_init); > module_exit(qcom_iommu_exit); > > -IOMMU_OF_DECLARE(qcom_iommu_dev, "qcom,msm-iommu-v1", NULL); > +IOMMU_OF_DECLARE(qcom_iommu_dev, "qcom,msm-iommu-v1"); > > MODULE_DESCRIPTION("IOMMU API for QCOM IOMMU v1 implementations"); > MODULE_LICENSE("GPL v2"); > diff --git a/include/linux/of_iommu.h b/include/linux/of_iommu.h > index 13394ac83c66..0cac59db95bc 100644 > --- a/include/linux/of_iommu.h > +++ b/include/linux/of_iommu.h > @@ -33,9 +33,6 @@ static inline const struct iommu_ops *of_iommu_configure(struct device *dev, > > extern struct of_device_id __iommu_of_table; > > -typedef int (*of_iommu_init_fn)(struct device_node *); > - > -#define IOMMU_OF_DECLARE(name, compat, fn) \ > - _OF_DECLARE(iommu, name, compat, fn, of_iommu_init_fn) > +#define IOMMU_OF_DECLARE(name, compat) OF_DECLARE_1(iommu, name, compat, NULL) > > #endif /* __OF_IOMMU_H */ > Reviewed-by: Sricharan R <sricharan@codeaurora.org> Regards, Sricharan -- "QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 1/2] iommu/msm: Claim bus ops on probe 2018-01-08 18:42 ` Robin Murphy @ 2018-01-09 6:04 ` Sricharan R -1 siblings, 0 replies; 18+ messages in thread From: Sricharan R @ 2018-01-09 6:04 UTC (permalink / raw) To: Robin Murphy, alex.williamson-H+wXaHxf7aLQT0dZR+AlfA, joro-zLv9SwRftAIdnm+yROfE0A Cc: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA, srinivas.kandagatla-QSEj5FYQhm4dnm+yROfE0A, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r On 1/9/2018 12:12 AM, Robin Murphy wrote: > Since the MSM IOMMU driver now probes via DT exclusively rather than > platform data, dependent masters should be deferred until the IOMMU > itself is ready. Thus we can do away with the early initialisation > hook to unconditionally claim the bus ops, and instead do that only > once an IOMMU is actually probed. Furthermore, this should also make > the driver safe for multiplatform kernels on non-MSM SoCs. > > Signed-off-by: Robin Murphy <robin.murphy-5wv7dgnIgG8@public.gmane.org> > --- > drivers/iommu/msm_iommu.c | 16 +++------------- > 1 file changed, 3 insertions(+), 13 deletions(-) > > diff --git a/drivers/iommu/msm_iommu.c b/drivers/iommu/msm_iommu.c > index 04f4d51ffacb..dda1ce87a070 100644 > --- a/drivers/iommu/msm_iommu.c > +++ b/drivers/iommu/msm_iommu.c > @@ -823,6 +823,8 @@ static int msm_iommu_probe(struct platform_device *pdev) > goto fail; > } > > + bus_set_iommu(&platform_bus_type, &msm_iommu_ops); > + > pr_info("device mapped at %p, irq %d with %d ctx banks\n", > iommu->base, iommu->irq, iommu->ncb); > > @@ -875,19 +877,7 @@ static void __exit msm_iommu_driver_exit(void) > subsys_initcall(msm_iommu_driver_init); > module_exit(msm_iommu_driver_exit); > > -static int __init msm_iommu_init(void) > -{ > - bus_set_iommu(&platform_bus_type, &msm_iommu_ops); > - return 0; > -} > - > -static int __init msm_iommu_of_setup(struct device_node *np) > -{ > - msm_iommu_init(); > - return 0; > -} > - > -IOMMU_OF_DECLARE(msm_iommu_of, "qcom,apq8064-iommu", msm_iommu_of_setup); > +IOMMU_OF_DECLARE(msm_iommu_of, "qcom,apq8064-iommu", NULL); > > MODULE_LICENSE("GPL v2"); > MODULE_AUTHOR("Stepan Moskovchenko <stepanm-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>"); > Reviewed-by: Sricharan R <sricharan-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> Regards, Sricharan -- "QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation ^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH 1/2] iommu/msm: Claim bus ops on probe @ 2018-01-09 6:04 ` Sricharan R 0 siblings, 0 replies; 18+ messages in thread From: Sricharan R @ 2018-01-09 6:04 UTC (permalink / raw) To: linux-arm-kernel On 1/9/2018 12:12 AM, Robin Murphy wrote: > Since the MSM IOMMU driver now probes via DT exclusively rather than > platform data, dependent masters should be deferred until the IOMMU > itself is ready. Thus we can do away with the early initialisation > hook to unconditionally claim the bus ops, and instead do that only > once an IOMMU is actually probed. Furthermore, this should also make > the driver safe for multiplatform kernels on non-MSM SoCs. > > Signed-off-by: Robin Murphy <robin.murphy@arm.com> > --- > drivers/iommu/msm_iommu.c | 16 +++------------- > 1 file changed, 3 insertions(+), 13 deletions(-) > > diff --git a/drivers/iommu/msm_iommu.c b/drivers/iommu/msm_iommu.c > index 04f4d51ffacb..dda1ce87a070 100644 > --- a/drivers/iommu/msm_iommu.c > +++ b/drivers/iommu/msm_iommu.c > @@ -823,6 +823,8 @@ static int msm_iommu_probe(struct platform_device *pdev) > goto fail; > } > > + bus_set_iommu(&platform_bus_type, &msm_iommu_ops); > + > pr_info("device mapped at %p, irq %d with %d ctx banks\n", > iommu->base, iommu->irq, iommu->ncb); > > @@ -875,19 +877,7 @@ static void __exit msm_iommu_driver_exit(void) > subsys_initcall(msm_iommu_driver_init); > module_exit(msm_iommu_driver_exit); > > -static int __init msm_iommu_init(void) > -{ > - bus_set_iommu(&platform_bus_type, &msm_iommu_ops); > - return 0; > -} > - > -static int __init msm_iommu_of_setup(struct device_node *np) > -{ > - msm_iommu_init(); > - return 0; > -} > - > -IOMMU_OF_DECLARE(msm_iommu_of, "qcom,apq8064-iommu", msm_iommu_of_setup); > +IOMMU_OF_DECLARE(msm_iommu_of, "qcom,apq8064-iommu", NULL); > > MODULE_LICENSE("GPL v2"); > MODULE_AUTHOR("Stepan Moskovchenko <stepanm@codeaurora.org>"); > Reviewed-by: Sricharan R <sricharan@codeaurora.org> Regards, Sricharan -- "QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 1/2] iommu/msm: Claim bus ops on probe 2018-01-08 18:42 ` Robin Murphy @ 2018-01-17 13:33 ` Joerg Roedel -1 siblings, 0 replies; 18+ messages in thread From: Joerg Roedel @ 2018-01-17 13:33 UTC (permalink / raw) To: Robin Murphy Cc: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA, srinivas.kandagatla-QSEj5FYQhm4dnm+yROfE0A, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r On Mon, Jan 08, 2018 at 06:42:30PM +0000, Robin Murphy wrote: > Since the MSM IOMMU driver now probes via DT exclusively rather than > platform data, dependent masters should be deferred until the IOMMU > itself is ready. Thus we can do away with the early initialisation > hook to unconditionally claim the bus ops, and instead do that only > once an IOMMU is actually probed. Furthermore, this should also make > the driver safe for multiplatform kernels on non-MSM SoCs. > > Signed-off-by: Robin Murphy <robin.murphy-5wv7dgnIgG8@public.gmane.org> Applied both, thanks Robin. ^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH 1/2] iommu/msm: Claim bus ops on probe @ 2018-01-17 13:33 ` Joerg Roedel 0 siblings, 0 replies; 18+ messages in thread From: Joerg Roedel @ 2018-01-17 13:33 UTC (permalink / raw) To: linux-arm-kernel On Mon, Jan 08, 2018 at 06:42:30PM +0000, Robin Murphy wrote: > Since the MSM IOMMU driver now probes via DT exclusively rather than > platform data, dependent masters should be deferred until the IOMMU > itself is ready. Thus we can do away with the early initialisation > hook to unconditionally claim the bus ops, and instead do that only > once an IOMMU is actually probed. Furthermore, this should also make > the driver safe for multiplatform kernels on non-MSM SoCs. > > Signed-off-by: Robin Murphy <robin.murphy@arm.com> Applied both, thanks Robin. ^ permalink raw reply [flat|nested] 18+ messages in thread
[parent not found: <20180117133331.vidtyduiu7zr3fwc-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>]
* Re: [PATCH 1/2] iommu/msm: Claim bus ops on probe 2018-01-17 13:33 ` Joerg Roedel @ 2018-01-17 13:39 ` Robin Murphy -1 siblings, 0 replies; 18+ messages in thread From: Robin Murphy @ 2018-01-17 13:39 UTC (permalink / raw) To: Joerg Roedel Cc: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA, srinivas.kandagatla-QSEj5FYQhm4dnm+yROfE0A, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r On 17/01/18 13:33, Joerg Roedel wrote: > On Mon, Jan 08, 2018 at 06:42:30PM +0000, Robin Murphy wrote: >> Since the MSM IOMMU driver now probes via DT exclusively rather than >> platform data, dependent masters should be deferred until the IOMMU >> itself is ready. Thus we can do away with the early initialisation >> hook to unconditionally claim the bus ops, and instead do that only >> once an IOMMU is actually probed. Furthermore, this should also make >> the driver safe for multiplatform kernels on non-MSM SoCs. >> >> Signed-off-by: Robin Murphy <robin.murphy-5wv7dgnIgG8@public.gmane.org> > > Applied both, thanks Robin. Oops, patch #2 of this series will break the build, as it was accidentally based on an older branch missing the Renesas IPMMU updates. Please see v2 [1] - I'm still hoping for confirmation from the Renesas folks, but it *should* be fine... Incidentally, per your other mail, these changes also makes Jeffy's "Only do IOMMU lookup for available ones" patch obsolete. Sorry for the mess, Robin. [1] https://lists.linuxfoundation.org/pipermail/iommu/2018-January/025395.html ^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH 1/2] iommu/msm: Claim bus ops on probe @ 2018-01-17 13:39 ` Robin Murphy 0 siblings, 0 replies; 18+ messages in thread From: Robin Murphy @ 2018-01-17 13:39 UTC (permalink / raw) To: linux-arm-kernel On 17/01/18 13:33, Joerg Roedel wrote: > On Mon, Jan 08, 2018 at 06:42:30PM +0000, Robin Murphy wrote: >> Since the MSM IOMMU driver now probes via DT exclusively rather than >> platform data, dependent masters should be deferred until the IOMMU >> itself is ready. Thus we can do away with the early initialisation >> hook to unconditionally claim the bus ops, and instead do that only >> once an IOMMU is actually probed. Furthermore, this should also make >> the driver safe for multiplatform kernels on non-MSM SoCs. >> >> Signed-off-by: Robin Murphy <robin.murphy@arm.com> > > Applied both, thanks Robin. Oops, patch #2 of this series will break the build, as it was accidentally based on an older branch missing the Renesas IPMMU updates. Please see v2 [1] - I'm still hoping for confirmation from the Renesas folks, but it *should* be fine... Incidentally, per your other mail, these changes also makes Jeffy's "Only do IOMMU lookup for available ones" patch obsolete. Sorry for the mess, Robin. [1] https://lists.linuxfoundation.org/pipermail/iommu/2018-January/025395.html ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 1/2] iommu/msm: Claim bus ops on probe 2018-01-17 13:39 ` Robin Murphy @ 2018-01-17 13:53 ` Joerg Roedel -1 siblings, 0 replies; 18+ messages in thread From: Joerg Roedel @ 2018-01-17 13:53 UTC (permalink / raw) To: Robin Murphy Cc: architt, iommu, alex.williamson, srinivas.kandagatla, sricharan, linux-arm-kernel Hi Robin, On Wed, Jan 17, 2018 at 01:39:18PM +0000, Robin Murphy wrote: > Oops, patch #2 of this series will break the build, as it was accidentally > based on an older branch missing the Renesas IPMMU updates. So patch #2 needs the ipmmu-patch from your v2 post to build? I am a bit confused... > Please see v2 [1] - I'm still hoping for confirmation from the Renesas > folks, but it *should* be fine... I can apply the patches again from your v2 post, thats fine, I just want to understand the dependencies first. > Incidentally, per your other mail, these changes also makes Jeffy's "Only do > IOMMU lookup for available ones" patch obsolete. Okay, thanks for letting me know. Thanks, Joerg ^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH 1/2] iommu/msm: Claim bus ops on probe @ 2018-01-17 13:53 ` Joerg Roedel 0 siblings, 0 replies; 18+ messages in thread From: Joerg Roedel @ 2018-01-17 13:53 UTC (permalink / raw) To: linux-arm-kernel Hi Robin, On Wed, Jan 17, 2018 at 01:39:18PM +0000, Robin Murphy wrote: > Oops, patch #2 of this series will break the build, as it was accidentally > based on an older branch missing the Renesas IPMMU updates. So patch #2 needs the ipmmu-patch from your v2 post to build? I am a bit confused... > Please see v2 [1] - I'm still hoping for confirmation from the Renesas > folks, but it *should* be fine... I can apply the patches again from your v2 post, thats fine, I just want to understand the dependencies first. > Incidentally, per your other mail, these changes also makes Jeffy's "Only do > IOMMU lookup for available ones" patch obsolete. Okay, thanks for letting me know. Thanks, Joerg ^ permalink raw reply [flat|nested] 18+ messages in thread
[parent not found: <20180117135356.GQ28161-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>]
* Re: [PATCH 1/2] iommu/msm: Claim bus ops on probe 2018-01-17 13:53 ` Joerg Roedel @ 2018-01-17 14:05 ` Robin Murphy -1 siblings, 0 replies; 18+ messages in thread From: Robin Murphy @ 2018-01-17 14:05 UTC (permalink / raw) To: Joerg Roedel Cc: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA, srinivas.kandagatla-QSEj5FYQhm4dnm+yROfE0A, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r On 17/01/18 13:53, Joerg Roedel wrote: > Hi Robin, > > On Wed, Jan 17, 2018 at 01:39:18PM +0000, Robin Murphy wrote: >> Oops, patch #2 of this series will break the build, as it was accidentally >> based on an older branch missing the Renesas IPMMU updates. > > So patch #2 needs the ipmmu-patch from your v2 post to build? I am a bit > confused... > >> Please see v2 [1] - I'm still hoping for confirmation from the Renesas >> folks, but it *should* be fine... > > I can apply the patches again from your v2 post, thats fine, I just want > to understand the dependencies first. The IOMMU_OF_DECLARE() in ipmmu-vmsa.c added in 4.15 is missed by the prototype change in (4.14-based) v1 2/2 - by applying v2 2/3 on top of the two v1 patches you will end up with an extra NULL argument there which will then fail to compile. v2 3/3 supersedes v1 2/2 by removing that one as well. This is entirely my fault for hacking out some quick patches on top of unrelated development work instead of creating a fresh branch... >> Incidentally, per your other mail, these changes also makes Jeffy's "Only do >> IOMMU lookup for available ones" patch obsolete. > > Okay, thanks for letting me know. Cheers, Robin. ^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH 1/2] iommu/msm: Claim bus ops on probe @ 2018-01-17 14:05 ` Robin Murphy 0 siblings, 0 replies; 18+ messages in thread From: Robin Murphy @ 2018-01-17 14:05 UTC (permalink / raw) To: linux-arm-kernel On 17/01/18 13:53, Joerg Roedel wrote: > Hi Robin, > > On Wed, Jan 17, 2018 at 01:39:18PM +0000, Robin Murphy wrote: >> Oops, patch #2 of this series will break the build, as it was accidentally >> based on an older branch missing the Renesas IPMMU updates. > > So patch #2 needs the ipmmu-patch from your v2 post to build? I am a bit > confused... > >> Please see v2 [1] - I'm still hoping for confirmation from the Renesas >> folks, but it *should* be fine... > > I can apply the patches again from your v2 post, thats fine, I just want > to understand the dependencies first. The IOMMU_OF_DECLARE() in ipmmu-vmsa.c added in 4.15 is missed by the prototype change in (4.14-based) v1 2/2 - by applying v2 2/3 on top of the two v1 patches you will end up with an extra NULL argument there which will then fail to compile. v2 3/3 supersedes v1 2/2 by removing that one as well. This is entirely my fault for hacking out some quick patches on top of unrelated development work instead of creating a fresh branch... >> Incidentally, per your other mail, these changes also makes Jeffy's "Only do >> IOMMU lookup for available ones" patch obsolete. > > Okay, thanks for letting me know. Cheers, Robin. ^ permalink raw reply [flat|nested] 18+ messages in thread
[parent not found: <fc884e48-bf80-23a7-8275-209950e0ef34-5wv7dgnIgG8@public.gmane.org>]
* Re: [PATCH 1/2] iommu/msm: Claim bus ops on probe 2018-01-17 14:05 ` Robin Murphy @ 2018-01-17 14:27 ` Joerg Roedel -1 siblings, 0 replies; 18+ messages in thread From: Joerg Roedel @ 2018-01-17 14:27 UTC (permalink / raw) To: Robin Murphy Cc: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA, srinivas.kandagatla-QSEj5FYQhm4dnm+yROfE0A, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r On Wed, Jan 17, 2018 at 02:05:21PM +0000, Robin Murphy wrote: > The IOMMU_OF_DECLARE() in ipmmu-vmsa.c added in 4.15 is missed by the > prototype change in (4.14-based) v1 2/2 - by applying v2 2/3 on top of the > two v1 patches you will end up with an extra NULL argument there which will > then fail to compile. v2 3/3 supersedes v1 2/2 by removing that one as well. > This is entirely my fault for hacking out some quick patches on top of > unrelated development work instead of creating a fresh branch... Okay, I see. So I removed the two patches from arm/msm and the one patch from arm/renesas and applied all 3 patches from v2 to the core branch instead. Thanks, Joerg ^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH 1/2] iommu/msm: Claim bus ops on probe @ 2018-01-17 14:27 ` Joerg Roedel 0 siblings, 0 replies; 18+ messages in thread From: Joerg Roedel @ 2018-01-17 14:27 UTC (permalink / raw) To: linux-arm-kernel On Wed, Jan 17, 2018 at 02:05:21PM +0000, Robin Murphy wrote: > The IOMMU_OF_DECLARE() in ipmmu-vmsa.c added in 4.15 is missed by the > prototype change in (4.14-based) v1 2/2 - by applying v2 2/3 on top of the > two v1 patches you will end up with an extra NULL argument there which will > then fail to compile. v2 3/3 supersedes v1 2/2 by removing that one as well. > This is entirely my fault for hacking out some quick patches on top of > unrelated development work instead of creating a fresh branch... Okay, I see. So I removed the two patches from arm/msm and the one patch from arm/renesas and applied all 3 patches from v2 to the core branch instead. Thanks, Joerg ^ permalink raw reply [flat|nested] 18+ messages in thread
end of thread, other threads:[~2018-01-17 14:27 UTC | newest]
Thread overview: 18+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-08 18:42 [PATCH 1/2] iommu/msm: Claim bus ops on probe Robin Murphy
2018-01-08 18:42 ` Robin Murphy
[not found] ` <f1a506337bf602c54f4d6d417c14ca556a5f3674.1515436860.git.robin.murphy-5wv7dgnIgG8@public.gmane.org>
2018-01-08 18:42 ` [PATCH 2/2] iommu: Clean up of_iommu_init_fn Robin Murphy
2018-01-08 18:42 ` Robin Murphy
[not found] ` <1eb597bb451da7e723b83369d5dc6ee478e802f5.1515436860.git.robin.murphy-5wv7dgnIgG8@public.gmane.org>
2018-01-09 6:19 ` Sricharan R
2018-01-09 6:19 ` Sricharan R
2018-01-09 6:04 ` [PATCH 1/2] iommu/msm: Claim bus ops on probe Sricharan R
2018-01-09 6:04 ` Sricharan R
2018-01-17 13:33 ` Joerg Roedel
2018-01-17 13:33 ` Joerg Roedel
[not found] ` <20180117133331.vidtyduiu7zr3fwc-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2018-01-17 13:39 ` Robin Murphy
2018-01-17 13:39 ` Robin Murphy
2018-01-17 13:53 ` Joerg Roedel
2018-01-17 13:53 ` Joerg Roedel
[not found] ` <20180117135356.GQ28161-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2018-01-17 14:05 ` Robin Murphy
2018-01-17 14:05 ` Robin Murphy
[not found] ` <fc884e48-bf80-23a7-8275-209950e0ef34-5wv7dgnIgG8@public.gmane.org>
2018-01-17 14:27 ` Joerg Roedel
2018-01-17 14:27 ` Joerg Roedel
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.