* [PATCH] drm: rcar-du: Remove zpos field from rcar_du_vsp_plane_state structure
@ 2018-01-17 18:44 Laurent Pinchart
2018-01-31 8:12 ` Daniel Vetter
0 siblings, 1 reply; 2+ messages in thread
From: Laurent Pinchart @ 2018-01-17 18:44 UTC (permalink / raw)
To: dri-devel; +Cc: linux-renesas-soc
Since commit 2fc4d838aaf2 ("drm: rcar: use generic code for managing
zpos plane property") the rcar-du driver stores the plane zpos in the
drm_plane_state structure. The commit however forgot to remove the zpos
field from the rcar_du_vsp_plane_state structure. Remove it.
Fixes: 2fc4d838aaf2 ("drm: rcar: use generic code for managing zpos plane property")
Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
---
drivers/gpu/drm/rcar-du/rcar_du_vsp.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/rcar-du/rcar_du_vsp.h b/drivers/gpu/drm/rcar-du/rcar_du_vsp.h
index f876c512163c..4c5d7bbce6aa 100644
--- a/drivers/gpu/drm/rcar-du/rcar_du_vsp.h
+++ b/drivers/gpu/drm/rcar-du/rcar_du_vsp.h
@@ -45,7 +45,6 @@ static inline struct rcar_du_vsp_plane *to_rcar_vsp_plane(struct drm_plane *p)
* @format: information about the pixel format used by the plane
* @sg_tables: scatter-gather tables for the frame buffer memory
* @alpha: value of the plane alpha property
- * @zpos: value of the plane zpos property
*/
struct rcar_du_vsp_plane_state {
struct drm_plane_state state;
@@ -54,7 +53,6 @@ struct rcar_du_vsp_plane_state {
struct sg_table sg_tables[3];
unsigned int alpha;
- unsigned int zpos;
};
static inline struct rcar_du_vsp_plane_state *
--
Regards,
Laurent Pinchart
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm: rcar-du: Remove zpos field from rcar_du_vsp_plane_state structure
2018-01-17 18:44 [PATCH] drm: rcar-du: Remove zpos field from rcar_du_vsp_plane_state structure Laurent Pinchart
@ 2018-01-31 8:12 ` Daniel Vetter
0 siblings, 0 replies; 2+ messages in thread
From: Daniel Vetter @ 2018-01-31 8:12 UTC (permalink / raw)
To: Laurent Pinchart; +Cc: dri-devel, linux-renesas-soc
On Wed, Jan 17, 2018 at 08:44:29PM +0200, Laurent Pinchart wrote:
> Since commit 2fc4d838aaf2 ("drm: rcar: use generic code for managing
> zpos plane property") the rcar-du driver stores the plane zpos in the
> drm_plane_state structure. The commit however forgot to remove the zpos
> field from the rcar_du_vsp_plane_state structure. Remove it.
>
> Fixes: 2fc4d838aaf2 ("drm: rcar: use generic code for managing zpos plane property")
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
More Cc: helps sometimes, e.g. dim fixes autoadds all you ever want :-)
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> ---
> drivers/gpu/drm/rcar-du/rcar_du_vsp.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/rcar-du/rcar_du_vsp.h b/drivers/gpu/drm/rcar-du/rcar_du_vsp.h
> index f876c512163c..4c5d7bbce6aa 100644
> --- a/drivers/gpu/drm/rcar-du/rcar_du_vsp.h
> +++ b/drivers/gpu/drm/rcar-du/rcar_du_vsp.h
> @@ -45,7 +45,6 @@ static inline struct rcar_du_vsp_plane *to_rcar_vsp_plane(struct drm_plane *p)
> * @format: information about the pixel format used by the plane
> * @sg_tables: scatter-gather tables for the frame buffer memory
> * @alpha: value of the plane alpha property
> - * @zpos: value of the plane zpos property
> */
> struct rcar_du_vsp_plane_state {
> struct drm_plane_state state;
> @@ -54,7 +53,6 @@ struct rcar_du_vsp_plane_state {
> struct sg_table sg_tables[3];
>
> unsigned int alpha;
> - unsigned int zpos;
> };
>
> static inline struct rcar_du_vsp_plane_state *
> --
> Regards,
>
> Laurent Pinchart
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-01-31 8:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-17 18:44 [PATCH] drm: rcar-du: Remove zpos field from rcar_du_vsp_plane_state structure Laurent Pinchart
2018-01-31 8:12 ` Daniel Vetter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.