From: Jesus Sanchez-Palencia <jesus.sanchez-palencia@intel.com> To: netdev@vger.kernel.org Cc: jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us, vinicius.gomes@intel.com, richardcochran@gmail.com, intel-wired-lan@lists.osuosl.org, anna-maria@linutronix.de, henrik@austad.us, tglx@linutronix.de, john.stultz@linaro.org, andre.guedes@intel.com, ivan.briano@intel.com, levi.pearson@harman.com, Jesus Sanchez-Palencia <jesus.sanchez-palencia@intel.com> Subject: [RFC v2 net-next 09/10] igb: Refactor igb_offload_cbs() Date: Wed, 17 Jan 2018 15:06:20 -0800 [thread overview] Message-ID: <20180117230621.26074-10-jesus.sanchez-palencia@intel.com> (raw) In-Reply-To: <20180117230621.26074-1-jesus.sanchez-palencia@intel.com> Split code into a separate function (igb_offload_apply()) that will be used by TBS offload implementation. Signed-off-by: Jesus Sanchez-Palencia <jesus.sanchez-palencia@intel.com> --- drivers/net/ethernet/intel/igb/igb_main.c | 23 ++++++++++++++--------- 1 file changed, 14 insertions(+), 9 deletions(-) diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c index a955e1723ed5..fc2fc571b87b 100644 --- a/drivers/net/ethernet/intel/igb/igb_main.c +++ b/drivers/net/ethernet/intel/igb/igb_main.c @@ -2462,6 +2462,19 @@ igb_features_check(struct sk_buff *skb, struct net_device *dev, return features; } +static void igb_offload_apply(struct igb_adapter *adapter, s32 queue) +{ + if (!is_fqtss_enabled(adapter)) { + enable_fqtss(adapter, true); + return; + } + + igb_config_tx_modes(adapter, queue); + + if (!is_any_cbs_enabled(adapter)) + enable_fqtss(adapter, false); +} + static int igb_offload_cbs(struct igb_adapter *adapter, struct tc_cbs_qopt_offload *qopt) { @@ -2482,15 +2495,7 @@ static int igb_offload_cbs(struct igb_adapter *adapter, if (err) return err; - if (is_fqtss_enabled(adapter)) { - igb_config_tx_modes(adapter, qopt->queue); - - if (!is_any_cbs_enabled(adapter)) - enable_fqtss(adapter, false); - - } else { - enable_fqtss(adapter, true); - } + igb_offload_apply(adapter, qopt->queue); return 0; } -- 2.15.1
WARNING: multiple messages have this Message-ID (diff)
From: Jesus Sanchez-Palencia <jesus.sanchez-palencia@intel.com> To: intel-wired-lan@osuosl.org Subject: [Intel-wired-lan] [RFC v2 net-next 09/10] igb: Refactor igb_offload_cbs() Date: Wed, 17 Jan 2018 15:06:20 -0800 [thread overview] Message-ID: <20180117230621.26074-10-jesus.sanchez-palencia@intel.com> (raw) In-Reply-To: <20180117230621.26074-1-jesus.sanchez-palencia@intel.com> Split code into a separate function (igb_offload_apply()) that will be used by TBS offload implementation. Signed-off-by: Jesus Sanchez-Palencia <jesus.sanchez-palencia@intel.com> --- drivers/net/ethernet/intel/igb/igb_main.c | 23 ++++++++++++++--------- 1 file changed, 14 insertions(+), 9 deletions(-) diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c index a955e1723ed5..fc2fc571b87b 100644 --- a/drivers/net/ethernet/intel/igb/igb_main.c +++ b/drivers/net/ethernet/intel/igb/igb_main.c @@ -2462,6 +2462,19 @@ igb_features_check(struct sk_buff *skb, struct net_device *dev, return features; } +static void igb_offload_apply(struct igb_adapter *adapter, s32 queue) +{ + if (!is_fqtss_enabled(adapter)) { + enable_fqtss(adapter, true); + return; + } + + igb_config_tx_modes(adapter, queue); + + if (!is_any_cbs_enabled(adapter)) + enable_fqtss(adapter, false); +} + static int igb_offload_cbs(struct igb_adapter *adapter, struct tc_cbs_qopt_offload *qopt) { @@ -2482,15 +2495,7 @@ static int igb_offload_cbs(struct igb_adapter *adapter, if (err) return err; - if (is_fqtss_enabled(adapter)) { - igb_config_tx_modes(adapter, qopt->queue); - - if (!is_any_cbs_enabled(adapter)) - enable_fqtss(adapter, false); - - } else { - enable_fqtss(adapter, true); - } + igb_offload_apply(adapter, qopt->queue); return 0; } -- 2.15.1
next prev parent reply other threads:[~2018-01-17 23:07 UTC|newest] Thread overview: 86+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-01-17 23:06 [RFC v2 net-next 00/10] Time based packet transmission Jesus Sanchez-Palencia 2018-01-17 23:06 ` [Intel-wired-lan] " Jesus Sanchez-Palencia 2018-01-17 23:06 ` [RFC v2 net-next 01/10] net: Add a new socket option for a future transmit time Jesus Sanchez-Palencia 2018-01-17 23:06 ` [Intel-wired-lan] " Jesus Sanchez-Palencia 2018-01-18 8:42 ` Miroslav Lichvar 2018-01-18 8:42 ` Miroslav Lichvar 2018-01-18 17:13 ` Richard Cochran 2018-01-18 17:13 ` Richard Cochran 2018-02-01 0:49 ` Jesus Sanchez-Palencia 2018-02-01 0:49 ` Jesus Sanchez-Palencia 2018-02-01 4:16 ` Richard Cochran 2018-02-01 4:16 ` Richard Cochran 2018-02-01 9:27 ` Miroslav Lichvar 2018-02-01 9:27 ` Miroslav Lichvar 2018-02-01 20:55 ` Jesus Sanchez-Palencia 2018-02-01 20:55 ` Jesus Sanchez-Palencia 2018-01-23 21:22 ` Vinicius Costa Gomes 2018-01-23 21:22 ` Vinicius Costa Gomes 2018-01-24 3:04 ` Richard Cochran 2018-01-24 3:04 ` Richard Cochran 2018-01-24 22:46 ` Vinicius Costa Gomes 2018-01-24 22:46 ` Vinicius Costa Gomes 2018-01-26 2:12 ` Richard Cochran 2018-01-26 2:12 ` Richard Cochran 2018-02-12 22:39 ` Jesus Sanchez-Palencia 2018-02-12 22:39 ` Jesus Sanchez-Palencia 2018-02-13 9:56 ` Miroslav Lichvar 2018-02-13 9:56 ` Miroslav Lichvar 2018-01-18 17:11 ` Richard Cochran 2018-01-18 17:11 ` [Intel-wired-lan] " Richard Cochran 2018-01-23 18:12 ` Jesus Sanchez-Palencia 2018-01-23 18:12 ` [Intel-wired-lan] " Jesus Sanchez-Palencia 2018-01-19 21:15 ` Willem de Bruijn 2018-01-19 21:15 ` [Intel-wired-lan] " Willem de Bruijn 2018-01-20 2:09 ` Richard Cochran 2018-01-20 2:09 ` [Intel-wired-lan] " Richard Cochran 2018-01-25 9:12 ` Miroslav Lichvar 2018-01-25 9:12 ` Miroslav Lichvar 2018-01-25 16:52 ` Richard Cochran 2018-01-25 16:52 ` Richard Cochran 2018-01-23 18:24 ` Jesus Sanchez-Palencia 2018-01-23 18:24 ` [Intel-wired-lan] " Jesus Sanchez-Palencia 2018-01-23 20:02 ` Willem de Bruijn 2018-01-23 20:02 ` [Intel-wired-lan] " Willem de Bruijn 2018-01-17 23:06 ` [RFC v2 net-next 02/10] net: ipv4: raw: Hook into time based transmission Jesus Sanchez-Palencia 2018-01-17 23:06 ` [Intel-wired-lan] " Jesus Sanchez-Palencia 2018-01-18 0:28 ` Eric Dumazet 2018-01-18 0:28 ` [Intel-wired-lan] " Eric Dumazet 2018-01-17 23:06 ` [RFC v2 net-next 03/10] net: ipv4: udp: " Jesus Sanchez-Palencia 2018-01-17 23:06 ` [Intel-wired-lan] " Jesus Sanchez-Palencia 2018-01-17 23:06 ` [RFC v2 net-next 04/10] net: packet: " Jesus Sanchez-Palencia 2018-01-17 23:06 ` [Intel-wired-lan] " Jesus Sanchez-Palencia 2018-01-17 23:06 ` [RFC v2 net-next 05/10] net/sched: Allow creating a Qdisc watchdog with other clocks Jesus Sanchez-Palencia 2018-01-17 23:06 ` [Intel-wired-lan] " Jesus Sanchez-Palencia 2018-01-17 23:06 ` [RFC v2 net-next 06/10] net/sched: Introduce the TBS Qdisc Jesus Sanchez-Palencia 2018-01-17 23:06 ` [Intel-wired-lan] " Jesus Sanchez-Palencia 2018-01-18 13:35 ` Jamal Hadi Salim 2018-01-18 13:35 ` [Intel-wired-lan] " Jamal Hadi Salim 2018-01-18 13:44 ` Jamal Hadi Salim 2018-01-18 13:44 ` [Intel-wired-lan] " Jamal Hadi Salim 2018-01-23 21:45 ` Jesus Sanchez-Palencia 2018-01-23 21:45 ` [Intel-wired-lan] " Jesus Sanchez-Palencia 2018-01-18 17:18 ` Richard Cochran 2018-01-18 17:18 ` [Intel-wired-lan] " Richard Cochran 2018-01-23 22:01 ` Jesus Sanchez-Palencia 2018-01-23 22:01 ` [Intel-wired-lan] " Jesus Sanchez-Palencia 2018-01-19 21:18 ` Willem de Bruijn 2018-01-19 21:18 ` [Intel-wired-lan] " Willem de Bruijn 2018-01-17 23:06 ` [RFC v2 net-next 07/10] igb: Refactor igb_configure_cbs() Jesus Sanchez-Palencia 2018-01-17 23:06 ` [Intel-wired-lan] " Jesus Sanchez-Palencia 2018-01-17 23:06 ` [RFC v2 net-next 08/10] igb: Only change Tx arbitration when CBS is on Jesus Sanchez-Palencia 2018-01-17 23:06 ` [Intel-wired-lan] " Jesus Sanchez-Palencia 2018-01-17 23:06 ` Jesus Sanchez-Palencia [this message] 2018-01-17 23:06 ` [Intel-wired-lan] [RFC v2 net-next 09/10] igb: Refactor igb_offload_cbs() Jesus Sanchez-Palencia 2018-01-17 23:06 ` [RFC v2 net-next 10/10] igb: Add support for TBS offload Jesus Sanchez-Palencia 2018-01-17 23:06 ` [Intel-wired-lan] " Jesus Sanchez-Palencia 2018-01-23 5:23 ` [RFC v2 net-next 00/10] Time based packet transmission Richard Cochran 2018-01-23 5:23 ` [Intel-wired-lan] " Richard Cochran 2018-01-23 5:26 ` Richard Cochran 2018-01-23 5:26 ` [Intel-wired-lan] " Richard Cochran 2018-01-23 18:07 ` Jesus Sanchez-Palencia 2018-01-23 18:07 ` [Intel-wired-lan] " Jesus Sanchez-Palencia 2018-01-24 1:43 ` Levi Pearson 2018-01-24 1:43 ` [Intel-wired-lan] " Levi Pearson 2018-01-27 0:04 ` Jesus Sanchez-Palencia 2018-01-27 0:04 ` [Intel-wired-lan] " Jesus Sanchez-Palencia
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20180117230621.26074-10-jesus.sanchez-palencia@intel.com \ --to=jesus.sanchez-palencia@intel.com \ --cc=andre.guedes@intel.com \ --cc=anna-maria@linutronix.de \ --cc=henrik@austad.us \ --cc=intel-wired-lan@lists.osuosl.org \ --cc=ivan.briano@intel.com \ --cc=jhs@mojatatu.com \ --cc=jiri@resnulli.us \ --cc=john.stultz@linaro.org \ --cc=levi.pearson@harman.com \ --cc=netdev@vger.kernel.org \ --cc=richardcochran@gmail.com \ --cc=tglx@linutronix.de \ --cc=vinicius.gomes@intel.com \ --cc=xiyou.wangcong@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.