* [PATCH RESEND] Bluetooth: btbcm: Add entry for BCM4343A0 UART bluetooth
@ 2018-01-17 23:27 Jörg Krause
2018-01-18 7:45 ` Marcel Holtmann
0 siblings, 1 reply; 7+ messages in thread
From: Jörg Krause @ 2018-01-17 23:27 UTC (permalink / raw)
To: linux-bluetooth; +Cc: Marcel Holtmann, Gustavo Padovan, Jörg Krause
UkVTRU5EIGJlY2F1c2Ugb2YgbWlzc2luZyB0aGUgY29ycmVjdCBDY3MuIE9yaWdpbmFsIHBhdGNo
IGlzIFswXS4KClRoaXMgcGF0Y2ggYWRkcyB0aGUgZGV2aWNlIElEIGZvciB0aGUgYmx1ZXRvb3Ro
IGNoaXAgdXNlZCBpbiB0aGUKQU1QQUsgQVA2MjEyIFdpRmkrQmx1ZXRvb3RoIG1vZHVsZS4gVGhl
IEFQNjIxMiBpcyB1c2VkIG9uIHNldmVyYWwKQmFuYW5hUGkgYm9hcmRzLCBlLmcuIE0yLVVsdHJh
LgoKVGhlIEFQNjIxMiBpcyBhIGNvbWJvIG1vZHVsZSwgd2hlcmUgdGhlIFdpRmkgY2hpcCBpcyBp
ZGVudGlmaWVkIGFzCkJDTTQzNDMwQTAgd2hlcmVhcyB0aGUgQmx1ZXRvb3RoIGNoaXAgaWRlbnRp
ZmllcyBpdHNlbGYgYXMgNDM0M0EwLiBOb3RlLAp0aGUgbWlzc2luZyAnMCcgYmVmb3JlIHRoZSAn
QTAnLgoKVGhlIEFQNjIxMiBuZWVkcyBhIGZpcm13YXJlIGJsb2IuIExvYWRpbmcgdGhlIHByb3Zp
ZGVkIGZpcm13YXJlIGZpbGUKZnJvbSB0aGUgQmFuYW5hUGkgdmVuZG9yLCB0aGUgYWRhcHRlciBu
YW1lIGlzIHByaW50ZWQgYXMKJ0JDTTQzNDNBMCAyNk1IeiBBUDYyMTJfQ0wxLTAwNjEnOgoKJycn
CmhjaTA6CVR5cGU6IFByaW1hcnkgIEJ1czogVUFSVAoJQkQgQWRkcmVzczogNDM6NDM6QTA6MTI6
MUY6QUMgIEFDTCBNVFU6IDEwMjE6OCAgU0NPIE1UVTogNjQ6MQoJVVAgUlVOTklORwoJUlggYnl0
ZXM6MzA3NiBhY2w6MCBzY286MCBldmVudHM6Mjc4IGVycm9yczowCglUWCBieXRlczozOTcyNiBh
Y2w6MCBzY286MCBjb21tYW5kczoyNzkgZXJyb3JzOjAKCUZlYXR1cmVzOiAweGJmIDB4ZmUgMHhj
ZiAweGZlIDB4ZGIgMHhmZiAweDdiIDB4ODcKCVBhY2tldCB0eXBlOiBETTEgRE0zIERNNSBESDEg
REgzIERINSBIVjEgSFYyIEhWMwoJTGluayBwb2xpY3k6IFJTV0lUQ0ggU05JRkYKCUxpbmsgbW9k
ZTogU0xBVkUgQUNDRVBUCglOYW1lOiAnQkNNNDM0M0EwIDI2TUh6IEFQNjIxMl9DTDEtMDA2MScK
CUNsYXNzOiAweDAwMDAwMAoJU2VydmljZSBDbGFzc2VzOiBVbnNwZWNpZmllZAoJRGV2aWNlIENs
YXNzOiBNaXNjZWxsYW5lb3VzLAoJSENJIFZlcnNpb246IDQuMSAoMHg3KSAgUmV2aXNpb246IDB4
ZjIKCUxNUCBWZXJzaW9uOiA0LjEgKDB4NykgIFN1YnZlcnNpb246IDB4MjEyMgoJTWFudWZhY3R1
cmVyOiBCcm9hZGNvbSBDb3Jwb3JhdGlvbiAoMTUpCicnJwoKWzBdIGh0dHBzOi8vd3d3LnNwaW5p
Y3MubmV0L2xpc3RzL2xpbnV4LWJsdWV0b290aC9tc2c3MTg3Ni5odG1sCgpTaWduZWQtb2ZmLWJ5
OiBKw7ZyZyBLcmF1c2UgPGpvZXJnLmtyYXVzZUBlbWJlZGRlZC5yb2Nrcz4KLS0tCiBkcml2ZXJz
L2JsdWV0b290aC9idGJjbS5jIHwgMSArCiAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKykK
CmRpZmYgLS1naXQgYS9kcml2ZXJzL2JsdWV0b290aC9idGJjbS5jIGIvZHJpdmVycy9ibHVldG9v
dGgvYnRiY20uYwppbmRleCBjYzRiZGVmYTY2NDguLjQ2ODRiZTI0N2QyOCAxMDA2NDQKLS0tIGEv
ZHJpdmVycy9ibHVldG9vdGgvYnRiY20uYworKysgYi9kcml2ZXJzL2JsdWV0b290aC9idGJjbS5j
CkBAIC0zMjYsNiArMzI2LDcgQEAgc3RhdGljIGNvbnN0IHN0cnVjdCB7CiAJeyAweDQxMGUsICJC
Q000MzM0MUIwIgl9LAkvKiAwMDIuMDAxLjAxNCAqLwogCXsgMHg0NDA2LCAiQkNNNDMyNEIzIgl9
LAkvKiAwMDIuMDA0LjAwNiAqLwogCXsgMHg2MTBjLCAiQkNNNDM1NCIJfSwJLyogMDAzLjAwMS4w
MTIgKi8KKwl7IDB4MjEyMiwgIkJDTTQzNDNBMCIJfSwJLyogMDAxLjAwMS4wMzQgKi8KIAl7IDB4
MjIwOSwgIkJDTTQzNDMwQTEiICB9LAkvKiAwMDEuMDAyLjAwOSAqLwogCXsgfQogfTsKLS0gCjIu
MTUuMQoK
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH RESEND] Bluetooth: btbcm: Add entry for BCM4343A0 UART bluetooth
2018-01-17 23:27 [PATCH RESEND] Bluetooth: btbcm: Add entry for BCM4343A0 UART bluetooth Jörg Krause
@ 2018-01-18 7:45 ` Marcel Holtmann
2018-01-18 8:30 ` Jörg Krause
0 siblings, 1 reply; 7+ messages in thread
From: Marcel Holtmann @ 2018-01-18 7:45 UTC (permalink / raw)
To: Jörg Krause; +Cc: linux-bluetooth, Gustavo F. Padovan
Hi Joerg,
> RESEND because of missing the correct Ccs. Original patch is [0].
>
> This patch adds the device ID for the bluetooth chip used in the
> AMPAK AP6212 WiFi+Bluetooth module. The AP6212 is used on several
> BananaPi boards, e.g. M2-Ultra.
>
> The AP6212 is a combo module, where the WiFi chip is identified as
> BCM43430A0 whereas the Bluetooth chip identifies itself as 4343A0. Note,
> the missing '0' before the 'A0'.
>
> The AP6212 needs a firmware blob. Loading the provided firmware file
> from the BananaPi vendor, the adapter name is printed as
> 'BCM4343A0 26MHz AP6212_CL1-0061':
>
> '''
> hci0: Type: Primary Bus: UART
> BD Address: 43:43:A0:12:1F:AC ACL MTU: 1021:8 SCO MTU: 64:1
> UP RUNNING
> RX bytes:3076 acl:0 sco:0 events:278 errors:0
> TX bytes:39726 acl:0 sco:0 commands:279 errors:0
> Features: 0xbf 0xfe 0xcf 0xfe 0xdb 0xff 0x7b 0x87
> Packet type: DM1 DM3 DM5 DH1 DH3 DH5 HV1 HV2 HV3
> Link policy: RSWITCH SNIFF
> Link mode: SLAVE ACCEPT
> Name: 'BCM4343A0 26MHz AP6212_CL1-0061'
> Class: 0x000000
> Service Classes: Unspecified
> Device Class: Miscellaneous,
> HCI Version: 4.1 (0x7) Revision: 0xf2
> LMP Version: 4.1 (0x7) Subversion: 0x2122
> Manufacturer: Broadcom Corporation (15)
> '''
>
> [0] https://www.spinics.net/lists/linux-bluetooth/msg71876.html
>
> Signed-off-by: Jörg Krause <joerg.krause@embedded.rocks>
> ---
> drivers/bluetooth/btbcm.c | 1 +
> 1 file changed, 1 insertion(+)
can you use git-send-email so that I get a patch that is not base64 encoded. Otherwise I can not apply it.
Regards
Marcel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH RESEND] Bluetooth: btbcm: Add entry for BCM4343A0 UART bluetooth
2018-01-18 7:45 ` Marcel Holtmann
@ 2018-01-18 8:30 ` Jörg Krause
2018-01-18 8:42 ` Marcel Holtmann
0 siblings, 1 reply; 7+ messages in thread
From: Jörg Krause @ 2018-01-18 8:30 UTC (permalink / raw)
To: Marcel Holtmann; +Cc: linux-bluetooth, Gustavo F. Padovan
Hi Marcel,
On Thu, 2018-01-18 at 08:45 +0100, Marcel Holtmann wrote:
> Hi Joerg,
>
> > RESEND because of missing the correct Ccs. Original patch is [0].
> >
> > This patch adds the device ID for the bluetooth chip used in the
> > AMPAK AP6212 WiFi+Bluetooth module. The AP6212 is used on several
> > BananaPi boards, e.g. M2-Ultra.
> >
> > The AP6212 is a combo module, where the WiFi chip is identified as
> > BCM43430A0 whereas the Bluetooth chip identifies itself as 4343A0. Note,
> > the missing '0' before the 'A0'.
> >
> > The AP6212 needs a firmware blob. Loading the provided firmware file
> > from the BananaPi vendor, the adapter name is printed as
> > 'BCM4343A0 26MHz AP6212_CL1-0061':
> >
> > '''
> > hci0: Type: Primary Bus: UART
> > BD Address: 43:43:A0:12:1F:AC ACL MTU: 1021:8 SCO MTU: 64:1
> > UP RUNNING
> > RX bytes:3076 acl:0 sco:0 events:278 errors:0
> > TX bytes:39726 acl:0 sco:0 commands:279 errors:0
> > Features: 0xbf 0xfe 0xcf 0xfe 0xdb 0xff 0x7b 0x87
> > Packet type: DM1 DM3 DM5 DH1 DH3 DH5 HV1 HV2 HV3
> > Link policy: RSWITCH SNIFF
> > Link mode: SLAVE ACCEPT
> > Name: 'BCM4343A0 26MHz AP6212_CL1-0061'
> > Class: 0x000000
> > Service Classes: Unspecified
> > Device Class: Miscellaneous,
> > HCI Version: 4.1 (0x7) Revision: 0xf2
> > LMP Version: 4.1 (0x7) Subversion: 0x2122
> > Manufacturer: Broadcom Corporation (15)
> > '''
> >
> > [0] https://www.spinics.net/lists/linux-bluetooth/msg71876.html
> >
> > Signed-off-by: Jörg Krause <joerg.krause@embedded.rocks>
> > ---
> > drivers/bluetooth/btbcm.c | 1 +
> > 1 file changed, 1 insertion(+)
>
> can you use git-send-email so that I get a patch that is not base64 encoded. Otherwise I can not apply it.
I did use git-send-email, but you're right, I set the transferencoding
to base64. Shall I use 8bit instead?
Best regards,
Jörg Krause
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH RESEND] Bluetooth: btbcm: Add entry for BCM4343A0 UART bluetooth
2018-01-18 8:30 ` Jörg Krause
@ 2018-01-18 8:42 ` Marcel Holtmann
2018-01-18 9:24 ` Jörg Krause
0 siblings, 1 reply; 7+ messages in thread
From: Marcel Holtmann @ 2018-01-18 8:42 UTC (permalink / raw)
To: Jörg Krause; +Cc: open list:BLUETOOTH DRIVERS, Gustavo F. Padovan
Hi Joerg,
>>> RESEND because of missing the correct Ccs. Original patch is [0].
>>>
>>> This patch adds the device ID for the bluetooth chip used in the
>>> AMPAK AP6212 WiFi+Bluetooth module. The AP6212 is used on several
>>> BananaPi boards, e.g. M2-Ultra.
>>>
>>> The AP6212 is a combo module, where the WiFi chip is identified as
>>> BCM43430A0 whereas the Bluetooth chip identifies itself as 4343A0. Note,
>>> the missing '0' before the 'A0'.
>>>
>>> The AP6212 needs a firmware blob. Loading the provided firmware file
>>> from the BananaPi vendor, the adapter name is printed as
>>> 'BCM4343A0 26MHz AP6212_CL1-0061':
>>>
>>> '''
>>> hci0: Type: Primary Bus: UART
>>> BD Address: 43:43:A0:12:1F:AC ACL MTU: 1021:8 SCO MTU: 64:1
>>> UP RUNNING
>>> RX bytes:3076 acl:0 sco:0 events:278 errors:0
>>> TX bytes:39726 acl:0 sco:0 commands:279 errors:0
>>> Features: 0xbf 0xfe 0xcf 0xfe 0xdb 0xff 0x7b 0x87
>>> Packet type: DM1 DM3 DM5 DH1 DH3 DH5 HV1 HV2 HV3
>>> Link policy: RSWITCH SNIFF
>>> Link mode: SLAVE ACCEPT
>>> Name: 'BCM4343A0 26MHz AP6212_CL1-0061'
>>> Class: 0x000000
>>> Service Classes: Unspecified
>>> Device Class: Miscellaneous,
>>> HCI Version: 4.1 (0x7) Revision: 0xf2
>>> LMP Version: 4.1 (0x7) Subversion: 0x2122
>>> Manufacturer: Broadcom Corporation (15)
>>> '''
>>>
>>> [0] https://www.spinics.net/lists/linux-bluetooth/msg71876.html
>>>
>>> Signed-off-by: Jörg Krause <joerg.krause@embedded.rocks>
>>> ---
>>> drivers/bluetooth/btbcm.c | 1 +
>>> 1 file changed, 1 insertion(+)
>>
>> can you use git-send-email so that I get a patch that is not base64 encoded. Otherwise I can not apply it.
>
> I did use git-send-email, but you're right, I set the transferencoding
> to base64. Shall I use 8bit instead?
I need the patch portion in plain ASCII if possible. Or something that git-am accepts.
Regards
Marcel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH RESEND] Bluetooth: btbcm: Add entry for BCM4343A0 UART bluetooth
2018-01-18 8:42 ` Marcel Holtmann
@ 2018-01-18 9:24 ` Jörg Krause
0 siblings, 0 replies; 7+ messages in thread
From: Jörg Krause @ 2018-01-18 9:24 UTC (permalink / raw)
To: Marcel Holtmann; +Cc: open list:BLUETOOTH DRIVERS, Gustavo F. Padovan
Hi Marcel,
On Thu, 2018-01-18 at 09:42 +0100, Marcel Holtmann wrote:
> Hi Joerg,
>
> > > > RESEND because of missing the correct Ccs. Original patch is [0].
> > > >
> > > > This patch adds the device ID for the bluetooth chip used in the
> > > > AMPAK AP6212 WiFi+Bluetooth module. The AP6212 is used on several
> > > > BananaPi boards, e.g. M2-Ultra.
> > > >
> > > > The AP6212 is a combo module, where the WiFi chip is identified as
> > > > BCM43430A0 whereas the Bluetooth chip identifies itself as 4343A0. Note,
> > > > the missing '0' before the 'A0'.
> > > >
> > > > The AP6212 needs a firmware blob. Loading the provided firmware file
> > > > from the BananaPi vendor, the adapter name is printed as
> > > > 'BCM4343A0 26MHz AP6212_CL1-0061':
> > > >
> > > > '''
> > > > hci0: Type: Primary Bus: UART
> > > > BD Address: 43:43:A0:12:1F:AC ACL MTU: 1021:8 SCO MTU: 64:1
> > > > UP RUNNING
> > > > RX bytes:3076 acl:0 sco:0 events:278 errors:0
> > > > TX bytes:39726 acl:0 sco:0 commands:279 errors:0
> > > > Features: 0xbf 0xfe 0xcf 0xfe 0xdb 0xff 0x7b 0x87
> > > > Packet type: DM1 DM3 DM5 DH1 DH3 DH5 HV1 HV2 HV3
> > > > Link policy: RSWITCH SNIFF
> > > > Link mode: SLAVE ACCEPT
> > > > Name: 'BCM4343A0 26MHz AP6212_CL1-0061'
> > > > Class: 0x000000
> > > > Service Classes: Unspecified
> > > > Device Class: Miscellaneous,
> > > > HCI Version: 4.1 (0x7) Revision: 0xf2
> > > > LMP Version: 4.1 (0x7) Subversion: 0x2122
> > > > Manufacturer: Broadcom Corporation (15)
> > > > '''
> > > >
> > > > [0] https://www.spinics.net/lists/linux-bluetooth/msg71876.html
> > > >
> > > > Signed-off-by: Jörg Krause <joerg.krause@embedded.rocks>
> > > > ---
> > > > drivers/bluetooth/btbcm.c | 1 +
> > > > 1 file changed, 1 insertion(+)
> > >
> > > can you use git-send-email so that I get a patch that is not base64 encoded. Otherwise I can not apply it.
> >
> > I did use git-send-email, but you're right, I set the transferencoding
> > to base64. Shall I use 8bit instead?
>
> I need the patch portion in plain ASCII if possible. Or something that git-am accepts.
Well, git-am usually accepts base64. I've never heard about a problem
using it. However, I've resend the patch using 8bit encoding.
Best regards,
Jörg
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH RESEND] Bluetooth: btbcm: Add entry for BCM4343A0 UART bluetooth
2018-01-18 9:21 Jörg Krause
@ 2018-01-18 9:25 ` Marcel Holtmann
0 siblings, 0 replies; 7+ messages in thread
From: Marcel Holtmann @ 2018-01-18 9:25 UTC (permalink / raw)
To: Jörg Krause; +Cc: open list:BLUETOOTH DRIVERS, Gustavo F. Padovan
Hi Joerg,
> RESEND using Content-Transfer-Encoding: 8bit instead of base64.
>
> This patch adds the device ID for the bluetooth chip used in the
> AMPAK AP6212 WiFi+Bluetooth module. The AP6212 is used on several
> BananaPi boards, e.g. M2-Ultra.
>
> The AP6212 is a combo module, where the WiFi chip is identified as
> BCM43430A0 whereas the Bluetooth chip identifies itself as 4343A0. Note,
> the missing '0' before the 'A0'.
>
> The AP6212 needs a firmware blob. Loading the provided firmware file
> from the BananaPi vendor, the adapter name is printed as
> 'BCM4343A0 26MHz AP6212_CL1-0061':
>
> '''
> hci0: Type: Primary Bus: UART
> BD Address: 43:43:A0:12:1F:AC ACL MTU: 1021:8 SCO MTU: 64:1
> UP RUNNING
> RX bytes:3076 acl:0 sco:0 events:278 errors:0
> TX bytes:39726 acl:0 sco:0 commands:279 errors:0
> Features: 0xbf 0xfe 0xcf 0xfe 0xdb 0xff 0x7b 0x87
> Packet type: DM1 DM3 DM5 DH1 DH3 DH5 HV1 HV2 HV3
> Link policy: RSWITCH SNIFF
> Link mode: SLAVE ACCEPT
> Name: 'BCM4343A0 26MHz AP6212_CL1-0061'
> Class: 0x000000
> Service Classes: Unspecified
> Device Class: Miscellaneous,
> HCI Version: 4.1 (0x7) Revision: 0xf2
> LMP Version: 4.1 (0x7) Subversion: 0x2122
> Manufacturer: Broadcom Corporation (15)
> '''
>
> Signed-off-by: Jörg Krause <joerg.krause@embedded.rocks>
> ---
> drivers/bluetooth/btbcm.c | 1 +
> 1 file changed, 1 insertion(+)
patch has been applied to bluetooth-next tree.
Regards
Marcel
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH RESEND] Bluetooth: btbcm: Add entry for BCM4343A0 UART bluetooth
@ 2018-01-18 9:21 Jörg Krause
2018-01-18 9:25 ` Marcel Holtmann
0 siblings, 1 reply; 7+ messages in thread
From: Jörg Krause @ 2018-01-18 9:21 UTC (permalink / raw)
To: linux-bluetooth; +Cc: Marcel Holtmann, Gustavo Padovan, Jörg Krause
RESEND using Content-Transfer-Encoding: 8bit instead of base64.
This patch adds the device ID for the bluetooth chip used in the
AMPAK AP6212 WiFi+Bluetooth module. The AP6212 is used on several
BananaPi boards, e.g. M2-Ultra.
The AP6212 is a combo module, where the WiFi chip is identified as
BCM43430A0 whereas the Bluetooth chip identifies itself as 4343A0. Note,
the missing '0' before the 'A0'.
The AP6212 needs a firmware blob. Loading the provided firmware file
from the BananaPi vendor, the adapter name is printed as
'BCM4343A0 26MHz AP6212_CL1-0061':
'''
hci0: Type: Primary Bus: UART
BD Address: 43:43:A0:12:1F:AC ACL MTU: 1021:8 SCO MTU: 64:1
UP RUNNING
RX bytes:3076 acl:0 sco:0 events:278 errors:0
TX bytes:39726 acl:0 sco:0 commands:279 errors:0
Features: 0xbf 0xfe 0xcf 0xfe 0xdb 0xff 0x7b 0x87
Packet type: DM1 DM3 DM5 DH1 DH3 DH5 HV1 HV2 HV3
Link policy: RSWITCH SNIFF
Link mode: SLAVE ACCEPT
Name: 'BCM4343A0 26MHz AP6212_CL1-0061'
Class: 0x000000
Service Classes: Unspecified
Device Class: Miscellaneous,
HCI Version: 4.1 (0x7) Revision: 0xf2
LMP Version: 4.1 (0x7) Subversion: 0x2122
Manufacturer: Broadcom Corporation (15)
'''
Signed-off-by: Jörg Krause <joerg.krause@embedded.rocks>
---
drivers/bluetooth/btbcm.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/bluetooth/btbcm.c b/drivers/bluetooth/btbcm.c
index afa4cb3b16e3..6659f113042c 100644
--- a/drivers/bluetooth/btbcm.c
+++ b/drivers/bluetooth/btbcm.c
@@ -323,6 +323,7 @@ static const struct {
{ 0x410e, "BCM43341B0" }, /* 002.001.014 */
{ 0x4406, "BCM4324B3" }, /* 002.004.006 */
{ 0x610c, "BCM4354" }, /* 003.001.012 */
+ { 0x2122, "BCM4343A0" }, /* 001.001.034 */
{ 0x2209, "BCM43430A1" }, /* 001.002.009 */
{ 0x6119, "BCM4345C0" }, /* 003.001.025 */
{ 0x230f, "BCM4356A2" }, /* 001.003.015 */
--
2.15.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
end of thread, other threads:[~2018-01-18 9:25 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-17 23:27 [PATCH RESEND] Bluetooth: btbcm: Add entry for BCM4343A0 UART bluetooth Jörg Krause
2018-01-18 7:45 ` Marcel Holtmann
2018-01-18 8:30 ` Jörg Krause
2018-01-18 8:42 ` Marcel Holtmann
2018-01-18 9:24 ` Jörg Krause
2018-01-18 9:21 Jörg Krause
2018-01-18 9:25 ` Marcel Holtmann
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.