All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] soc: xilinx: xlnx_vcu: Fix && vs & typo
@ 2018-01-18 10:28 ` Dan Carpenter
  0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2018-01-18 10:28 UTC (permalink / raw)
  To: Michal Simek, Dhaval Shah; +Cc: linux-arm-kernel, linux-kernel, kernel-janitors

We accidentally used a logical AND instead of a bitwise AND here.

Fixes: cee8113a295a ("soc: xilinx: xlnx_vcu: Add Xilinx ZYNQMP VCU logicoreIP init driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/drivers/soc/xilinx/xlnx_vcu.c b/drivers/soc/xilinx/xlnx_vcu.c
index c1d6f1b190b6..a840c0272135 100644
--- a/drivers/soc/xilinx/xlnx_vcu.c
+++ b/drivers/soc/xilinx/xlnx_vcu.c
@@ -334,7 +334,7 @@ static int xvcu_set_vcu_pll_info(struct xvcu_device *xvcu)
 	 */
 	vcu_pll_ctrl = xvcu_read(xvcu->vcu_slcr_ba, VCU_PLL_CTRL);
 	clkoutdiv = vcu_pll_ctrl >> VCU_PLL_CTRL_CLKOUTDIV_SHIFT;
-	clkoutdiv = clkoutdiv && VCU_PLL_CTRL_CLKOUTDIV_MASK;
+	clkoutdiv = clkoutdiv & VCU_PLL_CTRL_CLKOUTDIV_MASK;
 	if (clkoutdiv != 1) {
 		dev_err(xvcu->dev, "clkoutdiv value is invalid\n");
 		return -EINVAL;

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [PATCH] soc: xilinx: xlnx_vcu: Fix && vs & typo
@ 2018-01-18 10:28 ` Dan Carpenter
  0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2018-01-18 10:28 UTC (permalink / raw)
  To: linux-arm-kernel

We accidentally used a logical AND instead of a bitwise AND here.

Fixes: cee8113a295a ("soc: xilinx: xlnx_vcu: Add Xilinx ZYNQMP VCU logicoreIP init driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/drivers/soc/xilinx/xlnx_vcu.c b/drivers/soc/xilinx/xlnx_vcu.c
index c1d6f1b190b6..a840c0272135 100644
--- a/drivers/soc/xilinx/xlnx_vcu.c
+++ b/drivers/soc/xilinx/xlnx_vcu.c
@@ -334,7 +334,7 @@ static int xvcu_set_vcu_pll_info(struct xvcu_device *xvcu)
 	 */
 	vcu_pll_ctrl = xvcu_read(xvcu->vcu_slcr_ba, VCU_PLL_CTRL);
 	clkoutdiv = vcu_pll_ctrl >> VCU_PLL_CTRL_CLKOUTDIV_SHIFT;
-	clkoutdiv = clkoutdiv && VCU_PLL_CTRL_CLKOUTDIV_MASK;
+	clkoutdiv = clkoutdiv & VCU_PLL_CTRL_CLKOUTDIV_MASK;
 	if (clkoutdiv != 1) {
 		dev_err(xvcu->dev, "clkoutdiv value is invalid\n");
 		return -EINVAL;

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [PATCH] soc: xilinx: xlnx_vcu: Fix && vs & typo
@ 2018-01-18 10:28 ` Dan Carpenter
  0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2018-01-18 10:28 UTC (permalink / raw)
  To: linux-arm-kernel

We accidentally used a logical AND instead of a bitwise AND here.

Fixes: cee8113a295a ("soc: xilinx: xlnx_vcu: Add Xilinx ZYNQMP VCU logicoreIP init driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/drivers/soc/xilinx/xlnx_vcu.c b/drivers/soc/xilinx/xlnx_vcu.c
index c1d6f1b190b6..a840c0272135 100644
--- a/drivers/soc/xilinx/xlnx_vcu.c
+++ b/drivers/soc/xilinx/xlnx_vcu.c
@@ -334,7 +334,7 @@ static int xvcu_set_vcu_pll_info(struct xvcu_device *xvcu)
 	 */
 	vcu_pll_ctrl = xvcu_read(xvcu->vcu_slcr_ba, VCU_PLL_CTRL);
 	clkoutdiv = vcu_pll_ctrl >> VCU_PLL_CTRL_CLKOUTDIV_SHIFT;
-	clkoutdiv = clkoutdiv && VCU_PLL_CTRL_CLKOUTDIV_MASK;
+	clkoutdiv = clkoutdiv & VCU_PLL_CTRL_CLKOUTDIV_MASK;
 	if (clkoutdiv != 1) {
 		dev_err(xvcu->dev, "clkoutdiv value is invalid\n");
 		return -EINVAL;

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH] soc: xilinx: xlnx_vcu: Fix && vs & typo
  2018-01-18 10:28 ` Dan Carpenter
  (?)
@ 2018-01-18 11:37   ` Michal Simek
  -1 siblings, 0 replies; 6+ messages in thread
From: Michal Simek @ 2018-01-18 11:37 UTC (permalink / raw)
  To: Dan Carpenter, Michal Simek, Dhaval Shah
  Cc: linux-arm-kernel, linux-kernel, kernel-janitors

On 18.1.2018 11:28, Dan Carpenter wrote:
> We accidentally used a logical AND instead of a bitwise AND here.
> 
> Fixes: cee8113a295a ("soc: xilinx: xlnx_vcu: Add Xilinx ZYNQMP VCU logicoreIP init driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> 
> diff --git a/drivers/soc/xilinx/xlnx_vcu.c b/drivers/soc/xilinx/xlnx_vcu.c
> index c1d6f1b190b6..a840c0272135 100644
> --- a/drivers/soc/xilinx/xlnx_vcu.c
> +++ b/drivers/soc/xilinx/xlnx_vcu.c
> @@ -334,7 +334,7 @@ static int xvcu_set_vcu_pll_info(struct xvcu_device *xvcu)
>  	 */
>  	vcu_pll_ctrl = xvcu_read(xvcu->vcu_slcr_ba, VCU_PLL_CTRL);
>  	clkoutdiv = vcu_pll_ctrl >> VCU_PLL_CTRL_CLKOUTDIV_SHIFT;
> -	clkoutdiv = clkoutdiv && VCU_PLL_CTRL_CLKOUTDIV_MASK;
> +	clkoutdiv = clkoutdiv & VCU_PLL_CTRL_CLKOUTDIV_MASK;
>  	if (clkoutdiv != 1) {
>  		dev_err(xvcu->dev, "clkoutdiv value is invalid\n");
>  		return -EINVAL;
> 

Already fixed by https://www.spinics.net/lists/arm-kernel/msg628989.html

Thanks,
Michal

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] soc: xilinx: xlnx_vcu: Fix && vs & typo
@ 2018-01-18 11:37   ` Michal Simek
  0 siblings, 0 replies; 6+ messages in thread
From: Michal Simek @ 2018-01-18 11:37 UTC (permalink / raw)
  To: linux-arm-kernel

On 18.1.2018 11:28, Dan Carpenter wrote:
> We accidentally used a logical AND instead of a bitwise AND here.
> 
> Fixes: cee8113a295a ("soc: xilinx: xlnx_vcu: Add Xilinx ZYNQMP VCU logicoreIP init driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> 
> diff --git a/drivers/soc/xilinx/xlnx_vcu.c b/drivers/soc/xilinx/xlnx_vcu.c
> index c1d6f1b190b6..a840c0272135 100644
> --- a/drivers/soc/xilinx/xlnx_vcu.c
> +++ b/drivers/soc/xilinx/xlnx_vcu.c
> @@ -334,7 +334,7 @@ static int xvcu_set_vcu_pll_info(struct xvcu_device *xvcu)
>  	 */
>  	vcu_pll_ctrl = xvcu_read(xvcu->vcu_slcr_ba, VCU_PLL_CTRL);
>  	clkoutdiv = vcu_pll_ctrl >> VCU_PLL_CTRL_CLKOUTDIV_SHIFT;
> -	clkoutdiv = clkoutdiv && VCU_PLL_CTRL_CLKOUTDIV_MASK;
> +	clkoutdiv = clkoutdiv & VCU_PLL_CTRL_CLKOUTDIV_MASK;
>  	if (clkoutdiv != 1) {
>  		dev_err(xvcu->dev, "clkoutdiv value is invalid\n");
>  		return -EINVAL;
> 

Already fixed by https://www.spinics.net/lists/arm-kernel/msg628989.html

Thanks,
Michal

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [PATCH] soc: xilinx: xlnx_vcu: Fix && vs & typo
@ 2018-01-18 11:37   ` Michal Simek
  0 siblings, 0 replies; 6+ messages in thread
From: Michal Simek @ 2018-01-18 11:37 UTC (permalink / raw)
  To: linux-arm-kernel

On 18.1.2018 11:28, Dan Carpenter wrote:
> We accidentally used a logical AND instead of a bitwise AND here.
> 
> Fixes: cee8113a295a ("soc: xilinx: xlnx_vcu: Add Xilinx ZYNQMP VCU logicoreIP init driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> 
> diff --git a/drivers/soc/xilinx/xlnx_vcu.c b/drivers/soc/xilinx/xlnx_vcu.c
> index c1d6f1b190b6..a840c0272135 100644
> --- a/drivers/soc/xilinx/xlnx_vcu.c
> +++ b/drivers/soc/xilinx/xlnx_vcu.c
> @@ -334,7 +334,7 @@ static int xvcu_set_vcu_pll_info(struct xvcu_device *xvcu)
>  	 */
>  	vcu_pll_ctrl = xvcu_read(xvcu->vcu_slcr_ba, VCU_PLL_CTRL);
>  	clkoutdiv = vcu_pll_ctrl >> VCU_PLL_CTRL_CLKOUTDIV_SHIFT;
> -	clkoutdiv = clkoutdiv && VCU_PLL_CTRL_CLKOUTDIV_MASK;
> +	clkoutdiv = clkoutdiv & VCU_PLL_CTRL_CLKOUTDIV_MASK;
>  	if (clkoutdiv != 1) {
>  		dev_err(xvcu->dev, "clkoutdiv value is invalid\n");
>  		return -EINVAL;
> 

Already fixed by https://www.spinics.net/lists/arm-kernel/msg628989.html

Thanks,
Michal

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-01-18 11:37 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-18 10:28 [PATCH] soc: xilinx: xlnx_vcu: Fix && vs & typo Dan Carpenter
2018-01-18 10:28 ` Dan Carpenter
2018-01-18 10:28 ` Dan Carpenter
2018-01-18 11:37 ` Michal Simek
2018-01-18 11:37   ` Michal Simek
2018-01-18 11:37   ` Michal Simek

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.