[PATCH] phy: brcm-sata: remove unused variable

[PATCH] phy: brcm-sata: remove unused variable

[Arnd Bergmann]

The newly introduced calibrate function has a variable
that has never been used and needs to be removed to avoid
this harmless warning:

drivers/phy/broadcom/phy-brcm-sata.c: In function 'brcm_stb_sata_calibrate':
drivers/phy/broadcom/phy-brcm-sata.c:514:24: error: unused variable 'priv' [-Werror=unused-variable]

Fixes: 3e507769d15e ("phy: brcm-sata: Implement calibrate callback")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/phy/broadcom/phy-brcm-sata.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/phy/broadcom/phy-brcm-sata.c b/drivers/phy/broadcom/phy-brcm-sata.c
index 5dd9ebeac750..8708ea3b4d6d 100644
--- a/drivers/phy/broadcom/phy-brcm-sata.c
+++ b/drivers/phy/broadcom/phy-brcm-sata.c
@@ -511,7 +511,6 @@ static int brcm_sata_phy_init(struct phy *phy)
 static void brcm_stb_sata_calibrate(struct brcm_sata_port *port)
 {
 	void __iomem *base = brcm_sata_pcb_base(port);
-	struct brcm_sata_phy *priv = port->phy_priv;
 	u32 tmp = BIT(8);
 
 	brcm_sata_phy_wr(base, RXPMD_REG_BANK, RXPMD_RX_FREQ_MON_CONTROL1,
-- 
2.9.0

Re: [PATCH] phy: brcm-sata: remove unused variable

[Tejun Heo]

On Thu, Jan 18, 2018 at 02:19:58PM +0100, Arnd Bergmann wrote:
> The newly introduced calibrate function has a variable
> that has never been used and needs to be removed to avoid
> this harmless warning:
> 
> drivers/phy/broadcom/phy-brcm-sata.c: In function 'brcm_stb_sata_calibrate':
> drivers/phy/broadcom/phy-brcm-sata.c:514:24: error: unused variable 'priv' [-Werror=unused-variable]
> 
> Fixes: 3e507769d15e ("phy: brcm-sata: Implement calibrate callback")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Applied to libata/for-4.16.

Thanks.

-- 
tejun

Re: [PATCH] phy: brcm-sata: remove unused variable

[Florian Fainelli]

On 01/18/2018 05:19 AM, Arnd Bergmann wrote:
> The newly introduced calibrate function has a variable
> that has never been used and needs to be removed to avoid
> this harmless warning:
> 
> drivers/phy/broadcom/phy-brcm-sata.c: In function 'brcm_stb_sata_calibrate':
> drivers/phy/broadcom/phy-brcm-sata.c:514:24: error: unused variable 'priv' [-Werror=unused-variable]
> 
> Fixes: 3e507769d15e ("phy: brcm-sata: Implement calibrate callback")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Sorry, rebased and this was left, thanks Arnd!
-- 
Florian