* Re: [fstests PATCH 2/2] generic/347: dm-thin lacks DAX support
@ 2018-01-18 4:23 ` Eryu Guan
0 siblings, 0 replies; 11+ messages in thread
From: Eryu Guan @ 2018-01-18 4:23 UTC (permalink / raw)
To: Ross Zwisler
Cc: linux-ext4-u79uwXL29TY76Z2rM5mHXA,
fstests-u79uwXL29TY76Z2rM5mHXA,
linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw
On Wed, Jan 17, 2018 at 04:23:51PM -0700, Ross Zwisler wrote:
> generic/347 currently fails when run in cojunction with the DAX mount
> option:
>
> generic/347 72s ... - output mismatch (see
> /root/project/xfstests/results//generic/347.out.bad)
> --- tests/generic/347.out 2016-05-12 11:56:32.086618744 -0600
> +++ /root/project/xfstests/results//generic/347.out.bad 2018-01-17
> 16:04:33.459348448 -0700
> @@ -1,2 +1,3 @@
> QA output created by 347
> +mount: /mnt/xfstests_scratch: can't read superblock on
> /dev/mapper/thin-vol.
> === completed
> ...
> (Run 'diff -u tests/generic/347.out
> /root/project/xfstests/results//generic/347.out.bad' to see the entire
> diff)
>
> This is expected because the dm-thin target currently lacks DAX support.
>
> Just skip this test if we are using DAX.
>
> Signed-off-by: Ross Zwisler <ross.zwisler-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
> ---
> tests/generic/347 | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tests/generic/347 b/tests/generic/347
> index 3adc6744..0c2dec98 100755
> --- a/tests/generic/347
> +++ b/tests/generic/347
> @@ -72,6 +72,7 @@ _supported_fs generic
> _supported_os Linux
> _require_scratch_nocheck
> _require_dm_target thin-pool
> +_exclude_scratch_mount_option dax
IMHO, it'd be better to put this in common/dmthin file, as what's done
in common/dmerror or common/dmflakey (we grep for dax directly there,
that's because they've been added before _exclude_scratch_mount_option
was introduced), so all thinp tests are excluded from dax tests.
Thanks,
Eryu
>
> _setup_thin
> _workout
> --
> 2.14.3
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [fstests PATCH 2/2] generic/347: dm-thin lacks DAX support
@ 2018-01-18 4:23 ` Eryu Guan
0 siblings, 0 replies; 11+ messages in thread
From: Eryu Guan @ 2018-01-18 4:23 UTC (permalink / raw)
To: Ross Zwisler; +Cc: fstests, linux-ext4, linux-nvdimm, dave.jiang
On Wed, Jan 17, 2018 at 04:23:51PM -0700, Ross Zwisler wrote:
> generic/347 currently fails when run in cojunction with the DAX mount
> option:
>
> generic/347 72s ... - output mismatch (see
> /root/project/xfstests/results//generic/347.out.bad)
> --- tests/generic/347.out 2016-05-12 11:56:32.086618744 -0600
> +++ /root/project/xfstests/results//generic/347.out.bad 2018-01-17
> 16:04:33.459348448 -0700
> @@ -1,2 +1,3 @@
> QA output created by 347
> +mount: /mnt/xfstests_scratch: can't read superblock on
> /dev/mapper/thin-vol.
> === completed
> ...
> (Run 'diff -u tests/generic/347.out
> /root/project/xfstests/results//generic/347.out.bad' to see the entire
> diff)
>
> This is expected because the dm-thin target currently lacks DAX support.
>
> Just skip this test if we are using DAX.
>
> Signed-off-by: Ross Zwisler <ross.zwisler@linux.intel.com>
> ---
> tests/generic/347 | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tests/generic/347 b/tests/generic/347
> index 3adc6744..0c2dec98 100755
> --- a/tests/generic/347
> +++ b/tests/generic/347
> @@ -72,6 +72,7 @@ _supported_fs generic
> _supported_os Linux
> _require_scratch_nocheck
> _require_dm_target thin-pool
> +_exclude_scratch_mount_option dax
IMHO, it'd be better to put this in common/dmthin file, as what's done
in common/dmerror or common/dmflakey (we grep for dax directly there,
that's because they've been added before _exclude_scratch_mount_option
was introduced), so all thinp tests are excluded from dax tests.
Thanks,
Eryu
>
> _setup_thin
> _workout
> --
> 2.14.3
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [fstests PATCH 2/2] generic/347: dm-thin lacks DAX support
2018-01-18 4:23 ` Eryu Guan
@ 2018-01-18 16:06 ` Ross Zwisler
-1 siblings, 0 replies; 11+ messages in thread
From: Ross Zwisler @ 2018-01-18 16:06 UTC (permalink / raw)
To: Eryu Guan; +Cc: linux-ext4, fstests, linux-nvdimm
On Thu, Jan 18, 2018 at 12:23:43PM +0800, Eryu Guan wrote:
> On Wed, Jan 17, 2018 at 04:23:51PM -0700, Ross Zwisler wrote:
> > generic/347 currently fails when run in cojunction with the DAX mount
> > option:
> >
> > generic/347 72s ... - output mismatch (see
> > /root/project/xfstests/results//generic/347.out.bad)
> > --- tests/generic/347.out 2016-05-12 11:56:32.086618744 -0600
> > +++ /root/project/xfstests/results//generic/347.out.bad 2018-01-17
> > 16:04:33.459348448 -0700
> > @@ -1,2 +1,3 @@
> > QA output created by 347
> > +mount: /mnt/xfstests_scratch: can't read superblock on
> > /dev/mapper/thin-vol.
> > === completed
> > ...
> > (Run 'diff -u tests/generic/347.out
> > /root/project/xfstests/results//generic/347.out.bad' to see the entire
> > diff)
> >
> > This is expected because the dm-thin target currently lacks DAX support.
> >
> > Just skip this test if we are using DAX.
> >
> > Signed-off-by: Ross Zwisler <ross.zwisler@linux.intel.com>
> > ---
> > tests/generic/347 | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/tests/generic/347 b/tests/generic/347
> > index 3adc6744..0c2dec98 100755
> > --- a/tests/generic/347
> > +++ b/tests/generic/347
> > @@ -72,6 +72,7 @@ _supported_fs generic
> > _supported_os Linux
> > _require_scratch_nocheck
> > _require_dm_target thin-pool
> > +_exclude_scratch_mount_option dax
>
> IMHO, it'd be better to put this in common/dmthin file, as what's done
> in common/dmerror or common/dmflakey (we grep for dax directly there,
> that's because they've been added before _exclude_scratch_mount_option
> was introduced), so all thinp tests are excluded from dax tests.
Sure, will do. Thanks for the review.
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [fstests PATCH 2/2] generic/347: dm-thin lacks DAX support
@ 2018-01-18 16:06 ` Ross Zwisler
0 siblings, 0 replies; 11+ messages in thread
From: Ross Zwisler @ 2018-01-18 16:06 UTC (permalink / raw)
To: Eryu Guan; +Cc: Ross Zwisler, fstests, linux-ext4, linux-nvdimm, dave.jiang
On Thu, Jan 18, 2018 at 12:23:43PM +0800, Eryu Guan wrote:
> On Wed, Jan 17, 2018 at 04:23:51PM -0700, Ross Zwisler wrote:
> > generic/347 currently fails when run in cojunction with the DAX mount
> > option:
> >
> > generic/347 72s ... - output mismatch (see
> > /root/project/xfstests/results//generic/347.out.bad)
> > --- tests/generic/347.out 2016-05-12 11:56:32.086618744 -0600
> > +++ /root/project/xfstests/results//generic/347.out.bad 2018-01-17
> > 16:04:33.459348448 -0700
> > @@ -1,2 +1,3 @@
> > QA output created by 347
> > +mount: /mnt/xfstests_scratch: can't read superblock on
> > /dev/mapper/thin-vol.
> > === completed
> > ...
> > (Run 'diff -u tests/generic/347.out
> > /root/project/xfstests/results//generic/347.out.bad' to see the entire
> > diff)
> >
> > This is expected because the dm-thin target currently lacks DAX support.
> >
> > Just skip this test if we are using DAX.
> >
> > Signed-off-by: Ross Zwisler <ross.zwisler@linux.intel.com>
> > ---
> > tests/generic/347 | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/tests/generic/347 b/tests/generic/347
> > index 3adc6744..0c2dec98 100755
> > --- a/tests/generic/347
> > +++ b/tests/generic/347
> > @@ -72,6 +72,7 @@ _supported_fs generic
> > _supported_os Linux
> > _require_scratch_nocheck
> > _require_dm_target thin-pool
> > +_exclude_scratch_mount_option dax
>
> IMHO, it'd be better to put this in common/dmthin file, as what's done
> in common/dmerror or common/dmflakey (we grep for dax directly there,
> that's because they've been added before _exclude_scratch_mount_option
> was introduced), so all thinp tests are excluded from dax tests.
Sure, will do. Thanks for the review.
^ permalink raw reply [flat|nested] 11+ messages in thread
* [fstests PATCH v2] generic/347: dm-thin lacks DAX support
2018-01-18 4:23 ` Eryu Guan
@ 2018-01-18 16:07 ` Ross Zwisler
-1 siblings, 0 replies; 11+ messages in thread
From: Ross Zwisler @ 2018-01-18 16:07 UTC (permalink / raw)
To: Eryu Guan, fstests; +Cc: linux-ext4, linux-nvdimm
generic/347 currently fails when run in conjunction with the DAX mount
option:
generic/347 72s ... - output mismatch (see
/root/project/xfstests/results//generic/347.out.bad)
--- tests/generic/347.out 2016-05-12 11:56:32.086618744 -0600
+++ /root/project/xfstests/results//generic/347.out.bad 2018-01-17
16:04:33.459348448 -0700
@@ -1,2 +1,3 @@
QA output created by 347
+mount: /mnt/xfstests_scratch: can't read superblock on
/dev/mapper/thin-vol.
=== completed
...
(Run 'diff -u tests/generic/347.out
/root/project/xfstests/results//generic/347.out.bad' to see the entire
diff)
This is expected because the dm-thin target currently lacks DAX support.
Just skip this test if we are using DAX.
Signed-off-by: Ross Zwisler <ross.zwisler@linux.intel.com>
---
common/dmthin | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/common/dmthin b/common/dmthin
index baab6284..da0ad284 100644
--- a/common/dmthin
+++ b/common/dmthin
@@ -35,6 +35,11 @@ DMTHIN_POOL_DEV="/dev/mapper/$DMTHIN_POOL_NAME"
DMTHIN_VOL_NAME="thin-vol"
DMTHIN_VOL_DEV="/dev/mapper/$DMTHIN_VOL_NAME"
+echo $MOUNT_OPTIONS | grep -q dax
+if [ $? -eq 0 ]; then
+ _notrun "Cannot run tests with DAX on dmthin devices"
+fi
+
_dmthin_cleanup()
{
$UMOUNT_PROG $SCRATCH_MNT > /dev/null 2>&1
--
2.14.3
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
^ permalink raw reply related [flat|nested] 11+ messages in thread* [fstests PATCH v2] generic/347: dm-thin lacks DAX support
@ 2018-01-18 16:07 ` Ross Zwisler
0 siblings, 0 replies; 11+ messages in thread
From: Ross Zwisler @ 2018-01-18 16:07 UTC (permalink / raw)
To: Eryu Guan, fstests; +Cc: Ross Zwisler, linux-ext4, linux-nvdimm, dave.jiang
generic/347 currently fails when run in conjunction with the DAX mount
option:
generic/347 72s ... - output mismatch (see
/root/project/xfstests/results//generic/347.out.bad)
--- tests/generic/347.out 2016-05-12 11:56:32.086618744 -0600
+++ /root/project/xfstests/results//generic/347.out.bad 2018-01-17
16:04:33.459348448 -0700
@@ -1,2 +1,3 @@
QA output created by 347
+mount: /mnt/xfstests_scratch: can't read superblock on
/dev/mapper/thin-vol.
=== completed
...
(Run 'diff -u tests/generic/347.out
/root/project/xfstests/results//generic/347.out.bad' to see the entire
diff)
This is expected because the dm-thin target currently lacks DAX support.
Just skip this test if we are using DAX.
Signed-off-by: Ross Zwisler <ross.zwisler@linux.intel.com>
---
common/dmthin | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/common/dmthin b/common/dmthin
index baab6284..da0ad284 100644
--- a/common/dmthin
+++ b/common/dmthin
@@ -35,6 +35,11 @@ DMTHIN_POOL_DEV="/dev/mapper/$DMTHIN_POOL_NAME"
DMTHIN_VOL_NAME="thin-vol"
DMTHIN_VOL_DEV="/dev/mapper/$DMTHIN_VOL_NAME"
+echo $MOUNT_OPTIONS | grep -q dax
+if [ $? -eq 0 ]; then
+ _notrun "Cannot run tests with DAX on dmthin devices"
+fi
+
_dmthin_cleanup()
{
$UMOUNT_PROG $SCRATCH_MNT > /dev/null 2>&1
--
2.14.3
^ permalink raw reply related [flat|nested] 11+ messages in thread