* [PATCH 0/1] tinfoil.py: Check if BUILDDIR exists
@ 2018-01-18 23:45 Amanda Brindle
2018-01-18 23:45 ` [PATCH 1/1] " Amanda Brindle
2018-01-19 0:02 ` ✗ patchtest: failure for " Patchwork
0 siblings, 2 replies; 3+ messages in thread
From: Amanda Brindle @ 2018-01-18 23:45 UTC (permalink / raw)
To: openembedded-core; +Cc: paul.eggleton, Amanda Brindle
The following changes since commit 364f8bcfcbd04e722490f363ad36a15fb7066ba7:
linux-firmware: Bump revision to 65b1c68c (2018-01-11 10:26:07 +0000)
are available in the git repository at:
git://git.yoctoproject.org/poky-contrib abrindle/tinfoil
http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=abrindle/tinfoil
Amanda Brindle (1):
tinfoil.py: Check if BUILDDIR exists
bitbake/lib/bb/tinfoil.py | 5 +++++
1 file changed, 5 insertions(+)
--
2.7.4
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 1/1] tinfoil.py: Check if BUILDDIR exists
2018-01-18 23:45 [PATCH 0/1] tinfoil.py: Check if BUILDDIR exists Amanda Brindle
@ 2018-01-18 23:45 ` Amanda Brindle
2018-01-19 0:02 ` ✗ patchtest: failure for " Patchwork
1 sibling, 0 replies; 3+ messages in thread
From: Amanda Brindle @ 2018-01-18 23:45 UTC (permalink / raw)
To: openembedded-core; +Cc: paul.eggleton, Amanda Brindle
Check if BUILDDIR exists in order to deterimine if a tinfoil using
script is running without having called oe-init-build-env (or similar).
If not, instruct user to initialise the build environment, and then
error out immediately. Before, tinfoil would hang for 30s before
erroring out.
Fixes [YOCTO #12096]
Signed-off-by: Amanda Brindle <amanda.r.brindle@intel.com>
---
bitbake/lib/bb/tinfoil.py | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/bitbake/lib/bb/tinfoil.py b/bitbake/lib/bb/tinfoil.py
index 368264f..e156b47 100644
--- a/bitbake/lib/bb/tinfoil.py
+++ b/bitbake/lib/bb/tinfoil.py
@@ -372,6 +372,11 @@ class Tinfoil:
"""
self.quiet = quiet
+ basepath = os.environ.get('BUILDDIR')
+ if not basepath:
+ print("Tinfoil can only be run after initialising the build environment (e.g. by using oe-init-build-env)")
+ sys.exit(1)
+
if self.tracking:
extrafeatures = [bb.cooker.CookerFeatures.BASEDATASTORE_TRACKING]
else:
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* ✗ patchtest: failure for tinfoil.py: Check if BUILDDIR exists
2018-01-18 23:45 [PATCH 0/1] tinfoil.py: Check if BUILDDIR exists Amanda Brindle
2018-01-18 23:45 ` [PATCH 1/1] " Amanda Brindle
@ 2018-01-19 0:02 ` Patchwork
1 sibling, 0 replies; 3+ messages in thread
From: Patchwork @ 2018-01-19 0:02 UTC (permalink / raw)
To: Amanda Brindle; +Cc: openembedded-core
== Series Details ==
Series: tinfoil.py: Check if BUILDDIR exists
Revision: 1
URL : https://patchwork.openembedded.org/series/10609/
State : failure
== Summary ==
Thank you for submitting this patch series to OpenEmbedded Core. This is
an automated response. Several tests have been executed on the proposed
series by patchtest resulting in the following failures:
* Issue Series sent to the wrong mailing list or some patches from the series correspond to different mailing lists [test_target_mailing_list]
Suggested fix Send the series again to the correct mailing list (ML)
Suggested ML bitbake-devel@lists.openembedded.org [http://git.openembedded.org/bitbake/]
Patch's path: bitbake/lib/bb/tinfoil.py
* Issue Series does not apply on top of target branch [test_series_merge_on_head]
Suggested fix Rebase your series on top of targeted branch
Targeted branch master (currently at 6b87ad5b08)
If you believe any of these test results are incorrect, please reply to the
mailing list (openembedded-core@lists.openembedded.org) raising your concerns.
Otherwise we would appreciate you correcting the issues and submitting a new
version of the patchset if applicable. Please ensure you add/increment the
version number when sending the new version (i.e. [PATCH] -> [PATCH v2] ->
[PATCH v3] -> ...).
---
Guidelines: https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest
Test suite: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-01-19 0:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-18 23:45 [PATCH 0/1] tinfoil.py: Check if BUILDDIR exists Amanda Brindle
2018-01-18 23:45 ` [PATCH 1/1] " Amanda Brindle
2018-01-19 0:02 ` ✗ patchtest: failure for " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.