From: Dave Young <dyoung@redhat.com> To: Steven Rostedt <rostedt@goodmis.org> Cc: Andi Kleen <ak@linux.intel.com>, pmladek@suse.com, sergey.senozhatsky@gmail.com, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, kexec@lists.infradead.org Subject: Re: [PATCH] print kdump kernel loaded status in stack dump Date: Fri, 19 Jan 2018 12:47:19 +0800 [thread overview] Message-ID: <20180119044719.GA3985@dhcp-128-65.nay.redhat.com> (raw) In-Reply-To: <20180118135704.62d0f79f@gandalf.local.home> On 01/18/18 at 01:57pm, Steven Rostedt wrote: > On Thu, 18 Jan 2018 10:02:17 -0800 > Andi Kleen <ak@linux.intel.com> wrote: > > > Dave Young <dyoung@redhat.com> writes: > > > printk("%sHardware name: %s\n", > > > log_lvl, dump_stack_arch_desc_str); > > > + if (kexec_crash_loaded()) > > > + printk("%skdump kernel loaded\n", log_lvl); > > > > Oops/warnings are getting longer and longer, often scrolling away > > from the screen, and if the kernel crashes backscroll does not work > > anymore, so precious information is lost. > > > > Can you merge it with some other line? > > > > Just a [KDUMP] or so somewhere should be good enough. > > Or perhaps we should add it as a TAINT. Not all taints are bad. Hmm, I also thought about this before but It sounds like not match the "tainted" meaning with the assumption that it is bad :( Maybe it would be better to do like Andi said, but print a better word than "KDUMP", eg. "Kdumpable" sounds better. If this is fine I can repost the patch. > > -- Steve Thanks Dave
WARNING: multiple messages have this Message-ID (diff)
From: Dave Young <dyoung@redhat.com> To: Steven Rostedt <rostedt@goodmis.org> Cc: pmladek@suse.com, Andi Kleen <ak@linux.intel.com>, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, sergey.senozhatsky@gmail.com, akpm@linux-foundation.org Subject: Re: [PATCH] print kdump kernel loaded status in stack dump Date: Fri, 19 Jan 2018 12:47:19 +0800 [thread overview] Message-ID: <20180119044719.GA3985@dhcp-128-65.nay.redhat.com> (raw) In-Reply-To: <20180118135704.62d0f79f@gandalf.local.home> On 01/18/18 at 01:57pm, Steven Rostedt wrote: > On Thu, 18 Jan 2018 10:02:17 -0800 > Andi Kleen <ak@linux.intel.com> wrote: > > > Dave Young <dyoung@redhat.com> writes: > > > printk("%sHardware name: %s\n", > > > log_lvl, dump_stack_arch_desc_str); > > > + if (kexec_crash_loaded()) > > > + printk("%skdump kernel loaded\n", log_lvl); > > > > Oops/warnings are getting longer and longer, often scrolling away > > from the screen, and if the kernel crashes backscroll does not work > > anymore, so precious information is lost. > > > > Can you merge it with some other line? > > > > Just a [KDUMP] or so somewhere should be good enough. > > Or perhaps we should add it as a TAINT. Not all taints are bad. Hmm, I also thought about this before but It sounds like not match the "tainted" meaning with the assumption that it is bad :( Maybe it would be better to do like Andi said, but print a better word than "KDUMP", eg. "Kdumpable" sounds better. If this is fine I can repost the patch. > > -- Steve Thanks Dave _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2018-01-19 4:47 UTC|newest] Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-01-17 4:50 [PATCH] print kdump kernel loaded status in stack dump Dave Young 2018-01-17 4:50 ` Dave Young 2018-01-17 8:57 ` Petr Mladek 2018-01-17 8:57 ` Petr Mladek 2018-01-17 12:32 ` Dave Young 2018-01-17 12:32 ` Dave Young 2018-01-17 13:42 ` Petr Mladek 2018-01-17 13:42 ` Petr Mladek 2018-01-17 15:48 ` Steven Rostedt 2018-01-17 15:48 ` Steven Rostedt 2018-01-18 1:57 ` Dave Young 2018-01-18 1:57 ` Dave Young 2018-01-18 18:02 ` Andi Kleen 2018-01-18 18:02 ` Andi Kleen 2018-01-18 18:57 ` Steven Rostedt 2018-01-18 18:57 ` Steven Rostedt 2018-01-19 4:47 ` Dave Young [this message] 2018-01-19 4:47 ` Dave Young 2018-01-19 13:06 ` Petr Tesarik 2018-01-26 7:37 ` Dave Young 2018-01-26 7:37 ` Dave Young 2018-01-26 12:17 ` Petr Mladek 2018-01-26 12:17 ` Petr Mladek 2018-01-27 3:57 ` Dave Young 2018-01-27 3:57 ` Dave Young 2018-01-19 5:45 ` Sergey Senozhatsky 2018-01-19 5:45 ` Sergey Senozhatsky 2018-01-19 8:16 ` Dave Young 2018-01-19 8:16 ` Dave Young 2018-01-19 8:28 ` Sergey Senozhatsky 2018-01-19 8:28 ` Sergey Senozhatsky 2018-01-19 8:42 ` Dave Young 2018-01-19 8:42 ` Dave Young 2018-01-19 9:46 ` Sergey Senozhatsky 2018-01-19 9:46 ` Sergey Senozhatsky 2018-01-19 8:32 ` Sergey Senozhatsky 2018-01-19 8:32 ` Sergey Senozhatsky 2018-01-19 16:16 ` Andi Kleen 2018-01-19 16:16 ` Andi Kleen 2018-01-19 16:51 ` Petr Tesarik
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20180119044719.GA3985@dhcp-128-65.nay.redhat.com \ --to=dyoung@redhat.com \ --cc=ak@linux.intel.com \ --cc=akpm@linux-foundation.org \ --cc=kexec@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=pmladek@suse.com \ --cc=rostedt@goodmis.org \ --cc=sergey.senozhatsky@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.