* [PATCH v2] drm/i915: add support for specifying DMC firmware override by module param @ 2018-01-19 10:15 Jani Nikula 2018-01-19 11:25 ` ✓ Fi.CI.BAT: success for drm/i915: add support for specifying DMC firmware override by module param (rev2) Patchwork 2018-01-19 15:43 ` ✗ Fi.CI.IGT: failure " Patchwork 0 siblings, 2 replies; 3+ messages in thread From: Jani Nikula @ 2018-01-19 10:15 UTC (permalink / raw) To: intel-gfx; +Cc: Jani Nikula Use i915.dmc_firmware_path to override default firmware for the platform and bypassing version checks. v2: add missing param struct member declaration (David) Tested-by: David Weinehall <david.weinehall@linux.intel.com> Reviewed-by: David Weinehall <david.weinehall@linux.intel.com> Cc: Anusha Srivatsa <anusha.srivatsa@intel.com> Cc: David Weinehall <david.weinehall@linux.intel.com> Signed-off-by: Jani Nikula <jani.nikula@intel.com> --- drivers/gpu/drm/i915/i915_params.c | 3 +++ drivers/gpu/drm/i915/i915_params.h | 1 + drivers/gpu/drm/i915/intel_csr.c | 9 +++++++-- 3 files changed, 11 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_params.c b/drivers/gpu/drm/i915/i915_params.c index 0b553a8e48fb..888f03df8361 100644 --- a/drivers/gpu/drm/i915/i915_params.c +++ b/drivers/gpu/drm/i915/i915_params.c @@ -164,6 +164,9 @@ i915_param_named_unsafe(guc_firmware_path, charp, 0400, i915_param_named_unsafe(huc_firmware_path, charp, 0400, "HuC firmware path to use instead of the default one"); +i915_param_named_unsafe(dmc_firmware_path, charp, 0400, + "DMC firmware path to use instead of the default one"); + i915_param_named_unsafe(enable_dp_mst, bool, 0600, "Enable multi-stream transport (MST) for new DisplayPort sinks. (default: true)"); diff --git a/drivers/gpu/drm/i915/i915_params.h b/drivers/gpu/drm/i915/i915_params.h index c96360398072..6684025b7af8 100644 --- a/drivers/gpu/drm/i915/i915_params.h +++ b/drivers/gpu/drm/i915/i915_params.h @@ -51,6 +51,7 @@ struct drm_printer; param(int, guc_log_level, -1) \ param(char *, guc_firmware_path, NULL) \ param(char *, huc_firmware_path, NULL) \ + param(char *, dmc_firmware_path, NULL) \ param(int, mmio_debug, 0) \ param(int, edp_vswing, 0) \ param(int, reset, 2) \ diff --git a/drivers/gpu/drm/i915/intel_csr.c b/drivers/gpu/drm/i915/intel_csr.c index 41e6c75a7f3c..d81673250d3b 100644 --- a/drivers/gpu/drm/i915/intel_csr.c +++ b/drivers/gpu/drm/i915/intel_csr.c @@ -297,7 +297,10 @@ static uint32_t *parse_csr_fw(struct drm_i915_private *dev_priv, csr->version = css_header->version; - if (IS_CANNONLAKE(dev_priv)) { + if (csr->fw_path == i915_modparams.dmc_firmware_path) { + /* Bypass version check for firmware override. */ + required_version = csr->version; + } else if (IS_CANNONLAKE(dev_priv)) { required_version = CNL_CSR_VERSION_REQUIRED; } else if (IS_GEMINILAKE(dev_priv)) { required_version = GLK_CSR_VERSION_REQUIRED; @@ -452,7 +455,9 @@ void intel_csr_ucode_init(struct drm_i915_private *dev_priv) if (!HAS_CSR(dev_priv)) return; - if (IS_CANNONLAKE(dev_priv)) + if (i915_modparams.dmc_firmware_path) + csr->fw_path = i915_modparams.dmc_firmware_path; + else if (IS_CANNONLAKE(dev_priv)) csr->fw_path = I915_CSR_CNL; else if (IS_GEMINILAKE(dev_priv)) csr->fw_path = I915_CSR_GLK; -- 2.11.0 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply related [flat|nested] 3+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915: add support for specifying DMC firmware override by module param (rev2) 2018-01-19 10:15 [PATCH v2] drm/i915: add support for specifying DMC firmware override by module param Jani Nikula @ 2018-01-19 11:25 ` Patchwork 2018-01-19 15:43 ` ✗ Fi.CI.IGT: failure " Patchwork 1 sibling, 0 replies; 3+ messages in thread From: Patchwork @ 2018-01-19 11:25 UTC (permalink / raw) To: Jani Nikula; +Cc: intel-gfx == Series Details == Series: drm/i915: add support for specifying DMC firmware override by module param (rev2) URL : https://patchwork.freedesktop.org/series/34157/ State : success == Summary == Series 34157v2 drm/i915: add support for specifying DMC firmware override by module param https://patchwork.freedesktop.org/api/1.0/series/34157/revisions/2/mbox/ Test debugfs_test: Subgroup read_all_entries: dmesg-warn -> DMESG-FAIL (fi-elk-e7500) fdo#103989 Test kms_pipe_crc_basic: Subgroup suspend-read-crc-pipe-b: pass -> INCOMPLETE (fi-snb-2520m) fdo#103713 fdo#103989 https://bugs.freedesktop.org/show_bug.cgi?id=103989 fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713 fi-bdw-5557u total:288 pass:267 dwarn:0 dfail:0 fail:0 skip:21 time:419s fi-bdw-gvtdvm total:288 pass:264 dwarn:0 dfail:0 fail:0 skip:24 time:424s fi-blb-e6850 total:288 pass:223 dwarn:1 dfail:0 fail:0 skip:64 time:373s fi-bsw-n3050 total:288 pass:242 dwarn:0 dfail:0 fail:0 skip:46 time:490s fi-bwr-2160 total:288 pass:183 dwarn:0 dfail:0 fail:0 skip:105 time:282s fi-bxt-dsi total:288 pass:258 dwarn:0 dfail:0 fail:0 skip:30 time:482s fi-bxt-j4205 total:288 pass:259 dwarn:0 dfail:0 fail:0 skip:29 time:483s fi-byt-j1900 total:288 pass:253 dwarn:0 dfail:0 fail:0 skip:35 time:468s fi-byt-n2820 total:288 pass:249 dwarn:0 dfail:0 fail:0 skip:39 time:452s fi-elk-e7500 total:224 pass:168 dwarn:9 dfail:1 fail:0 skip:45 fi-gdg-551 total:288 pass:179 dwarn:0 dfail:0 fail:1 skip:108 time:278s fi-glk-1 total:288 pass:260 dwarn:0 dfail:0 fail:0 skip:28 time:510s fi-hsw-4770 total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:389s fi-hsw-4770r total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:400s fi-ilk-650 total:288 pass:228 dwarn:0 dfail:0 fail:0 skip:60 time:409s fi-ivb-3520m total:288 pass:259 dwarn:0 dfail:0 fail:0 skip:29 time:459s fi-ivb-3770 total:288 pass:255 dwarn:0 dfail:0 fail:0 skip:33 time:411s fi-kbl-7500u total:288 pass:263 dwarn:1 dfail:0 fail:0 skip:24 time:460s fi-kbl-7560u total:288 pass:269 dwarn:0 dfail:0 fail:0 skip:19 time:502s fi-kbl-7567u total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:454s fi-kbl-r total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:501s fi-pnv-d510 total:288 pass:222 dwarn:1 dfail:0 fail:0 skip:65 time:578s fi-skl-6260u total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:437s fi-skl-6600u total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:509s fi-skl-6700hq total:288 pass:262 dwarn:0 dfail:0 fail:0 skip:26 time:528s fi-skl-6700k2 total:288 pass:264 dwarn:0 dfail:0 fail:0 skip:24 time:490s fi-skl-6770hq total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:487s fi-skl-gvtdvm total:288 pass:265 dwarn:0 dfail:0 fail:0 skip:23 time:433s fi-snb-2520m total:245 pass:211 dwarn:0 dfail:0 fail:0 skip:33 fi-snb-2600 total:288 pass:248 dwarn:0 dfail:0 fail:0 skip:40 time:395s Blacklisted hosts: fi-cfl-s2 total:288 pass:262 dwarn:0 dfail:0 fail:0 skip:26 time:573s fi-glk-dsi total:288 pass:258 dwarn:0 dfail:0 fail:0 skip:30 time:473s fi-skl-guc total:288 pass:212 dwarn:47 dfail:0 fail:1 skip:28 time:418s 6a58f7b0566b01e2f9a61cf07973ac6429d2330c drm-tip: 2018y-01m-19d-10h-32m-15s UTC integration manifest 247412d6df86 drm/i915: add support for specifying DMC firmware override by module param == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_7718/issues.html _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 3+ messages in thread
* ✗ Fi.CI.IGT: failure for drm/i915: add support for specifying DMC firmware override by module param (rev2) 2018-01-19 10:15 [PATCH v2] drm/i915: add support for specifying DMC firmware override by module param Jani Nikula 2018-01-19 11:25 ` ✓ Fi.CI.BAT: success for drm/i915: add support for specifying DMC firmware override by module param (rev2) Patchwork @ 2018-01-19 15:43 ` Patchwork 1 sibling, 0 replies; 3+ messages in thread From: Patchwork @ 2018-01-19 15:43 UTC (permalink / raw) To: Jani Nikula; +Cc: intel-gfx == Series Details == Series: drm/i915: add support for specifying DMC firmware override by module param (rev2) URL : https://patchwork.freedesktop.org/series/34157/ State : failure == Summary == Test gem_eio: Subgroup in-flight-suspend: pass -> FAIL (shard-snb) fdo#103375 Test kms_frontbuffer_tracking: Subgroup fbc-1p-offscren-pri-shrfb-draw-render: pass -> FAIL (shard-snb) fdo#101623 Test gem_exec_schedule: Subgroup reorder-wide-vebox: fail -> PASS (shard-apl) fdo#102848 Test gem_pwrite_pread: Subgroup uncached-copy-performance: pass -> INCOMPLETE (shard-hsw) Test perf: Subgroup buffer-fill: pass -> FAIL (shard-apl) fdo#103755 Test kms_flip: Subgroup vblank-vs-suspend: pass -> FAIL (shard-apl) fdo#100368 Test kms_vblank: Subgroup wait-forked-busy: skip -> PASS (shard-snb) Test kms_cursor_legacy: Subgroup pipe-b-torture-move: pass -> INCOMPLETE (shard-hsw) fdo#103375 https://bugs.freedesktop.org/show_bug.cgi?id=103375 fdo#101623 https://bugs.freedesktop.org/show_bug.cgi?id=101623 fdo#102848 https://bugs.freedesktop.org/show_bug.cgi?id=102848 fdo#103755 https://bugs.freedesktop.org/show_bug.cgi?id=103755 fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368 shard-apl total:2753 pass:1714 dwarn:1 dfail:0 fail:23 skip:1015 time:14077s shard-hsw total:2706 pass:1693 dwarn:1 dfail:0 fail:12 skip:997 time:13451s shard-snb total:2694 pass:1291 dwarn:1 dfail:0 fail:13 skip:1388 time:7501s Blacklisted hosts: shard-kbl total:2741 pass:1792 dwarn:40 dfail:1 fail:21 skip:886 time:10354s == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_7718/shards.html _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-01-19 15:43 UTC | newest] Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2018-01-19 10:15 [PATCH v2] drm/i915: add support for specifying DMC firmware override by module param Jani Nikula 2018-01-19 11:25 ` ✓ Fi.CI.BAT: success for drm/i915: add support for specifying DMC firmware override by module param (rev2) Patchwork 2018-01-19 15:43 ` ✗ Fi.CI.IGT: failure " Patchwork
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.