All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/i915: Avoid leaking lpe audio platdev.data
@ 2017-12-09 22:21 Chris Wilson
  2017-12-09 22:50 ` ✗ Fi.CI.BAT: failure for " Patchwork
                   ` (3 more replies)
  0 siblings, 4 replies; 6+ messages in thread
From: Chris Wilson @ 2017-12-09 22:21 UTC (permalink / raw)
  To: intel-gfx; +Cc: Takashi Iwai

The struct platform_device memdups the provided data pointer requiring
us to free the template we construct during lpe_audio_platdev_create():

unreferenced object 0xffff88026eafe400 (size 512):
  comm "insmod", pid 6850, jiffies 4295060179 (age 22.300s)
  hex dump (first 32 bytes):
    00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
    00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
  backtrace:
    [<000000008e4a834c>] intel_audio_init+0x9/0x30 [i915]
    [<000000001360e195>] i915_driver_load+0x802/0x14e0 [i915]
    [<00000000ab3f0e99>] i915_pci_probe+0x29/0x70 [i915]
    [<0000000016330ee5>] pci_device_probe+0x9c/0x120
    [<000000000257d054>] driver_probe_device+0x307/0x470
    [<000000009f0a6cb6>] __driver_attach+0x98/0xe0
    [<0000000031b46e58>] bus_for_each_dev+0x57/0x80
    [<000000000e28239d>] bus_add_driver+0x1bd/0x260
    [<00000000abbe5161>] driver_register+0x52/0xc0
    [<000000005c6e23d4>] do_one_initcall+0x36/0x150
    [<00000000a55002f4>] do_init_module+0x56/0x1d7
    [<00000000e48f2217>] load_module+0x23c8/0x2910
    [<000000002b60bf61>] SyS_finit_module+0xb8/0xd0
    [<0000000041cbad96>] entry_SYSCALL_64_fastpath+0x17/0x70
    [<000000009f1d37ab>] 0xffffffffffffffff

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Takashi Iwai <tiwai@suse.de>
Cc: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 drivers/gpu/drm/i915/intel_lpe_audio.c | 14 ++++----------
 1 file changed, 4 insertions(+), 10 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_lpe_audio.c b/drivers/gpu/drm/i915/intel_lpe_audio.c
index 3bf65288ffff..0a2e1fea43fa 100644
--- a/drivers/gpu/drm/i915/intel_lpe_audio.c
+++ b/drivers/gpu/drm/i915/intel_lpe_audio.c
@@ -74,7 +74,6 @@
 static struct platform_device *
 lpe_audio_platdev_create(struct drm_i915_private *dev_priv)
 {
-	int ret;
 	struct drm_device *dev = &dev_priv->drm;
 	struct platform_device_info pinfo = {};
 	struct resource *rsc;
@@ -119,24 +118,19 @@ lpe_audio_platdev_create(struct drm_i915_private *dev_priv)
 	spin_lock_init(&pdata->lpe_audio_slock);
 
 	platdev = platform_device_register_full(&pinfo);
+	kfree(rsc);
+	kfree(pdata);
+
 	if (IS_ERR(platdev)) {
-		ret = PTR_ERR(platdev);
 		DRM_ERROR("Failed to allocate LPE audio platform device\n");
-		goto err;
+		return platdev;
 	}
 
-	kfree(rsc);
-
 	pm_runtime_forbid(&platdev->dev);
 	pm_runtime_set_active(&platdev->dev);
 	pm_runtime_enable(&platdev->dev);
 
 	return platdev;
-
-err:
-	kfree(rsc);
-	kfree(pdata);
-	return ERR_PTR(ret);
 }
 
 static void lpe_audio_platdev_destroy(struct drm_i915_private *dev_priv)
-- 
2.15.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* ✗ Fi.CI.BAT: failure for drm/i915: Avoid leaking lpe audio platdev.data
  2017-12-09 22:21 [PATCH] drm/i915: Avoid leaking lpe audio platdev.data Chris Wilson
@ 2017-12-09 22:50 ` Patchwork
  2018-01-19 14:11 ` [PATCH] " Jani Nikula
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2017-12-09 22:50 UTC (permalink / raw)
  To: Chris Wilson; +Cc: intel-gfx

== Series Details ==

Series: drm/i915: Avoid leaking lpe audio platdev.data
URL   : https://patchwork.freedesktop.org/series/35151/
State : failure

== Summary ==

Series 35151v1 drm/i915: Avoid leaking lpe audio platdev.data
https://patchwork.freedesktop.org/api/1.0/series/35151/revisions/1/mbox/

Test debugfs_test:
        Subgroup read_all_entries:
                pass       -> DMESG-FAIL (fi-elk-e7500) fdo#103989
Test gem_mmap_gtt:
        Subgroup basic-small-bo-tiledx:
                fail       -> PASS       (fi-gdg-551) fdo#102575
Test kms_pipe_crc_basic:
        Subgroup suspend-read-crc-pipe-b:
                pass       -> INCOMPLETE (fi-skl-6260u)

fdo#103989 https://bugs.freedesktop.org/show_bug.cgi?id=103989
fdo#102575 https://bugs.freedesktop.org/show_bug.cgi?id=102575

fi-bdw-5557u     total:288  pass:267  dwarn:0   dfail:0   fail:0   skip:21  time:437s
fi-bdw-gvtdvm    total:288  pass:264  dwarn:0   dfail:0   fail:0   skip:24  time:446s
fi-blb-e6850     total:288  pass:223  dwarn:1   dfail:0   fail:0   skip:64  time:386s
fi-bsw-n3050     total:288  pass:242  dwarn:0   dfail:0   fail:0   skip:46  time:516s
fi-bwr-2160      total:288  pass:183  dwarn:0   dfail:0   fail:0   skip:105 time:280s
fi-bxt-dsi       total:288  pass:258  dwarn:0   dfail:0   fail:0   skip:30  time:505s
fi-bxt-j4205     total:288  pass:259  dwarn:0   dfail:0   fail:0   skip:29  time:507s
fi-byt-j1900     total:288  pass:253  dwarn:0   dfail:0   fail:0   skip:35  time:489s
fi-byt-n2820     total:288  pass:249  dwarn:0   dfail:0   fail:0   skip:39  time:474s
fi-elk-e7500     total:224  pass:163  dwarn:14  dfail:1   fail:0   skip:45 
fi-gdg-551       total:288  pass:179  dwarn:1   dfail:0   fail:0   skip:108 time:270s
fi-hsw-4770      total:288  pass:261  dwarn:0   dfail:0   fail:0   skip:27  time:370s
fi-hsw-4770r     total:288  pass:224  dwarn:0   dfail:0   fail:0   skip:64  time:258s
fi-ilk-650       total:288  pass:228  dwarn:0   dfail:0   fail:0   skip:60  time:401s
fi-ivb-3520m     total:288  pass:259  dwarn:0   dfail:0   fail:0   skip:29  time:483s
fi-ivb-3770      total:288  pass:259  dwarn:0   dfail:0   fail:0   skip:29  time:449s
fi-kbl-7500u     total:288  pass:263  dwarn:1   dfail:0   fail:0   skip:24  time:484s
fi-kbl-7560u     total:288  pass:269  dwarn:0   dfail:0   fail:0   skip:19  time:526s
fi-kbl-7567u     total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:475s
fi-kbl-r         total:288  pass:260  dwarn:1   dfail:0   fail:0   skip:27  time:535s
fi-pnv-d510      total:288  pass:222  dwarn:1   dfail:0   fail:0   skip:65  time:596s
fi-skl-6260u     total:245  pass:228  dwarn:0   dfail:0   fail:0   skip:16 
fi-skl-6600u     total:288  pass:261  dwarn:0   dfail:0   fail:0   skip:27  time:545s
fi-skl-6700hq    total:288  pass:262  dwarn:0   dfail:0   fail:0   skip:26  time:567s
fi-skl-6700k     total:288  pass:264  dwarn:0   dfail:0   fail:0   skip:24  time:516s
fi-skl-6770hq    total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:500s
fi-skl-gvtdvm    total:288  pass:265  dwarn:0   dfail:0   fail:0   skip:23  time:449s
fi-snb-2520m     total:288  pass:249  dwarn:0   dfail:0   fail:0   skip:39  time:555s
fi-snb-2600      total:288  pass:248  dwarn:0   dfail:0   fail:0   skip:40  time:411s
Blacklisted hosts:
fi-cfl-s2        total:288  pass:262  dwarn:0   dfail:0   fail:0   skip:26  time:609s
fi-cnl-y         total:288  pass:262  dwarn:0   dfail:0   fail:0   skip:26  time:666s
fi-glk-dsi       total:288  pass:258  dwarn:0   dfail:0   fail:0   skip:30  time:487s
fi-glk-1 failed to collect. IGT log at Patchwork_7461/fi-glk-1/igt.log

3d02541270fc92e2d17ad51809c07630a0b8b47a drm-tip: 2017y-12m-09d-20h-01m-38s UTC integration manifest
fc9e414df2e8 drm/i915: Avoid leaking lpe audio platdev.data

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_7461/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] drm/i915: Avoid leaking lpe audio platdev.data
  2017-12-09 22:21 [PATCH] drm/i915: Avoid leaking lpe audio platdev.data Chris Wilson
  2017-12-09 22:50 ` ✗ Fi.CI.BAT: failure for " Patchwork
@ 2018-01-19 14:11 ` Jani Nikula
  2018-02-08 17:29   ` Chris Wilson
  2018-01-19 14:25 ` ✓ Fi.CI.BAT: success for " Patchwork
  2018-01-19 18:09 ` ✗ Fi.CI.IGT: failure " Patchwork
  3 siblings, 1 reply; 6+ messages in thread
From: Jani Nikula @ 2018-01-19 14:11 UTC (permalink / raw)
  To: Chris Wilson, intel-gfx; +Cc: Takashi Iwai

On Sat, 09 Dec 2017, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> The struct platform_device memdups the provided data pointer requiring
> us to free the template we construct during lpe_audio_platdev_create():
>
> unreferenced object 0xffff88026eafe400 (size 512):
>   comm "insmod", pid 6850, jiffies 4295060179 (age 22.300s)
>   hex dump (first 32 bytes):
>     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
>     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
>   backtrace:
>     [<000000008e4a834c>] intel_audio_init+0x9/0x30 [i915]
>     [<000000001360e195>] i915_driver_load+0x802/0x14e0 [i915]
>     [<00000000ab3f0e99>] i915_pci_probe+0x29/0x70 [i915]
>     [<0000000016330ee5>] pci_device_probe+0x9c/0x120
>     [<000000000257d054>] driver_probe_device+0x307/0x470
>     [<000000009f0a6cb6>] __driver_attach+0x98/0xe0
>     [<0000000031b46e58>] bus_for_each_dev+0x57/0x80
>     [<000000000e28239d>] bus_add_driver+0x1bd/0x260
>     [<00000000abbe5161>] driver_register+0x52/0xc0
>     [<000000005c6e23d4>] do_one_initcall+0x36/0x150
>     [<00000000a55002f4>] do_init_module+0x56/0x1d7
>     [<00000000e48f2217>] load_module+0x23c8/0x2910
>     [<000000002b60bf61>] SyS_finit_module+0xb8/0xd0
>     [<0000000041cbad96>] entry_SYSCALL_64_fastpath+0x17/0x70
>     [<000000009f1d37ab>] 0xffffffffffffffff
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Takashi Iwai <tiwai@suse.de>
> Cc: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>

I queued this for re-testing.

Reviewed-by: Jani Nikula <jani.nikula@intel.com>

> ---
>  drivers/gpu/drm/i915/intel_lpe_audio.c | 14 ++++----------
>  1 file changed, 4 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_lpe_audio.c b/drivers/gpu/drm/i915/intel_lpe_audio.c
> index 3bf65288ffff..0a2e1fea43fa 100644
> --- a/drivers/gpu/drm/i915/intel_lpe_audio.c
> +++ b/drivers/gpu/drm/i915/intel_lpe_audio.c
> @@ -74,7 +74,6 @@
>  static struct platform_device *
>  lpe_audio_platdev_create(struct drm_i915_private *dev_priv)
>  {
> -	int ret;
>  	struct drm_device *dev = &dev_priv->drm;
>  	struct platform_device_info pinfo = {};
>  	struct resource *rsc;
> @@ -119,24 +118,19 @@ lpe_audio_platdev_create(struct drm_i915_private *dev_priv)
>  	spin_lock_init(&pdata->lpe_audio_slock);
>  
>  	platdev = platform_device_register_full(&pinfo);
> +	kfree(rsc);
> +	kfree(pdata);
> +
>  	if (IS_ERR(platdev)) {
> -		ret = PTR_ERR(platdev);
>  		DRM_ERROR("Failed to allocate LPE audio platform device\n");
> -		goto err;
> +		return platdev;
>  	}
>  
> -	kfree(rsc);
> -
>  	pm_runtime_forbid(&platdev->dev);
>  	pm_runtime_set_active(&platdev->dev);
>  	pm_runtime_enable(&platdev->dev);
>  
>  	return platdev;
> -
> -err:
> -	kfree(rsc);
> -	kfree(pdata);
> -	return ERR_PTR(ret);
>  }
>  
>  static void lpe_audio_platdev_destroy(struct drm_i915_private *dev_priv)

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 6+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915: Avoid leaking lpe audio platdev.data
  2017-12-09 22:21 [PATCH] drm/i915: Avoid leaking lpe audio platdev.data Chris Wilson
  2017-12-09 22:50 ` ✗ Fi.CI.BAT: failure for " Patchwork
  2018-01-19 14:11 ` [PATCH] " Jani Nikula
@ 2018-01-19 14:25 ` Patchwork
  2018-01-19 18:09 ` ✗ Fi.CI.IGT: failure " Patchwork
  3 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2018-01-19 14:25 UTC (permalink / raw)
  To: Chris Wilson; +Cc: intel-gfx

== Series Details ==

Series: drm/i915: Avoid leaking lpe audio platdev.data
URL   : https://patchwork.freedesktop.org/series/35151/
State : success

== Summary ==

Series 35151v1 drm/i915: Avoid leaking lpe audio platdev.data
https://patchwork.freedesktop.org/api/1.0/series/35151/revisions/1/mbox/

Test debugfs_test:
        Subgroup read_all_entries:
                dmesg-warn -> FAIL       (fi-elk-e7500) fdo#103989 +1
                incomplete -> PASS       (fi-snb-2520m) fdo#103713

fdo#103989 https://bugs.freedesktop.org/show_bug.cgi?id=103989
fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713

fi-bdw-5557u     total:288  pass:267  dwarn:0   dfail:0   fail:0   skip:21  time:427s
fi-bdw-gvtdvm    total:288  pass:264  dwarn:0   dfail:0   fail:0   skip:24  time:435s
fi-blb-e6850     total:288  pass:223  dwarn:1   dfail:0   fail:0   skip:64  time:382s
fi-bsw-n3050     total:288  pass:242  dwarn:0   dfail:0   fail:0   skip:46  time:522s
fi-bwr-2160      total:288  pass:183  dwarn:0   dfail:0   fail:0   skip:105 time:294s
fi-bxt-dsi       total:288  pass:258  dwarn:0   dfail:0   fail:0   skip:30  time:498s
fi-bxt-j4205     total:288  pass:259  dwarn:0   dfail:0   fail:0   skip:29  time:504s
fi-byt-j1900     total:288  pass:253  dwarn:0   dfail:0   fail:0   skip:35  time:495s
fi-byt-n2820     total:288  pass:249  dwarn:0   dfail:0   fail:0   skip:39  time:482s
fi-elk-e7500     total:224  pass:167  dwarn:10  dfail:0   fail:1   skip:45 
fi-gdg-551       total:288  pass:179  dwarn:0   dfail:0   fail:1   skip:108 time:305s
fi-glk-1         total:288  pass:260  dwarn:0   dfail:0   fail:0   skip:28  time:527s
fi-hsw-4770      total:288  pass:261  dwarn:0   dfail:0   fail:0   skip:27  time:398s
fi-hsw-4770r     total:288  pass:261  dwarn:0   dfail:0   fail:0   skip:27  time:405s
fi-ilk-650       total:288  pass:228  dwarn:0   dfail:0   fail:0   skip:60  time:420s
fi-ivb-3520m     total:288  pass:259  dwarn:0   dfail:0   fail:0   skip:29  time:474s
fi-ivb-3770      total:288  pass:255  dwarn:0   dfail:0   fail:0   skip:33  time:422s
fi-kbl-7500u     total:288  pass:263  dwarn:1   dfail:0   fail:0   skip:24  time:464s
fi-kbl-7560u     total:288  pass:269  dwarn:0   dfail:0   fail:0   skip:19  time:501s
fi-kbl-7567u     total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:456s
fi-kbl-r         total:288  pass:261  dwarn:0   dfail:0   fail:0   skip:27  time:510s
fi-pnv-d510      total:288  pass:222  dwarn:1   dfail:0   fail:0   skip:65  time:634s
fi-skl-6260u     total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:443s
fi-skl-6600u     total:288  pass:261  dwarn:0   dfail:0   fail:0   skip:27  time:518s
fi-skl-6700hq    total:288  pass:262  dwarn:0   dfail:0   fail:0   skip:26  time:534s
fi-skl-6700k2    total:288  pass:264  dwarn:0   dfail:0   fail:0   skip:24  time:499s
fi-skl-6770hq    total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:494s
fi-skl-gvtdvm    total:288  pass:265  dwarn:0   dfail:0   fail:0   skip:23  time:441s
fi-snb-2520m     total:288  pass:248  dwarn:0   dfail:0   fail:0   skip:40  time:552s
fi-snb-2600      total:288  pass:248  dwarn:0   dfail:0   fail:0   skip:40  time:405s
Blacklisted hosts:
fi-cfl-s2        total:288  pass:256  dwarn:0   dfail:0   fail:3   skip:26  time:564s
fi-glk-dsi       total:288  pass:258  dwarn:0   dfail:0   fail:0   skip:30  time:486s
fi-skl-guc       total:288  pass:211  dwarn:49  dfail:0   fail:0   skip:28  time:411s

50a3d9c6fd3ca92a68c2693440d16d3ffdf067ff drm-tip: 2018y-01m-19d-13h-39m-21s UTC integration manifest
47aa344a53a3 drm/i915: Avoid leaking lpe audio platdev.data

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_7719/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 6+ messages in thread
* ✗ Fi.CI.IGT: failure for drm/i915: Avoid leaking lpe audio platdev.data
  2017-12-09 22:21 [PATCH] drm/i915: Avoid leaking lpe audio platdev.data Chris Wilson
                   ` (2 preceding siblings ...)
  2018-01-19 14:25 ` ✓ Fi.CI.BAT: success for " Patchwork
@ 2018-01-19 18:09 ` Patchwork
  3 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2018-01-19 18:09 UTC (permalink / raw)
  To: Chris Wilson; +Cc: intel-gfx

== Series Details ==

Series: drm/i915: Avoid leaking lpe audio platdev.data
URL   : https://patchwork.freedesktop.org/series/35151/
State : failure

== Summary ==

Test perf:
        Subgroup buffer-fill:
                pass       -> FAIL       (shard-apl) fdo#103755
        Subgroup enable-disable:
                pass       -> FAIL       (shard-apl) fdo#103715
        Subgroup oa-exponents:
                fail       -> PASS       (shard-apl) fdo#102254
Test kms_frontbuffer_tracking:
        Subgroup fbc-1p-offscren-pri-shrfb-draw-render:
                pass       -> FAIL       (shard-snb) fdo#101623 +1
Test gem_tiled_swapping:
        Subgroup non-threaded:
                incomplete -> PASS       (shard-snb) fdo#104218 +1
Test kms_cursor_crc:
        Subgroup cursor-128x128-sliding:
                pass       -> INCOMPLETE (shard-hsw)
Test kms_pipe_crc_basic:
        Subgroup suspend-read-crc-pipe-a:
                pass       -> SKIP       (shard-hsw) fdo#103375 +2
        Subgroup read-crc-pipe-c-frame-sequence:
                fail       -> PASS       (shard-apl) fdo#103481
Test kms_flip:
        Subgroup vblank-vs-suspend-interruptible:
                pass       -> INCOMPLETE (shard-hsw) fdo#100368
Test kms_sysfs_edid_timing:
                warn       -> PASS       (shard-apl) fdo#100047

fdo#103755 https://bugs.freedesktop.org/show_bug.cgi?id=103755
fdo#103715 https://bugs.freedesktop.org/show_bug.cgi?id=103715
fdo#102254 https://bugs.freedesktop.org/show_bug.cgi?id=102254
fdo#101623 https://bugs.freedesktop.org/show_bug.cgi?id=101623
fdo#104218 https://bugs.freedesktop.org/show_bug.cgi?id=104218
fdo#103375 https://bugs.freedesktop.org/show_bug.cgi?id=103375
fdo#103481 https://bugs.freedesktop.org/show_bug.cgi?id=103481
fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
fdo#100047 https://bugs.freedesktop.org/show_bug.cgi?id=100047

shard-apl        total:2780 pass:1713 dwarn:1   dfail:0   fail:25  skip:1041 time:14555s
shard-hsw        total:2716 pass:1666 dwarn:1   dfail:1   fail:13  skip:1031 time:13230s
shard-snb        total:2780 pass:1316 dwarn:1   dfail:0   fail:13  skip:1450 time:8035s
Blacklisted hosts:
shard-kbl        total:2758 pass:1824 dwarn:1   dfail:1   fail:23  skip:908 time:10493s

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_7719/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] drm/i915: Avoid leaking lpe audio platdev.data
  2018-01-19 14:11 ` [PATCH] " Jani Nikula
@ 2018-02-08 17:29   ` Chris Wilson
  0 siblings, 0 replies; 6+ messages in thread
From: Chris Wilson @ 2018-02-08 17:29 UTC (permalink / raw)
  To: Jani Nikula, intel-gfx; +Cc: Takashi Iwai

Quoting Jani Nikula (2018-01-19 14:11:29)
> On Sat, 09 Dec 2017, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> > The struct platform_device memdups the provided data pointer requiring
> > us to free the template we construct during lpe_audio_platdev_create():
> >
> > unreferenced object 0xffff88026eafe400 (size 512):
> >   comm "insmod", pid 6850, jiffies 4295060179 (age 22.300s)
> >   hex dump (first 32 bytes):
> >     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
> >     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
> >   backtrace:
> >     [<000000008e4a834c>] intel_audio_init+0x9/0x30 [i915]
> >     [<000000001360e195>] i915_driver_load+0x802/0x14e0 [i915]
> >     [<00000000ab3f0e99>] i915_pci_probe+0x29/0x70 [i915]
> >     [<0000000016330ee5>] pci_device_probe+0x9c/0x120
> >     [<000000000257d054>] driver_probe_device+0x307/0x470
> >     [<000000009f0a6cb6>] __driver_attach+0x98/0xe0
> >     [<0000000031b46e58>] bus_for_each_dev+0x57/0x80
> >     [<000000000e28239d>] bus_add_driver+0x1bd/0x260
> >     [<00000000abbe5161>] driver_register+0x52/0xc0
> >     [<000000005c6e23d4>] do_one_initcall+0x36/0x150
> >     [<00000000a55002f4>] do_init_module+0x56/0x1d7
> >     [<00000000e48f2217>] load_module+0x23c8/0x2910
> >     [<000000002b60bf61>] SyS_finit_module+0xb8/0xd0
> >     [<0000000041cbad96>] entry_SYSCALL_64_fastpath+0x17/0x70
> >     [<000000009f1d37ab>] 0xffffffffffffffff
> >
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: Takashi Iwai <tiwai@suse.de>
> > Cc: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> 
> I queued this for re-testing.
> 
> Reviewed-by: Jani Nikula <jani.nikula@intel.com>

And finally pushed, thanks.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-02-08 17:29 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-12-09 22:21 [PATCH] drm/i915: Avoid leaking lpe audio platdev.data Chris Wilson
2017-12-09 22:50 ` ✗ Fi.CI.BAT: failure for " Patchwork
2018-01-19 14:11 ` [PATCH] " Jani Nikula
2018-02-08 17:29   ` Chris Wilson
2018-01-19 14:25 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-01-19 18:09 ` ✗ Fi.CI.IGT: failure " Patchwork

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.