[U-Boot] [PATCH 1/1] fs: remove distractive message in fs_read()

[U-Boot] [PATCH 1/1] fs: remove distractive message in fs_read()

[Heinrich Schuchardt]

The message
"** %s shorter than offset + len **\n"
may be interesting when debugging but it does not indicate an
error.

So we should not write it if we are not in debug mode.

Fixes: 7a3e70cfd88c fs/fs.c: read up to EOF when len would read past EOF
Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---
 fs/fs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/fs.c b/fs/fs.c
index 9c4d67faf8..6155cb1daf 100644
--- a/fs/fs.c
+++ b/fs/fs.c
@@ -407,7 +407,7 @@ int fs_read(const char *filename, ulong addr, loff_t offset, loff_t len,
 
 	/* If we requested a specific number of bytes, check we got it */
 	if (ret == 0 && len && *actread != len)
-		printf("** %s shorter than offset + len **\n", filename);
+		debug("** %s shorter than offset + len **\n", filename);
 	fs_close();
 
 	return ret;
-- 
2.14.2

[U-Boot] [PATCH 1/1] fs: remove distractive message in fs_read()

[Simon Glass]

On 1 January 2018 at 13:15, Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:
> The message
> "** %s shorter than offset + len **\n"
> may be interesting when debugging but it does not indicate an
> error.
>
> So we should not write it if we are not in debug mode.
>
> Fixes: 7a3e70cfd88c fs/fs.c: read up to EOF when len would read past EOF
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ---
>  fs/fs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Simon Glass <sjg@chromium.org>

[U-Boot] [U-Boot, 1/1] fs: remove distractive message in fs_read()

[Tom Rini]

On Mon, Jan 01, 2018 at 09:15:37PM +0100, Heinrich Schuchardt wrote:

> The message
> "** %s shorter than offset + len **\n"
> may be interesting when debugging but it does not indicate an
> error.
> 
> So we should not write it if we are not in debug mode.
> 
> Fixes: 7a3e70cfd88c fs/fs.c: read up to EOF when len would read past EOF
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> Reviewed-by: Simon Glass <sjg@chromium.org>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180119/ff307532/attachment.sig>