All of lore.kernel.org
 help / color / mirror / Atom feed
* [U-Boot] [PATCH 1/1] board_r: remove superfluous #ifdef CONFIG_PRAM
@ 2018-01-06 23:54 Heinrich Schuchardt
  2018-01-08  4:52 ` Simon Glass
  2018-01-19 21:14 ` [U-Boot] [U-Boot, " Tom Rini
  0 siblings, 2 replies; 3+ messages in thread
From: Heinrich Schuchardt @ 2018-01-06 23:54 UTC (permalink / raw)
  To: u-boot

initr_mem() is already enclosed by
	#if defined(CONFIG_PRAM)
	#endif

So there is no need to check CONFIG_PRAM again inside the
function.

Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---
 common/board_r.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/common/board_r.c b/common/board_r.c
index 5e7eb2d5cb..98811edc07 100644
--- a/common/board_r.c
+++ b/common/board_r.c
@@ -624,9 +624,7 @@ int initr_mem(void)
 	ulong pram = 0;
 	char memsz[32];
 
-# ifdef CONFIG_PRAM
 	pram = env_get_ulong("pram", 10, CONFIG_PRAM);
-# endif
 	sprintf(memsz, "%ldk", (long int) ((gd->ram_size / 1024) - pram));
 	env_set("mem", memsz);
 
-- 
2.14.2

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [U-Boot] [PATCH 1/1] board_r: remove superfluous #ifdef CONFIG_PRAM
  2018-01-06 23:54 [U-Boot] [PATCH 1/1] board_r: remove superfluous #ifdef CONFIG_PRAM Heinrich Schuchardt
@ 2018-01-08  4:52 ` Simon Glass
  2018-01-19 21:14 ` [U-Boot] [U-Boot, " Tom Rini
  1 sibling, 0 replies; 3+ messages in thread
From: Simon Glass @ 2018-01-08  4:52 UTC (permalink / raw)
  To: u-boot

On 6 January 2018 at 16:54, Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:
> initr_mem() is already enclosed by
>         #if defined(CONFIG_PRAM)
>         #endif
>
> So there is no need to check CONFIG_PRAM again inside the
> function.
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ---
>  common/board_r.c | 2 --
>  1 file changed, 2 deletions(-)

Reviewed-by: Simon Glass <sjg@chromium.org>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [U-Boot] [U-Boot, 1/1] board_r: remove superfluous #ifdef CONFIG_PRAM
  2018-01-06 23:54 [U-Boot] [PATCH 1/1] board_r: remove superfluous #ifdef CONFIG_PRAM Heinrich Schuchardt
  2018-01-08  4:52 ` Simon Glass
@ 2018-01-19 21:14 ` Tom Rini
  1 sibling, 0 replies; 3+ messages in thread
From: Tom Rini @ 2018-01-19 21:14 UTC (permalink / raw)
  To: u-boot

On Sun, Jan 07, 2018 at 12:54:20AM +0100, Heinrich Schuchardt wrote:

> initr_mem() is already enclosed by
> 	#if defined(CONFIG_PRAM)
> 	#endif
> 
> So there is no need to check CONFIG_PRAM again inside the
> function.
> 
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> Reviewed-by: Simon Glass <sjg@chromium.org>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180119/6a0752e9/attachment.sig>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-01-19 21:14 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-06 23:54 [U-Boot] [PATCH 1/1] board_r: remove superfluous #ifdef CONFIG_PRAM Heinrich Schuchardt
2018-01-08  4:52 ` Simon Glass
2018-01-19 21:14 ` [U-Boot] [U-Boot, " Tom Rini

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.