* [U-Boot] [PATCH] configs: keystone2: env: Fix burn_uboot_spi command
@ 2018-01-16 8:13 Faiz Abbas
2018-01-16 15:25 ` Tom Rini
2018-01-19 21:15 ` [U-Boot] " Tom Rini
0 siblings, 2 replies; 6+ messages in thread
From: Faiz Abbas @ 2018-01-16 8:13 UTC (permalink / raw)
To: u-boot
Now the u-boot spi image is greater than 0x90000, increase the same in
env during spi erase.
Signed-off-by: Faiz Abbas <faiz_abbas@ti.com>
---
include/configs/ti_armv7_keystone2.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/configs/ti_armv7_keystone2.h b/include/configs/ti_armv7_keystone2.h
index 562bb65..7fb3aaf 100644
--- a/include/configs/ti_armv7_keystone2.h
+++ b/include/configs/ti_armv7_keystone2.h
@@ -266,7 +266,7 @@
"${bootdir}/${fit_bootfile}\0" \
"get_uboot_net=dhcp ${loadaddr} ${tftp_root}/${name_uboot}\0" \
"get_uboot_nfs=nfs ${loadaddr} ${nfs_root}/boot/${name_uboot}\0" \
- "burn_uboot_spi=sf probe; sf erase 0 0x90000; " \
+ "burn_uboot_spi=sf probe; sf erase 0 0x100000; " \
"sf write ${loadaddr} 0 ${filesize}\0" \
"burn_uboot_nand=nand erase 0 0x100000; " \
"nand write ${loadaddr} 0 ${filesize}\0" \
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] configs: keystone2: env: Fix burn_uboot_spi command
2018-01-16 8:13 [U-Boot] [PATCH] configs: keystone2: env: Fix burn_uboot_spi command Faiz Abbas
@ 2018-01-16 15:25 ` Tom Rini
2018-01-17 7:38 ` Faiz Abbas
2018-01-19 21:15 ` [U-Boot] " Tom Rini
1 sibling, 1 reply; 6+ messages in thread
From: Tom Rini @ 2018-01-16 15:25 UTC (permalink / raw)
To: u-boot
On Tue, Jan 16, 2018 at 01:43:40PM +0530, Faiz Abbas wrote:
> Now the u-boot spi image is greater than 0x90000, increase the same in
> env during spi erase.
>
> Signed-off-by: Faiz Abbas <faiz_abbas@ti.com>
> ---
> include/configs/ti_armv7_keystone2.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/configs/ti_armv7_keystone2.h b/include/configs/ti_armv7_keystone2.h
> index 562bb65..7fb3aaf 100644
> --- a/include/configs/ti_armv7_keystone2.h
> +++ b/include/configs/ti_armv7_keystone2.h
> @@ -266,7 +266,7 @@
> "${bootdir}/${fit_bootfile}\0" \
> "get_uboot_net=dhcp ${loadaddr} ${tftp_root}/${name_uboot}\0" \
> "get_uboot_nfs=nfs ${loadaddr} ${nfs_root}/boot/${name_uboot}\0" \
> - "burn_uboot_spi=sf probe; sf erase 0 0x90000; " \
> + "burn_uboot_spi=sf probe; sf erase 0 0x100000; " \
> "sf write ${loadaddr} 0 ${filesize}\0" \
> "burn_uboot_nand=nand erase 0 0x100000; " \
> "nand write ${loadaddr} 0 ${filesize}\0" \
Can we future proof this? Where is the next bit of content located in
the SPI flash? We should erase up to that instead I think. Thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180116/b48f4a6f/attachment.sig>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] configs: keystone2: env: Fix burn_uboot_spi command
2018-01-16 15:25 ` Tom Rini
@ 2018-01-17 7:38 ` Faiz Abbas
2018-01-17 12:56 ` Tom Rini
0 siblings, 1 reply; 6+ messages in thread
From: Faiz Abbas @ 2018-01-17 7:38 UTC (permalink / raw)
To: u-boot
Hi,
+Vignesh
On Tuesday 16 January 2018 08:55 PM, Tom Rini wrote:
> On Tue, Jan 16, 2018 at 01:43:40PM +0530, Faiz Abbas wrote:
>> Now the u-boot spi image is greater than 0x90000, increase the same in
>> env during spi erase.
>>
>> Signed-off-by: Faiz Abbas <faiz_abbas@ti.com>
>> ---
>> include/configs/ti_armv7_keystone2.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/include/configs/ti_armv7_keystone2.h b/include/configs/ti_armv7_keystone2.h
>> index 562bb65..7fb3aaf 100644
>> --- a/include/configs/ti_armv7_keystone2.h
>> +++ b/include/configs/ti_armv7_keystone2.h
>> @@ -266,7 +266,7 @@
>> "${bootdir}/${fit_bootfile}\0" \
>> "get_uboot_net=dhcp ${loadaddr} ${tftp_root}/${name_uboot}\0" \
>> "get_uboot_nfs=nfs ${loadaddr} ${nfs_root}/boot/${name_uboot}\0" \
>> - "burn_uboot_spi=sf probe; sf erase 0 0x90000; " \
>> + "burn_uboot_spi=sf probe; sf erase 0 0x100000; " \
>> "sf write ${loadaddr} 0 ${filesize}\0" \
>> "burn_uboot_nand=nand erase 0 0x100000; " \
>> "nand write ${loadaddr} 0 ${filesize}\0" \
>
> Can we future proof this? Where is the next bit of content located in
> the SPI flash? We should erase up to that instead I think. Thanks!
>
Currently it is limited to 1M by the parameter we pass to kernel in
include/environment/ti/spi.h
#define KEYSTONE_SPI0_MTD_PARTS "spi0.0:1m(u-boot-spl)ro,-(misc);\0"
#define KEYSTONE_SPI1_MTD_PARTS "spi1.0:1m(u-boot-spl)ro,-(misc);\0"
This was added by 3f18ff0 ("ARM: keystone: Pass SPI MTD partition table
via kernel command line")
So this is the maximum limit right now.
Thanks,
Faiz
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] configs: keystone2: env: Fix burn_uboot_spi command
2018-01-17 7:38 ` Faiz Abbas
@ 2018-01-17 12:56 ` Tom Rini
0 siblings, 0 replies; 6+ messages in thread
From: Tom Rini @ 2018-01-17 12:56 UTC (permalink / raw)
To: u-boot
On Wed, Jan 17, 2018 at 01:08:19PM +0530, Faiz Abbas wrote:
> Hi,
>
> +Vignesh
>
> On Tuesday 16 January 2018 08:55 PM, Tom Rini wrote:
> > On Tue, Jan 16, 2018 at 01:43:40PM +0530, Faiz Abbas wrote:
> >> Now the u-boot spi image is greater than 0x90000, increase the same in
> >> env during spi erase.
> >>
> >> Signed-off-by: Faiz Abbas <faiz_abbas@ti.com>
> >> ---
> >> include/configs/ti_armv7_keystone2.h | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/include/configs/ti_armv7_keystone2.h b/include/configs/ti_armv7_keystone2.h
> >> index 562bb65..7fb3aaf 100644
> >> --- a/include/configs/ti_armv7_keystone2.h
> >> +++ b/include/configs/ti_armv7_keystone2.h
> >> @@ -266,7 +266,7 @@
> >> "${bootdir}/${fit_bootfile}\0" \
> >> "get_uboot_net=dhcp ${loadaddr} ${tftp_root}/${name_uboot}\0" \
> >> "get_uboot_nfs=nfs ${loadaddr} ${nfs_root}/boot/${name_uboot}\0" \
> >> - "burn_uboot_spi=sf probe; sf erase 0 0x90000; " \
> >> + "burn_uboot_spi=sf probe; sf erase 0 0x100000; " \
> >> "sf write ${loadaddr} 0 ${filesize}\0" \
> >> "burn_uboot_nand=nand erase 0 0x100000; " \
> >> "nand write ${loadaddr} 0 ${filesize}\0" \
> >
> > Can we future proof this? Where is the next bit of content located in
> > the SPI flash? We should erase up to that instead I think. Thanks!
> >
>
> Currently it is limited to 1M by the parameter we pass to kernel in
> include/environment/ti/spi.h
>
>
> #define KEYSTONE_SPI0_MTD_PARTS "spi0.0:1m(u-boot-spl)ro,-(misc);\0"
> #define KEYSTONE_SPI1_MTD_PARTS "spi1.0:1m(u-boot-spl)ro,-(misc);\0"
>
>
> This was added by 3f18ff0 ("ARM: keystone: Pass SPI MTD partition table
> via kernel command line")
>
> So this is the maximum limit right now.
OK, thanks!
Reviewed-by: Tom Rini <trini@konsulko.com>
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180117/a2ea1775/attachment.sig>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] configs: keystone2: env: Fix burn_uboot_spi command
2018-01-16 8:13 [U-Boot] [PATCH] configs: keystone2: env: Fix burn_uboot_spi command Faiz Abbas
2018-01-16 15:25 ` Tom Rini
@ 2018-01-19 21:15 ` Tom Rini
1 sibling, 0 replies; 6+ messages in thread
From: Tom Rini @ 2018-01-19 21:15 UTC (permalink / raw)
To: u-boot
On Tue, Jan 16, 2018 at 01:43:40PM +0530, Faiz Abbas wrote:
> Now the u-boot spi image is greater than 0x90000, increase the same in
> env during spi erase.
>
> Signed-off-by: Faiz Abbas <faiz_abbas@ti.com>
> Reviewed-by: Tom Rini <trini@konsulko.com>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180119/c86854d8/attachment.sig>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] configs: keystone2: env: Fix burn_uboot_spi command
2017-09-21 2:01 [U-Boot] [PATCH] " Lokesh Vutla
@ 2017-09-29 20:26 ` Tom Rini
0 siblings, 0 replies; 6+ messages in thread
From: Tom Rini @ 2017-09-29 20:26 UTC (permalink / raw)
To: u-boot
On Thu, Sep 21, 2017 at 07:31:13AM +0530, Lokesh Vutla wrote:
> Now the u-boot spi image is greater than 0x80000, increase the same
> in env during spi erase.
>
> Reported-by: Yan Liu <yan-liu@ti.com>
> Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170929/955740c2/attachment.sig>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-01-19 21:15 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-16 8:13 [U-Boot] [PATCH] configs: keystone2: env: Fix burn_uboot_spi command Faiz Abbas
2018-01-16 15:25 ` Tom Rini
2018-01-17 7:38 ` Faiz Abbas
2018-01-17 12:56 ` Tom Rini
2018-01-19 21:15 ` [U-Boot] " Tom Rini
-- strict thread matches above, loose matches on Subject: below --
2017-09-21 2:01 [U-Boot] [PATCH] " Lokesh Vutla
2017-09-29 20:26 ` [U-Boot] " Tom Rini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.