[bug report] cpufreq: scpi: remove arm_big_little dependency

[bug report] cpufreq: scpi: remove arm_big_little dependency

[Dan Carpenter]

Hello Sudeep Holla,

The patch 343a8d17fa8d: "cpufreq: scpi: remove arm_big_little
dependency" from Jan 10, 2018, leads to the following static checker
warning:

	drivers/cpufreq/scpi-cpufreq.c:203 scpi_cpufreq_ready()
	warn: 'cdev' isn't an ERR_PTR

drivers/cpufreq/scpi-cpufreq.c
   198  static void scpi_cpufreq_ready(struct cpufreq_policy *policy)
   199  {
   200          struct scpi_data *priv = policy->driver_data;
   201          struct thermal_cooling_device *cdev;
   202  
   203          cdev = of_cpufreq_cooling_register(policy);
   204          if (!IS_ERR(cdev))
   205                  priv->cdev = cdev;

of_cpufreq_cooling_register() returns NULL on error.  Probably just
remove the if statement?

   206  }

regards,
dan carpenter

Re: [bug report] cpufreq: scpi: remove arm_big_little dependency

[Sudeep Holla]

Hi Dan,

On 22/01/18 10:48, Dan Carpenter wrote:
> Hello Sudeep Holla,
> 
> The patch 343a8d17fa8d: "cpufreq: scpi: remove arm_big_little
> dependency" from Jan 10, 2018, leads to the following static checker
> warning:
> 
> 	drivers/cpufreq/scpi-cpufreq.c:203 scpi_cpufreq_ready()
> 	warn: 'cdev' isn't an ERR_PTR
> 
> drivers/cpufreq/scpi-cpufreq.c
>    198  static void scpi_cpufreq_ready(struct cpufreq_policy *policy)
>    199  {
>    200          struct scpi_data *priv = policy->driver_data;
>    201          struct thermal_cooling_device *cdev;
>    202  
>    203          cdev = of_cpufreq_cooling_register(policy);
>    204          if (!IS_ERR(cdev))
>    205                  priv->cdev = cdev;
> 
> of_cpufreq_cooling_register() returns NULL on error.  Probably just
> remove the if statement?
> 
>    206  }
> 

Thanks for the report, will post the fix soon.

-- 
Regards,
Sudeep

[PATCH] cpufreq: scpi: fix static checker warning cdev isn't an ERR_PTR

[Sudeep Holla]

Commit 343a8d17fa8d ("cpufreq: scpi: remove arm_big_little dependency")
leads to the following static checker warning:

	drivers/cpufreq/scpi-cpufreq.c:203 scpi_cpufreq_ready()
	warn: 'cdev' isn't an ERR_PTR

of_cpufreq_cooling_register() returns NULL on error. This patch removes
the incorrect IS_ERR check on the returned pointer.

Fixes: 343a8d17fa8d ("cpufreq: scpi: remove arm_big_little dependency")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Rafael J. Wysocki <rjw@rjwysocki.net>
Cc: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
---
 drivers/cpufreq/scpi-cpufreq.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/cpufreq/scpi-cpufreq.c b/drivers/cpufreq/scpi-cpufreq.c
index 247fcbfa4cb5..efe32cbefa06 100644
--- a/drivers/cpufreq/scpi-cpufreq.c
+++ b/drivers/cpufreq/scpi-cpufreq.c
@@ -197,11 +197,8 @@ static int scpi_cpufreq_exit(struct cpufreq_policy *policy)
 static void scpi_cpufreq_ready(struct cpufreq_policy *policy)
 {
 	struct scpi_data *priv = policy->driver_data;
-	struct thermal_cooling_device *cdev;
 
-	cdev = of_cpufreq_cooling_register(policy);
-	if (!IS_ERR(cdev))
-		priv->cdev = cdev;
+	priv->cdev = of_cpufreq_cooling_register(policy);
 }
 
 static struct cpufreq_driver scpi_cpufreq_driver = {
-- 
2.7.4

Re: [PATCH] cpufreq: scpi: fix static checker warning cdev isn't an ERR_PTR

[Viresh Kumar]

On 22-01-18, 14:41, Sudeep Holla wrote:
> Commit 343a8d17fa8d ("cpufreq: scpi: remove arm_big_little dependency")
> leads to the following static checker warning:
> 
> 	drivers/cpufreq/scpi-cpufreq.c:203 scpi_cpufreq_ready()
> 	warn: 'cdev' isn't an ERR_PTR
> 
> of_cpufreq_cooling_register() returns NULL on error. This patch removes
> the incorrect IS_ERR check on the returned pointer.
> 
> Fixes: 343a8d17fa8d ("cpufreq: scpi: remove arm_big_little dependency")
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Cc: Rafael J. Wysocki <rjw@rjwysocki.net>
> Cc: Viresh Kumar <viresh.kumar@linaro.org>
> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
> ---
>  drivers/cpufreq/scpi-cpufreq.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)

Acked-by: Viresh Kumar <viresh.kumar@linaro.org>

-- 
viresh

Re: [PATCH] cpufreq: scpi: fix static checker warning cdev isn't an ERR_PTR

[Rafael J. Wysocki]

On Tuesday, January 23, 2018 3:41:42 AM CET Viresh Kumar wrote:
> On 22-01-18, 14:41, Sudeep Holla wrote:
> > Commit 343a8d17fa8d ("cpufreq: scpi: remove arm_big_little dependency")
> > leads to the following static checker warning:
> > 
> > 	drivers/cpufreq/scpi-cpufreq.c:203 scpi_cpufreq_ready()
> > 	warn: 'cdev' isn't an ERR_PTR
> > 
> > of_cpufreq_cooling_register() returns NULL on error. This patch removes
> > the incorrect IS_ERR check on the returned pointer.
> > 
> > Fixes: 343a8d17fa8d ("cpufreq: scpi: remove arm_big_little dependency")
> > Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> > Cc: Rafael J. Wysocki <rjw@rjwysocki.net>
> > Cc: Viresh Kumar <viresh.kumar@linaro.org>
> > Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
> > ---
> >  drivers/cpufreq/scpi-cpufreq.c | 5 +----
> >  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>

Patch applied, thanks!