* [PATCH 0/2] mfd/rc5t583: Adjustments for rc5t583_i2c_probe()
@ 2018-01-15 14:00 ` SF Markus Elfring
0 siblings, 0 replies; 10+ messages in thread
From: SF Markus Elfring @ 2018-01-15 14:00 UTC (permalink / raw)
To: kernel-janitors, Lee Jones; +Cc: LKML
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Mon, 15 Jan 2018 14:57:28 +0100
Two update suggestions were taken into account
from static source code analysis.
Markus Elfring (2):
Delete an error message for a failed memory allocation
Improve a size determination
drivers/mfd/rc5t583.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
--
2.15.1
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 0/2] mfd/rc5t583: Adjustments for rc5t583_i2c_probe()
@ 2018-01-15 14:00 ` SF Markus Elfring
0 siblings, 0 replies; 10+ messages in thread
From: SF Markus Elfring @ 2018-01-15 14:00 UTC (permalink / raw)
To: kernel-janitors, Lee Jones; +Cc: LKML
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Mon, 15 Jan 2018 14:57:28 +0100
Two update suggestions were taken into account
from static source code analysis.
Markus Elfring (2):
Delete an error message for a failed memory allocation
Improve a size determination
drivers/mfd/rc5t583.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
--
2.15.1
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 1/2] mfd/rc5t583: Delete an error message for a failed memory allocation in rc5t583_i2c_probe()
2018-01-15 14:00 ` SF Markus Elfring
@ 2018-01-15 14:01 ` SF Markus Elfring
-1 siblings, 0 replies; 10+ messages in thread
From: SF Markus Elfring @ 2018-01-15 14:01 UTC (permalink / raw)
To: kernel-janitors, Lee Jones; +Cc: LKML
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Mon, 15 Jan 2018 14:48:57 +0100
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/mfd/rc5t583.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/mfd/rc5t583.c b/drivers/mfd/rc5t583.c
index d12243d5ecb8..411dba636a53 100644
--- a/drivers/mfd/rc5t583.c
+++ b/drivers/mfd/rc5t583.c
@@ -259,10 +259,8 @@ static int rc5t583_i2c_probe(struct i2c_client *i2c,
}
rc5t583 = devm_kzalloc(&i2c->dev, sizeof(struct rc5t583), GFP_KERNEL);
- if (!rc5t583) {
- dev_err(&i2c->dev, "Memory allocation failed\n");
+ if (!rc5t583)
return -ENOMEM;
- }
rc5t583->dev = &i2c->dev;
i2c_set_clientdata(i2c, rc5t583);
--
2.15.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 1/2] mfd/rc5t583: Delete an error message for a failed memory allocation in rc5t583_i2c_probe
@ 2018-01-15 14:01 ` SF Markus Elfring
0 siblings, 0 replies; 10+ messages in thread
From: SF Markus Elfring @ 2018-01-15 14:01 UTC (permalink / raw)
To: kernel-janitors, Lee Jones; +Cc: LKML
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Mon, 15 Jan 2018 14:48:57 +0100
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/mfd/rc5t583.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/mfd/rc5t583.c b/drivers/mfd/rc5t583.c
index d12243d5ecb8..411dba636a53 100644
--- a/drivers/mfd/rc5t583.c
+++ b/drivers/mfd/rc5t583.c
@@ -259,10 +259,8 @@ static int rc5t583_i2c_probe(struct i2c_client *i2c,
}
rc5t583 = devm_kzalloc(&i2c->dev, sizeof(struct rc5t583), GFP_KERNEL);
- if (!rc5t583) {
- dev_err(&i2c->dev, "Memory allocation failed\n");
+ if (!rc5t583)
return -ENOMEM;
- }
rc5t583->dev = &i2c->dev;
i2c_set_clientdata(i2c, rc5t583);
--
2.15.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 2/2] mfd/rc5t583: Improve a size determination in rc5t583_i2c_probe()
2018-01-15 14:00 ` SF Markus Elfring
@ 2018-01-15 14:02 ` SF Markus Elfring
-1 siblings, 0 replies; 10+ messages in thread
From: SF Markus Elfring @ 2018-01-15 14:02 UTC (permalink / raw)
To: kernel-janitors, Lee Jones; +Cc: LKML
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Mon, 15 Jan 2018 14:50:25 +0100
Replace the specification of a data structure by a pointer dereference
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/mfd/rc5t583.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mfd/rc5t583.c b/drivers/mfd/rc5t583.c
index 411dba636a53..fd46de02b715 100644
--- a/drivers/mfd/rc5t583.c
+++ b/drivers/mfd/rc5t583.c
@@ -258,7 +258,7 @@ static int rc5t583_i2c_probe(struct i2c_client *i2c,
return -EINVAL;
}
- rc5t583 = devm_kzalloc(&i2c->dev, sizeof(struct rc5t583), GFP_KERNEL);
+ rc5t583 = devm_kzalloc(&i2c->dev, sizeof(*rc5t583), GFP_KERNEL);
if (!rc5t583)
return -ENOMEM;
--
2.15.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 2/2] mfd/rc5t583: Improve a size determination in rc5t583_i2c_probe()
@ 2018-01-15 14:02 ` SF Markus Elfring
0 siblings, 0 replies; 10+ messages in thread
From: SF Markus Elfring @ 2018-01-15 14:02 UTC (permalink / raw)
To: kernel-janitors, Lee Jones; +Cc: LKML
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Mon, 15 Jan 2018 14:50:25 +0100
Replace the specification of a data structure by a pointer dereference
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/mfd/rc5t583.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mfd/rc5t583.c b/drivers/mfd/rc5t583.c
index 411dba636a53..fd46de02b715 100644
--- a/drivers/mfd/rc5t583.c
+++ b/drivers/mfd/rc5t583.c
@@ -258,7 +258,7 @@ static int rc5t583_i2c_probe(struct i2c_client *i2c,
return -EINVAL;
}
- rc5t583 = devm_kzalloc(&i2c->dev, sizeof(struct rc5t583), GFP_KERNEL);
+ rc5t583 = devm_kzalloc(&i2c->dev, sizeof(*rc5t583), GFP_KERNEL);
if (!rc5t583)
return -ENOMEM;
--
2.15.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH 1/2] mfd/rc5t583: Delete an error message for a failed memory allocation in rc5t583_i2c_probe()
2018-01-15 14:01 ` [PATCH 1/2] mfd/rc5t583: Delete an error message for a failed memory allocation in rc5t583_i2c_probe SF Markus Elfring
@ 2018-01-22 15:45 ` Lee Jones
-1 siblings, 0 replies; 10+ messages in thread
From: Lee Jones @ 2018-01-22 15:45 UTC (permalink / raw)
To: SF Markus Elfring; +Cc: kernel-janitors, LKML
On Mon, 15 Jan 2018, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Mon, 15 Jan 2018 14:48:57 +0100
>
> Omit an extra message for a memory allocation failure in this function.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
> drivers/mfd/rc5t583.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
Applied, thanks.
--
Lee Jones
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/2] mfd/rc5t583: Delete an error message for a failed memory allocation in rc5t583_i2c_p
@ 2018-01-22 15:45 ` Lee Jones
0 siblings, 0 replies; 10+ messages in thread
From: Lee Jones @ 2018-01-22 15:45 UTC (permalink / raw)
To: SF Markus Elfring; +Cc: kernel-janitors, LKML
On Mon, 15 Jan 2018, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Mon, 15 Jan 2018 14:48:57 +0100
>
> Omit an extra message for a memory allocation failure in this function.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
> drivers/mfd/rc5t583.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
Applied, thanks.
--
Lee Jones
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 2/2] mfd/rc5t583: Improve a size determination in rc5t583_i2c_probe()
2018-01-15 14:02 ` SF Markus Elfring
@ 2018-01-22 15:45 ` Lee Jones
-1 siblings, 0 replies; 10+ messages in thread
From: Lee Jones @ 2018-01-22 15:45 UTC (permalink / raw)
To: SF Markus Elfring; +Cc: kernel-janitors, LKML
On Mon, 15 Jan 2018, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Mon, 15 Jan 2018 14:50:25 +0100
>
> Replace the specification of a data structure by a pointer dereference
> as the parameter for the operator "sizeof" to make the corresponding size
> determination a bit safer according to the Linux coding style convention.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
> drivers/mfd/rc5t583.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
--
Lee Jones
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 2/2] mfd/rc5t583: Improve a size determination in rc5t583_i2c_probe()
@ 2018-01-22 15:45 ` Lee Jones
0 siblings, 0 replies; 10+ messages in thread
From: Lee Jones @ 2018-01-22 15:45 UTC (permalink / raw)
To: SF Markus Elfring; +Cc: kernel-janitors, LKML
On Mon, 15 Jan 2018, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Mon, 15 Jan 2018 14:50:25 +0100
>
> Replace the specification of a data structure by a pointer dereference
> as the parameter for the operator "sizeof" to make the corresponding size
> determination a bit safer according to the Linux coding style convention.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
> drivers/mfd/rc5t583.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
--
Lee Jones
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2018-01-22 15:45 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-15 14:00 [PATCH 0/2] mfd/rc5t583: Adjustments for rc5t583_i2c_probe() SF Markus Elfring
2018-01-15 14:00 ` SF Markus Elfring
2018-01-15 14:01 ` [PATCH 1/2] mfd/rc5t583: Delete an error message for a failed memory allocation in rc5t583_i2c_probe() SF Markus Elfring
2018-01-15 14:01 ` [PATCH 1/2] mfd/rc5t583: Delete an error message for a failed memory allocation in rc5t583_i2c_probe SF Markus Elfring
2018-01-22 15:45 ` [PATCH 1/2] mfd/rc5t583: Delete an error message for a failed memory allocation in rc5t583_i2c_probe() Lee Jones
2018-01-22 15:45 ` [PATCH 1/2] mfd/rc5t583: Delete an error message for a failed memory allocation in rc5t583_i2c_p Lee Jones
2018-01-15 14:02 ` [PATCH 2/2] mfd/rc5t583: Improve a size determination in rc5t583_i2c_probe() SF Markus Elfring
2018-01-15 14:02 ` SF Markus Elfring
2018-01-22 15:45 ` Lee Jones
2018-01-22 15:45 ` Lee Jones
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.