All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/sun4i: Fix build warnings in sunxi_engine.h
@ 2018-01-22 17:42 ` Sean Paul
  0 siblings, 0 replies; 4+ messages in thread
From: Sean Paul @ 2018-01-22 17:42 UTC (permalink / raw)
  To: linux-arm-kernel

Fixes the following build warnings:
In file included from ../drivers/gpu/drm/sun4i/sun8i_mixer.h:18:0,
                 from ../drivers/gpu/drm/sun4i/sun8i_vi_scaler.h:13,
                 from ../drivers/gpu/drm/sun4i/sun8i_vi_scaler.c:12:
../drivers/gpu/drm/sun4i/sunxi_engine.h:36:16: warning: ?struct drm_crtc_state? declared inside parameter list will not be visible outside of this definition or declaration
         struct drm_crtc_state *old_state);
                ^~~~~~~~~~~~~~
../drivers/gpu/drm/sun4i/sunxi_engine.h:53:15: warning: ?struct drm_crtc_state? declared inside parameter list will not be visible outside of this definition or declaration
        struct drm_crtc_state *state);
               ^~~~~~~~~~~~~~
In file included from ../drivers/gpu/drm/sun4i/sun8i_mixer.h:18:0,
                 from ../drivers/gpu/drm/sun4i/sun8i_ui_scaler.h:12,
                 from ../drivers/gpu/drm/sun4i/sun8i_ui_scaler.c:12:
../drivers/gpu/drm/sun4i/sunxi_engine.h:36:16: warning: ?struct drm_crtc_state? declared inside parameter list will not be visible outside of this definition or declaration
         struct drm_crtc_state *old_state);
                ^~~~~~~~~~~~~~
../drivers/gpu/drm/sun4i/sunxi_engine.h:53:15: warning: ?struct drm_crtc_state? declared inside parameter list will not be visible outside of this definition or declaration
        struct drm_crtc_state *state);
               ^~~~~~~~~~~~~~

Fixes: 6b8562c86e24 ("drm/sun4i: engine: Create an atomic_begin
callback")
Fixes: 656e5f654903 ("drm/sun4i: engine: Add a custom crtc
atomic_check")
Cc: Chen-Yu Tsai <wens@csie.org>
Cc: Neil Armstrong <narmstrong@baylibre.com>
Cc: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: dri-devel at lists.freedesktop.org
Cc: linux-arm-kernel at lists.infradead.org
Signed-off-by: Sean Paul <seanpaul@chromium.org>
---
 drivers/gpu/drm/sun4i/sunxi_engine.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/sun4i/sunxi_engine.h b/drivers/gpu/drm/sun4i/sunxi_engine.h
index baa7a1f95300..d317ea04b8aa 100644
--- a/drivers/gpu/drm/sun4i/sunxi_engine.h
+++ b/drivers/gpu/drm/sun4i/sunxi_engine.h
@@ -12,6 +12,7 @@
 
 struct drm_plane;
 struct drm_device;
+struct drm_crtc_state;
 
 struct sunxi_engine;
 
-- 
2.16.0.rc1.238.g530d649a79-goog

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH] drm/sun4i: Fix build warnings in sunxi_engine.h
@ 2018-01-22 17:42 ` Sean Paul
  0 siblings, 0 replies; 4+ messages in thread
From: Sean Paul @ 2018-01-22 17:42 UTC (permalink / raw)
  To: dri-devel; +Cc: Chen-Yu Tsai, Maxime Ripard, linux-arm-kernel, Neil Armstrong

Fixes the following build warnings:
In file included from ../drivers/gpu/drm/sun4i/sun8i_mixer.h:18:0,
                 from ../drivers/gpu/drm/sun4i/sun8i_vi_scaler.h:13,
                 from ../drivers/gpu/drm/sun4i/sun8i_vi_scaler.c:12:
../drivers/gpu/drm/sun4i/sunxi_engine.h:36:16: warning: ‘struct drm_crtc_state’ declared inside parameter list will not be visible outside of this definition or declaration
         struct drm_crtc_state *old_state);
                ^~~~~~~~~~~~~~
../drivers/gpu/drm/sun4i/sunxi_engine.h:53:15: warning: ‘struct drm_crtc_state’ declared inside parameter list will not be visible outside of this definition or declaration
        struct drm_crtc_state *state);
               ^~~~~~~~~~~~~~
In file included from ../drivers/gpu/drm/sun4i/sun8i_mixer.h:18:0,
                 from ../drivers/gpu/drm/sun4i/sun8i_ui_scaler.h:12,
                 from ../drivers/gpu/drm/sun4i/sun8i_ui_scaler.c:12:
../drivers/gpu/drm/sun4i/sunxi_engine.h:36:16: warning: ‘struct drm_crtc_state’ declared inside parameter list will not be visible outside of this definition or declaration
         struct drm_crtc_state *old_state);
                ^~~~~~~~~~~~~~
../drivers/gpu/drm/sun4i/sunxi_engine.h:53:15: warning: ‘struct drm_crtc_state’ declared inside parameter list will not be visible outside of this definition or declaration
        struct drm_crtc_state *state);
               ^~~~~~~~~~~~~~

Fixes: 6b8562c86e24 ("drm/sun4i: engine: Create an atomic_begin
callback")
Fixes: 656e5f654903 ("drm/sun4i: engine: Add a custom crtc
atomic_check")
Cc: Chen-Yu Tsai <wens@csie.org>
Cc: Neil Armstrong <narmstrong@baylibre.com>
Cc: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: dri-devel@lists.freedesktop.org
Cc: linux-arm-kernel@lists.infradead.org
Signed-off-by: Sean Paul <seanpaul@chromium.org>
---
 drivers/gpu/drm/sun4i/sunxi_engine.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/sun4i/sunxi_engine.h b/drivers/gpu/drm/sun4i/sunxi_engine.h
index baa7a1f95300..d317ea04b8aa 100644
--- a/drivers/gpu/drm/sun4i/sunxi_engine.h
+++ b/drivers/gpu/drm/sun4i/sunxi_engine.h
@@ -12,6 +12,7 @@
 
 struct drm_plane;
 struct drm_device;
+struct drm_crtc_state;
 
 struct sunxi_engine;
 
-- 
2.16.0.rc1.238.g530d649a79-goog

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH] drm/sun4i: Fix build warnings in sunxi_engine.h
  2018-01-22 17:42 ` Sean Paul
@ 2018-01-23  9:58   ` Maxime Ripard
  -1 siblings, 0 replies; 4+ messages in thread
From: Maxime Ripard @ 2018-01-23  9:58 UTC (permalink / raw)
  To: linux-arm-kernel

On Mon, Jan 22, 2018 at 12:42:59PM -0500, Sean Paul wrote:
> Fixes the following build warnings:
> In file included from ../drivers/gpu/drm/sun4i/sun8i_mixer.h:18:0,
>                  from ../drivers/gpu/drm/sun4i/sun8i_vi_scaler.h:13,
>                  from ../drivers/gpu/drm/sun4i/sun8i_vi_scaler.c:12:
> ../drivers/gpu/drm/sun4i/sunxi_engine.h:36:16: warning: ?struct drm_crtc_state? declared inside parameter list will not be visible outside of this definition or declaration
>          struct drm_crtc_state *old_state);
>                 ^~~~~~~~~~~~~~
> ../drivers/gpu/drm/sun4i/sunxi_engine.h:53:15: warning: ?struct drm_crtc_state? declared inside parameter list will not be visible outside of this definition or declaration
>         struct drm_crtc_state *state);
>                ^~~~~~~~~~~~~~
> In file included from ../drivers/gpu/drm/sun4i/sun8i_mixer.h:18:0,
>                  from ../drivers/gpu/drm/sun4i/sun8i_ui_scaler.h:12,
>                  from ../drivers/gpu/drm/sun4i/sun8i_ui_scaler.c:12:
> ../drivers/gpu/drm/sun4i/sunxi_engine.h:36:16: warning: ?struct drm_crtc_state? declared inside parameter list will not be visible outside of this definition or declaration
>          struct drm_crtc_state *old_state);
>                 ^~~~~~~~~~~~~~
> ../drivers/gpu/drm/sun4i/sunxi_engine.h:53:15: warning: ?struct drm_crtc_state? declared inside parameter list will not be visible outside of this definition or declaration
>         struct drm_crtc_state *state);
>                ^~~~~~~~~~~~~~
> 
> Fixes: 6b8562c86e24 ("drm/sun4i: engine: Create an atomic_begin
> callback")
> Fixes: 656e5f654903 ("drm/sun4i: engine: Add a custom crtc
> atomic_check")
> Cc: Chen-Yu Tsai <wens@csie.org>
> Cc: Neil Armstrong <narmstrong@baylibre.com>
> Cc: Maxime Ripard <maxime.ripard@free-electrons.com>
> Cc: dri-devel at lists.freedesktop.org
> Cc: linux-arm-kernel at lists.infradead.org
> Signed-off-by: Sean Paul <seanpaul@chromium.org>

Sorry for that, I just pushed it.

Thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20180123/a94e6b47/attachment.sig>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] drm/sun4i: Fix build warnings in sunxi_engine.h
@ 2018-01-23  9:58   ` Maxime Ripard
  0 siblings, 0 replies; 4+ messages in thread
From: Maxime Ripard @ 2018-01-23  9:58 UTC (permalink / raw)
  To: Sean Paul; +Cc: Chen-Yu Tsai, linux-arm-kernel, dri-devel, Neil Armstrong


[-- Attachment #1.1: Type: text/plain, Size: 2159 bytes --]

On Mon, Jan 22, 2018 at 12:42:59PM -0500, Sean Paul wrote:
> Fixes the following build warnings:
> In file included from ../drivers/gpu/drm/sun4i/sun8i_mixer.h:18:0,
>                  from ../drivers/gpu/drm/sun4i/sun8i_vi_scaler.h:13,
>                  from ../drivers/gpu/drm/sun4i/sun8i_vi_scaler.c:12:
> ../drivers/gpu/drm/sun4i/sunxi_engine.h:36:16: warning: ‘struct drm_crtc_state’ declared inside parameter list will not be visible outside of this definition or declaration
>          struct drm_crtc_state *old_state);
>                 ^~~~~~~~~~~~~~
> ../drivers/gpu/drm/sun4i/sunxi_engine.h:53:15: warning: ‘struct drm_crtc_state’ declared inside parameter list will not be visible outside of this definition or declaration
>         struct drm_crtc_state *state);
>                ^~~~~~~~~~~~~~
> In file included from ../drivers/gpu/drm/sun4i/sun8i_mixer.h:18:0,
>                  from ../drivers/gpu/drm/sun4i/sun8i_ui_scaler.h:12,
>                  from ../drivers/gpu/drm/sun4i/sun8i_ui_scaler.c:12:
> ../drivers/gpu/drm/sun4i/sunxi_engine.h:36:16: warning: ‘struct drm_crtc_state’ declared inside parameter list will not be visible outside of this definition or declaration
>          struct drm_crtc_state *old_state);
>                 ^~~~~~~~~~~~~~
> ../drivers/gpu/drm/sun4i/sunxi_engine.h:53:15: warning: ‘struct drm_crtc_state’ declared inside parameter list will not be visible outside of this definition or declaration
>         struct drm_crtc_state *state);
>                ^~~~~~~~~~~~~~
> 
> Fixes: 6b8562c86e24 ("drm/sun4i: engine: Create an atomic_begin
> callback")
> Fixes: 656e5f654903 ("drm/sun4i: engine: Add a custom crtc
> atomic_check")
> Cc: Chen-Yu Tsai <wens@csie.org>
> Cc: Neil Armstrong <narmstrong@baylibre.com>
> Cc: Maxime Ripard <maxime.ripard@free-electrons.com>
> Cc: dri-devel@lists.freedesktop.org
> Cc: linux-arm-kernel@lists.infradead.org
> Signed-off-by: Sean Paul <seanpaul@chromium.org>

Sorry for that, I just pushed it.

Thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2018-01-23  9:58 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-22 17:42 [PATCH] drm/sun4i: Fix build warnings in sunxi_engine.h Sean Paul
2018-01-22 17:42 ` Sean Paul
2018-01-23  9:58 ` Maxime Ripard
2018-01-23  9:58   ` Maxime Ripard

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.