From: "Michael S. Tsirkin" <mst@redhat.com>
To: Wei Wang <wei.w.wang@intel.com>
Cc: virtio-dev@lists.oasis-open.org, linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org, kvm@vger.kernel.org,
linux-mm@kvack.org, mhocko@kernel.org, akpm@linux-foundation.org,
pbonzini@redhat.com, liliang.opensource@gmail.com,
yang.zhang.wz@gmail.com, quan.xu0@gmail.com, nilal@redhat.com,
riel@redhat.com
Subject: Re: [PATCH v23 2/2] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_VQ
Date: Wed, 24 Jan 2018 19:32:59 +0200 [thread overview]
Message-ID: <20180124193217-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <5A681E03.1030007@intel.com>
On Wed, Jan 24, 2018 at 01:47:47PM +0800, Wei Wang wrote:
> On 01/24/2018 01:01 PM, Michael S. Tsirkin wrote:
> > On Wed, Jan 24, 2018 at 10:50:27AM +0800, Wei Wang wrote:
> > This will not DTRT in all cases. It's quite possible
> > that host does not need the kick when ring is half full but
> > does need it later when ring is full.
> > You can kick at ring half full as optimization but you absolutely
> > still must kick on ring full. Something like:
> >
> > if (vq->num_free == virtqueue_get_vring_size(vq) / 2 ||
> > vq->num_free <= 2)
>
> Right. Would "if (vq->num_free < virtqueue_get_vring_size(vq) / 2" be
> better?
>
>
> Best,
> Wei
It gives more kicks ... this reminds me, you need to validate
that vring size is at least 2, otherwise fail probe.
--
MST
WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Wei Wang <wei.w.wang@intel.com>
Cc: virtio-dev@lists.oasis-open.org, linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org, kvm@vger.kernel.org,
linux-mm@kvack.org, mhocko@kernel.org, akpm@linux-foundation.org,
pbonzini@redhat.com, liliang.opensource@gmail.com,
yang.zhang.wz@gmail.com, quan.xu0@gmail.com, nilal@redhat.com,
riel@redhat.com
Subject: Re: [PATCH v23 2/2] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_VQ
Date: Wed, 24 Jan 2018 19:32:59 +0200 [thread overview]
Message-ID: <20180124193217-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <5A681E03.1030007@intel.com>
On Wed, Jan 24, 2018 at 01:47:47PM +0800, Wei Wang wrote:
> On 01/24/2018 01:01 PM, Michael S. Tsirkin wrote:
> > On Wed, Jan 24, 2018 at 10:50:27AM +0800, Wei Wang wrote:
> > This will not DTRT in all cases. It's quite possible
> > that host does not need the kick when ring is half full but
> > does need it later when ring is full.
> > You can kick at ring half full as optimization but you absolutely
> > still must kick on ring full. Something like:
> >
> > if (vq->num_free == virtqueue_get_vring_size(vq) / 2 ||
> > vq->num_free <= 2)
>
> Right. Would "if (vq->num_free < virtqueue_get_vring_size(vq) / 2" be
> better?
>
>
> Best,
> Wei
It gives more kicks ... this reminds me, you need to validate
that vring size is at least 2, otherwise fail probe.
--
MST
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Wei Wang <wei.w.wang@intel.com>
Cc: virtio-dev@lists.oasis-open.org, linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org, kvm@vger.kernel.org,
linux-mm@kvack.org, mhocko@kernel.org, akpm@linux-foundation.org,
pbonzini@redhat.com, liliang.opensource@gmail.com,
yang.zhang.wz@gmail.com, quan.xu0@gmail.com, nilal@redhat.com,
riel@redhat.com
Subject: [virtio-dev] Re: [PATCH v23 2/2] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_VQ
Date: Wed, 24 Jan 2018 19:32:59 +0200 [thread overview]
Message-ID: <20180124193217-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <5A681E03.1030007@intel.com>
On Wed, Jan 24, 2018 at 01:47:47PM +0800, Wei Wang wrote:
> On 01/24/2018 01:01 PM, Michael S. Tsirkin wrote:
> > On Wed, Jan 24, 2018 at 10:50:27AM +0800, Wei Wang wrote:
> > This will not DTRT in all cases. It's quite possible
> > that host does not need the kick when ring is half full but
> > does need it later when ring is full.
> > You can kick at ring half full as optimization but you absolutely
> > still must kick on ring full. Something like:
> >
> > if (vq->num_free == virtqueue_get_vring_size(vq) / 2 ||
> > vq->num_free <= 2)
>
> Right. Would "if (vq->num_free < virtqueue_get_vring_size(vq) / 2" be
> better?
>
>
> Best,
> Wei
It gives more kicks ... this reminds me, you need to validate
that vring size is at least 2, otherwise fail probe.
--
MST
---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
next prev parent reply other threads:[~2018-01-24 17:33 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-24 2:50 [PATCH v23 0/2] Virtio-balloon: support free page reporting Wei Wang
2018-01-24 2:50 ` [virtio-dev] " Wei Wang
2018-01-24 2:50 ` Wei Wang
2018-01-24 2:50 ` [PATCH v23 1/2] mm: support reporting free page blocks Wei Wang
2018-01-24 2:50 ` [virtio-dev] " Wei Wang
2018-01-24 2:50 ` Wei Wang
2018-01-24 2:50 ` Wei Wang
2018-01-24 2:50 ` [PATCH v23 2/2] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_VQ Wei Wang
2018-01-24 2:50 ` Wei Wang
2018-01-24 2:50 ` [virtio-dev] " Wei Wang
2018-01-24 2:50 ` Wei Wang
2018-01-24 5:01 ` Michael S. Tsirkin
2018-01-24 5:01 ` Michael S. Tsirkin
2018-01-24 5:01 ` [virtio-dev] " Michael S. Tsirkin
2018-01-24 5:01 ` Michael S. Tsirkin
2018-01-24 5:47 ` Wei Wang
2018-01-24 5:47 ` [virtio-dev] " Wei Wang
2018-01-24 5:47 ` Wei Wang
2018-01-24 17:32 ` Michael S. Tsirkin
2018-01-24 17:32 ` Michael S. Tsirkin [this message]
2018-01-24 17:32 ` [virtio-dev] " Michael S. Tsirkin
2018-01-24 17:32 ` Michael S. Tsirkin
2018-01-24 5:47 ` Wei Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180124193217-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=kvm@vger.kernel.org \
--cc=liliang.opensource@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=nilal@redhat.com \
--cc=pbonzini@redhat.com \
--cc=quan.xu0@gmail.com \
--cc=riel@redhat.com \
--cc=virtio-dev@lists.oasis-open.org \
--cc=virtualization@lists.linux-foundation.org \
--cc=wei.w.wang@intel.com \
--cc=yang.zhang.wz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.