[PATCH] cal: drop trailing blank line

[PATCH] cal: drop trailing blank line

[Mike Frysinger]

There's no history to be found behind this, and the comment in the
code indicates no one else knows, and it makes me angry :).

Signed-off-by: Mike Frysinger <vapier@gentoo.org>
---
 misc-utils/cal.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/misc-utils/cal.c b/misc-utils/cal.c
index 3e20530..479c967 100644
--- a/misc-utils/cal.c
+++ b/misc-utils/cal.c
@@ -767,9 +767,6 @@ static void yearly(const struct cal_control *ctl)
 		my_putstring("\n\n");
 	}
 	monthly(ctl);
-
-	/* Is empty line at the end year output really needed? */
-	my_putstring("\n");
 }
 
 /*
-- 
2.8.2

Re: [PATCH] cal: drop trailing blank line

[Bruce Dubbs]

Mike Frysinger wrote:
> There's no history to be found behind this, and the comment in the
> code indicates no one else knows, and it makes me angry :).
>
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> ---
>   misc-utils/cal.c | 3 ---
>   1 file changed, 3 deletions(-)
>
> diff --git a/misc-utils/cal.c b/misc-utils/cal.c
> index 3e20530..479c967 100644
> --- a/misc-utils/cal.c
> +++ b/misc-utils/cal.c
> @@ -767,9 +767,6 @@ static void yearly(const struct cal_control *ctl)
>   		my_putstring("\n\n");
>   	}
>   	monthly(ctl);
> -
> -	/* Is empty line at the end year output really needed? */
> -	my_putstring("\n");
>   }
>
>   /*

Personally I like the blank line. It sets off the cal output from the 
shell prompt making it easier to read.  It is basically adding the 
equivalent of the css property padding-bottom="1em".

I note that if doing a 'cal -y' that there is also a blank line between 
the year and February.  That should stay also.

   -- Bruce Dubbs
      linuxfromscratch.org

Re: [PATCH] cal: drop trailing blank line

[Mike Frysinger]

[-- Attachment #1: Type: text/plain, Size: 1453 bytes --]

On 23 May 2016 16:30, Bruce Dubbs wrote:
> Mike Frysinger wrote:
> > There's no history to be found behind this, and the comment in the
> > code indicates no one else knows, and it makes me angry :).
> >
> > --- a/misc-utils/cal.c
> > +++ b/misc-utils/cal.c
> > @@ -767,9 +767,6 @@ static void yearly(const struct cal_control *ctl)
> >   		my_putstring("\n\n");
> >   	}
> >   	monthly(ctl);
> > -
> > -	/* Is empty line at the end year output really needed? */
> > -	my_putstring("\n");
> >   }
> >
> >   /*
> 
> Personally I like the blank line. It sets off the cal output from the 
> shell prompt making it easier to read.  It is basically adding the 
> equivalent of the css property padding-bottom="1em".

why should cal care ?  you could make this same exact argument for any
other cli tool that displays things.  if you like that behavior, then
update your PS1 to include a leading \n.

> I note that if doing a 'cal -y' that there is also a blank line between 
> the year and February.  That should stay also.

that's a different issue.  cal always writes exactly 6 lines for a month
regardless of how many weeks a month actually uses.  it makes the code
simpler (no need to scan/remember sibling months) and the output more
consistent -- every row is 7 lines.  pick a non-leap year like 2015 and
see Feb take up only 4 lines but still leave 2 blank below it.  or pick
2019 and see Mar use all 6 lines.
-mike

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH] cal: drop trailing blank line

[Mike Frysinger]

[-- Attachment #1: Type: text/plain, Size: 102 bytes --]

On 23 May 2016 18:58, Mike Frysinger wrote:
> consistent -- every row is 7 lines.

s/row/month/
-mike

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH] cal: drop trailing blank line

[Bruce Dubbs]

Mike Frysinger wrote:
> On 23 May 2016 16:30, Bruce Dubbs wrote:
>> Mike Frysinger wrote:
>>> There's no history to be found behind this, and the comment in the
>>> code indicates no one else knows, and it makes me angry :).
>>>
>>> --- a/misc-utils/cal.c
>>> +++ b/misc-utils/cal.c
>>> @@ -767,9 +767,6 @@ static void yearly(const struct cal_control *ctl)
>>>    		my_putstring("\n\n");
>>>    	}
>>>    	monthly(ctl);
>>> -
>>> -	/* Is empty line at the end year output really needed? */
>>> -	my_putstring("\n");
>>>    }
>>>
>>>    /*
>>
>> Personally I like the blank line. It sets off the cal output from the
>> shell prompt making it easier to read.  It is basically adding the
>> equivalent of the css property padding-bottom="1em".
>
> why should cal care ?  you could make this same exact argument for any
> other cli tool that displays things.  if you like that behavior, then
> update your PS1 to include a leading \n.

I certainly do not want to double space every bash prompt.  Your solution 
causes more problems than it solves.

>> I note that if doing a 'cal -y' that there is also a blank line between
>> the year and February.  That should stay also.
>
> that's a different issue.  cal always writes exactly 6 lines for a month
> regardless of how many weeks a month actually uses.  it makes the code
> simpler (no need to scan/remember sibling months) and the output more
> consistent -- every row is 7 lines.  pick a non-leap year like 2015 and
> see Feb take up only 4 lines but still leave 2 blank below it.  or pick
> 2019 and see Mar use all 6 lines.

Did you look at the output?

                                2016
---> blank line
        January               February                 March
Su Mo Tu We Th Fr Sa   Su Mo Tu We Th Fr Sa   Su Mo Tu We Th Fr Sa
                 1  2       1  2  3  4  5  6          1  2  3  4  5


   -- Bruce

Re: [PATCH] cal: drop trailing blank line

[Mike Frysinger]

[-- Attachment #1: Type: text/plain, Size: 2120 bytes --]

On 23 May 2016 18:32, Bruce Dubbs wrote:
> Mike Frysinger wrote:
> > On 23 May 2016 16:30, Bruce Dubbs wrote:
> >> Mike Frysinger wrote:
> >>> There's no history to be found behind this, and the comment in the
> >>> code indicates no one else knows, and it makes me angry :).
> >>>
> >>> --- a/misc-utils/cal.c
> >>> +++ b/misc-utils/cal.c
> >>> @@ -767,9 +767,6 @@ static void yearly(const struct cal_control *ctl)
> >>>    		my_putstring("\n\n");
> >>>    	}
> >>>    	monthly(ctl);
> >>> -
> >>> -	/* Is empty line at the end year output really needed? */
> >>> -	my_putstring("\n");
> >>>    }
> >>>
> >>>    /*
> >>
> >> Personally I like the blank line. It sets off the cal output from the
> >> shell prompt making it easier to read.  It is basically adding the
> >> equivalent of the css property padding-bottom="1em".
> >
> > why should cal care ?  you could make this same exact argument for any
> > other cli tool that displays things.  if you like that behavior, then
> > update your PS1 to include a leading \n.
> 
> I certainly do not want to double space every bash prompt.  Your solution 
> causes more problems than it solves.

if you want to special case `cal` or any other util, then alias it in
your shell.  your personal preference for a util doesn't mean it should
stay that way.  the trailing newline is uncommon in the cli world.

> >> I note that if doing a 'cal -y' that there is also a blank line between
> >> the year and February.  That should stay also.
> >
> > that's a different issue.  cal always writes exactly 6 lines for a month
> > regardless of how many weeks a month actually uses.  it makes the code
> > simpler (no need to scan/remember sibling months) and the output more
> > consistent -- every row is 7 lines.  pick a non-leap year like 2015 and
> > see Feb take up only 4 lines but still leave 2 blank below it.  or pick
> > 2019 and see Mar use all 6 lines.
> 
> Did you look at the output?

i thought you were talking about the inter-month spacing.  i don't care
about either of those, nor does my change impact them.
-mike

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH] cal: drop trailing blank line

[Mike Frysinger]

[-- Attachment #1: Type: text/plain, Size: 720 bytes --]

On 23 May 2016 17:02, Mike Frysinger wrote:
> There's no history to be found behind this, and the comment in the
> code indicates no one else knows, and it makes me angry :).
> 
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> ---
>  misc-utils/cal.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/misc-utils/cal.c b/misc-utils/cal.c
> index 3e20530..479c967 100644
> --- a/misc-utils/cal.c
> +++ b/misc-utils/cal.c
> @@ -767,9 +767,6 @@ static void yearly(const struct cal_control *ctl)
>  		my_putstring("\n\n");
>  	}
>  	monthly(ctl);
> -
> -	/* Is empty line at the end year output really needed? */
> -	my_putstring("\n");
>  }
>  
>  /*
> -- 
> 2.8.2

ping ...
-mike

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH] cal: drop trailing blank line

[J William Piggott]

On 01/24/2018 11:22 PM, Mike Frysinger wrote:
> On 23 May 2016 17:02, Mike Frysinger wrote:
>> There's no history to be found behind this, and the comment in the
>> code indicates no one else knows, and it makes me angry :).
>>
>> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
>> ---
>>  misc-utils/cal.c | 3 ---
>>  1 file changed, 3 deletions(-)
>>
>> diff --git a/misc-utils/cal.c b/misc-utils/cal.c
>> index 3e20530..479c967 100644
>> --- a/misc-utils/cal.c
>> +++ b/misc-utils/cal.c
>> @@ -767,9 +767,6 @@ static void yearly(const struct cal_control *ctl)

Hi Mike,

If Karel accepts it, yearly() is removed completely in my last submission:
  [PATCH 2/4] cal: remove year top header


>>  		my_putstring("\n\n");
>>  	}
>>  	monthly(ctl);
>> -
>> -	/* Is empty line at the end year output really needed? */
>> -	my_putstring("\n");
>>  }
>>  
>>  /*
>> -- 
>> 2.8.2
> 
> ping ...
> -mike
>