From: Greg KH <greg@kroah.com>
To: Ingo Molnar <mingo@kernel.org>
Cc: Benjamin Gilbert <benjamin.gilbert@coreos.com>,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
x86@kernel.org, Borislav Petkov <bp@suse.de>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H . Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH 3/3] firmware: Fix up docs referring to FIRMWARE_IN_KERNEL
Date: Thu, 25 Jan 2018 10:38:17 +0100 [thread overview]
Message-ID: <20180125093817.GB14894@kroah.com> (raw)
In-Reply-To: <20180124074130.h35a6gghehnxr2st@gmail.com>
On Wed, Jan 24, 2018 at 08:41:30AM +0100, Ingo Molnar wrote:
>
> * Benjamin Gilbert <benjamin.gilbert@coreos.com> wrote:
>
> > We've removed the option, so stop talking about it.
> >
> > Signed-off-by: Benjamin Gilbert <benjamin.gilbert@coreos.com>
> > Cc: Borislav Petkov <bp@suse.de>
> > Cc: Thomas Gleixner <tglx@linutronix.de>
> > Cc: Ingo Molnar <mingo@redhat.com>
> > Cc: H. Peter Anvin <hpa@zytor.com>
> > ---
> > Documentation/driver-api/firmware/built-in-fw.rst | 7 +------
> > Documentation/x86/microcode.txt | 5 ++---
> > arch/x86/Kconfig | 6 +++---
> > 3 files changed, 6 insertions(+), 12 deletions(-)
> >
> > diff --git a/Documentation/driver-api/firmware/built-in-fw.rst b/Documentation/driver-api/firmware/built-in-fw.rst
> > index 7300e66857f8..396cdf591ac5 100644
> > --- a/Documentation/driver-api/firmware/built-in-fw.rst
> > +++ b/Documentation/driver-api/firmware/built-in-fw.rst
> > @@ -11,13 +11,8 @@ options:
> > * CONFIG_EXTRA_FIRMWARE
> > * CONFIG_EXTRA_FIRMWARE_DIR
> >
> > -This should not be confused with CONFIG_FIRMWARE_IN_KERNEL, this is for drivers
> > -which enables firmware to be built as part of the kernel build process. This
> > -option, CONFIG_FIRMWARE_IN_KERNEL, will build all firmware for all drivers
> > -enabled which ship its firmware inside the Linux kernel source tree.
> > -
> > There are a few reasons why you might want to consider building your firmware
> > -into the kernel with CONFIG_EXTRA_FIRMWARE though:
> > +into the kernel with CONFIG_EXTRA_FIRMWARE:
> >
> > * Speed
> > * Firmware is needed for accessing the boot device, and the user doesn't
> > diff --git a/Documentation/x86/microcode.txt b/Documentation/x86/microcode.txt
> > index f57e1b45e628..aacd2f5e1a46 100644
> > --- a/Documentation/x86/microcode.txt
> > +++ b/Documentation/x86/microcode.txt
> > @@ -108,12 +108,11 @@ packages already put them there.
> > ====================
> >
> > The loader supports also loading of a builtin microcode supplied through
> > -the regular firmware builtin method CONFIG_FIRMWARE_IN_KERNEL. Only
> > -64-bit is currently supported.
> > +the regular firmware builtin method CONFIG_EXTRA_FIRMWARE. Only 64-bit is
> > +currently supported.
>
> s/regular firmware builtin method
> /regular builtin firmware method
I'll go edit that up by hand, thanks for the review.
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <greg@kroah.com>
To: Ingo Molnar <mingo@kernel.org>
Cc: Benjamin Gilbert <benjamin.gilbert@coreos.com>,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
x86@kernel.org, Borislav Petkov <bp@suse.de>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H . Peter Anvin" <hpa@zytor.com>
Subject: [3/3] firmware: Fix up docs referring to FIRMWARE_IN_KERNEL
Date: Thu, 25 Jan 2018 10:38:17 +0100 [thread overview]
Message-ID: <20180125093817.GB14894@kroah.com> (raw)
On Wed, Jan 24, 2018 at 08:41:30AM +0100, Ingo Molnar wrote:
>
> * Benjamin Gilbert <benjamin.gilbert@coreos.com> wrote:
>
> > We've removed the option, so stop talking about it.
> >
> > Signed-off-by: Benjamin Gilbert <benjamin.gilbert@coreos.com>
> > Cc: Borislav Petkov <bp@suse.de>
> > Cc: Thomas Gleixner <tglx@linutronix.de>
> > Cc: Ingo Molnar <mingo@redhat.com>
> > Cc: H. Peter Anvin <hpa@zytor.com>
> > ---
> > Documentation/driver-api/firmware/built-in-fw.rst | 7 +------
> > Documentation/x86/microcode.txt | 5 ++---
> > arch/x86/Kconfig | 6 +++---
> > 3 files changed, 6 insertions(+), 12 deletions(-)
> >
> > diff --git a/Documentation/driver-api/firmware/built-in-fw.rst b/Documentation/driver-api/firmware/built-in-fw.rst
> > index 7300e66857f8..396cdf591ac5 100644
> > --- a/Documentation/driver-api/firmware/built-in-fw.rst
> > +++ b/Documentation/driver-api/firmware/built-in-fw.rst
> > @@ -11,13 +11,8 @@ options:
> > * CONFIG_EXTRA_FIRMWARE
> > * CONFIG_EXTRA_FIRMWARE_DIR
> >
> > -This should not be confused with CONFIG_FIRMWARE_IN_KERNEL, this is for drivers
> > -which enables firmware to be built as part of the kernel build process. This
> > -option, CONFIG_FIRMWARE_IN_KERNEL, will build all firmware for all drivers
> > -enabled which ship its firmware inside the Linux kernel source tree.
> > -
> > There are a few reasons why you might want to consider building your firmware
> > -into the kernel with CONFIG_EXTRA_FIRMWARE though:
> > +into the kernel with CONFIG_EXTRA_FIRMWARE:
> >
> > * Speed
> > * Firmware is needed for accessing the boot device, and the user doesn't
> > diff --git a/Documentation/x86/microcode.txt b/Documentation/x86/microcode.txt
> > index f57e1b45e628..aacd2f5e1a46 100644
> > --- a/Documentation/x86/microcode.txt
> > +++ b/Documentation/x86/microcode.txt
> > @@ -108,12 +108,11 @@ packages already put them there.
> > ====================
> >
> > The loader supports also loading of a builtin microcode supplied through
> > -the regular firmware builtin method CONFIG_FIRMWARE_IN_KERNEL. Only
> > -64-bit is currently supported.
> > +the regular firmware builtin method CONFIG_EXTRA_FIRMWARE. Only 64-bit is
> > +currently supported.
>
> s/regular firmware builtin method
> /regular builtin firmware method
I'll go edit that up by hand, thanks for the review.
greg k-h
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2018-01-25 9:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-24 2:06 [PATCH 0/3] Drop config options left over from in-kernel firmware Benjamin Gilbert
2018-01-24 2:06 ` [PATCH 1/3] USB: serial: keyspan: Drop firmware Kconfig options Benjamin Gilbert
2018-01-24 2:06 ` [1/3] " Benjamin Gilbert
2018-01-24 2:06 ` [PATCH 2/3] firmware: Drop FIRMWARE_IN_KERNEL Kconfig option Benjamin Gilbert
2018-01-24 2:06 ` [2/3] " Benjamin Gilbert
2018-01-24 5:59 ` [PATCH 2/3] " Robin H. Johnson
2018-01-24 5:59 ` [2/3] " Robin H. Johnson
2018-01-24 2:06 ` [PATCH 3/3] firmware: Fix up docs referring to FIRMWARE_IN_KERNEL Benjamin Gilbert
2018-01-24 2:06 ` [3/3] " Benjamin Gilbert
2018-01-24 7:41 ` [PATCH 3/3] " Ingo Molnar
2018-01-24 7:41 ` [3/3] " Ingo Molnar
2018-01-25 9:38 ` Greg KH [this message]
2018-01-25 9:38 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180125093817.GB14894@kroah.com \
--to=greg@kroah.com \
--cc=benjamin.gilbert@coreos.com \
--cc=bp@suse.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.