All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Chiranjeevi Rapolu <chiranjeevi.rapolu@intel.com>
Cc: linux-media@vger.kernel.org, tfiga@chromium.org,
	jian.xu.zheng@intel.com, tian.shu.qiu@intel.com,
	andy.yeh@intel.com, rajmohan.mani@intel.com,
	hyungwoo.yang@intel.com
Subject: Re: [PATCH v1] media: ov13858: Avoid possible null first frame
Date: Thu, 25 Jan 2018 12:29:58 +0200	[thread overview]
Message-ID: <20180125102958.dxky4qrzv5ags6av@paasikivi.fi.intel.com> (raw)
In-Reply-To: <1516854879-15029-1-git-send-email-chiranjeevi.rapolu@intel.com>

Hi Chiranjeevi,

On Wed, Jan 24, 2018 at 08:34:39PM -0800, Chiranjeevi Rapolu wrote:
> Previously, the sensor, with default settings, was outputting SOF without
> data. This results in frame sync error on the receiver side.
> 
> Now, configure the sensor to output SOF with MIPI data for all frames. This
> avoids possible null first frame on the bus.
> 
> Signed-off-by: Chiranjeevi Rapolu <chiranjeevi.rapolu@intel.com>
> Signed-off-by: Tianshu Qiu <tian.shu.qiu@intel.com>

Thanks for the patch.

I'll apply this now, however I see that most of the registers in the four
modes are the same. In the future it'd be good to separate the parts that
are common in all of them (to be written in sensor power-on) to make this
(slightly) more maintainable.

-- 
Kind regards,

Sakari Ailus
sakari.ailus@linux.intel.com

  reply	other threads:[~2018-01-25 10:30 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-25  4:34 [PATCH v1] media: ov13858: Avoid possible null first frame Chiranjeevi Rapolu
2018-01-25 10:29 ` Sakari Ailus [this message]
2018-01-25 17:36   ` Rapolu, Chiranjeevi
2018-01-30 12:45     ` Sakari Ailus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180125102958.dxky4qrzv5ags6av@paasikivi.fi.intel.com \
    --to=sakari.ailus@linux.intel.com \
    --cc=andy.yeh@intel.com \
    --cc=chiranjeevi.rapolu@intel.com \
    --cc=hyungwoo.yang@intel.com \
    --cc=jian.xu.zheng@intel.com \
    --cc=linux-media@vger.kernel.org \
    --cc=rajmohan.mani@intel.com \
    --cc=tfiga@chromium.org \
    --cc=tian.shu.qiu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.