From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: "Rapolu, Chiranjeevi" <chiranjeevi.rapolu@intel.com>
Cc: "linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
"tfiga@chromium.org" <tfiga@chromium.org>,
"Zheng, Jian Xu" <jian.xu.zheng@intel.com>,
"Qiu, Tian Shu" <tian.shu.qiu@intel.com>,
"Yeh, Andy" <andy.yeh@intel.com>,
"Mani, Rajmohan" <rajmohan.mani@intel.com>,
"Yang, Hyungwoo" <hyungwoo.yang@intel.com>
Subject: Re: [PATCH v1] media: ov13858: Avoid possible null first frame
Date: Tue, 30 Jan 2018 14:45:23 +0200 [thread overview]
Message-ID: <20180130124523.m5sikm3gvrktcnuh@kekkonen.localdomain> (raw)
In-Reply-To: <8408A4B5C50F354EA5F62D9FC805153D2C53637E@ORSMSX115.amr.corp.intel.com>
On Thu, Jan 25, 2018 at 05:36:44PM +0000, Rapolu, Chiranjeevi wrote:
> Hi Sakari,
>
> >I'll apply this now, however I see that most of the registers in the
> > four modes are the same. In the future it'd be good to separate the
> > parts that are common in all of them (to be written in sensor power-on)
> > to make this (slightly) more maintainable.
>
> Thanks for the review. Makes sense. Not sure how it impacts because the
> sequence of writes will be different, need thorough testing to confirm
> nothing is broken.
Yeah, that's a fair consideration. Most registers still have no side
effects apart of streaming control or such.
--
Sakari Ailus
sakari.ailus@linux.intel.com
prev parent reply other threads:[~2018-01-30 12:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-25 4:34 [PATCH v1] media: ov13858: Avoid possible null first frame Chiranjeevi Rapolu
2018-01-25 10:29 ` Sakari Ailus
2018-01-25 17:36 ` Rapolu, Chiranjeevi
2018-01-30 12:45 ` Sakari Ailus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180130124523.m5sikm3gvrktcnuh@kekkonen.localdomain \
--to=sakari.ailus@linux.intel.com \
--cc=andy.yeh@intel.com \
--cc=chiranjeevi.rapolu@intel.com \
--cc=hyungwoo.yang@intel.com \
--cc=jian.xu.zheng@intel.com \
--cc=linux-media@vger.kernel.org \
--cc=rajmohan.mani@intel.com \
--cc=tfiga@chromium.org \
--cc=tian.shu.qiu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.