* [PATCH] xen: fix xsm build
@ 2018-01-25 13:14 Wei Liu
2018-01-25 13:29 ` Andrew Cooper
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Wei Liu @ 2018-01-25 13:14 UTC (permalink / raw)
To: Xen-devel
Cc: Wei Liu, Ian Jackson, Jan Beulich, Daniel De Graaf, Roger Pau Monne
Commit e8d461497d9 renamed gcov_op to coverage_op but forgot to change
XSM handles.
Signed-off-by: Wei Liu <wei.liu2@citrix.com>
---
Cc: Jan Beulich <jbeulich@suse.com>
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: Wei Liu <wei.liu2@citrix.com>
Cc: Ian Jackson <ian.jackson@eu.citrix.com>
Cc: Roger Pau Monne <roger.pau@citrix.com>
Cc: Daniel De Graaf <dgdegra@tycho.nsa.gov>
---
tools/flask/policy/modules/dom0.te | 2 +-
xen/xsm/flask/hooks.c | 4 ++--
xen/xsm/flask/policy/access_vectors | 4 ++--
3 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/tools/flask/policy/modules/dom0.te b/tools/flask/policy/modules/dom0.te
index 07de3d5083..bf794d9bdd 100644
--- a/tools/flask/policy/modules/dom0.te
+++ b/tools/flask/policy/modules/dom0.te
@@ -16,7 +16,7 @@ allow dom0_t xen_t:xen {
allow dom0_t xen_t:xen2 {
resource_op psr_cmt_op psr_alloc pmu_ctrl get_symbol
get_cpu_levelling_caps get_cpu_featureset livepatch_op
- gcov_op set_parameter
+ coverage_op set_parameter
};
# Allow dom0 to use all XENVER_ subops that have checks.
diff --git a/xen/xsm/flask/hooks.c b/xen/xsm/flask/hooks.c
index 835b3d1a03..3533259f9f 100644
--- a/xen/xsm/flask/hooks.c
+++ b/xen/xsm/flask/hooks.c
@@ -825,9 +825,9 @@ static int flask_sysctl(int cmd)
case XEN_SYSCTL_livepatch_op:
return avc_current_has_perm(SECINITSID_XEN, SECCLASS_XEN2,
XEN2__LIVEPATCH_OP, NULL);
- case XEN_SYSCTL_gcov_op:
+ case XEN_SYSCTL_coverage_op:
return avc_current_has_perm(SECINITSID_XEN, SECCLASS_XEN2,
- XEN2__GCOV_OP, NULL);
+ XEN2__COVERAGE_OP, NULL);
case XEN_SYSCTL_set_parameter:
return avc_current_has_perm(SECINITSID_XEN, SECCLASS_XEN2,
XEN2__SET_PARAMETER, NULL);
diff --git a/xen/xsm/flask/policy/access_vectors b/xen/xsm/flask/policy/access_vectors
index 50dfc36c1c..e74d98d736 100644
--- a/xen/xsm/flask/policy/access_vectors
+++ b/xen/xsm/flask/policy/access_vectors
@@ -99,8 +99,8 @@ class xen2
get_cpu_featureset
# XEN_SYSCTL_livepatch_op
livepatch_op
-# XEN_SYSCTL_gcov_op
- gcov_op
+# XEN_SYSCTL_coverage_op
+ coverage_op
# XEN_SYSCTL_set_parameter
set_parameter
}
--
2.11.0
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] xen: fix xsm build
2018-01-25 13:14 [PATCH] xen: fix xsm build Wei Liu
@ 2018-01-25 13:29 ` Andrew Cooper
2018-01-25 13:50 ` Roger Pau Monné
2018-01-26 11:45 ` Wei Liu
2 siblings, 0 replies; 7+ messages in thread
From: Andrew Cooper @ 2018-01-25 13:29 UTC (permalink / raw)
To: Wei Liu, Xen-devel
Cc: Daniel De Graaf, Ian Jackson, Jan Beulich, Roger Pau Monne
On 25/01/18 13:14, Wei Liu wrote:
> Commit e8d461497d9 renamed gcov_op to coverage_op but forgot to change
> XSM handles.
>
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] xen: fix xsm build
2018-01-25 13:14 [PATCH] xen: fix xsm build Wei Liu
2018-01-25 13:29 ` Andrew Cooper
@ 2018-01-25 13:50 ` Roger Pau Monné
2018-01-25 15:10 ` Ian Jackson
2018-01-26 11:45 ` Wei Liu
2 siblings, 1 reply; 7+ messages in thread
From: Roger Pau Monné @ 2018-01-25 13:50 UTC (permalink / raw)
To: Wei Liu; +Cc: Xen-devel, Daniel De Graaf, Ian Jackson, Jan Beulich
On Thu, Jan 25, 2018 at 01:14:24PM +0000, Wei Liu wrote:
> Commit e8d461497d9 renamed gcov_op to coverage_op but forgot to change
> XSM handles.
>
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>
Thanks!
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] xen: fix xsm build
2018-01-25 13:50 ` Roger Pau Monné
@ 2018-01-25 15:10 ` Ian Jackson
0 siblings, 0 replies; 7+ messages in thread
From: Ian Jackson @ 2018-01-25 15:10 UTC (permalink / raw)
To: Roger Pau Monné; +Cc: Xen-devel, Daniel De Graaf, Wei Liu, Jan Beulich
Roger Pau Monné writes ("Re: [PATCH] xen: fix xsm build"):
> On Thu, Jan 25, 2018 at 01:14:24PM +0000, Wei Liu wrote:
> > Commit e8d461497d9 renamed gcov_op to coverage_op but forgot to change
> > XSM handles.
> >
> > Signed-off-by: Wei Liu <wei.liu2@citrix.com>
>
> Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>
Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
(in case you feel it's needed)
Thanks,
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] xen: fix xsm build
2018-01-25 13:14 [PATCH] xen: fix xsm build Wei Liu
2018-01-25 13:29 ` Andrew Cooper
2018-01-25 13:50 ` Roger Pau Monné
@ 2018-01-26 11:45 ` Wei Liu
2018-01-26 12:13 ` Jan Beulich
2 siblings, 1 reply; 7+ messages in thread
From: Wei Liu @ 2018-01-26 11:45 UTC (permalink / raw)
To: Xen-devel
Cc: Wei Liu, Ian Jackson, Jan Beulich, Daniel De Graaf, Roger Pau Monne
On Thu, Jan 25, 2018 at 01:14:24PM +0000, Wei Liu wrote:
> Commit e8d461497d9 renamed gcov_op to coverage_op but forgot to change
> XSM handles.
>
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
Osstest's ARM build is blocked by this now.
I will wait until 5pm UK time for Daniel to express his opinion.
Wei.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] xen: fix xsm build
2018-01-26 11:45 ` Wei Liu
@ 2018-01-26 12:13 ` Jan Beulich
2018-01-26 13:52 ` Ian Jackson
0 siblings, 1 reply; 7+ messages in thread
From: Jan Beulich @ 2018-01-26 12:13 UTC (permalink / raw)
To: Wei Liu; +Cc: Xen-devel, DanielDe Graaf, Ian Jackson, Roger Pau Monne
>>> On 26.01.18 at 12:45, <wei.liu2@citrix.com> wrote:
> On Thu, Jan 25, 2018 at 01:14:24PM +0000, Wei Liu wrote:
>> Commit e8d461497d9 renamed gcov_op to coverage_op but forgot to change
>> XSM handles.
>>
>> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
>
> Osstest's ARM build is blocked by this now.
>
> I will wait until 5pm UK time for Daniel to express his opinion.
I don't think such pure renaming warrants waiting, the more that
you've got 3 other acks already iirc.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] xen: fix xsm build
2018-01-26 12:13 ` Jan Beulich
@ 2018-01-26 13:52 ` Ian Jackson
0 siblings, 0 replies; 7+ messages in thread
From: Ian Jackson @ 2018-01-26 13:52 UTC (permalink / raw)
To: Jan Beulich; +Cc: Xen-devel, DanielDe Graaf, Wei Liu, Roger Pau Monne
Jan Beulich writes ("Re: [PATCH] xen: fix xsm build"):
> On 26.01.18 at 12:45, <wei.liu2@citrix.com> wrote:
> > I will wait until 5pm UK time for Daniel to express his opinion.
>
> I don't think such pure renaming warrants waiting, the more that
> you've got 3 other acks already iirc.
And I committed this this morning :-).
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2018-01-26 13:52 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-25 13:14 [PATCH] xen: fix xsm build Wei Liu
2018-01-25 13:29 ` Andrew Cooper
2018-01-25 13:50 ` Roger Pau Monné
2018-01-25 15:10 ` Ian Jackson
2018-01-26 11:45 ` Wei Liu
2018-01-26 12:13 ` Jan Beulich
2018-01-26 13:52 ` Ian Jackson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.