All of lore.kernel.org
 help / color / mirror / Atom feed
* [RFC PATCH net-next] sfc: efx_default_channel_want_txqs() can be static
  2018-01-26  1:03 [net-next:master 1913/1931] drivers/net/ethernet/sfc/efx.c:899:6: sparse: symbol 'efx_default_channel_want_txqs' was not declared. Should it be static? kbuild test robot
@ 2018-01-26  1:03 ` kbuild test robot
  2018-01-26 15:13   ` Edward Cree
  0 siblings, 1 reply; 6+ messages in thread
From: kbuild test robot @ 2018-01-26  1:03 UTC (permalink / raw)
  To: Edward Cree
  Cc: kbuild-all, netdev, Solarflare linux maintainers, Bert Kenward,
	linux-kernel


Fixes: 2935e3c38228 ("sfc: on 8000 series use TX queues for TX timestamps")
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
 efx.c |    2 +-
 ptp.c |    4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/net/ethernet/sfc/efx.c b/drivers/net/ethernet/sfc/efx.c
index 456866b0..16757cf 100644
--- a/drivers/net/ethernet/sfc/efx.c
+++ b/drivers/net/ethernet/sfc/efx.c
@@ -896,7 +896,7 @@ void efx_schedule_slow_fill(struct efx_rx_queue *rx_queue)
 	mod_timer(&rx_queue->slow_fill, jiffies + msecs_to_jiffies(100));
 }
 
-bool efx_default_channel_want_txqs(struct efx_channel *channel)
+static bool efx_default_channel_want_txqs(struct efx_channel *channel)
 {
 	return channel->channel - channel->efx->tx_channel_offset <
 		channel->efx->n_tx_channels;
diff --git a/drivers/net/ethernet/sfc/ptp.c b/drivers/net/ethernet/sfc/ptp.c
index 433d29d..3e2c5b1 100644
--- a/drivers/net/ethernet/sfc/ptp.c
+++ b/drivers/net/ethernet/sfc/ptp.c
@@ -366,7 +366,7 @@ bool efx_ptp_use_mac_tx_timestamps(struct efx_nic *efx)
 /* PTP 'extra' channel is still a traffic channel, but we only create TX queues
  * if PTP uses MAC TX timestamps, not if PTP uses the MC directly to transmit.
  */
-bool efx_ptp_want_txqs(struct efx_channel *channel)
+static bool efx_ptp_want_txqs(struct efx_channel *channel)
 {
 	return efx_ptp_use_mac_tx_timestamps(channel->efx);
 }
@@ -2146,7 +2146,7 @@ static int efx_phc_enable(struct ptp_clock_info *ptp,
 	return 0;
 }
 
-const struct efx_channel_type efx_ptp_channel_type = {
+static const struct efx_channel_type efx_ptp_channel_type = {
 	.handle_no_channel	= efx_ptp_handle_no_channel,
 	.pre_probe		= efx_ptp_probe_channel,
 	.post_remove		= efx_ptp_remove_channel,

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [net-next:master 1913/1931] drivers/net/ethernet/sfc/efx.c:899:6: sparse: symbol 'efx_default_channel_want_txqs' was not declared. Should it be static?
@ 2018-01-26  1:03 kbuild test robot
  2018-01-26  1:03 ` [RFC PATCH net-next] sfc: efx_default_channel_want_txqs() can be static kbuild test robot
  0 siblings, 1 reply; 6+ messages in thread
From: kbuild test robot @ 2018-01-26  1:03 UTC (permalink / raw)
  To: Edward Cree
  Cc: kbuild-all, netdev, Solarflare linux maintainers, Bert Kenward,
	linux-kernel

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master
head:   fdd6d771c7de9d351c6dbdbab5bdc83805c06955
commit: 2935e3c38228ad9bf073eeb0eedff5849eea63db [1913/1931] sfc: on 8000 series use TX queues for TX timestamps
reproduce:
        # apt-get install sparse
        git checkout 2935e3c38228ad9bf073eeb0eedff5849eea63db
        make ARCH=x86_64 allmodconfig
        make C=1 CF=-D__CHECK_ENDIAN__


sparse warnings: (new ones prefixed by >>)

>> drivers/net/ethernet/sfc/efx.c:899:6: sparse: symbol 'efx_default_channel_want_txqs' was not declared. Should it be
--
>> drivers/net/ethernet/sfc/ptp.c:347:6: sparse: symbol 'efx_ptp_want_txqs' was not declared. Should it be
>> drivers/net/ethernet/sfc/ptp.c:2023:31: sparse: symbol 'efx_ptp_channel_type' was not declared. Should it be

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [RFC PATCH net-next] sfc: efx_default_channel_want_txqs() can be static
  2018-01-26  1:03 ` [RFC PATCH net-next] sfc: efx_default_channel_want_txqs() can be static kbuild test robot
@ 2018-01-26 15:13   ` Edward Cree
  2018-01-26 16:13     ` David Miller
  0 siblings, 1 reply; 6+ messages in thread
From: Edward Cree @ 2018-01-26 15:13 UTC (permalink / raw)
  To: kbuild test robot, David Miller
  Cc: kbuild-all, netdev, Solarflare linux maintainers, Bert Kenward,
	linux-kernel

On 26/01/18 01:03, kbuild test robot wrote:
> Fixes: 2935e3c38228 ("sfc: on 8000 series use TX queues for TX timestamps")
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
Acked-by: Edward Cree <ecree@solarflare.com>

Dave, can you take this directly or do you need it reposted without RFC tags?  I'm not sure what the procedure is for robopatches.
> ---
>  efx.c |    2 +-
>  ptp.c |    4 ++--
>  2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/ethernet/sfc/efx.c b/drivers/net/ethernet/sfc/efx.c
> index 456866b0..16757cf 100644
> --- a/drivers/net/ethernet/sfc/efx.c
> +++ b/drivers/net/ethernet/sfc/efx.c
> @@ -896,7 +896,7 @@ void efx_schedule_slow_fill(struct efx_rx_queue *rx_queue)
>  	mod_timer(&rx_queue->slow_fill, jiffies + msecs_to_jiffies(100));
>  }
>  
> -bool efx_default_channel_want_txqs(struct efx_channel *channel)
> +static bool efx_default_channel_want_txqs(struct efx_channel *channel)
>  {
>  	return channel->channel - channel->efx->tx_channel_offset <
>  		channel->efx->n_tx_channels;
> diff --git a/drivers/net/ethernet/sfc/ptp.c b/drivers/net/ethernet/sfc/ptp.c
> index 433d29d..3e2c5b1 100644
> --- a/drivers/net/ethernet/sfc/ptp.c
> +++ b/drivers/net/ethernet/sfc/ptp.c
> @@ -366,7 +366,7 @@ bool efx_ptp_use_mac_tx_timestamps(struct efx_nic *efx)
>  /* PTP 'extra' channel is still a traffic channel, but we only create TX queues
>   * if PTP uses MAC TX timestamps, not if PTP uses the MC directly to transmit.
>   */
> -bool efx_ptp_want_txqs(struct efx_channel *channel)
> +static bool efx_ptp_want_txqs(struct efx_channel *channel)
>  {
>  	return efx_ptp_use_mac_tx_timestamps(channel->efx);
>  }
> @@ -2146,7 +2146,7 @@ static int efx_phc_enable(struct ptp_clock_info *ptp,
>  	return 0;
>  }
>  
> -const struct efx_channel_type efx_ptp_channel_type = {
> +static const struct efx_channel_type efx_ptp_channel_type = {
>  	.handle_no_channel	= efx_ptp_handle_no_channel,
>  	.pre_probe		= efx_ptp_probe_channel,
>  	.post_remove		= efx_ptp_remove_channel,

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [RFC PATCH net-next] sfc: efx_default_channel_want_txqs() can be static
  2018-01-26 15:13   ` Edward Cree
@ 2018-01-26 16:13     ` David Miller
  2018-01-26 17:00       ` [PATCH net-next] sfc: mark some unexported symbols as static Edward Cree
  0 siblings, 1 reply; 6+ messages in thread
From: David Miller @ 2018-01-26 16:13 UTC (permalink / raw)
  To: ecree
  Cc: fengguang.wu, kbuild-all, netdev, linux-net-drivers, bkenward,
	linux-kernel

From: Edward Cree <ecree@solarflare.com>
Date: Fri, 26 Jan 2018 15:13:05 +0000

> On 26/01/18 01:03, kbuild test robot wrote:
>> Fixes: 2935e3c38228 ("sfc: on 8000 series use TX queues for TX timestamps")
>> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> Acked-by: Edward Cree <ecree@solarflare.com>
> 
> Dave, can you take this directly or do you need it reposted without RFC tags?  I'm not sure what the procedure is for robopatches.

No I cannot.

Don't you even notice that the subject line and commit message are
totally inaccurate?

They say that one function is being marked static.

But the patch actually marks two different functions static, as well
as a structure which is also completely not mentioned in the commit
message nor subject line.

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [PATCH net-next] sfc: mark some unexported symbols as static
  2018-01-26 16:13     ` David Miller
@ 2018-01-26 17:00       ` Edward Cree
  2018-01-29  2:59         ` David Miller
  0 siblings, 1 reply; 6+ messages in thread
From: Edward Cree @ 2018-01-26 17:00 UTC (permalink / raw)
  To: davem
  Cc: linux-net-drivers, netdev, kbuild test robot, kbuild-all,
	Bert Kenward, linux-kernel

From: kbuild test robot <fengguang.wu@intel.com>

efx_default_channel_want_txqs() is only used in efx.c, while
 efx_ptp_want_txqs() and efx_ptp_channel_type (a struct) are only used
 in ptp.c.  In all cases these symbols should be static.

Fixes: 2935e3c38228 ("sfc: on 8000 series use TX queues for TX timestamps")
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
[ecree@solarflare.com: rewrote commit message]
Signed-off-by: Edward Cree <ecree@solarflare.com>
---
 drivers/net/ethernet/sfc/efx.c | 2 +-
 drivers/net/ethernet/sfc/ptp.c | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/net/ethernet/sfc/efx.c b/drivers/net/ethernet/sfc/efx.c
index 456866b05641..16757cfc5b29 100644
--- a/drivers/net/ethernet/sfc/efx.c
+++ b/drivers/net/ethernet/sfc/efx.c
@@ -896,7 +896,7 @@ void efx_schedule_slow_fill(struct efx_rx_queue *rx_queue)
 	mod_timer(&rx_queue->slow_fill, jiffies + msecs_to_jiffies(100));
 }
 
-bool efx_default_channel_want_txqs(struct efx_channel *channel)
+static bool efx_default_channel_want_txqs(struct efx_channel *channel)
 {
 	return channel->channel - channel->efx->tx_channel_offset <
 		channel->efx->n_tx_channels;
diff --git a/drivers/net/ethernet/sfc/ptp.c b/drivers/net/ethernet/sfc/ptp.c
index 433d29d6bc95..3e2c5b11b5ef 100644
--- a/drivers/net/ethernet/sfc/ptp.c
+++ b/drivers/net/ethernet/sfc/ptp.c
@@ -366,7 +366,7 @@ bool efx_ptp_use_mac_tx_timestamps(struct efx_nic *efx)
 /* PTP 'extra' channel is still a traffic channel, but we only create TX queues
  * if PTP uses MAC TX timestamps, not if PTP uses the MC directly to transmit.
  */
-bool efx_ptp_want_txqs(struct efx_channel *channel)
+static bool efx_ptp_want_txqs(struct efx_channel *channel)
 {
 	return efx_ptp_use_mac_tx_timestamps(channel->efx);
 }
@@ -2146,7 +2146,7 @@ static int efx_phc_enable(struct ptp_clock_info *ptp,
 	return 0;
 }
 
-const struct efx_channel_type efx_ptp_channel_type = {
+static const struct efx_channel_type efx_ptp_channel_type = {
 	.handle_no_channel	= efx_ptp_handle_no_channel,
 	.pre_probe		= efx_ptp_probe_channel,
 	.post_remove		= efx_ptp_remove_channel,

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH net-next] sfc: mark some unexported symbols as static
  2018-01-26 17:00       ` [PATCH net-next] sfc: mark some unexported symbols as static Edward Cree
@ 2018-01-29  2:59         ` David Miller
  0 siblings, 0 replies; 6+ messages in thread
From: David Miller @ 2018-01-29  2:59 UTC (permalink / raw)
  To: ecree
  Cc: linux-net-drivers, netdev, fengguang.wu, kbuild-all, bkenward,
	linux-kernel

From: Edward Cree <ecree@solarflare.com>
Date: Fri, 26 Jan 2018 17:00:39 +0000

> From: kbuild test robot <fengguang.wu@intel.com>
> 
> efx_default_channel_want_txqs() is only used in efx.c, while
>  efx_ptp_want_txqs() and efx_ptp_channel_type (a struct) are only used
>  in ptp.c.  In all cases these symbols should be static.
> 
> Fixes: 2935e3c38228 ("sfc: on 8000 series use TX queues for TX timestamps")
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> [ecree@solarflare.com: rewrote commit message]
> Signed-off-by: Edward Cree <ecree@solarflare.com>

Applied, thanks Edward.

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-01-29  2:59 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-26  1:03 [net-next:master 1913/1931] drivers/net/ethernet/sfc/efx.c:899:6: sparse: symbol 'efx_default_channel_want_txqs' was not declared. Should it be static? kbuild test robot
2018-01-26  1:03 ` [RFC PATCH net-next] sfc: efx_default_channel_want_txqs() can be static kbuild test robot
2018-01-26 15:13   ` Edward Cree
2018-01-26 16:13     ` David Miller
2018-01-26 17:00       ` [PATCH net-next] sfc: mark some unexported symbols as static Edward Cree
2018-01-29  2:59         ` David Miller

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.