* [Buildroot] [PATCH 1/1] package: Add thunderbolt-tools package
@ 2018-01-25 13:09 Andrei Emeltchenko
2018-01-25 14:19 ` Yegor Yefremov
` (2 more replies)
0 siblings, 3 replies; 9+ messages in thread
From: Andrei Emeltchenko @ 2018-01-25 13:09 UTC (permalink / raw)
To: buildroot
From: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
Add package thunderbolt-tools to handle Thunderbolt devices.
Signed-off-by: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
---
package/Config.in | 1 +
package/thunderbolt-tools/Config.in | 11 +++++++++++
package/thunderbolt-tools/thunderbolt-tools.mk | 14 ++++++++++++++
3 files changed, 26 insertions(+)
create mode 100644 package/thunderbolt-tools/Config.in
create mode 100644 package/thunderbolt-tools/thunderbolt-tools.mk
diff --git a/package/Config.in b/package/Config.in
index 00451f526d..d638ac3a72 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -505,6 +505,7 @@ endmenu
source "package/sunxi-mali/Config.in"
source "package/sysstat/Config.in"
source "package/targetcli-fb/Config.in"
+ source "package/thunderbolt-tools/Config.in"
source "package/ti-gfx/Config.in"
source "package/ti-sgx-demos/Config.in"
source "package/ti-sgx-km/Config.in"
diff --git a/package/thunderbolt-tools/Config.in b/package/thunderbolt-tools/Config.in
new file mode 100644
index 0000000000..1057300772
--- /dev/null
+++ b/package/thunderbolt-tools/Config.in
@@ -0,0 +1,11 @@
+config BR2_PACKAGE_THUNDERBOLT_TOOLS
+ bool "thunderbolt-tools"
+# select BR2_TOOLCHAIN_BUILDROOT_CXX
+ select BR2_PACKAGE_BOOST
+ select BR2_PACKAGE_BOOST_FILESYSTEM
+ depends on BR2_PACKAGE_HAS_UDEV
+ help
+ Thunderbolt tools for Linux
+
+comment "thunderbolt-tools package needs udev provided by systemd of eudev, C++"
+ depends on BR2_PACKAGE_HAS_UDEV
diff --git a/package/thunderbolt-tools/thunderbolt-tools.mk b/package/thunderbolt-tools/thunderbolt-tools.mk
new file mode 100644
index 0000000000..5fd469c4ef
--- /dev/null
+++ b/package/thunderbolt-tools/thunderbolt-tools.mk
@@ -0,0 +1,14 @@
+################################################################################
+#
+# thunderbolt-tools
+#
+################################################################################
+
+THUNDERBOLT_TOOLS_VERSION = master
+THUNDERBOLT_TOOLS_SITE = https://github.com/01org/thunderbolt-software-user-space.git
+#THUNDERBOLT_TOOLS_SITE = $(call github,01org,thunderbolt-software-user-space,$(THUNDERBOLT_TOOLS_VERSION))
+THUNDERBOLT_TOOLS_SITE_METHOD = git
+
+THUNDERBOLT_TOOLS_DEPENDENCIES = host-pkgconf boost eudev
+
+$(eval $(cmake-package))
--
2.14.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH 1/1] package: Add thunderbolt-tools package
2018-01-25 13:09 [Buildroot] [PATCH 1/1] package: Add thunderbolt-tools package Andrei Emeltchenko
@ 2018-01-25 14:19 ` Yegor Yefremov
2018-01-25 16:38 ` Andrei Emeltchenko
2018-01-26 14:20 ` [Buildroot] [PATCH 1/1] thunderbolt-tools: new package Andrei Emeltchenko
2018-01-26 15:30 ` [Buildroot] [PATCHv3 " Andrei Emeltchenko
2 siblings, 1 reply; 9+ messages in thread
From: Yegor Yefremov @ 2018-01-25 14:19 UTC (permalink / raw)
To: buildroot
Hi Andrei,
thank you for your contribution. Some change requests below.
On Thu, Jan 25, 2018 at 2:09 PM, Andrei Emeltchenko
<Andrei.Emeltchenko.news@gmail.com> wrote:
> From: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
>
> Add package thunderbolt-tools to handle Thunderbolt devices.
>
> Signed-off-by: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
> ---
> package/Config.in | 1 +
> package/thunderbolt-tools/Config.in | 11 +++++++++++
> package/thunderbolt-tools/thunderbolt-tools.mk | 14 ++++++++++++++
> 3 files changed, 26 insertions(+)
> create mode 100644 package/thunderbolt-tools/Config.in
> create mode 100644 package/thunderbolt-tools/thunderbolt-tools.mk
Please add yourself to the DEVELOPERS file.
package/thunderbolt-tools/thunderbolt-tools.hash is missing.
> diff --git a/package/Config.in b/package/Config.in
> index 00451f526d..d638ac3a72 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -505,6 +505,7 @@ endmenu
> source "package/sunxi-mali/Config.in"
> source "package/sysstat/Config.in"
> source "package/targetcli-fb/Config.in"
> + source "package/thunderbolt-tools/Config.in"
> source "package/ti-gfx/Config.in"
> source "package/ti-sgx-demos/Config.in"
> source "package/ti-sgx-km/Config.in"
> diff --git a/package/thunderbolt-tools/Config.in b/package/thunderbolt-tools/Config.in
> new file mode 100644
> index 0000000000..1057300772
> --- /dev/null
> +++ b/package/thunderbolt-tools/Config.in
> @@ -0,0 +1,11 @@
> +config BR2_PACKAGE_THUNDERBOLT_TOOLS
> + bool "thunderbolt-tools"
> +# select BR2_TOOLCHAIN_BUILDROOT_CXX
you mean "depends on BR2_INSTALL_LIBSTDCPP"
> + select BR2_PACKAGE_BOOST
> + select BR2_PACKAGE_BOOST_FILESYSTEM
> + depends on BR2_PACKAGE_HAS_UDEV
> + help
> + Thunderbolt tools for Linux
Project URL is missing
> +
> +comment "thunderbolt-tools package needs udev provided by systemd of eudev, C++"
> + depends on BR2_PACKAGE_HAS_UDEV
> diff --git a/package/thunderbolt-tools/thunderbolt-tools.mk b/package/thunderbolt-tools/thunderbolt-tools.mk
> new file mode 100644
> index 0000000000..5fd469c4ef
> --- /dev/null
> +++ b/package/thunderbolt-tools/thunderbolt-tools.mk
> @@ -0,0 +1,14 @@
> +################################################################################
> +#
> +# thunderbolt-tools
> +#
> +################################################################################
> +
> +THUNDERBOLT_TOOLS_VERSION = master
use a special commit ID here
> +THUNDERBOLT_TOOLS_SITE = https://github.com/01org/thunderbolt-software-user-space.git
> +#THUNDERBOLT_TOOLS_SITE = $(call github,01org,thunderbolt-software-user-space,$(THUNDERBOLT_TOOLS_VERSION))
use githun helper
> +THUNDERBOLT_TOOLS_SITE_METHOD = git
if you are using github helper or git URL you don't need to specify
the site method
> +
> +THUNDERBOLT_TOOLS_DEPENDENCIES = host-pkgconf boost eudev
Add licence info, i.e.
https://github.com/intel/thunderbolt-software-user-space/blob/master/COPYING
and SPDX type of the licence. See the manual.
> +$(eval $(cmake-package))
> --
> 2.14.1
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH 1/1] package: Add thunderbolt-tools package
2018-01-25 14:19 ` Yegor Yefremov
@ 2018-01-25 16:38 ` Andrei Emeltchenko
2018-01-25 18:31 ` Yegor Yefremov
0 siblings, 1 reply; 9+ messages in thread
From: Andrei Emeltchenko @ 2018-01-25 16:38 UTC (permalink / raw)
To: buildroot
Hi Yegor,
Thanks for review,
On Thu, Jan 25, 2018 at 03:19:39PM +0100, Yegor Yefremov wrote:
> > +
> > +THUNDERBOLT_TOOLS_DEPENDENCIES = host-pkgconf boost eudev
>
> Add licence info, i.e.
> https://github.com/intel/thunderbolt-software-user-space/blob/master/COPYING
> and SPDX type of the licence. See the manual.
It is "BSD-style" ;).
If I cannot get SPDX type, can I copy license file to
package directory and specify it like:
THUNDERBOLT_TOOLS_LICENSE_FILES = COPYING
Best regards
Andrei Emeltchenko
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH 1/1] package: Add thunderbolt-tools package
2018-01-25 16:38 ` Andrei Emeltchenko
@ 2018-01-25 18:31 ` Yegor Yefremov
0 siblings, 0 replies; 9+ messages in thread
From: Yegor Yefremov @ 2018-01-25 18:31 UTC (permalink / raw)
To: buildroot
On Thu, Jan 25, 2018 at 5:38 PM, Andrei Emeltchenko
<andrei.emeltchenko.news@gmail.com> wrote:
> Hi Yegor,
>
> Thanks for review,
>
> On Thu, Jan 25, 2018 at 03:19:39PM +0100, Yegor Yefremov wrote:
>> > +
>> > +THUNDERBOLT_TOOLS_DEPENDENCIES = host-pkgconf boost eudev
>>
>> Add licence info, i.e.
>> https://github.com/intel/thunderbolt-software-user-space/blob/master/COPYING
>> and SPDX type of the licence. See the manual.
>
> It is "BSD-style" ;).
>
> If I cannot get SPDX type, can I copy license file to
> package directory and specify it like:
>
> THUNDERBOLT_TOOLS_LICENSE_FILES = COPYING
Looks like BSD-3-Clause [1]
By the way the patch title should be:
thunderbolt-tools: new package
[1] https://spdx.org/licenses/BSD-3-Clause.html
Yegor
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH 1/1] thunderbolt-tools: new package
2018-01-25 13:09 [Buildroot] [PATCH 1/1] package: Add thunderbolt-tools package Andrei Emeltchenko
2018-01-25 14:19 ` Yegor Yefremov
@ 2018-01-26 14:20 ` Andrei Emeltchenko
2018-01-26 14:36 ` Yegor Yefremov
2018-01-26 15:30 ` [Buildroot] [PATCHv3 " Andrei Emeltchenko
2 siblings, 1 reply; 9+ messages in thread
From: Andrei Emeltchenko @ 2018-01-26 14:20 UTC (permalink / raw)
To: buildroot
From: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
Add package thunderbolt-tools to handle Thunderbolt devices.
Signed-off-by: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
---
DEVELOPERS | 3 +++
package/Config.in | 1 +
package/thunderbolt-tools/Config.in | 13 +++++++++++++
package/thunderbolt-tools/thunderbolt-tools.hash | 2 ++
package/thunderbolt-tools/thunderbolt-tools.mk | 15 +++++++++++++++
5 files changed, 34 insertions(+)
create mode 100644 package/thunderbolt-tools/Config.in
create mode 100644 package/thunderbolt-tools/thunderbolt-tools.hash
create mode 100644 package/thunderbolt-tools/thunderbolt-tools.mk
diff --git a/DEVELOPERS b/DEVELOPERS
index 73c0231bc0..822961a467 100644
--- a/DEVELOPERS
+++ b/DEVELOPERS
@@ -1949,3 +1949,6 @@ F: package/qjson/
F: package/quazip/
F: package/shapelib/
F: package/tinc/
+
+N: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
+F: package/thunderbolt-tools/
diff --git a/package/Config.in b/package/Config.in
index 00451f526d..d638ac3a72 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -505,6 +505,7 @@ endmenu
source "package/sunxi-mali/Config.in"
source "package/sysstat/Config.in"
source "package/targetcli-fb/Config.in"
+ source "package/thunderbolt-tools/Config.in"
source "package/ti-gfx/Config.in"
source "package/ti-sgx-demos/Config.in"
source "package/ti-sgx-km/Config.in"
diff --git a/package/thunderbolt-tools/Config.in b/package/thunderbolt-tools/Config.in
new file mode 100644
index 0000000000..0187ee4569
--- /dev/null
+++ b/package/thunderbolt-tools/Config.in
@@ -0,0 +1,13 @@
+config BR2_PACKAGE_THUNDERBOLT_TOOLS
+ bool "thunderbolt-tools"
+ select BR2_PACKAGE_BOOST
+ select BR2_PACKAGE_BOOST_FILESYSTEM
+ depends on BR2_PACKAGE_HAS_UDEV
+ depends on BR2_INSTALL_LIBSTDCPP
+ help
+ Thunderbolt user space tools
+
+ https://github.com/intel/thunderbolt-software-user-space
+
+comment "thunderbolt-tools package needs udev provided by systemd of eudev, C++"
+ depends on BR2_PACKAGE_HAS_UDEV
diff --git a/package/thunderbolt-tools/thunderbolt-tools.hash b/package/thunderbolt-tools/thunderbolt-tools.hash
new file mode 100644
index 0000000000..b1cfded05a
--- /dev/null
+++ b/package/thunderbolt-tools/thunderbolt-tools.hash
@@ -0,0 +1,2 @@
+# locally computed
+sha256 705f56b095a9764ca933f43ecf7629812976cb20600545ac9838730bd0ae6e2c thunderbolt-tools-8c82b2f84dfede86683873bc47a0b95714129a66.tar.gz
diff --git a/package/thunderbolt-tools/thunderbolt-tools.mk b/package/thunderbolt-tools/thunderbolt-tools.mk
new file mode 100644
index 0000000000..6bf7b7a9c7
--- /dev/null
+++ b/package/thunderbolt-tools/thunderbolt-tools.mk
@@ -0,0 +1,15 @@
+################################################################################
+#
+# thunderbolt-tools
+#
+################################################################################
+
+THUNDERBOLT_TOOLS_VERSION = 8c82b2f84dfede86683873bc47a0b95714129a66
+THUNDERBOLT_TOOLS_SITE = https://github.com/01org/thunderbolt-software-user-space.git
+THUNDERBOLT_TOOLS_SITE = $(call github,intel,thunderbolt-software-user-space,$(THUNDERBOLT_TOOLS_VERSION))
+THUNDERBOLT_TOOLS_LICENSE = BSD-3-Clause
+THUNDERBOLT_TOOLS_LICENSE_FILES = COPYING
+
+THUNDERBOLT_TOOLS_DEPENDENCIES = host-pkgconf boost eudev
+
+$(eval $(cmake-package))
--
2.14.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH 1/1] thunderbolt-tools: new package
2018-01-26 14:20 ` [Buildroot] [PATCH 1/1] thunderbolt-tools: new package Andrei Emeltchenko
@ 2018-01-26 14:36 ` Yegor Yefremov
2018-01-26 14:38 ` Yegor Yefremov
0 siblings, 1 reply; 9+ messages in thread
From: Yegor Yefremov @ 2018-01-26 14:36 UTC (permalink / raw)
To: buildroot
On Fri, Jan 26, 2018 at 3:20 PM, Andrei Emeltchenko
<Andrei.Emeltchenko.news@gmail.com> wrote:
> From: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
>
> Add package thunderbolt-tools to handle Thunderbolt devices.
>
> Signed-off-by: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
> ---
> DEVELOPERS | 3 +++
> package/Config.in | 1 +
> package/thunderbolt-tools/Config.in | 13 +++++++++++++
> package/thunderbolt-tools/thunderbolt-tools.hash | 2 ++
> package/thunderbolt-tools/thunderbolt-tools.mk | 15 +++++++++++++++
> 5 files changed, 34 insertions(+)
> create mode 100644 package/thunderbolt-tools/Config.in
> create mode 100644 package/thunderbolt-tools/thunderbolt-tools.hash
> create mode 100644 package/thunderbolt-tools/thunderbolt-tools.mk
>
> diff --git a/DEVELOPERS b/DEVELOPERS
> index 73c0231bc0..822961a467 100644
> --- a/DEVELOPERS
> +++ b/DEVELOPERS
> @@ -1949,3 +1949,6 @@ F: package/qjson/
> F: package/quazip/
> F: package/shapelib/
> F: package/tinc/
> +
> +N: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
> +F: package/thunderbolt-tools/
> diff --git a/package/Config.in b/package/Config.in
> index 00451f526d..d638ac3a72 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -505,6 +505,7 @@ endmenu
> source "package/sunxi-mali/Config.in"
> source "package/sysstat/Config.in"
> source "package/targetcli-fb/Config.in"
> + source "package/thunderbolt-tools/Config.in"
> source "package/ti-gfx/Config.in"
> source "package/ti-sgx-demos/Config.in"
> source "package/ti-sgx-km/Config.in"
> diff --git a/package/thunderbolt-tools/Config.in b/package/thunderbolt-tools/Config.in
> new file mode 100644
> index 0000000000..0187ee4569
> --- /dev/null
> +++ b/package/thunderbolt-tools/Config.in
> @@ -0,0 +1,13 @@
> +config BR2_PACKAGE_THUNDERBOLT_TOOLS
> + bool "thunderbolt-tools"
> + select BR2_PACKAGE_BOOST
> + select BR2_PACKAGE_BOOST_FILESYSTEM
> + depends on BR2_PACKAGE_HAS_UDEV
> + depends on BR2_INSTALL_LIBSTDCPP
> + help
> + Thunderbolt user space tools
> +
> + https://github.com/intel/thunderbolt-software-user-space
> +
> +comment "thunderbolt-tools package needs udev provided by systemd of eudev, C++"
s/of/or
> + depends on BR2_PACKAGE_HAS_UDEV
depends on !BR2_INSTALL_LIBSTDCPP || !BR2_PACKAGE_HAS_UDEV
> diff --git a/package/thunderbolt-tools/thunderbolt-tools.hash b/package/thunderbolt-tools/thunderbolt-tools.hash
> new file mode 100644
> index 0000000000..b1cfded05a
> --- /dev/null
> +++ b/package/thunderbolt-tools/thunderbolt-tools.hash
> @@ -0,0 +1,2 @@
> +# locally computed
> +sha256 705f56b095a9764ca933f43ecf7629812976cb20600545ac9838730bd0ae6e2c thunderbolt-tools-8c82b2f84dfede86683873bc47a0b95714129a66.tar.gz
> diff --git a/package/thunderbolt-tools/thunderbolt-tools.mk b/package/thunderbolt-tools/thunderbolt-tools.mk
> new file mode 100644
> index 0000000000..6bf7b7a9c7
> --- /dev/null
> +++ b/package/thunderbolt-tools/thunderbolt-tools.mk
> @@ -0,0 +1,15 @@
> +################################################################################
> +#
> +# thunderbolt-tools
> +#
> +################################################################################
> +
> +THUNDERBOLT_TOOLS_VERSION = 8c82b2f84dfede86683873bc47a0b95714129a66
> +THUNDERBOLT_TOOLS_SITE = https://github.com/01org/thunderbolt-software-user-space.git
remove this line
with this changed applied you can add my
Reviewed-by: Yegor Yefremov <yegorslists@googlemail.com>
Yegor
> +THUNDERBOLT_TOOLS_SITE = $(call github,intel,thunderbolt-software-user-space,$(THUNDERBOLT_TOOLS_VERSION))
> +THUNDERBOLT_TOOLS_LICENSE = BSD-3-Clause
> +THUNDERBOLT_TOOLS_LICENSE_FILES = COPYING
> +
> +THUNDERBOLT_TOOLS_DEPENDENCIES = host-pkgconf boost eudev
> +
> +$(eval $(cmake-package))
> --
> 2.14.1
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH 1/1] thunderbolt-tools: new package
2018-01-26 14:36 ` Yegor Yefremov
@ 2018-01-26 14:38 ` Yegor Yefremov
0 siblings, 0 replies; 9+ messages in thread
From: Yegor Yefremov @ 2018-01-26 14:38 UTC (permalink / raw)
To: buildroot
On Fri, Jan 26, 2018 at 3:36 PM, Yegor Yefremov
<yegorslists@googlemail.com> wrote:
> On Fri, Jan 26, 2018 at 3:20 PM, Andrei Emeltchenko
> <Andrei.Emeltchenko.news@gmail.com> wrote:
>> From: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
>>
>> Add package thunderbolt-tools to handle Thunderbolt devices.
>>
>> Signed-off-by: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
>> ---
>> DEVELOPERS | 3 +++
>> package/Config.in | 1 +
>> package/thunderbolt-tools/Config.in | 13 +++++++++++++
>> package/thunderbolt-tools/thunderbolt-tools.hash | 2 ++
>> package/thunderbolt-tools/thunderbolt-tools.mk | 15 +++++++++++++++
>> 5 files changed, 34 insertions(+)
>> create mode 100644 package/thunderbolt-tools/Config.in
>> create mode 100644 package/thunderbolt-tools/thunderbolt-tools.hash
>> create mode 100644 package/thunderbolt-tools/thunderbolt-tools.mk
>>
>> diff --git a/DEVELOPERS b/DEVELOPERS
>> index 73c0231bc0..822961a467 100644
>> --- a/DEVELOPERS
>> +++ b/DEVELOPERS
>> @@ -1949,3 +1949,6 @@ F: package/qjson/
>> F: package/quazip/
>> F: package/shapelib/
>> F: package/tinc/
>> +
>> +N: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
>> +F: package/thunderbolt-tools/
>> diff --git a/package/Config.in b/package/Config.in
>> index 00451f526d..d638ac3a72 100644
>> --- a/package/Config.in
>> +++ b/package/Config.in
>> @@ -505,6 +505,7 @@ endmenu
>> source "package/sunxi-mali/Config.in"
>> source "package/sysstat/Config.in"
>> source "package/targetcli-fb/Config.in"
>> + source "package/thunderbolt-tools/Config.in"
>> source "package/ti-gfx/Config.in"
>> source "package/ti-sgx-demos/Config.in"
>> source "package/ti-sgx-km/Config.in"
>> diff --git a/package/thunderbolt-tools/Config.in b/package/thunderbolt-tools/Config.in
>> new file mode 100644
>> index 0000000000..0187ee4569
>> --- /dev/null
>> +++ b/package/thunderbolt-tools/Config.in
>> @@ -0,0 +1,13 @@
>> +config BR2_PACKAGE_THUNDERBOLT_TOOLS
>> + bool "thunderbolt-tools"
>> + select BR2_PACKAGE_BOOST
>> + select BR2_PACKAGE_BOOST_FILESYSTEM
>> + depends on BR2_PACKAGE_HAS_UDEV
>> + depends on BR2_INSTALL_LIBSTDCPP
>> + help
>> + Thunderbolt user space tools
>> +
>> + https://github.com/intel/thunderbolt-software-user-space
>> +
>> +comment "thunderbolt-tools package needs udev provided by systemd of eudev, C++"
>
> s/of/or
>
>> + depends on BR2_PACKAGE_HAS_UDEV
>
> depends on !BR2_INSTALL_LIBSTDCPP || !BR2_PACKAGE_HAS_UDEV
>
>> diff --git a/package/thunderbolt-tools/thunderbolt-tools.hash b/package/thunderbolt-tools/thunderbolt-tools.hash
>> new file mode 100644
>> index 0000000000..b1cfded05a
>> --- /dev/null
>> +++ b/package/thunderbolt-tools/thunderbolt-tools.hash
>> @@ -0,0 +1,2 @@
>> +# locally computed
>> +sha256 705f56b095a9764ca933f43ecf7629812976cb20600545ac9838730bd0ae6e2c thunderbolt-tools-8c82b2f84dfede86683873bc47a0b95714129a66.tar.gz
please add sha256 checksum for COPYING
>> diff --git a/package/thunderbolt-tools/thunderbolt-tools.mk b/package/thunderbolt-tools/thunderbolt-tools.mk
>> new file mode 100644
>> index 0000000000..6bf7b7a9c7
>> --- /dev/null
>> +++ b/package/thunderbolt-tools/thunderbolt-tools.mk
>> @@ -0,0 +1,15 @@
>> +################################################################################
>> +#
>> +# thunderbolt-tools
>> +#
>> +################################################################################
>> +
>> +THUNDERBOLT_TOOLS_VERSION = 8c82b2f84dfede86683873bc47a0b95714129a66
>> +THUNDERBOLT_TOOLS_SITE = https://github.com/01org/thunderbolt-software-user-space.git
>
> remove this line
>
> with this changed applied you can add my
>
> Reviewed-by: Yegor Yefremov <yegorslists@googlemail.com>
>
> Yegor
>
>> +THUNDERBOLT_TOOLS_SITE = $(call github,intel,thunderbolt-software-user-space,$(THUNDERBOLT_TOOLS_VERSION))
>> +THUNDERBOLT_TOOLS_LICENSE = BSD-3-Clause
>> +THUNDERBOLT_TOOLS_LICENSE_FILES = COPYING
>> +
>> +THUNDERBOLT_TOOLS_DEPENDENCIES = host-pkgconf boost eudev
>> +
>> +$(eval $(cmake-package))
>> --
>> 2.14.1
>>
>> _______________________________________________
>> buildroot mailing list
>> buildroot at busybox.net
>> http://lists.busybox.net/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] [PATCHv3 1/1] thunderbolt-tools: new package
2018-01-25 13:09 [Buildroot] [PATCH 1/1] package: Add thunderbolt-tools package Andrei Emeltchenko
2018-01-25 14:19 ` Yegor Yefremov
2018-01-26 14:20 ` [Buildroot] [PATCH 1/1] thunderbolt-tools: new package Andrei Emeltchenko
@ 2018-01-26 15:30 ` Andrei Emeltchenko
2018-01-27 11:55 ` Peter Korsgaard
2 siblings, 1 reply; 9+ messages in thread
From: Andrei Emeltchenko @ 2018-01-26 15:30 UTC (permalink / raw)
To: buildroot
From: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
Add package thunderbolt-tools to handle Thunderbolt devices.
Signed-off-by: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
Reviewed-by: Yegor Yefremov <yegorslists@googlemail.com>
---
DEVELOPERS | 3 +++
package/Config.in | 1 +
package/thunderbolt-tools/Config.in | 13 +++++++++++++
package/thunderbolt-tools/thunderbolt-tools.hash | 3 +++
package/thunderbolt-tools/thunderbolt-tools.mk | 14 ++++++++++++++
5 files changed, 34 insertions(+)
create mode 100644 package/thunderbolt-tools/Config.in
create mode 100644 package/thunderbolt-tools/thunderbolt-tools.hash
create mode 100644 package/thunderbolt-tools/thunderbolt-tools.mk
diff --git a/DEVELOPERS b/DEVELOPERS
index 73c0231bc0..822961a467 100644
--- a/DEVELOPERS
+++ b/DEVELOPERS
@@ -1949,3 +1949,6 @@ F: package/qjson/
F: package/quazip/
F: package/shapelib/
F: package/tinc/
+
+N: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
+F: package/thunderbolt-tools/
diff --git a/package/Config.in b/package/Config.in
index 00451f526d..d638ac3a72 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -505,6 +505,7 @@ endmenu
source "package/sunxi-mali/Config.in"
source "package/sysstat/Config.in"
source "package/targetcli-fb/Config.in"
+ source "package/thunderbolt-tools/Config.in"
source "package/ti-gfx/Config.in"
source "package/ti-sgx-demos/Config.in"
source "package/ti-sgx-km/Config.in"
diff --git a/package/thunderbolt-tools/Config.in b/package/thunderbolt-tools/Config.in
new file mode 100644
index 0000000000..be80c81dc0
--- /dev/null
+++ b/package/thunderbolt-tools/Config.in
@@ -0,0 +1,13 @@
+config BR2_PACKAGE_THUNDERBOLT_TOOLS
+ bool "thunderbolt-tools"
+ select BR2_PACKAGE_BOOST
+ select BR2_PACKAGE_BOOST_FILESYSTEM
+ depends on BR2_PACKAGE_HAS_UDEV
+ depends on BR2_INSTALL_LIBSTDCPP
+ help
+ Thunderbolt user space tools
+
+ https://github.com/intel/thunderbolt-software-user-space
+
+comment "thunderbolt-tools package needs udev provided by systemd or eudev, C++"
+ depends on !BR2_INSTALL_LIBSTDCPP || !BR2_PACKAGE_HAS_UDEV
diff --git a/package/thunderbolt-tools/thunderbolt-tools.hash b/package/thunderbolt-tools/thunderbolt-tools.hash
new file mode 100644
index 0000000000..b73e1a6317
--- /dev/null
+++ b/package/thunderbolt-tools/thunderbolt-tools.hash
@@ -0,0 +1,3 @@
+# locally computed
+sha256 705f56b095a9764ca933f43ecf7629812976cb20600545ac9838730bd0ae6e2c thunderbolt-tools-8c82b2f84dfede86683873bc47a0b95714129a66.tar.gz
+sha256 4050c82f8e2fcfc6c24515e25fbc5e48537413ad59d056b4c1a4b183e2ea88a1 COPYING
diff --git a/package/thunderbolt-tools/thunderbolt-tools.mk b/package/thunderbolt-tools/thunderbolt-tools.mk
new file mode 100644
index 0000000000..4c7b48d178
--- /dev/null
+++ b/package/thunderbolt-tools/thunderbolt-tools.mk
@@ -0,0 +1,14 @@
+################################################################################
+#
+# thunderbolt-tools
+#
+################################################################################
+
+THUNDERBOLT_TOOLS_VERSION = 8c82b2f84dfede86683873bc47a0b95714129a66
+THUNDERBOLT_TOOLS_SITE = $(call github,intel,thunderbolt-software-user-space,$(THUNDERBOLT_TOOLS_VERSION))
+THUNDERBOLT_TOOLS_LICENSE = BSD-3-Clause
+THUNDERBOLT_TOOLS_LICENSE_FILES = COPYING
+
+THUNDERBOLT_TOOLS_DEPENDENCIES = host-pkgconf boost
+
+$(eval $(cmake-package))
--
2.14.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [Buildroot] [PATCHv3 1/1] thunderbolt-tools: new package
2018-01-26 15:30 ` [Buildroot] [PATCHv3 " Andrei Emeltchenko
@ 2018-01-27 11:55 ` Peter Korsgaard
0 siblings, 0 replies; 9+ messages in thread
From: Peter Korsgaard @ 2018-01-27 11:55 UTC (permalink / raw)
To: buildroot
>>>>> "Andrei" == Andrei Emeltchenko <Andrei.Emeltchenko.news@gmail.com> writes:
> From: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
> Add package thunderbolt-tools to handle Thunderbolt devices.
> Signed-off-by: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
> Reviewed-by: Yegor Yefremov <yegorslists@googlemail.com>
Thanks, it is starting to look good, but there's still a few issues.
> ---
> DEVELOPERS | 3 +++
> package/Config.in | 1 +
> package/thunderbolt-tools/Config.in | 13 +++++++++++++
> package/thunderbolt-tools/thunderbolt-tools.hash | 3 +++
> package/thunderbolt-tools/thunderbolt-tools.mk | 14 ++++++++++++++
> 5 files changed, 34 insertions(+)
> create mode 100644 package/thunderbolt-tools/Config.in
> create mode 100644 package/thunderbolt-tools/thunderbolt-tools.hash
> create mode 100644 package/thunderbolt-tools/thunderbolt-tools.mk
> diff --git a/DEVELOPERS b/DEVELOPERS
> index 73c0231bc0..822961a467 100644
> --- a/DEVELOPERS
> +++ b/DEVELOPERS
> @@ -1949,3 +1949,6 @@ F: package/qjson/
> F: package/quazip/
> F: package/shapelib/
> F: package/tinc/
> +
> +N: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
> +F: package/thunderbolt-tools/
Plese keep this file alphabetically sorted (so add before Andrey
Smirnov).
> diff --git a/package/Config.in b/package/Config.in
> index 00451f526d..d638ac3a72 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -505,6 +505,7 @@ endmenu
> source "package/sunxi-mali/Config.in"
> source "package/sysstat/Config.in"
> source "package/targetcli-fb/Config.in"
> + source "package/thunderbolt-tools/Config.in"
> source "package/ti-gfx/Config.in"
> source "package/ti-sgx-demos/Config.in"
> source "package/ti-sgx-km/Config.in"
> diff --git a/package/thunderbolt-tools/Config.in b/package/thunderbolt-tools/Config.in
> new file mode 100644
> index 0000000000..be80c81dc0
> --- /dev/null
> +++ b/package/thunderbolt-tools/Config.in
> @@ -0,0 +1,13 @@
> +config BR2_PACKAGE_THUNDERBOLT_TOOLS
> + bool "thunderbolt-tools"
> + select BR2_PACKAGE_BOOST
> + select BR2_PACKAGE_BOOST_FILESYSTEM
> + depends on BR2_PACKAGE_HAS_UDEV
> + depends on BR2_INSTALL_LIBSTDCPP
> + help
> + Thunderbolt user space tools
> +
> + https://github.com/intel/thunderbolt-software-user-space
Please run the package through utils/check-package. Depends on should
come before select. The boost package also has a number of dependencies
that you need to propagate, E.G. something like:
depends on BR2_TOOLCHAIN_HAS_THREADS # boost
depends on BR2_USE_WCHAR # boost
> +
> +comment "thunderbolt-tools package needs udev provided by systemd or eudev, C++"
> + depends on !BR2_INSTALL_LIBSTDCPP || !BR2_PACKAGE_HAS_UDEV
Drop 'package' to make the text shorter. Other packages with similar
requirements (E.G. modem-manager) use wording like:
comment "thunderbolt-tools needs udev /dev management, wchar, C++, threads"
> +++ b/package/thunderbolt-tools/thunderbolt-tools.mk
> @@ -0,0 +1,14 @@
> +################################################################################
> +#
> +# thunderbolt-tools
> +#
> +################################################################################
> +
> +THUNDERBOLT_TOOLS_VERSION = 8c82b2f84dfede86683873bc47a0b95714129a66
> +THUNDERBOLT_TOOLS_SITE = $(call github,intel,thunderbolt-software-user-space,$(THUNDERBOLT_TOOLS_VERSION))
Is there a specific reason why you are using a random git hash and not
just the latest release? Please document this in the commit message.
We normally try to use the same name for the buildroot package as for
the upstream project, but I agree that
BR2_PACKAGE_THUNDERBOLT_SOFTWARE_USER_SPACE is quite a mouthful, so OK.
> +THUNDERBOLT_TOOLS_LICENSE = BSD-3-Clause
> +THUNDERBOLT_TOOLS_LICENSE_FILES = COPYING
> +
> +THUNDERBOLT_TOOLS_DEPENDENCIES = host-pkgconf boost
I see that CMakeLists.txt looks for pkg-config variables from the udev
package, so it isn't just a runtime dependency and you need to add it to
the _DEPENDENCIES line.
I tried a test build with the above fixed, but it errors out if txt2tags
isn't available:
-- Found PkgConfig: /home/peko/source/buildroot/output-thunder/host/bin/pkg-config (found version "0.28")
CMake Warning at /usr/share/cmake-3.7/Modules/FindBoost.cmake:761 (message):
Imported targets not available for Boost version 106600
Call Stack (most recent call first):
/usr/share/cmake-3.7/Modules/FindBoost.cmake:865 (_Boost_COMPONENT_DEPENDENCIES)
/usr/share/cmake-3.7/Modules/FindBoost.cmake:1470 (_Boost_MISSING_DEPENDENCIES)
common/CMakeLists.txt:5 (find_package)
-- Boost version: 1.66.0
-- Found the following Boost libraries:
-- filesystem
CMake Error at docs/CMakeLists.txt:7 (message):
txt2tags is needed for generating the man page
So you should make man generation optional (and disable it in the
buildroot package).
Care to fix these issues and resend? Thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2018-01-27 11:55 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-25 13:09 [Buildroot] [PATCH 1/1] package: Add thunderbolt-tools package Andrei Emeltchenko
2018-01-25 14:19 ` Yegor Yefremov
2018-01-25 16:38 ` Andrei Emeltchenko
2018-01-25 18:31 ` Yegor Yefremov
2018-01-26 14:20 ` [Buildroot] [PATCH 1/1] thunderbolt-tools: new package Andrei Emeltchenko
2018-01-26 14:36 ` Yegor Yefremov
2018-01-26 14:38 ` Yegor Yefremov
2018-01-26 15:30 ` [Buildroot] [PATCHv3 " Andrei Emeltchenko
2018-01-27 11:55 ` Peter Korsgaard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.