* [PATCH iproute2] ip: address: fix stats64 JSON object name
@ 2018-01-26 19:30 Jakub Kicinski
2018-01-28 0:08 ` Stephen Hemminger
0 siblings, 1 reply; 2+ messages in thread
From: Jakub Kicinski @ 2018-01-26 19:30 UTC (permalink / raw)
To: stephen, dsahern; +Cc: oss-drivers, netdev, Jakub Kicinski
The JSON object name for statistics in ip link show is "stats644".
Looks like a typo, commit d0e720111aad ("ip: ipaddress.c: add support
for json output") contains an example with the expected "stats64" name.
The fact that no one has noticed until now is probably an indication
that no one is using this object. Hopefully it's not too late to fix
this, although IIUC this has already been in 4.13 and 4.14 releases :S
Fixes: d0e720111aad ("ip: ipaddress.c: add support for json output")
Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
---
ip/ipaddress.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ip/ipaddress.c b/ip/ipaddress.c
index ba60125c1b78..67ac6bd31373 100644
--- a/ip/ipaddress.c
+++ b/ip/ipaddress.c
@@ -598,7 +598,7 @@ static void print_link_stats64(FILE *fp, const struct rtnl_link_stats64 *s,
const struct rtattr *carrier_changes)
{
if (is_json_context()) {
- open_json_object("stats644");
+ open_json_object("stats64");
/* RX stats */
open_json_object("rx");
--
2.15.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH iproute2] ip: address: fix stats64 JSON object name
2018-01-26 19:30 [PATCH iproute2] ip: address: fix stats64 JSON object name Jakub Kicinski
@ 2018-01-28 0:08 ` Stephen Hemminger
0 siblings, 0 replies; 2+ messages in thread
From: Stephen Hemminger @ 2018-01-28 0:08 UTC (permalink / raw)
To: Jakub Kicinski; +Cc: dsahern, oss-drivers, netdev
On Fri, 26 Jan 2018 11:30:35 -0800
Jakub Kicinski <jakub.kicinski@netronome.com> wrote:
> The JSON object name for statistics in ip link show is "stats644".
> Looks like a typo, commit d0e720111aad ("ip: ipaddress.c: add support
> for json output") contains an example with the expected "stats64" name.
>
> The fact that no one has noticed until now is probably an indication
> that no one is using this object. Hopefully it's not too late to fix
> this, although IIUC this has already been in 4.13 and 4.14 releases :S
>
> Fixes: d0e720111aad ("ip: ipaddress.c: add support for json output")
> Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
> ---
> ip/ipaddress.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/ip/ipaddress.c b/ip/ipaddress.c
> index ba60125c1b78..67ac6bd31373 100644
> --- a/ip/ipaddress.c
> +++ b/ip/ipaddress.c
> @@ -598,7 +598,7 @@ static void print_link_stats64(FILE *fp, const struct rtnl_link_stats64 *s,
> const struct rtattr *carrier_changes)
> {
> if (is_json_context()) {
> - open_json_object("stats644");
> + open_json_object("stats64");
>
> /* RX stats */
> open_json_object("rx");
Thanks for the bugfix. Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-01-28 0:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-26 19:30 [PATCH iproute2] ip: address: fix stats64 JSON object name Jakub Kicinski
2018-01-28 0:08 ` Stephen Hemminger
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.