All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: xiyou.wangcong@gmail.com
Cc: netdev@vger.kernel.org, john.fastabend@gmail.com
Subject: Re: [Patch net-next v3 0/3] net_sched: reflect tx_queue_len change for pfifo_fast
Date: Mon, 29 Jan 2018 12:43:24 -0500 (EST)	[thread overview]
Message-ID: <20180129.124324.1307163515349322323.davem@davemloft.net> (raw)
In-Reply-To: <20180126022624.20442-1-xiyou.wangcong@gmail.com>

From: Cong Wang <xiyou.wangcong@gmail.com>
Date: Thu, 25 Jan 2018 18:26:21 -0800

> This pathcset restores the pfifo_fast qdisc behavior of dropping
> packets based on latest dev->tx_queue_len. Patch 1 introduces
> a helper, patch 2 introduces a new Qdisc ops which is called when
> we modify tx_queue_len, patch 3 implements this ops for pfifo_fast.
> 
> Please see each patch for details.
> 
> ---
> v3: use skb_array_resize_multiple()
> v2: handle error case for ->change_tx_queue_len()

Series applied, thanks Cong.

Please follow up with John about making the queue allocation use
a prepare + commit phase.

And as for the TX queue state handling on change, I think it's
fine to purge the whole queue.  That is definitely better than
allowing the queue length to be visibly over the tx_queue_len
setting.

Thank you.

  parent reply	other threads:[~2018-01-29 17:43 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-26  2:26 [Patch net-next v3 0/3] net_sched: reflect tx_queue_len change for pfifo_fast Cong Wang
2018-01-26  2:26 ` [Patch net-next v3 1/3] net: introduce helper dev_change_tx_queue_len() Cong Wang
2018-06-27 16:14   ` Eric Dumazet
2018-06-27 17:41     ` Cong Wang
2018-01-26  2:26 ` [Patch net-next v3 2/3] net_sched: plug in qdisc ops change_tx_queue_len Cong Wang
2018-01-26 14:16   ` Michael S. Tsirkin
2018-01-29  2:31     ` Cong Wang
2018-01-26  2:26 ` [Patch net-next v3 3/3] net_sched: implement ->change_tx_queue_len() for pfifo_fast Cong Wang
2018-01-26  3:57   ` Jason Wang
2018-01-26  4:01     ` Cong Wang
2018-01-26 14:10       ` Michael S. Tsirkin
2018-01-29  2:33         ` Cong Wang
2018-01-29  3:31       ` Jason Wang
2018-01-26 13:48     ` Michael S. Tsirkin
2018-01-29  5:35 ` [Patch net-next v3 0/3] net_sched: reflect tx_queue_len change " John Fastabend
2018-01-29  5:57   ` Cong Wang
2018-01-29  6:09     ` John Fastabend
2018-01-29  6:25       ` Cong Wang
2018-01-29  6:01   ` Cong Wang
2018-01-29 17:43 ` David Miller [this message]
2018-01-30  0:12   ` Cong Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180129.124324.1307163515349322323.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=john.fastabend@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.