All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jason Wang <jasowang@redhat.com>
To: Cong Wang <xiyou.wangcong@gmail.com>
Cc: Linux Kernel Network Developers <netdev@vger.kernel.org>,
	John Fastabend <john.fastabend@gmail.com>,
	"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Patch net-next v3 3/3] net_sched: implement ->change_tx_queue_len() for pfifo_fast
Date: Mon, 29 Jan 2018 11:31:42 +0800	[thread overview]
Message-ID: <0f00a250-a3d7-47cf-21bd-e893e4b36afa@redhat.com> (raw)
In-Reply-To: <CAM_iQpWLNhm-k_2Ncv2D=K1FCnUJtcqfemu6oKt6DXQk7rQy7g@mail.gmail.com>



On 2018年01月26日 12:01, Cong Wang wrote:
>> Is __skb_array_empty() in pfifo_fast_dequeue() still safe after this change?
> Yes, we sync with dequeue path before calling ->change_tx_queue_len().
> I already mentioned this in patch 2/3.

Aha, ok, I think I get the synchronize_net() trick in dev_deactivate_many().

Thanks

  parent reply	other threads:[~2018-01-29  3:31 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-26  2:26 [Patch net-next v3 0/3] net_sched: reflect tx_queue_len change for pfifo_fast Cong Wang
2018-01-26  2:26 ` [Patch net-next v3 1/3] net: introduce helper dev_change_tx_queue_len() Cong Wang
2018-06-27 16:14   ` Eric Dumazet
2018-06-27 17:41     ` Cong Wang
2018-01-26  2:26 ` [Patch net-next v3 2/3] net_sched: plug in qdisc ops change_tx_queue_len Cong Wang
2018-01-26 14:16   ` Michael S. Tsirkin
2018-01-29  2:31     ` Cong Wang
2018-01-26  2:26 ` [Patch net-next v3 3/3] net_sched: implement ->change_tx_queue_len() for pfifo_fast Cong Wang
2018-01-26  3:57   ` Jason Wang
2018-01-26  4:01     ` Cong Wang
2018-01-26 14:10       ` Michael S. Tsirkin
2018-01-29  2:33         ` Cong Wang
2018-01-29  3:31       ` Jason Wang [this message]
2018-01-26 13:48     ` Michael S. Tsirkin
2018-01-29  5:35 ` [Patch net-next v3 0/3] net_sched: reflect tx_queue_len change " John Fastabend
2018-01-29  5:57   ` Cong Wang
2018-01-29  6:09     ` John Fastabend
2018-01-29  6:25       ` Cong Wang
2018-01-29  6:01   ` Cong Wang
2018-01-29 17:43 ` David Miller
2018-01-30  0:12   ` Cong Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0f00a250-a3d7-47cf-21bd-e893e4b36afa@redhat.com \
    --to=jasowang@redhat.com \
    --cc=john.fastabend@gmail.com \
    --cc=mst@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.