* [PATCH net-next] bnxt_en: cleanup DIM work on device shutdown
@ 2018-01-26 15:27 Andy Gospodarek
2018-01-26 19:12 ` Michael Chan
2018-01-29 19:20 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Andy Gospodarek @ 2018-01-26 15:27 UTC (permalink / raw)
To: netdev; +Cc: Andy Gospodarek, Michael Chan
From: Andy Gospodarek <gospo@broadcom.com>
Make sure to cancel any pending work that might update driver coalesce
settings when taking down an interface.
Fixes: 6a8788f25625 ("bnxt_en: add support for software dynamic interrupt moderation")
Signed-off-by: Andy Gospodarek <gospo@broadcom.com>
Cc: Michael Chan <michael.chan@broadcom.com>
---
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
index 4b001d2..1500243 100644
--- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c
+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
@@ -6082,8 +6082,14 @@ static void bnxt_disable_napi(struct bnxt *bp)
if (!bp->bnapi)
return;
- for (i = 0; i < bp->cp_nr_rings; i++)
+ for (i = 0; i < bp->cp_nr_rings; i++) {
+ struct bnxt_cp_ring_info *cpr = &bp->bnapi[i]->cp_ring;
+
+ if (bp->bnapi[i]->rx_ring)
+ cancel_work_sync(&cpr->dim.work);
+
napi_disable(&bp->bnapi[i]->napi);
+ }
}
static void bnxt_enable_napi(struct bnxt *bp)
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] bnxt_en: cleanup DIM work on device shutdown
2018-01-26 15:27 [PATCH net-next] bnxt_en: cleanup DIM work on device shutdown Andy Gospodarek
@ 2018-01-26 19:12 ` Michael Chan
2018-01-29 19:20 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Michael Chan @ 2018-01-26 19:12 UTC (permalink / raw)
To: Andy Gospodarek; +Cc: Netdev, Andy Gospodarek
On Fri, Jan 26, 2018 at 7:27 AM, Andy Gospodarek <andy@greyhouse.net> wrote:
>
> From: Andy Gospodarek <gospo@broadcom.com>
>
> Make sure to cancel any pending work that might update driver coalesce
> settings when taking down an interface.
>
> Fixes: 6a8788f25625 ("bnxt_en: add support for software dynamic interrupt moderation")
> Signed-off-by: Andy Gospodarek <gospo@broadcom.com>
> Cc: Michael Chan <michael.chan@broadcom.com>
Acked-by: Michael Chan <michael.chan@broadcom.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] bnxt_en: cleanup DIM work on device shutdown
2018-01-26 15:27 [PATCH net-next] bnxt_en: cleanup DIM work on device shutdown Andy Gospodarek
2018-01-26 19:12 ` Michael Chan
@ 2018-01-29 19:20 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2018-01-29 19:20 UTC (permalink / raw)
To: andy; +Cc: netdev, gospo, michael.chan
From: Andy Gospodarek <andy@greyhouse.net>
Date: Fri, 26 Jan 2018 10:27:47 -0500
> From: Andy Gospodarek <gospo@broadcom.com>
>
> Make sure to cancel any pending work that might update driver coalesce
> settings when taking down an interface.
>
> Fixes: 6a8788f25625 ("bnxt_en: add support for software dynamic interrupt moderation")
> Signed-off-by: Andy Gospodarek <gospo@broadcom.com>
> Cc: Michael Chan <michael.chan@broadcom.com>
Applied, thank you.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-01-29 19:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-26 15:27 [PATCH net-next] bnxt_en: cleanup DIM work on device shutdown Andy Gospodarek
2018-01-26 19:12 ` Michael Chan
2018-01-29 19:20 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.