* firmware/shim: fix build process to use POSIX find options
@ 2018-01-26 19:54 Michael Glasgow
2018-01-29 11:37 ` Roger Pau Monné
0 siblings, 1 reply; 6+ messages in thread
From: Michael Glasgow @ 2018-01-26 19:54 UTC (permalink / raw)
To: xen-devel
This recent patch can be simplified a bit. (The patch below is
untested, just a suggestion.)
diff -ur a/tools/firmware/xen-dir/Makefile b/tools/firmware/xen-dir/Makefile
--- a/tools/firmware/xen-dir/Makefile 2018-01-26 11:40:00.711389605 -0600
+++ b/tools/firmware/xen-dir/Makefile 2018-01-26 11:51:41.279825142 -0600
@@ -20,9 +20,8 @@
rm -f linkfarm.stamp.tmp
$(foreach d, $(LINK_DIRS), \
(mkdir -p $(D)/$(d); \
- cd $(D)/$(d); \
- find $(XEN_ROOT)/$(d)/ -type d -exec sh -c \
- "echo {} | sed 's,^$(XEN_ROOT)/$(d)/,,g' | xargs mkdir -p" \;);)
+ cd $(D)/$(d) && \
+ (cd $(XEN_ROOT)/$(d) && find . -type d) | xargs mkdir -p \;);)
$(foreach d, $(LINK_DIRS), \
(cd $(XEN_ROOT); \
find $(d) ! -type l -type f \
--
Michael Glasgow <glasgow@beer.net>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: firmware/shim: fix build process to use POSIX find options
2018-01-26 19:54 firmware/shim: fix build process to use POSIX find options Michael Glasgow
@ 2018-01-29 11:37 ` Roger Pau Monné
2018-01-30 18:57 ` Michael Glasgow
0 siblings, 1 reply; 6+ messages in thread
From: Roger Pau Monné @ 2018-01-29 11:37 UTC (permalink / raw)
To: Michael Glasgow; +Cc: xen-devel, Wei Liu, Ian Jackson
On Fri, Jan 26, 2018 at 01:54:30PM -0600, Michael Glasgow wrote:
> This recent patch can be simplified a bit. (The patch below is
> untested, just a suggestion.)
>
Thanks, this LGTM, but it needs your Signed-off-by tag in order to be
applied.
Also remember to Cc the maintainers when resending, I've done this for
you now.
> diff -ur a/tools/firmware/xen-dir/Makefile b/tools/firmware/xen-dir/Makefile
> --- a/tools/firmware/xen-dir/Makefile 2018-01-26 11:40:00.711389605 -0600
> +++ b/tools/firmware/xen-dir/Makefile 2018-01-26 11:51:41.279825142 -0600
> @@ -20,9 +20,8 @@
> rm -f linkfarm.stamp.tmp
> $(foreach d, $(LINK_DIRS), \
> (mkdir -p $(D)/$(d); \
> - cd $(D)/$(d); \
> - find $(XEN_ROOT)/$(d)/ -type d -exec sh -c \
> - "echo {} | sed 's,^$(XEN_ROOT)/$(d)/,,g' | xargs mkdir -p" \;);)
> + cd $(D)/$(d) && \
> + (cd $(XEN_ROOT)/$(d) && find . -type d) | xargs mkdir -p \;);)
> $(foreach d, $(LINK_DIRS), \
> (cd $(XEN_ROOT); \
> find $(d) ! -type l -type f \
>
>
> --
> Michael Glasgow <glasgow@beer.net>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xenproject.org
> https://lists.xenproject.org/mailman/listinfo/xen-devel
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: firmware/shim: fix build process to use POSIX find options
2018-01-29 11:37 ` Roger Pau Monné
@ 2018-01-30 18:57 ` Michael Glasgow
2018-02-01 10:13 ` Roger Pau Monné
0 siblings, 1 reply; 6+ messages in thread
From: Michael Glasgow @ 2018-01-30 18:57 UTC (permalink / raw)
To: Roger Pau [Monn_]; +Cc: xen-devel, Wei Liu, Ian Jackson
Roger Pau [Monn_] wrote:
> On Fri, Jan 26, 2018 at 01:54:30PM -0600, Michael Glasgow wrote:
> > This recent patch can be simplified a bit. (The patch below is
> > untested, just a suggestion.)
>
> Thanks, this LGTM, but it needs your Signed-off-by tag in order to be
> applied.
Simplify posix-friendly changes a bit.
Signed-off-by: Michael Glasgow <glasgow@beer.net>
---
diff -ur a/tools/firmware/xen-dir/Makefile b/tools/firmware/xen-dir/Makefile
--- a/tools/firmware/xen-dir/Makefile 2018-01-26 11:40:00.711389605 -0600
+++ b/tools/firmware/xen-dir/Makefile 2018-01-26 11:51:41.279825142 -0600
@@ -20,9 +20,8 @@
rm -f linkfarm.stamp.tmp
$(foreach d, $(LINK_DIRS), \
(mkdir -p $(D)/$(d); \
- cd $(D)/$(d); \
- find $(XEN_ROOT)/$(d)/ -type d -exec sh -c \
- "echo {} | sed 's,^$(XEN_ROOT)/$(d)/,,g' | xargs mkdir -p"
\;);)
+ cd $(D)/$(d) && \
+ (cd $(XEN_ROOT)/$(d) && find . -type d) | xargs mkdir -p \;);)
$(foreach d, $(LINK_DIRS), \
(cd $(XEN_ROOT); \
find $(d) ! -type l -type f \
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: firmware/shim: fix build process to use POSIX find options
2018-01-30 18:57 ` Michael Glasgow
@ 2018-02-01 10:13 ` Roger Pau Monné
2018-02-01 10:25 ` Jan Beulich
0 siblings, 1 reply; 6+ messages in thread
From: Roger Pau Monné @ 2018-02-01 10:13 UTC (permalink / raw)
To: Michael Glasgow; +Cc: xen-devel, Wei Liu, Ian Jackson
On Tue, Jan 30, 2018 at 12:57:28PM -0600, Michael Glasgow wrote:
> Roger Pau [Monn_] wrote:
> > On Fri, Jan 26, 2018 at 01:54:30PM -0600, Michael Glasgow wrote:
> > > This recent patch can be simplified a bit. (The patch below is
> > > untested, just a suggestion.)
> >
> > Thanks, this LGTM, but it needs your Signed-off-by tag in order to be
> > applied.
>
> Simplify posix-friendly changes a bit.
>
> Signed-off-by: Michael Glasgow <glasgow@beer.net>
Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>
With one nit...
> ---
>
> diff -ur a/tools/firmware/xen-dir/Makefile b/tools/firmware/xen-dir/Makefile
> --- a/tools/firmware/xen-dir/Makefile 2018-01-26 11:40:00.711389605 -0600
> +++ b/tools/firmware/xen-dir/Makefile 2018-01-26 11:51:41.279825142 -0600
> @@ -20,9 +20,8 @@
> rm -f linkfarm.stamp.tmp
> $(foreach d, $(LINK_DIRS), \
> (mkdir -p $(D)/$(d); \
> - cd $(D)/$(d); \
> - find $(XEN_ROOT)/$(d)/ -type d -exec sh -c \
> - "echo {} | sed 's,^$(XEN_ROOT)/$(d)/,,g' | xargs mkdir -p"
> \;);)
> + cd $(D)/$(d) && \
There should be no need for the '&&', all this chunk should be
executed with 'set -e', so please restore the previous ';'.
Thanks, Roger.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: firmware/shim: fix build process to use POSIX find options
2018-02-01 10:13 ` Roger Pau Monné
@ 2018-02-01 10:25 ` Jan Beulich
2018-02-01 10:29 ` Roger Pau Monné
0 siblings, 1 reply; 6+ messages in thread
From: Jan Beulich @ 2018-02-01 10:25 UTC (permalink / raw)
To: Roger Pau Monné; +Cc: Ian Jackson, Michael Glasgow, Wei Liu, xen-devel
>>> On 01.02.18 at 11:13, <roger.pau@citrix.com> wrote:
> On Tue, Jan 30, 2018 at 12:57:28PM -0600, Michael Glasgow wrote:
>> Roger Pau [Monn_] wrote:
>> > On Fri, Jan 26, 2018 at 01:54:30PM -0600, Michael Glasgow wrote:
>> > > This recent patch can be simplified a bit. (The patch below is
>> > > untested, just a suggestion.)
>> >
>> > Thanks, this LGTM, but it needs your Signed-off-by tag in order to be
>> > applied.
>>
>> Simplify posix-friendly changes a bit.
>>
>> Signed-off-by: Michael Glasgow <glasgow@beer.net>
>
> Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>
>
> With one nit...
>
>> ---
>>
>> diff -ur a/tools/firmware/xen-dir/Makefile b/tools/firmware/xen-dir/Makefile
>> --- a/tools/firmware/xen-dir/Makefile 2018-01-26 11:40:00.711389605 -0600
>> +++ b/tools/firmware/xen-dir/Makefile 2018-01-26 11:51:41.279825142 -0600
>> @@ -20,9 +20,8 @@
>> rm -f linkfarm.stamp.tmp
>> $(foreach d, $(LINK_DIRS), \
>> (mkdir -p $(D)/$(d); \
>> - cd $(D)/$(d); \
>> - find $(XEN_ROOT)/$(d)/ -type d -exec sh -c \
>> - "echo {} | sed 's,^$(XEN_ROOT)/$(d)/,,g' | xargs mkdir -p"
>> \;);)
>> + cd $(D)/$(d) && \
>
> There should be no need for the '&&', all this chunk should be
> executed with 'set -e', so please restore the previous ';'.
As you've seen from the patch I've sent - "should be" != "is".
The way it's currently placed the "set -e" has no effect at all.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: firmware/shim: fix build process to use POSIX find options
2018-02-01 10:25 ` Jan Beulich
@ 2018-02-01 10:29 ` Roger Pau Monné
0 siblings, 0 replies; 6+ messages in thread
From: Roger Pau Monné @ 2018-02-01 10:29 UTC (permalink / raw)
To: Jan Beulich; +Cc: Ian Jackson, Michael Glasgow, Wei Liu, xen-devel
On Thu, Feb 01, 2018 at 03:25:50AM -0700, Jan Beulich wrote:
> >>> On 01.02.18 at 11:13, <roger.pau@citrix.com> wrote:
> > On Tue, Jan 30, 2018 at 12:57:28PM -0600, Michael Glasgow wrote:
> >> Roger Pau [Monn_] wrote:
> >> > On Fri, Jan 26, 2018 at 01:54:30PM -0600, Michael Glasgow wrote:
> >> > > This recent patch can be simplified a bit. (The patch below is
> >> > > untested, just a suggestion.)
> >> >
> >> > Thanks, this LGTM, but it needs your Signed-off-by tag in order to be
> >> > applied.
> >>
> >> Simplify posix-friendly changes a bit.
> >>
> >> Signed-off-by: Michael Glasgow <glasgow@beer.net>
> >
> > Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>
> >
> > With one nit...
> >
> >> ---
> >>
> >> diff -ur a/tools/firmware/xen-dir/Makefile b/tools/firmware/xen-dir/Makefile
> >> --- a/tools/firmware/xen-dir/Makefile 2018-01-26 11:40:00.711389605 -0600
> >> +++ b/tools/firmware/xen-dir/Makefile 2018-01-26 11:51:41.279825142 -0600
> >> @@ -20,9 +20,8 @@
> >> rm -f linkfarm.stamp.tmp
> >> $(foreach d, $(LINK_DIRS), \
> >> (mkdir -p $(D)/$(d); \
> >> - cd $(D)/$(d); \
> >> - find $(XEN_ROOT)/$(d)/ -type d -exec sh -c \
> >> - "echo {} | sed 's,^$(XEN_ROOT)/$(d)/,,g' | xargs mkdir -p"
> >> \;);)
> >> + cd $(D)/$(d) && \
> >
> > There should be no need for the '&&', all this chunk should be
> > executed with 'set -e', so please restore the previous ';'.
>
> As you've seen from the patch I've sent - "should be" != "is".
> The way it's currently placed the "set -e" has no effect at all.
Hehe, yes, I've realized that, that's why I've said "should be". In
any case this should stay as ';' and the set -e fixed like you do in
your patch.
Roger.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-02-01 10:29 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-26 19:54 firmware/shim: fix build process to use POSIX find options Michael Glasgow
2018-01-29 11:37 ` Roger Pau Monné
2018-01-30 18:57 ` Michael Glasgow
2018-02-01 10:13 ` Roger Pau Monné
2018-02-01 10:25 ` Jan Beulich
2018-02-01 10:29 ` Roger Pau Monné
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.