All of lore.kernel.org
 help / color / mirror / Atom feed
* [igt-dev] [PATCH i-g-t] tests/perf: fix report validity check on gen10+
@ 2018-01-29 12:03 Lionel Landwerlin
  2018-01-29 12:54 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Lionel Landwerlin @ 2018-01-29 12:03 UTC (permalink / raw)
  To: igt-dev

Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Testcase: igt/perf/buffer-fill & igt/perf/enable-disable & igt/perf/gen8-unprivileged-single-ctx-counters
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104658
---
 tests/perf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/perf.c b/tests/perf.c
index a173680c..55d6e9ea 100644
--- a/tests/perf.c
+++ b/tests/perf.c
@@ -473,7 +473,7 @@ oa_report_ctx_is_valid(uint32_t *report)
 		return false; /* TODO */
 	} else if (IS_GEN8(devid)) {
 		return report[0] & (1ul << 25);
-	} else if (IS_GEN9(devid)) {
+	} else if (AT_LEAST_GEN(devid, 9)) {
 		return report[0] & (1ul << 16);
 	}
 
-- 
2.15.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [igt-dev] ✓ Fi.CI.BAT: success for tests/perf: fix report validity check on gen10+
  2018-01-29 12:03 [igt-dev] [PATCH i-g-t] tests/perf: fix report validity check on gen10+ Lionel Landwerlin
@ 2018-01-29 12:54 ` Patchwork
  2018-01-29 18:24 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
  2018-01-31 20:04 ` [igt-dev] [PATCH i-g-t] " Matthew Auld
  2 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2018-01-29 12:54 UTC (permalink / raw)
  To: Lionel Landwerlin; +Cc: igt-dev

== Series Details ==

Series: tests/perf: fix report validity check on gen10+
URL   : https://patchwork.freedesktop.org/series/37269/
State : success

== Summary ==

IGT patchset tested on top of latest successful build
2649a091a0a67e6d4106024fb6d74cf7119f350f lib: Refactor igt_wait() to use library timers

with latest DRM-Tip kernel build CI_DRM_3689
2bbded26cfa2 drm-tip: 2018y-01m-29d-10h-43m-15s UTC integration manifest

No testlist changes.

Test debugfs_test:
        Subgroup read_all_entries:
                pass       -> INCOMPLETE (fi-snb-2520m) fdo#103713
Test gem_exec_suspend:
        Subgroup basic-s4-devices:
                dmesg-warn -> PASS       (fi-elk-e7500) fdo#103989

fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713
fdo#103989 https://bugs.freedesktop.org/show_bug.cgi?id=103989

fi-bdw-5557u     total:288  pass:267  dwarn:0   dfail:0   fail:0   skip:21  time:428s
fi-bdw-gvtdvm    total:288  pass:264  dwarn:0   dfail:0   fail:0   skip:24  time:435s
fi-blb-e6850     total:288  pass:223  dwarn:1   dfail:0   fail:0   skip:64  time:374s
fi-bsw-n3050     total:288  pass:242  dwarn:0   dfail:0   fail:0   skip:46  time:490s
fi-bwr-2160      total:288  pass:183  dwarn:0   dfail:0   fail:0   skip:105 time:282s
fi-bxt-dsi       total:288  pass:258  dwarn:0   dfail:0   fail:0   skip:30  time:483s
fi-bxt-j4205     total:288  pass:259  dwarn:0   dfail:0   fail:0   skip:29  time:492s
fi-byt-j1900     total:288  pass:253  dwarn:0   dfail:0   fail:0   skip:35  time:475s
fi-byt-n2820     total:288  pass:249  dwarn:0   dfail:0   fail:0   skip:39  time:460s
fi-cfl-s2        total:288  pass:262  dwarn:0   dfail:0   fail:0   skip:26  time:560s
fi-elk-e7500     total:224  pass:169  dwarn:8   dfail:1   fail:0   skip:45 
fi-gdg-551       total:288  pass:179  dwarn:0   dfail:0   fail:1   skip:108 time:277s
fi-glk-1         total:288  pass:260  dwarn:0   dfail:0   fail:0   skip:28  time:515s
fi-hsw-4770      total:288  pass:261  dwarn:0   dfail:0   fail:0   skip:27  time:396s
fi-hsw-4770r     total:288  pass:261  dwarn:0   dfail:0   fail:0   skip:27  time:400s
fi-ilk-650       total:288  pass:228  dwarn:0   dfail:0   fail:0   skip:60  time:415s
fi-ivb-3520m     total:288  pass:259  dwarn:0   dfail:0   fail:0   skip:29  time:471s
fi-ivb-3770      total:288  pass:255  dwarn:0   dfail:0   fail:0   skip:33  time:413s
fi-kbl-7500u     total:288  pass:263  dwarn:1   dfail:0   fail:0   skip:24  time:463s
fi-kbl-7560u     total:288  pass:269  dwarn:0   dfail:0   fail:0   skip:19  time:504s
fi-kbl-7567u     total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:453s
fi-kbl-r         total:288  pass:261  dwarn:0   dfail:0   fail:0   skip:27  time:505s
fi-pnv-d510      total:288  pass:222  dwarn:1   dfail:0   fail:0   skip:65  time:590s
fi-skl-6260u     total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:434s
fi-skl-6600u     total:288  pass:261  dwarn:0   dfail:0   fail:0   skip:27  time:513s
fi-skl-6700hq    total:288  pass:262  dwarn:0   dfail:0   fail:0   skip:26  time:530s
fi-skl-6700k2    total:288  pass:264  dwarn:0   dfail:0   fail:0   skip:24  time:496s
fi-skl-6770hq    total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:484s
fi-skl-guc       total:288  pass:260  dwarn:0   dfail:0   fail:0   skip:28  time:416s
fi-skl-gvtdvm    total:288  pass:265  dwarn:0   dfail:0   fail:0   skip:23  time:433s
fi-snb-2520m     total:3    pass:2    dwarn:0   dfail:0   fail:0   skip:0  
fi-snb-2600      total:288  pass:248  dwarn:0   dfail:0   fail:0   skip:40  time:399s
Blacklisted hosts:
fi-cnl-y2        total:288  pass:261  dwarn:0   dfail:0   fail:0   skip:27  time:528s
fi-glk-dsi       total:288  pass:258  dwarn:0   dfail:0   fail:0   skip:30  time:476s

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_831/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [igt-dev] ✗ Fi.CI.IGT: failure for tests/perf: fix report validity check on gen10+
  2018-01-29 12:03 [igt-dev] [PATCH i-g-t] tests/perf: fix report validity check on gen10+ Lionel Landwerlin
  2018-01-29 12:54 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
@ 2018-01-29 18:24 ` Patchwork
  2018-01-31 20:04 ` [igt-dev] [PATCH i-g-t] " Matthew Auld
  2 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2018-01-29 18:24 UTC (permalink / raw)
  To: Lionel Landwerlin; +Cc: igt-dev

== Series Details ==

Series: tests/perf: fix report validity check on gen10+
URL   : https://patchwork.freedesktop.org/series/37269/
State : failure

== Summary ==

Test kms_plane:
        Subgroup plane-panning-bottom-right-suspend-pipe-a-planes:
                skip       -> PASS       (shard-snb) fdo#102365
Test kms_frontbuffer_tracking:
        Subgroup fbc-rgb565-draw-blt:
                fail       -> PASS       (shard-apl) fdo#101623 +2
        Subgroup fbc-1p-primscrn-cur-indfb-draw-mmap-wc:
                pass       -> FAIL       (shard-apl)
Test perf_pmu:
        Subgroup busy-vcs0:
                pass       -> FAIL       (shard-apl)
        Subgroup frequency:
                fail       -> PASS       (shard-apl) fdo#104829
Test syncobj_wait:
        Subgroup wait-any-snapshot:
                fail       -> PASS       (shard-apl)
Test kms_flip:
        Subgroup 2x-plain-flip-ts-check:
                pass       -> FAIL       (shard-hsw)
Test gem_eio:
        Subgroup in-flight:
                dmesg-warn -> PASS       (shard-snb) fdo#104058

fdo#102365 https://bugs.freedesktop.org/show_bug.cgi?id=102365
fdo#101623 https://bugs.freedesktop.org/show_bug.cgi?id=101623
fdo#104829 https://bugs.freedesktop.org/show_bug.cgi?id=104829
fdo#104058 https://bugs.freedesktop.org/show_bug.cgi?id=104058

shard-apl        total:2838 pass:1751 dwarn:1   dfail:0   fail:22  skip:1064 time:12695s
shard-hsw        total:2838 pass:1735 dwarn:1   dfail:0   fail:11  skip:1090 time:11795s
shard-snb        total:2838 pass:1330 dwarn:1   dfail:0   fail:10  skip:1497 time:6587s
Blacklisted hosts:
shard-kbl        total:2813 pass:1852 dwarn:1   dfail:0   fail:21  skip:937 time:9362s

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_831/shards.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [igt-dev] [PATCH i-g-t] tests/perf: fix report validity check on gen10+
  2018-01-29 12:03 [igt-dev] [PATCH i-g-t] tests/perf: fix report validity check on gen10+ Lionel Landwerlin
  2018-01-29 12:54 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
  2018-01-29 18:24 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
@ 2018-01-31 20:04 ` Matthew Auld
  2018-02-01 15:20   ` Lionel Landwerlin
  2 siblings, 1 reply; 5+ messages in thread
From: Matthew Auld @ 2018-01-31 20:04 UTC (permalink / raw)
  To: Lionel Landwerlin; +Cc: igt-dev

On 29 January 2018 at 12:03, Lionel Landwerlin
<lionel.g.landwerlin@intel.com> wrote:
> Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
> Testcase: igt/perf/buffer-fill & igt/perf/enable-disable & igt/perf/gen8-unprivileged-single-ctx-counters
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104658
> ---
>  tests/perf.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/perf.c b/tests/perf.c
> index a173680c..55d6e9ea 100644
> --- a/tests/perf.c
> +++ b/tests/perf.c
> @@ -473,7 +473,7 @@ oa_report_ctx_is_valid(uint32_t *report)
>                 return false; /* TODO */
>         } else if (IS_GEN8(devid)) {
>                 return report[0] & (1ul << 25);
> -       } else if (IS_GEN9(devid)) {
> +       } else if (AT_LEAST_GEN(devid, 9)) {
>                 return report[0] & (1ul << 16);
>         }

Do we want to drop the !"reached", since this is now very much a catch all?

Anyway:
Reviewed-by: Matthew Auld <matthew.auld@intel.com>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [igt-dev] [PATCH i-g-t] tests/perf: fix report validity check on gen10+
  2018-01-31 20:04 ` [igt-dev] [PATCH i-g-t] " Matthew Auld
@ 2018-02-01 15:20   ` Lionel Landwerlin
  0 siblings, 0 replies; 5+ messages in thread
From: Lionel Landwerlin @ 2018-02-01 15:20 UTC (permalink / raw)
  To: Matthew Auld; +Cc: igt-dev

On 31/01/18 20:04, Matthew Auld wrote:
> On 29 January 2018 at 12:03, Lionel Landwerlin
> <lionel.g.landwerlin@intel.com> wrote:
>> Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
>> Testcase: igt/perf/buffer-fill & igt/perf/enable-disable & igt/perf/gen8-unprivileged-single-ctx-counters
>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104658
>> ---
>>   tests/perf.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tests/perf.c b/tests/perf.c
>> index a173680c..55d6e9ea 100644
>> --- a/tests/perf.c
>> +++ b/tests/perf.c
>> @@ -473,7 +473,7 @@ oa_report_ctx_is_valid(uint32_t *report)
>>                  return false; /* TODO */
>>          } else if (IS_GEN8(devid)) {
>>                  return report[0] & (1ul << 25);
>> -       } else if (IS_GEN9(devid)) {
>> +       } else if (AT_LEAST_GEN(devid, 9)) {
>>                  return report[0] & (1ul << 16);
>>          }
> Do we want to drop the !"reached", since this is now very much a catch all?
>
> Anyway:
> Reviewed-by: Matthew Auld <matthew.auld@intel.com>
>
Thanks Matt, decided to leave that assert for now.
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2018-02-01 15:20 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-29 12:03 [igt-dev] [PATCH i-g-t] tests/perf: fix report validity check on gen10+ Lionel Landwerlin
2018-01-29 12:54 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2018-01-29 18:24 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2018-01-31 20:04 ` [igt-dev] [PATCH i-g-t] " Matthew Auld
2018-02-01 15:20   ` Lionel Landwerlin

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.