* [PATCH libdrm] tests/amdgpu: add missing config.h include
@ 2018-01-29 14:56 Emil Velikov
2018-01-29 15:20 ` Eric Engestrom
0 siblings, 1 reply; 2+ messages in thread
From: Emil Velikov @ 2018-01-29 14:56 UTC (permalink / raw)
To: dri-devel; +Cc: Fabio Pedretti, emil.l.velikov
From: Emil Velikov <emil.velikov@collabora.com>
Otherwise we'll end up without the macros set during configure stage.
And effectively error out in sanity tests such as the mmap static
assert.
To reproduce, do a multilib build - 32bit build on 64bit machine.
Cc: Fabio Pedretti <pedretti.fabio@gmail.com>
Cc: Andrey Grodzovsky <Andrey.Grodzovsky@amd.com>
Fixes: 33dcc29f7cc ("amdgpu: Add VMID reservation per GPU context test.")
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104819
Signed-off-by: Emil Velikov <emil.velikov@collabora.com>
---
tests/amdgpu/vm_tests.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/tests/amdgpu/vm_tests.c b/tests/amdgpu/vm_tests.c
index 4b0121ff..0379a79d 100644
--- a/tests/amdgpu/vm_tests.c
+++ b/tests/amdgpu/vm_tests.c
@@ -21,6 +21,10 @@
*
*/
+#ifdef HAVE_CONFIG_H
+#include "config.h"
+#endif
+
#include "CUnit/Basic.h"
#include "amdgpu_test.h"
--
2.16.0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH libdrm] tests/amdgpu: add missing config.h include
2018-01-29 14:56 [PATCH libdrm] tests/amdgpu: add missing config.h include Emil Velikov
@ 2018-01-29 15:20 ` Eric Engestrom
0 siblings, 0 replies; 2+ messages in thread
From: Eric Engestrom @ 2018-01-29 15:20 UTC (permalink / raw)
To: Emil Velikov; +Cc: Fabio Pedretti, dri-devel
On Monday, 2018-01-29 14:56:04 +0000, Emil Velikov wrote:
> From: Emil Velikov <emil.velikov@collabora.com>
>
> Otherwise we'll end up without the macros set during configure stage.
> And effectively error out in sanity tests such as the mmap static
> assert.
>
> To reproduce, do a multilib build - 32bit build on 64bit machine.
>
> Cc: Fabio Pedretti <pedretti.fabio@gmail.com>
> Cc: Andrey Grodzovsky <Andrey.Grodzovsky@amd.com>
> Fixes: 33dcc29f7cc ("amdgpu: Add VMID reservation per GPU context test.")
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104819
> Signed-off-by: Emil Velikov <emil.velikov@collabora.com>
Reviewed-by: Eric Engestrom <eric.engestrom@imgtec.com>
And my apologies for being a bit too trigger-happy when blaming
autotools :(
> ---
> tests/amdgpu/vm_tests.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/tests/amdgpu/vm_tests.c b/tests/amdgpu/vm_tests.c
> index 4b0121ff..0379a79d 100644
> --- a/tests/amdgpu/vm_tests.c
> +++ b/tests/amdgpu/vm_tests.c
> @@ -21,6 +21,10 @@
> *
> */
>
> +#ifdef HAVE_CONFIG_H
> +#include "config.h"
> +#endif
> +
> #include "CUnit/Basic.h"
>
> #include "amdgpu_test.h"
> --
> 2.16.0
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-01-29 15:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-29 14:56 [PATCH libdrm] tests/amdgpu: add missing config.h include Emil Velikov
2018-01-29 15:20 ` Eric Engestrom
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.