From: Michal Hocko <mhocko@kernel.org>
To: "He, Roger" <Hongbo.He@amd.com>
Cc: "linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"Koenig, Christian" <Christian.Koenig@amd.com>
Subject: Re: [PATCH] mm/swap: add function get_total_swap_pages to expose total_swap_pages
Date: Tue, 30 Jan 2018 08:55:53 +0100 [thread overview]
Message-ID: <20180130075553.GM21609@dhcp22.suse.cz> (raw)
In-Reply-To: <MWHPR1201MB01278542F6EE848ABD187BDBFDE40@MWHPR1201MB0127.namprd12.prod.outlook.com>
On Tue 30-01-18 02:56:51, He, Roger wrote:
> Hi Michal:
>
> We need a API to tell TTM module the system totally has how many swap
> cache. Then TTM module can use it to restrict how many the swap cache
> it can use to prevent triggering OOM. For Now we set the threshold of
> swap size TTM used as 1/2 * total size and leave the rest for others
> use.
Why do you so much memory? Are you going to use TB of memory on large
systems? What about memory hotplug when the memory is added/released?
> But get_nr_swap_pages is the only API we can accessed from other
> module now. It can't cover the case of the dynamic swap size
> increment. I mean: user can use "swapon" to enable new swap file or
> swap disk dynamically or "swapoff" to disable swap space.
Exactly. Your scaling configuration based on get_nr_swap_pages or the
available memory simply sounds wrong.
--
Michal Hocko
SUSE Labs
WARNING: multiple messages have this Message-ID (diff)
From: Michal Hocko <mhocko@kernel.org>
To: "He, Roger" <Hongbo.He@amd.com>
Cc: "linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"Koenig, Christian" <Christian.Koenig@amd.com>
Subject: Re: [PATCH] mm/swap: add function get_total_swap_pages to expose total_swap_pages
Date: Tue, 30 Jan 2018 08:55:53 +0100 [thread overview]
Message-ID: <20180130075553.GM21609@dhcp22.suse.cz> (raw)
In-Reply-To: <MWHPR1201MB01278542F6EE848ABD187BDBFDE40@MWHPR1201MB0127.namprd12.prod.outlook.com>
On Tue 30-01-18 02:56:51, He, Roger wrote:
> Hi Michal:
>
> We need a API to tell TTM module the system totally has how many swap
> cache. Then TTM module can use it to restrict how many the swap cache
> it can use to prevent triggering OOM. For Now we set the threshold of
> swap size TTM used as 1/2 * total size and leave the rest for others
> use.
Why do you so much memory? Are you going to use TB of memory on large
systems? What about memory hotplug when the memory is added/released?
> But get_nr_swap_pages is the only API we can accessed from other
> module now. It can't cover the case of the dynamic swap size
> increment. I mean: user can use "swapon" to enable new swap file or
> swap disk dynamically or "swapoff" to disable swap space.
Exactly. Your scaling configuration based on get_nr_swap_pages or the
available memory simply sounds wrong.
--
Michal Hocko
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Michal Hocko <mhocko@kernel.org>
To: "He, Roger" <Hongbo.He@amd.com>
Cc: "linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"Koenig, Christian" <Christian.Koenig@amd.com>
Subject: Re: [PATCH] mm/swap: add function get_total_swap_pages to expose total_swap_pages
Date: Tue, 30 Jan 2018 08:55:53 +0100 [thread overview]
Message-ID: <20180130075553.GM21609@dhcp22.suse.cz> (raw)
In-Reply-To: <MWHPR1201MB01278542F6EE848ABD187BDBFDE40@MWHPR1201MB0127.namprd12.prod.outlook.com>
On Tue 30-01-18 02:56:51, He, Roger wrote:
> Hi Michal:
>
> We need a API to tell TTM module the system totally has how many swap
> cache. Then TTM module can use it to restrict how many the swap cache
> it can use to prevent triggering OOM. For Now we set the threshold of
> swap size TTM used as 1/2 * total size and leave the rest for others
> use.
Why do you so much memory? Are you going to use TB of memory on large
systems? What about memory hotplug when the memory is added/released?
> But get_nr_swap_pages is the only API we can accessed from other
> module now. It can't cover the case of the dynamic swap size
> increment. I mean: user can use "swapon" to enable new swap file or
> swap disk dynamically or "swapoff" to disable swap space.
Exactly. Your scaling configuration based on get_nr_swap_pages or the
available memory simply sounds wrong.
--
Michal Hocko
SUSE Labs
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2018-01-30 7:55 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-29 8:29 [PATCH] mm/swap: add function get_total_swap_pages to expose total_swap_pages Roger He
2018-01-29 8:29 ` Roger He
2018-01-29 8:29 ` Roger He
2018-01-29 16:31 ` Michal Hocko
2018-01-29 16:31 ` Michal Hocko
2018-01-29 16:31 ` Michal Hocko
2018-01-30 2:56 ` He, Roger
2018-01-30 2:56 ` He, Roger
2018-01-30 5:13 ` He, Roger
2018-01-30 7:55 ` Michal Hocko [this message]
2018-01-30 7:55 ` Michal Hocko
2018-01-30 7:55 ` Michal Hocko
2018-01-30 9:00 ` Christian König
2018-01-30 9:00 ` Christian König
2018-01-30 9:00 ` Christian König
2018-01-30 10:18 ` Michal Hocko
2018-01-30 10:18 ` Michal Hocko
2018-01-30 10:18 ` Michal Hocko
2018-01-30 10:32 ` Christian König
2018-01-30 10:32 ` Christian König
2018-01-30 10:32 ` Christian König
2018-01-30 12:28 ` Michal Hocko
2018-01-30 12:28 ` Michal Hocko
2018-01-30 12:28 ` Michal Hocko
2018-01-30 12:52 ` Christian König
2018-01-30 12:52 ` Christian König
2018-01-31 5:52 ` He, Roger
2018-01-31 5:52 ` He, Roger
2018-01-31 5:52 ` He, Roger
2018-02-01 6:13 ` He, Roger
2018-02-01 6:13 ` He, Roger
2018-02-01 8:15 ` Michal Hocko
2018-02-01 8:15 ` Michal Hocko
2018-01-31 7:15 ` Chunming Zhou
2018-01-31 7:15 ` Chunming Zhou
2018-01-31 7:15 ` Chunming Zhou
2018-01-31 8:08 ` He, Roger
2018-01-31 8:12 ` Christian König
2018-01-31 8:12 ` Christian König
2018-01-31 8:12 ` Christian König
2018-01-31 8:52 ` Chunming Zhou
2018-01-31 8:52 ` Chunming Zhou
2018-01-31 8:52 ` Chunming Zhou
2018-02-01 5:48 ` He, Roger
2018-02-01 5:48 ` He, Roger
2018-02-01 8:03 ` He, Roger
2018-02-02 6:57 ` He, Roger
2018-02-02 6:57 ` He, Roger
2018-02-02 7:46 ` Christian König
2018-02-02 7:46 ` Christian König
2018-02-02 7:46 ` Christian König
2018-02-02 7:54 ` He, Roger
2018-02-02 8:59 ` He, Roger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180130075553.GM21609@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=Christian.Koenig@amd.com \
--cc=Hongbo.He@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.