[PATCH 00/10] Remove empty help texts from Kconfig files

[PATCH 00/10] Remove empty help texts from Kconfig files

[Ulf Magnusson]

This is preparation for adding the warning in
https://lkml.org/lkml/2018/1/30/516 ("kconfig: Warn if help text is blank")

Empty help texts are probably either a typo, a Kconfig misunderstanding, or
some kind of half-committing to adding a help text (in which case a TODO
comment would be clearer, if the help text really can't be added right away).
Best to flag them, IMO.

Ulf Magnusson (10):
  net/sched: kconfig: Remove empty help texts
  video: fbdev: kconfig: Remove empty help text
  mmc: kconfig: Remove empty help text
  Staging: rtl8192u: kconfig: Remove empty help text
  Staging: rtl8192e: kconfig: Remove empty help text
  lib/Kconfig.debug: Remove empty help text
  MIPS: BCM63XX: kconfig: Remove empty help text
  MIPS: kconfig: Remove empty help text
  arm: vt8500: kconfig: Remove empty help text
  nios2: kconfig: Remove empty help text

 arch/arm/mach-vt8500/Kconfig              | 1 -
 arch/mips/Kconfig                         | 1 -
 arch/mips/bcm63xx/boards/Kconfig          | 1 -
 arch/nios2/Kconfig                        | 1 -
 drivers/mmc/host/Kconfig                  | 1 -
 drivers/staging/rtl8192e/rtl8192e/Kconfig | 1 -
 drivers/staging/rtl8192u/Kconfig          | 1 -
 drivers/video/fbdev/Kconfig               | 1 -
 lib/Kconfig.debug                         | 1 -
 net/sched/Kconfig                         | 3 ---
 10 files changed, 12 deletions(-)

-- 
2.14.1

[PATCH 01/10] net/sched: kconfig: Remove empty help texts

[Ulf Magnusson]

In preparation for adding a warning ("kconfig: Warn if help text is
blank"): https://lkml.org/lkml/2018/1/30/516

Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com>
---
 net/sched/Kconfig | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/net/sched/Kconfig b/net/sched/Kconfig
index c03d86a7775e..f24a6ae6819a 100644
--- a/net/sched/Kconfig
+++ b/net/sched/Kconfig
@@ -857,17 +857,14 @@ config NET_ACT_TUNNEL_KEY
 config NET_IFE_SKBMARK
         tristate "Support to encoding decoding skb mark on IFE action"
         depends on NET_ACT_IFE
-        ---help---
 
 config NET_IFE_SKBPRIO
         tristate "Support to encoding decoding skb prio on IFE action"
         depends on NET_ACT_IFE
-        ---help---
 
 config NET_IFE_SKBTCINDEX
         tristate "Support to encoding decoding skb tcindex on IFE action"
         depends on NET_ACT_IFE
-        ---help---
 
 config NET_CLS_IND
 	bool "Incoming device classification"
-- 
2.14.1

[PATCH 02/10] video: fbdev: kconfig: Remove empty help text

In preparation for adding a warning ("kconfig: Warn if help text is
blank"): https://lkml.org/lkml/2018/1/30/516

Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com>
---
 drivers/video/fbdev/Kconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig
index 6962b4583fd7..11e699f1062b 100644
--- a/drivers/video/fbdev/Kconfig
+++ b/drivers/video/fbdev/Kconfig
@@ -1156,7 +1156,6 @@ config FB_I810_I2C
 	bool "Enable DDC Support"
 	depends on FB_I810 && FB_I810_GTF
 	select FB_DDC
-	help
 
 config FB_LE80578
 	tristate "Intel LE80578 (Vermilion) support"
-- 
2.14.1

[PATCH 02/10] video: fbdev: kconfig: Remove empty help text

[Ulf Magnusson]

In preparation for adding a warning ("kconfig: Warn if help text is
blank"): https://lkml.org/lkml/2018/1/30/516

Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com>
---
 drivers/video/fbdev/Kconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig
index 6962b4583fd7..11e699f1062b 100644
--- a/drivers/video/fbdev/Kconfig
+++ b/drivers/video/fbdev/Kconfig
@@ -1156,7 +1156,6 @@ config FB_I810_I2C
 	bool "Enable DDC Support"
 	depends on FB_I810 && FB_I810_GTF
 	select FB_DDC
-	help
 
 config FB_LE80578
 	tristate "Intel LE80578 (Vermilion) support"
-- 
2.14.1

[PATCH 03/10] mmc: kconfig: Remove empty help text

[Ulf Magnusson]

In preparation for adding a warning ("kconfig: Warn if help text is
blank"): https://lkml.org/lkml/2018/1/30/516

Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com>
---
 drivers/mmc/host/Kconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
index 67bd3344dd03..24dee8eb5270 100644
--- a/drivers/mmc/host/Kconfig
+++ b/drivers/mmc/host/Kconfig
@@ -874,7 +874,6 @@ config MMC_CQHCI
 config MMC_TOSHIBA_PCI
 	tristate "Toshiba Type A SD/MMC Card Interface Driver"
 	depends on PCI
-	help
 
 config MMC_BCM2835
 	tristate "Broadcom BCM2835 SDHOST MMC Controller support"
-- 
2.14.1

[PATCH 04/10] Staging: rtl8192u: kconfig: Remove empty help text

[Ulf Magnusson]

In preparation for adding a warning ("kconfig: Warn if help text is
blank"): https://lkml.org/lkml/2018/1/30/516

Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com>
---
 drivers/staging/rtl8192u/Kconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/staging/rtl8192u/Kconfig b/drivers/staging/rtl8192u/Kconfig
index 3ee9d0d00fb6..97df6507a485 100644
--- a/drivers/staging/rtl8192u/Kconfig
+++ b/drivers/staging/rtl8192u/Kconfig
@@ -5,4 +5,3 @@ config RTL8192U
 	select WIRELESS_EXT
 	select WEXT_PRIV
 	select CRYPTO
-	---help---
-- 
2.14.1

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 04/10] Staging: rtl8192u: kconfig: Remove empty help text

[Ulf Magnusson]

In preparation for adding a warning ("kconfig: Warn if help text is
blank"): https://lkml.org/lkml/2018/1/30/516

Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com>
---
 drivers/staging/rtl8192u/Kconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/staging/rtl8192u/Kconfig b/drivers/staging/rtl8192u/Kconfig
index 3ee9d0d00fb6..97df6507a485 100644
--- a/drivers/staging/rtl8192u/Kconfig
+++ b/drivers/staging/rtl8192u/Kconfig
@@ -5,4 +5,3 @@ config RTL8192U
 	select WIRELESS_EXT
 	select WEXT_PRIV
 	select CRYPTO
-	---help---
-- 
2.14.1

[PATCH 05/10] Staging: rtl8192e: kconfig: Remove empty help text

[Ulf Magnusson]

In preparation for adding a warning ("kconfig: Warn if help text is
blank"): https://lkml.org/lkml/2018/1/30/516

Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com>
---
 drivers/staging/rtl8192e/rtl8192e/Kconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/staging/rtl8192e/rtl8192e/Kconfig b/drivers/staging/rtl8192e/rtl8192e/Kconfig
index 282e293da18f..7ac42a590e21 100644
--- a/drivers/staging/rtl8192e/rtl8192e/Kconfig
+++ b/drivers/staging/rtl8192e/rtl8192e/Kconfig
@@ -6,4 +6,3 @@ config RTL8192E
 	select WEXT_PRIV
 	select CRYPTO
 	select FW_LOADER
-	---help---
-- 
2.14.1

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 05/10] Staging: rtl8192e: kconfig: Remove empty help text

[Ulf Magnusson]

In preparation for adding a warning ("kconfig: Warn if help text is
blank"): https://lkml.org/lkml/2018/1/30/516

Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com>
---
 drivers/staging/rtl8192e/rtl8192e/Kconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/staging/rtl8192e/rtl8192e/Kconfig b/drivers/staging/rtl8192e/rtl8192e/Kconfig
index 282e293da18f..7ac42a590e21 100644
--- a/drivers/staging/rtl8192e/rtl8192e/Kconfig
+++ b/drivers/staging/rtl8192e/rtl8192e/Kconfig
@@ -6,4 +6,3 @@ config RTL8192E
 	select WEXT_PRIV
 	select CRYPTO
 	select FW_LOADER
-	---help---
-- 
2.14.1

[PATCH 06/10] lib/Kconfig.debug: Remove empty help text

[Ulf Magnusson]

In preparation for adding a warning ("kconfig: Warn if help text is
blank"): https://lkml.org/lkml/2018/1/30/516

Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com>
---
 lib/Kconfig.debug | 1 -
 1 file changed, 1 deletion(-)

diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
index b66c264d4194..6088408ef26c 100644
--- a/lib/Kconfig.debug
+++ b/lib/Kconfig.debug
@@ -351,7 +351,6 @@ config SECTION_MISMATCH_WARN_ONLY
 #
 config ARCH_WANT_FRAME_POINTERS
 	bool
-	help
 
 config FRAME_POINTER
 	bool "Compile the kernel with frame pointers"
-- 
2.14.1

[PATCH 07/10] MIPS: BCM63XX: kconfig: Remove empty help text

[Ulf Magnusson]

In preparation for adding a warning ("kconfig: Warn if help text is
blank"): https://lkml.org/lkml/2018/1/30/516

Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com>
---
 arch/mips/bcm63xx/boards/Kconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/mips/bcm63xx/boards/Kconfig b/arch/mips/bcm63xx/boards/Kconfig
index 6ff0a7481081..f60d96610ace 100644
--- a/arch/mips/bcm63xx/boards/Kconfig
+++ b/arch/mips/bcm63xx/boards/Kconfig
@@ -7,6 +7,5 @@ choice
 config BOARD_BCM963XX
        bool "Generic Broadcom 963xx boards"
 	select SSB
-       help
 
 endchoice
-- 
2.14.1

[PATCH 07/10] MIPS: BCM63XX: kconfig: Remove empty help text

[Ulf Magnusson]

In preparation for adding a warning ("kconfig: Warn if help text is
blank"): https://lkml.org/lkml/2018/1/30/516

Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com>
---
 arch/mips/bcm63xx/boards/Kconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/mips/bcm63xx/boards/Kconfig b/arch/mips/bcm63xx/boards/Kconfig
index 6ff0a7481081..f60d96610ace 100644
--- a/arch/mips/bcm63xx/boards/Kconfig
+++ b/arch/mips/bcm63xx/boards/Kconfig
@@ -7,6 +7,5 @@ choice
 config BOARD_BCM963XX
        bool "Generic Broadcom 963xx boards"
 	select SSB
-       help
 
 endchoice
-- 
2.14.1

[PATCH 08/10] MIPS: kconfig: Remove empty help text

[Ulf Magnusson]

In preparation for adding a warning ("kconfig: Warn if help text is
blank"): https://lkml.org/lkml/2018/1/30/516

Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com>
---
 arch/mips/Kconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
index ab98569994f0..57cd591e7b28 100644
--- a/arch/mips/Kconfig
+++ b/arch/mips/Kconfig
@@ -2326,7 +2326,6 @@ config MIPS_VPE_LOADER_TOM
 config MIPS_VPE_APSP_API
 	bool "Enable support for AP/SP API (RTLX)"
 	depends on MIPS_VPE_LOADER
-	help
 
 config MIPS_VPE_APSP_API_CMP
 	bool
-- 
2.14.1

[PATCH 09/10] arm: vt8500: kconfig: Remove empty help text

[Ulf Magnusson]

In preparation for adding a warning ("kconfig: Warn if help text is
blank"): https://lkml.org/lkml/2018/1/30/516

Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com>
---
 arch/arm/mach-vt8500/Kconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm/mach-vt8500/Kconfig b/arch/arm/mach-vt8500/Kconfig
index 1156a585dafc..8841199058ea 100644
--- a/arch/arm/mach-vt8500/Kconfig
+++ b/arch/arm/mach-vt8500/Kconfig
@@ -13,7 +13,6 @@ config ARCH_WM8505
  	depends on ARCH_MULTI_V5
  	select ARCH_VT8500
  	select CPU_ARM926T
- 	help
 
 config ARCH_WM8750
 	bool "WonderMedia WM8750"
-- 
2.14.1

[PATCH 09/10] arm: vt8500: kconfig: Remove empty help text

[Ulf Magnusson]

In preparation for adding a warning ("kconfig: Warn if help text is
blank"): https://lkml.org/lkml/2018/1/30/516

Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com>
---
 arch/arm/mach-vt8500/Kconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm/mach-vt8500/Kconfig b/arch/arm/mach-vt8500/Kconfig
index 1156a585dafc..8841199058ea 100644
--- a/arch/arm/mach-vt8500/Kconfig
+++ b/arch/arm/mach-vt8500/Kconfig
@@ -13,7 +13,6 @@ config ARCH_WM8505
  	depends on ARCH_MULTI_V5
  	select ARCH_VT8500
  	select CPU_ARM926T
- 	help
 
 config ARCH_WM8750
 	bool "WonderMedia WM8750"
-- 
2.14.1

[PATCH 10/10] nios2: kconfig: Remove empty help text

[Ulf Magnusson]

In preparation for adding a warning ("kconfig: Warn if help text is
blank"): https://lkml.org/lkml/2018/1/30/516

Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com>
---
 arch/nios2/Kconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/nios2/Kconfig b/arch/nios2/Kconfig
index 60fae03dac79..3d4ec88f1db1 100644
--- a/arch/nios2/Kconfig
+++ b/arch/nios2/Kconfig
@@ -152,7 +152,6 @@ menu "Advanced setup"
 
 config ADVANCED_OPTIONS
 	bool "Prompt for advanced kernel configuration options"
-	help
 
 comment "Default settings for advanced configuration options are used"
 	depends on !ADVANCED_OPTIONS
-- 
2.14.1

Re: [PATCH 05/10] Staging: rtl8192e: kconfig: Remove empty help text

[Dan Carpenter]

On Tue, Jan 30, 2018 at 08:05:27PM +0100, Ulf Magnusson wrote:
> In preparation for adding a warning ("kconfig: Warn if help text is
> blank"): https://lkml.org/lkml/2018/1/30/516
> 

Please don't start the boddy of the email in the middle of a sentence.

It looks like this:

https://marc.info/?l=linux-driver-devel&m=151733925532413&w=2

Notice how the subject is up above the From, Date, and Message-id email
headers?  It's totally disconnected from the body of the email.

regards,
dan carpenter

Re: [PATCH 05/10] Staging: rtl8192e: kconfig: Remove empty help text

[Ulf Magnusson]

On Wed, Jan 31, 2018 at 9:06 AM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> On Tue, Jan 30, 2018 at 08:05:27PM +0100, Ulf Magnusson wrote:
>> In preparation for adding a warning ("kconfig: Warn if help text is
>> blank"): https://lkml.org/lkml/2018/1/30/516
>>
>
> Please don't start the boddy of the email in the middle of a sentence.
>
> It looks like this:
>
> https://marc.info/?l=linux-driver-devel&m=151733925532413&w=2
>
> Notice how the subject is up above the From, Date, and Message-id email
> headers?  It's totally disconnected from the body of the email.
>
> regards,
> dan carpenter

The 'this is in...' was implied. I'll try to be less of a sloppy bastard.

Cheers,
Ulf
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 05/10] Staging: rtl8192e: kconfig: Remove empty help text

[Ulf Magnusson]

On Wed, Jan 31, 2018 at 9:06 AM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> On Tue, Jan 30, 2018 at 08:05:27PM +0100, Ulf Magnusson wrote:
>> In preparation for adding a warning ("kconfig: Warn if help text is
>> blank"): https://lkml.org/lkml/2018/1/30/516
>>
>
> Please don't start the boddy of the email in the middle of a sentence.
>
> It looks like this:
>
> https://marc.info/?l=linux-driver-devel&m=151733925532413&w=2
>
> Notice how the subject is up above the From, Date, and Message-id email
> headers?  It's totally disconnected from the body of the email.
>
> regards,
> dan carpenter

The 'this is in...' was implied. I'll try to be less of a sloppy bastard.

Cheers,
Ulf

Re: [PATCH 05/10] Staging: rtl8192e: kconfig: Remove empty help text

[Dan Carpenter]

On Wed, Jan 31, 2018 at 09:41:24AM +0100, Ulf Magnusson wrote:
> On Wed, Jan 31, 2018 at 9:06 AM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> > On Tue, Jan 30, 2018 at 08:05:27PM +0100, Ulf Magnusson wrote:
> >> In preparation for adding a warning ("kconfig: Warn if help text is
> >> blank"): https://lkml.org/lkml/2018/1/30/516
> >>
> >
> > Please don't start the boddy of the email in the middle of a sentence.
> >
> > It looks like this:
> >
> > https://marc.info/?l=linux-driver-devel&m=151733925532413&w=2
> >
> > Notice how the subject is up above the From, Date, and Message-id email
> > headers?  It's totally disconnected from the body of the email.
> >
> > regards,
> > dan carpenter
> 
> The 'this is in...' was implied. I'll try to be less of a sloppy bastard.
> 

I do feel that patch descriptions should say what the patch does as well
as why.  Right now the subject says what but I normally read either the
body or the subject but not both.

regards,
dan carpenter

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 05/10] Staging: rtl8192e: kconfig: Remove empty help text

[Dan Carpenter]

On Wed, Jan 31, 2018 at 09:41:24AM +0100, Ulf Magnusson wrote:
> On Wed, Jan 31, 2018 at 9:06 AM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> > On Tue, Jan 30, 2018 at 08:05:27PM +0100, Ulf Magnusson wrote:
> >> In preparation for adding a warning ("kconfig: Warn if help text is
> >> blank"): https://lkml.org/lkml/2018/1/30/516
> >>
> >
> > Please don't start the boddy of the email in the middle of a sentence.
> >
> > It looks like this:
> >
> > https://marc.info/?l=linux-driver-devel&m=151733925532413&w=2
> >
> > Notice how the subject is up above the From, Date, and Message-id email
> > headers?  It's totally disconnected from the body of the email.
> >
> > regards,
> > dan carpenter
> 
> The 'this is in...' was implied. I'll try to be less of a sloppy bastard.
> 

I do feel that patch descriptions should say what the patch does as well
as why.  Right now the subject says what but I normally read either the
body or the subject but not both.

regards,
dan carpenter

Re: [PATCH 05/10] Staging: rtl8192e: kconfig: Remove empty help text

[Ulf Magnusson]

On Wed, Jan 31, 2018 at 9:46 AM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> On Wed, Jan 31, 2018 at 09:41:24AM +0100, Ulf Magnusson wrote:
>> On Wed, Jan 31, 2018 at 9:06 AM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
>> > On Tue, Jan 30, 2018 at 08:05:27PM +0100, Ulf Magnusson wrote:
>> >> In preparation for adding a warning ("kconfig: Warn if help text is
>> >> blank"): https://lkml.org/lkml/2018/1/30/516
>> >>
>> >
>> > Please don't start the boddy of the email in the middle of a sentence.
>> >
>> > It looks like this:
>> >
>> > https://marc.info/?l=linux-driver-devel&m=151733925532413&w=2
>> >
>> > Notice how the subject is up above the From, Date, and Message-id email
>> > headers?  It's totally disconnected from the body of the email.
>> >
>> > regards,
>> > dan carpenter
>>
>> The 'this is in...' was implied. I'll try to be less of a sloppy bastard.
>>
>
> I do feel that patch descriptions should say what the patch does as well
> as why.  Right now the subject says what but I normally read either the
> body or the subject but not both.
>
> regards,
> dan carpenter
>

I fleshed out the individual commit messages and rolled a new
patchset, which adds the warning at the end:
https://lkml.org/lkml/2018/1/31/137

I wonder why that one doesn't display with proper threading on LKML.
It does show the entire thread once you click on one of the later
messages.

Cheers,
Ulf
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 05/10] Staging: rtl8192e: kconfig: Remove empty help text

[Ulf Magnusson]

On Wed, Jan 31, 2018 at 9:46 AM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> On Wed, Jan 31, 2018 at 09:41:24AM +0100, Ulf Magnusson wrote:
>> On Wed, Jan 31, 2018 at 9:06 AM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
>> > On Tue, Jan 30, 2018 at 08:05:27PM +0100, Ulf Magnusson wrote:
>> >> In preparation for adding a warning ("kconfig: Warn if help text is
>> >> blank"): https://lkml.org/lkml/2018/1/30/516
>> >>
>> >
>> > Please don't start the boddy of the email in the middle of a sentence.
>> >
>> > It looks like this:
>> >
>> > https://marc.info/?l=linux-driver-devel&m=151733925532413&w=2
>> >
>> > Notice how the subject is up above the From, Date, and Message-id email
>> > headers?  It's totally disconnected from the body of the email.
>> >
>> > regards,
>> > dan carpenter
>>
>> The 'this is in...' was implied. I'll try to be less of a sloppy bastard.
>>
>
> I do feel that patch descriptions should say what the patch does as well
> as why.  Right now the subject says what but I normally read either the
> body or the subject but not both.
>
> regards,
> dan carpenter
>

I fleshed out the individual commit messages and rolled a new
patchset, which adds the warning at the end:
https://lkml.org/lkml/2018/1/31/137

I wonder why that one doesn't display with proper threading on LKML.
It does show the entire thread once you click on one of the later
messages.

Cheers,
Ulf

Re: [PATCH 05/10] Staging: rtl8192e: kconfig: Remove empty help text

[Dan Carpenter]

On Wed, Jan 31, 2018 at 10:52:08AM +0100, Ulf Magnusson wrote:
> On Wed, Jan 31, 2018 at 9:46 AM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> > On Wed, Jan 31, 2018 at 09:41:24AM +0100, Ulf Magnusson wrote:
> >> On Wed, Jan 31, 2018 at 9:06 AM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> >> > On Tue, Jan 30, 2018 at 08:05:27PM +0100, Ulf Magnusson wrote:
> >> >> In preparation for adding a warning ("kconfig: Warn if help text is
> >> >> blank"): https://lkml.org/lkml/2018/1/30/516
> >> >>
> >> >
> >> > Please don't start the boddy of the email in the middle of a sentence.
> >> >
> >> > It looks like this:
> >> >
> >> > https://marc.info/?l=linux-driver-devel&m=151733925532413&w=2
> >> >
> >> > Notice how the subject is up above the From, Date, and Message-id email
> >> > headers?  It's totally disconnected from the body of the email.
> >> >
> >> > regards,
> >> > dan carpenter
> >>
> >> The 'this is in...' was implied. I'll try to be less of a sloppy bastard.
> >>
> >
> > I do feel that patch descriptions should say what the patch does as well
> > as why.  Right now the subject says what but I normally read either the
> > body or the subject but not both.
> >
> > regards,
> > dan carpenter
> >
> 
> I fleshed out the individual commit messages and rolled a new
> patchset, which adds the warning at the end:
> https://lkml.org/lkml/2018/1/31/137

Thanks!

regards,
dan carpenter

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 05/10] Staging: rtl8192e: kconfig: Remove empty help text

[Dan Carpenter]

On Wed, Jan 31, 2018 at 10:52:08AM +0100, Ulf Magnusson wrote:
> On Wed, Jan 31, 2018 at 9:46 AM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> > On Wed, Jan 31, 2018 at 09:41:24AM +0100, Ulf Magnusson wrote:
> >> On Wed, Jan 31, 2018 at 9:06 AM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> >> > On Tue, Jan 30, 2018 at 08:05:27PM +0100, Ulf Magnusson wrote:
> >> >> In preparation for adding a warning ("kconfig: Warn if help text is
> >> >> blank"): https://lkml.org/lkml/2018/1/30/516
> >> >>
> >> >
> >> > Please don't start the boddy of the email in the middle of a sentence.
> >> >
> >> > It looks like this:
> >> >
> >> > https://marc.info/?l=linux-driver-devel&m=151733925532413&w=2
> >> >
> >> > Notice how the subject is up above the From, Date, and Message-id email
> >> > headers?  It's totally disconnected from the body of the email.
> >> >
> >> > regards,
> >> > dan carpenter
> >>
> >> The 'this is in...' was implied. I'll try to be less of a sloppy bastard.
> >>
> >
> > I do feel that patch descriptions should say what the patch does as well
> > as why.  Right now the subject says what but I normally read either the
> > body or the subject but not both.
> >
> > regards,
> > dan carpenter
> >
> 
> I fleshed out the individual commit messages and rolled a new
> patchset, which adds the warning at the end:
> https://lkml.org/lkml/2018/1/31/137

Thanks!

regards,
dan carpenter

Re: [PATCH 01/10] net/sched: kconfig: Remove empty help texts

[David Miller]

From: Ulf Magnusson <ulfalizer@gmail.com>
Date: Tue, 30 Jan 2018 20:05:23 +0100

> In preparation for adding a warning ("kconfig: Warn if help text is
> blank"): https://lkml.org/lkml/2018/1/30/516
> 
> Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com>

Applied.

Re: [PATCH 01/10] net/sched: kconfig: Remove empty help texts

[Masahiro Yamada]

2018-02-01 0:32 GMT+09:00 David Miller <davem@davemloft.net>:
> From: Ulf Magnusson <ulfalizer@gmail.com>
> Date: Tue, 30 Jan 2018 20:05:23 +0100
>
>> In preparation for adding a warning ("kconfig: Warn if help text is
>> blank"): https://lkml.org/lkml/2018/1/30/516
>>
>> Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com>
>
> Applied.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html


I had applied the whole series into linux-kbuild.


Do you want to apply it to your tree?


-- 
Best Regards
Masahiro Yamada

Re: [PATCH 01/10] net/sched: kconfig: Remove empty help texts

[David Miller]

From: Masahiro Yamada <yamada.masahiro@socionext.com>
Date: Thu, 1 Feb 2018 00:37:27 +0900

> 2018-02-01 0:32 GMT+09:00 David Miller <davem@davemloft.net>:
>> From: Ulf Magnusson <ulfalizer@gmail.com>
>> Date: Tue, 30 Jan 2018 20:05:23 +0100
>>
>>> In preparation for adding a warning ("kconfig: Warn if help text is
>>> blank"): https://lkml.org/lkml/2018/1/30/516
>>>
>>> Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com>
>>
>> Applied.
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
> 
> I had applied the whole series into linux-kbuild.
> 
> 
> Do you want to apply it to your tree?

I already did :-)

It won't cause any problems for it to be in both of our trees so let's
just leave it this way.

Re: [PATCH 01/10] net/sched: kconfig: Remove empty help texts

[Ulf Magnusson]

On Wed, Jan 31, 2018 at 4:43 PM, David Miller <davem@davemloft.net> wrote:
> From: Masahiro Yamada <yamada.masahiro@socionext.com>
> Date: Thu, 1 Feb 2018 00:37:27 +0900
>
>> 2018-02-01 0:32 GMT+09:00 David Miller <davem@davemloft.net>:
>>> From: Ulf Magnusson <ulfalizer@gmail.com>
>>> Date: Tue, 30 Jan 2018 20:05:23 +0100
>>>
>>>> In preparation for adding a warning ("kconfig: Warn if help text is
>>>> blank"): https://lkml.org/lkml/2018/1/30/516
>>>>
>>>> Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com>
>>>
>>> Applied.
>>> --
>>> To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
>>> the body of a message to majordomo@vger.kernel.org
>>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>>
>>
>> I had applied the whole series into linux-kbuild.
>>
>>
>> Do you want to apply it to your tree?
>
> I already did :-)
>
> It won't cause any problems for it to be in both of our trees so let's
> just leave it this way.

Yeah, sorry about that mess. I had assumed this would require
coordination from more people. :)

Masahiro: Thanks for merging it so quickly!

Cheers,
Ulf