All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2 0/2] Add missing bt nodes
@ 2018-01-31  2:39 Joel Stanley
  2018-01-31  2:39 ` [PATCH v2 1/2] ARM: dts: aspeed: Add IPMI BT node Joel Stanley
  2018-01-31  2:39 ` [PATCH v2 2/2] ARM: dts: aspeed: Enable IPMI BT node on OpenPower machines Joel Stanley
  0 siblings, 2 replies; 6+ messages in thread
From: Joel Stanley @ 2018-01-31  2:39 UTC (permalink / raw)
  To: openbmc, andrew

Joel Stanley (2):
  ARM: dts: aspeed: Add IPMI BT node
  ARM: dts: aspeed: Enable IPMI BT node on OpenPower machines

 arch/arm/boot/dts/aspeed-bmc-opp-palmetto.dts    | 4 ++++
 arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts     | 4 ++++
 arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts | 4 ++++
 arch/arm/boot/dts/aspeed-bmc-opp-zaius.dts       | 4 ++++
 arch/arm/boot/dts/aspeed-g4.dtsi                 | 7 +++++++
 arch/arm/boot/dts/aspeed-g5.dtsi                 | 7 +++++++
 6 files changed, 30 insertions(+)

-- 
2.15.1

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH v2 1/2] ARM: dts: aspeed: Add IPMI BT node
  2018-01-31  2:39 [PATCH v2 0/2] Add missing bt nodes Joel Stanley
@ 2018-01-31  2:39 ` Joel Stanley
  2018-01-31  2:54   ` Joel Stanley
  2018-01-31  2:39 ` [PATCH v2 2/2] ARM: dts: aspeed: Enable IPMI BT node on OpenPower machines Joel Stanley
  1 sibling, 1 reply; 6+ messages in thread
From: Joel Stanley @ 2018-01-31  2:39 UTC (permalink / raw)
  To: openbmc, andrew

The IPMI BT device part of the LPC interface and is used for
communication with the host processor.

Signed-off-by: Joel Stanley <joel@jms.id.au>
---
v2:
 Fix bt reg node. It should be an offset from the lpc_host address,
 not the actual address of the iBT

 arch/arm/boot/dts/aspeed-g4.dtsi | 7 +++++++
 arch/arm/boot/dts/aspeed-g5.dtsi | 7 +++++++
 2 files changed, 14 insertions(+)

diff --git a/arch/arm/boot/dts/aspeed-g4.dtsi b/arch/arm/boot/dts/aspeed-g4.dtsi
index e6f4047142a8..7e0da0b8cd12 100644
--- a/arch/arm/boot/dts/aspeed-g4.dtsi
+++ b/arch/arm/boot/dts/aspeed-g4.dtsi
@@ -246,6 +246,13 @@
 						reg = <0x20 0x24 0x48 0x8>;
 					};
 
+					ibt: ibt@140 {
+						compatible = "aspeed,ast2400-ibt-bmc";
+						reg = <0xc0 0x18>;
+						interrupts = <8>;
+						status = "disabled";
+					};
+
 					mbox: mbox@180 {
 						compatible = "aspeed,ast2400-mbox";
 						reg = <0x180 0x5c>;
diff --git a/arch/arm/boot/dts/aspeed-g5.dtsi b/arch/arm/boot/dts/aspeed-g5.dtsi
index b7b42c7c89e1..f1b2fa204873 100644
--- a/arch/arm/boot/dts/aspeed-g5.dtsi
+++ b/arch/arm/boot/dts/aspeed-g5.dtsi
@@ -299,6 +299,13 @@
 						reg = <0x20 0x24 0x48 0x8>;
 					};
 
+					ibt: ibt@140 {
+						compatible = "aspeed,ast2500-ibt-bmc";
+						reg = <0xc0 0x18>;
+						interrupts = <8>;
+						status = "disabled";
+					};
+
 					mbox: mbox@180 {
 						compatible = "aspeed,ast2500-mbox";
 						reg = <0x180 0x5c>;
-- 
2.15.1

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH v2 2/2] ARM: dts: aspeed: Enable IPMI BT node on OpenPower machines
  2018-01-31  2:39 [PATCH v2 0/2] Add missing bt nodes Joel Stanley
  2018-01-31  2:39 ` [PATCH v2 1/2] ARM: dts: aspeed: Add IPMI BT node Joel Stanley
@ 2018-01-31  2:39 ` Joel Stanley
  2018-02-05  4:53   ` Joel Stanley
  1 sibling, 1 reply; 6+ messages in thread
From: Joel Stanley @ 2018-01-31  2:39 UTC (permalink / raw)
  To: openbmc, andrew

These BMC systems require this device to communicate with the host.

Signed-off-by: Joel Stanley <joel@jms.id.au>
---
 arch/arm/boot/dts/aspeed-bmc-opp-palmetto.dts    | 4 ++++
 arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts     | 4 ++++
 arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts | 4 ++++
 arch/arm/boot/dts/aspeed-bmc-opp-zaius.dts       | 4 ++++
 4 files changed, 16 insertions(+)

diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-palmetto.dts b/arch/arm/boot/dts/aspeed-bmc-opp-palmetto.dts
index c03c4274f910..e64df1c3b01a 100644
--- a/arch/arm/boot/dts/aspeed-bmc-opp-palmetto.dts
+++ b/arch/arm/boot/dts/aspeed-bmc-opp-palmetto.dts
@@ -114,3 +114,7 @@
 &vuart {
 	status = "okay";
 };
+
+&ibt {
+	status = "okay";
+};
diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts b/arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts
index 09dab179e154..4039381f9361 100644
--- a/arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts
+++ b/arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts
@@ -270,3 +270,7 @@
 		aspeed,fan-tach-ch = /bits/ 8 <0x0e>;
 	};
 };
+
+&ibt {
+	status = "okay";
+};
diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts b/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts
index b24ea9967fc8..5f8dbffa6b22 100644
--- a/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts
+++ b/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts
@@ -632,3 +632,7 @@
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_wdtrst1_default>;
 };
+
+&ibt {
+	status = "okay";
+};
diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-zaius.dts b/arch/arm/boot/dts/aspeed-bmc-opp-zaius.dts
index e7669d126df1..7f5a29566801 100644
--- a/arch/arm/boot/dts/aspeed-bmc-opp-zaius.dts
+++ b/arch/arm/boot/dts/aspeed-bmc-opp-zaius.dts
@@ -435,3 +435,7 @@
 		aspeed,fan-tach-ch = /bits/ 8 <0x03>;
 	};
 };
+
+&ibt {
+	status = "okay";
+};
-- 
2.15.1

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH v2 1/2] ARM: dts: aspeed: Add IPMI BT node
  2018-01-31  2:39 ` [PATCH v2 1/2] ARM: dts: aspeed: Add IPMI BT node Joel Stanley
@ 2018-01-31  2:54   ` Joel Stanley
  2018-02-05  4:54     ` Joel Stanley
  0 siblings, 1 reply; 6+ messages in thread
From: Joel Stanley @ 2018-01-31  2:54 UTC (permalink / raw)
  To: OpenBMC Maillist, Andrew Jeffery

On Wed, Jan 31, 2018 at 1:09 PM, Joel Stanley <joel@jms.id.au> wrote:
> The IPMI BT device part of the LPC interface and is used for
> communication with the host processor.
>
> Signed-off-by: Joel Stanley <joel@jms.id.au>
> ---
> v2:
>  Fix bt reg node. It should be an offset from the lpc_host address,
>  not the actual address of the iBT
>
>  arch/arm/boot/dts/aspeed-g4.dtsi | 7 +++++++
>  arch/arm/boot/dts/aspeed-g5.dtsi | 7 +++++++
>  2 files changed, 14 insertions(+)
>
> diff --git a/arch/arm/boot/dts/aspeed-g4.dtsi b/arch/arm/boot/dts/aspeed-g4.dtsi
> index e6f4047142a8..7e0da0b8cd12 100644
> --- a/arch/arm/boot/dts/aspeed-g4.dtsi
> +++ b/arch/arm/boot/dts/aspeed-g4.dtsi
> @@ -246,6 +246,13 @@
>                                                 reg = <0x20 0x24 0x48 0x8>;
>                                         };
>
> +                                       ibt: ibt@140 {
> +                                               compatible = "aspeed,ast2400-ibt-bmc";
> +                                               reg = <0xc0 0x18>;
> +                                               interrupts = <8>;
> +                                               status = "disabled";
> +                                       };
> +
>                                         mbox: mbox@180 {
>                                                 compatible = "aspeed,ast2400-mbox";
>                                                 reg = <0x180 0x5c>;
> diff --git a/arch/arm/boot/dts/aspeed-g5.dtsi b/arch/arm/boot/dts/aspeed-g5.dtsi
> index b7b42c7c89e1..f1b2fa204873 100644
> --- a/arch/arm/boot/dts/aspeed-g5.dtsi
> +++ b/arch/arm/boot/dts/aspeed-g5.dtsi
> @@ -299,6 +299,13 @@
>                                                 reg = <0x20 0x24 0x48 0x8>;
>                                         };
>
> +                                       ibt: ibt@140 {

I forgot to update the node name.

> +                                               compatible = "aspeed,ast2500-ibt-bmc";
> +                                               reg = <0xc0 0x18>;
> +                                               interrupts = <8>;
> +                                               status = "disabled";
> +                                       };
> +
>                                         mbox: mbox@180 {
>                                                 compatible = "aspeed,ast2500-mbox";
>                                                 reg = <0x180 0x5c>;
> --
> 2.15.1
>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v2 2/2] ARM: dts: aspeed: Enable IPMI BT node on OpenPower machines
  2018-01-31  2:39 ` [PATCH v2 2/2] ARM: dts: aspeed: Enable IPMI BT node on OpenPower machines Joel Stanley
@ 2018-02-05  4:53   ` Joel Stanley
  0 siblings, 0 replies; 6+ messages in thread
From: Joel Stanley @ 2018-02-05  4:53 UTC (permalink / raw)
  To: OpenBMC Maillist, Andrew Jeffery

On Wed, Jan 31, 2018 at 1:09 PM, Joel Stanley <joel@jms.id.au> wrote:
> These BMC systems require this device to communicate with the host.
>
> Signed-off-by: Joel Stanley <joel@jms.id.au>

Andrew did an over the shoulder review of this patch:

Acked-by: Andrew Jeffery <andrew@aj.id.au>


> ---
>  arch/arm/boot/dts/aspeed-bmc-opp-palmetto.dts    | 4 ++++
>  arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts     | 4 ++++
>  arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts | 4 ++++
>  arch/arm/boot/dts/aspeed-bmc-opp-zaius.dts       | 4 ++++
>  4 files changed, 16 insertions(+)
>
> diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-palmetto.dts b/arch/arm/boot/dts/aspeed-bmc-opp-palmetto.dts
> index c03c4274f910..e64df1c3b01a 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-opp-palmetto.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-opp-palmetto.dts
> @@ -114,3 +114,7 @@
>  &vuart {
>         status = "okay";
>  };
> +
> +&ibt {
> +       status = "okay";
> +};
> diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts b/arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts
> index 09dab179e154..4039381f9361 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts
> @@ -270,3 +270,7 @@
>                 aspeed,fan-tach-ch = /bits/ 8 <0x0e>;
>         };
>  };
> +
> +&ibt {
> +       status = "okay";
> +};
> diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts b/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts
> index b24ea9967fc8..5f8dbffa6b22 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts
> @@ -632,3 +632,7 @@
>         pinctrl-names = "default";
>         pinctrl-0 = <&pinctrl_wdtrst1_default>;
>  };
> +
> +&ibt {
> +       status = "okay";
> +};
> diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-zaius.dts b/arch/arm/boot/dts/aspeed-bmc-opp-zaius.dts
> index e7669d126df1..7f5a29566801 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-opp-zaius.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-opp-zaius.dts
> @@ -435,3 +435,7 @@
>                 aspeed,fan-tach-ch = /bits/ 8 <0x03>;
>         };
>  };
> +
> +&ibt {
> +       status = "okay";
> +};
> --
> 2.15.1
>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v2 1/2] ARM: dts: aspeed: Add IPMI BT node
  2018-01-31  2:54   ` Joel Stanley
@ 2018-02-05  4:54     ` Joel Stanley
  0 siblings, 0 replies; 6+ messages in thread
From: Joel Stanley @ 2018-02-05  4:54 UTC (permalink / raw)
  To: OpenBMC Maillist, Andrew Jeffery

On Wed, Jan 31, 2018 at 1:24 PM, Joel Stanley <joel@jms.id.au> wrote:
> On Wed, Jan 31, 2018 at 1:09 PM, Joel Stanley <joel@jms.id.au> wrote:
>> The IPMI BT device part of the LPC interface and is used for
>> communication with the host processor.
>>
>> Signed-off-by: Joel Stanley <joel@jms.id.au>
>> ---
>> v2:
>>  Fix bt reg node. It should be an offset from the lpc_host address,
>>  not the actual address of the iBT
>>
>>  arch/arm/boot/dts/aspeed-g4.dtsi | 7 +++++++
>>  arch/arm/boot/dts/aspeed-g5.dtsi | 7 +++++++
>>  2 files changed, 14 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/aspeed-g4.dtsi b/arch/arm/boot/dts/aspeed-g4.dtsi
>> index e6f4047142a8..7e0da0b8cd12 100644
>> --- a/arch/arm/boot/dts/aspeed-g4.dtsi
>> +++ b/arch/arm/boot/dts/aspeed-g4.dtsi
>> @@ -246,6 +246,13 @@
>>                                                 reg = <0x20 0x24 0x48 0x8>;
>>                                         };
>>
>> +                                       ibt: ibt@140 {
>> +                                               compatible = "aspeed,ast2400-ibt-bmc";
>> +                                               reg = <0xc0 0x18>;
>> +                                               interrupts = <8>;
>> +                                               status = "disabled";
>> +                                       };
>> +
>>                                         mbox: mbox@180 {
>>                                                 compatible = "aspeed,ast2400-mbox";
>>                                                 reg = <0x180 0x5c>;
>> diff --git a/arch/arm/boot/dts/aspeed-g5.dtsi b/arch/arm/boot/dts/aspeed-g5.dtsi
>> index b7b42c7c89e1..f1b2fa204873 100644
>> --- a/arch/arm/boot/dts/aspeed-g5.dtsi
>> +++ b/arch/arm/boot/dts/aspeed-g5.dtsi
>> @@ -299,6 +299,13 @@
>>                                                 reg = <0x20 0x24 0x48 0x8>;
>>                                         };
>>
>> +                                       ibt: ibt@140 {
>
> I forgot to update the node name.

Andrew did an over the shoulder review of this patch. He said that
with the node name fixed:


Acked-by: Andrew Jeffery <andrew@aj.id.au>

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2018-02-05  4:54 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-31  2:39 [PATCH v2 0/2] Add missing bt nodes Joel Stanley
2018-01-31  2:39 ` [PATCH v2 1/2] ARM: dts: aspeed: Add IPMI BT node Joel Stanley
2018-01-31  2:54   ` Joel Stanley
2018-02-05  4:54     ` Joel Stanley
2018-01-31  2:39 ` [PATCH v2 2/2] ARM: dts: aspeed: Enable IPMI BT node on OpenPower machines Joel Stanley
2018-02-05  4:53   ` Joel Stanley

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.