* [PATCH rdma-core] rc_pingpong: Fix getopt processing of -t
@ 2018-01-31 0:04 Jason Gunthorpe
[not found] ` <20180131000415.GA29879-uk2M96/98Pc@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Jason Gunthorpe @ 2018-01-31 0:04 UTC (permalink / raw)
To: linux-rdma-u79uwXL29TY76Z2rM5mHXA; +Cc: Yuval Shaia
The -t option never had an argument, a : was erroneously added when
the -c option was added
Fixes: 099c5aa50bc8 ("libibverb/examples: Add command line option to enable buffer validation")
Signed-off-by: Jason Gunthorpe <jgg-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
---
libibverbs/examples/rc_pingpong.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libibverbs/examples/rc_pingpong.c b/libibverbs/examples/rc_pingpong.c
index b5153bceb8254b..cf5c045741b7be 100644
--- a/libibverbs/examples/rc_pingpong.c
+++ b/libibverbs/examples/rc_pingpong.c
@@ -730,7 +730,7 @@ int main(int argc, char *argv[])
{}
};
- c = getopt_long(argc, argv, "p:d:i:s:m:r:n:l:eg:ot:c",
+ c = getopt_long(argc, argv, "p:d:i:s:m:r:n:l:eg:otc",
long_options, NULL);
if (c == -1)
--
2.15.1
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH rdma-core] rc_pingpong: Fix getopt processing of -t
[not found] ` <20180131000415.GA29879-uk2M96/98Pc@public.gmane.org>
@ 2018-01-31 5:58 ` Leon Romanovsky
2018-01-31 7:17 ` Yuval Shaia
1 sibling, 0 replies; 3+ messages in thread
From: Leon Romanovsky @ 2018-01-31 5:58 UTC (permalink / raw)
To: Jason Gunthorpe; +Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA, Yuval Shaia
[-- Attachment #1: Type: text/plain, Size: 459 bytes --]
On Tue, Jan 30, 2018 at 05:04:15PM -0700, Jason Gunthorpe wrote:
> The -t option never had an argument, a : was erroneously added when
> the -c option was added
>
> Fixes: 099c5aa50bc8 ("libibverb/examples: Add command line option to enable buffer validation")
> Signed-off-by: Jason Gunthorpe <jgg-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> ---
> libibverbs/examples/rc_pingpong.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Thanks, applied.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH rdma-core] rc_pingpong: Fix getopt processing of -t
[not found] ` <20180131000415.GA29879-uk2M96/98Pc@public.gmane.org>
2018-01-31 5:58 ` Leon Romanovsky
@ 2018-01-31 7:17 ` Yuval Shaia
1 sibling, 0 replies; 3+ messages in thread
From: Yuval Shaia @ 2018-01-31 7:17 UTC (permalink / raw)
To: Jason Gunthorpe; +Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA
On Tue, Jan 30, 2018 at 05:04:15PM -0700, Jason Gunthorpe wrote:
> The -t option never had an argument, a : was erroneously added when
> the -c option was added
Thanks,
Now i've learned how to add arguments so can implement Ram's idea :)
Sorry for that.
Reviewed-by: Yuval Shaia <yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
>
> Fixes: 099c5aa50bc8 ("libibverb/examples: Add command line option to enable buffer validation")
> Signed-off-by: Jason Gunthorpe <jgg-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> ---
> libibverbs/examples/rc_pingpong.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libibverbs/examples/rc_pingpong.c b/libibverbs/examples/rc_pingpong.c
> index b5153bceb8254b..cf5c045741b7be 100644
> --- a/libibverbs/examples/rc_pingpong.c
> +++ b/libibverbs/examples/rc_pingpong.c
> @@ -730,7 +730,7 @@ int main(int argc, char *argv[])
> {}
> };
>
> - c = getopt_long(argc, argv, "p:d:i:s:m:r:n:l:eg:ot:c",
> + c = getopt_long(argc, argv, "p:d:i:s:m:r:n:l:eg:otc",
> long_options, NULL);
>
> if (c == -1)
> --
> 2.15.1
>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-01-31 7:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-31 0:04 [PATCH rdma-core] rc_pingpong: Fix getopt processing of -t Jason Gunthorpe
[not found] ` <20180131000415.GA29879-uk2M96/98Pc@public.gmane.org>
2018-01-31 5:58 ` Leon Romanovsky
2018-01-31 7:17 ` Yuval Shaia
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.