* [PATCH 0/3] checks: failure message improvements
@ 2018-01-31 14:57 Rob Herring
[not found] ` <20180131145705.21335-1-robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
0 siblings, 1 reply; 6+ messages in thread
From: Rob Herring @ 2018-01-31 14:57 UTC (permalink / raw)
To: David Gibson; +Cc: Julia Lawall, devicetree-compiler-u79uwXL29TY76Z2rM5mHXA
This series standardizes how node paths and property names are printed
in failure messages and switches to using source file and line numbers
for failure messages.
The first 2 patches can apply to master. The 3rd is dependent on Julia's
source annotation series.
Rob
Rob Herring (3):
checks: centralize printing of node path in check_msg
checks: centralize printing of property names in failure messages
checks: Use source position information for check failures
checks.c | 276 +++++++++++++++++++++++++++++++--------------------------------
1 file changed, 136 insertions(+), 140 deletions(-)
--
2.14.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/3] checks: centralize printing of node path in check_msg
[not found] ` <20180131145705.21335-1-robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
@ 2018-01-31 14:57 ` Rob Herring
[not found] ` <20180131145705.21335-2-robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2018-01-31 14:57 ` [PATCH 2/3] checks: centralize printing of property names in failure messages Rob Herring
2018-01-31 14:57 ` [PATCH 3/3] checks: Use source position information for check failures Rob Herring
2 siblings, 1 reply; 6+ messages in thread
From: Rob Herring @ 2018-01-31 14:57 UTC (permalink / raw)
To: David Gibson; +Cc: Julia Lawall, devicetree-compiler-u79uwXL29TY76Z2rM5mHXA
Most error/warning messages print the node path as part of their error
message. Move printing of the node path into check_msg() so the
formatting can be standardized to the form:
<output file>: (ERROR|warning) (<check name>): <full node name>: <check message>
Signed-off-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
---
checks.c | 232 ++++++++++++++++++++++++++++-----------------------------------
1 file changed, 104 insertions(+), 128 deletions(-)
diff --git a/checks.c b/checks.c
index 1cded3658491..54df014c1c79 100644
--- a/checks.c
+++ b/checks.c
@@ -72,7 +72,8 @@ struct check {
#define CHECK(nm_, fn_, d_, ...) \
CHECK_ENTRY(nm_, fn_, d_, false, false, __VA_ARGS__)
-static inline void PRINTF(3, 4) check_msg(struct check *c, struct dt_info *dti,
+static inline void PRINTF(4, 5) check_msg(struct check *c, struct dt_info *dti,
+ struct node *node,
const char *fmt, ...)
{
va_list ap;
@@ -83,17 +84,19 @@ static inline void PRINTF(3, 4) check_msg(struct check *c, struct dt_info *dti,
fprintf(stderr, "%s: %s (%s): ",
strcmp(dti->outname, "-") ? dti->outname : "<stdout>",
(c->error) ? "ERROR" : "Warning", c->name);
+ if (node)
+ fprintf(stderr, "%s: ", node->fullpath);
vfprintf(stderr, fmt, ap);
fprintf(stderr, "\n");
}
va_end(ap);
}
-#define FAIL(c, dti, ...) \
+#define FAIL(c, dti, node, ...) \
do { \
TRACE((c), "\t\tFAILED at %s:%d", __FILE__, __LINE__); \
(c)->status = FAILED; \
- check_msg((c), dti, __VA_ARGS__); \
+ check_msg((c), dti, node, __VA_ARGS__); \
} while (0)
static void check_nodes_props(struct check *c, struct dt_info *dti, struct node *node)
@@ -126,7 +129,7 @@ static bool run_check(struct check *c, struct dt_info *dti)
error = error || run_check(prq, dti);
if (prq->status != PASSED) {
c->status = PREREQ;
- check_msg(c, dti, "Failed prerequisite '%s'",
+ check_msg(c, dti, NULL, "Failed prerequisite '%s'",
c->prereq[i]->name);
}
}
@@ -156,7 +159,7 @@ out:
static inline void check_always_fail(struct check *c, struct dt_info *dti,
struct node *node)
{
- FAIL(c, dti, "always_fail check");
+ FAIL(c, dti, node, "always_fail check");
}
CHECK(always_fail, check_always_fail, NULL);
@@ -171,8 +174,7 @@ static void check_is_string(struct check *c, struct dt_info *dti,
return; /* Not present, assumed ok */
if (!data_is_one_string(prop->val))
- FAIL(c, dti, "\"%s\" property in %s is not a string",
- propname, node->fullpath);
+ FAIL(c, dti, node, "\"%s\" property is not a string", propname);
}
#define WARNING_IF_NOT_STRING(nm, propname) \
WARNING(nm, check_is_string, (propname))
@@ -196,8 +198,8 @@ static void check_is_string_list(struct check *c, struct dt_info *dti,
while (rem > 0) {
l = strnlen(str, rem);
if (l == rem) {
- FAIL(c, dti, "\"%s\" property in %s is not a string list",
- propname, node->fullpath);
+ FAIL(c, dti, node, "\"%s\" property is not a string list",
+ propname);
break;
}
rem -= l + 1;
@@ -220,8 +222,8 @@ static void check_is_cell(struct check *c, struct dt_info *dti,
return; /* Not present, assumed ok */
if (prop->val.len != sizeof(cell_t))
- FAIL(c, dti, "\"%s\" property in %s is not a single cell",
- propname, node->fullpath);
+ FAIL(c, dti, node, "\"%s\" property is not a single cell",
+ propname);
}
#define WARNING_IF_NOT_CELL(nm, propname) \
WARNING(nm, check_is_cell, (propname))
@@ -242,8 +244,7 @@ static void check_duplicate_node_names(struct check *c, struct dt_info *dti,
child2;
child2 = child2->next_sibling)
if (streq(child->name, child2->name))
- FAIL(c, dti, "Duplicate node name %s",
- child->fullpath);
+ FAIL(c, dti, node, "Duplicate node name");
}
ERROR(duplicate_node_names, check_duplicate_node_names, NULL);
@@ -257,8 +258,8 @@ static void check_duplicate_property_names(struct check *c, struct dt_info *dti,
if (prop2->deleted)
continue;
if (streq(prop->name, prop2->name))
- FAIL(c, dti, "Duplicate property name %s in %s",
- prop->name, node->fullpath);
+ FAIL(c, dti, node, "Duplicate property name %s",
+ prop->name);
}
}
}
@@ -276,8 +277,8 @@ static void check_node_name_chars(struct check *c, struct dt_info *dti,
int n = strspn(node->name, c->data);
if (n < strlen(node->name))
- FAIL(c, dti, "Bad character '%c' in node %s",
- node->name[n], node->fullpath);
+ FAIL(c, dti, node, "Bad character '%c' in node name",
+ node->name[n]);
}
ERROR(node_name_chars, check_node_name_chars, PROPNODECHARS "@");
@@ -287,8 +288,8 @@ static void check_node_name_chars_strict(struct check *c, struct dt_info *dti,
int n = strspn(node->name, c->data);
if (n < node->basenamelen)
- FAIL(c, dti, "Character '%c' not recommended in node %s",
- node->name[n], node->fullpath);
+ FAIL(c, dti, node, "Character '%c' not recommended in node name",
+ node->name[n]);
}
CHECK(node_name_chars_strict, check_node_name_chars_strict, PROPNODECHARSSTRICT);
@@ -296,8 +297,7 @@ static void check_node_name_format(struct check *c, struct dt_info *dti,
struct node *node)
{
if (strchr(get_unitname(node), '@'))
- FAIL(c, dti, "Node %s has multiple '@' characters in name",
- node->fullpath);
+ FAIL(c, dti, node, "multiple '@' characters in node name");
}
ERROR(node_name_format, check_node_name_format, NULL, &node_name_chars);
@@ -315,12 +315,10 @@ static void check_unit_address_vs_reg(struct check *c, struct dt_info *dti,
if (prop) {
if (!unitname[0])
- FAIL(c, dti, "Node %s has a reg or ranges property, but no unit name",
- node->fullpath);
+ FAIL(c, dti, node, "node has a reg or ranges property, but no unit name");
} else {
if (unitname[0])
- FAIL(c, dti, "Node %s has a unit name, but no reg property",
- node->fullpath);
+ FAIL(c, dti, node, "node has a unit name, but no reg property");
}
}
WARNING(unit_address_vs_reg, check_unit_address_vs_reg, NULL);
@@ -334,8 +332,8 @@ static void check_property_name_chars(struct check *c, struct dt_info *dti,
int n = strspn(prop->name, c->data);
if (n < strlen(prop->name))
- FAIL(c, dti, "Bad character '%c' in property name \"%s\", node %s",
- prop->name[n], prop->name, node->fullpath);
+ FAIL(c, dti, node, "Bad character '%c' in property name \"%s\"",
+ prop->name[n], prop->name);
}
}
ERROR(property_name_chars, check_property_name_chars, PROPNODECHARS);
@@ -366,8 +364,8 @@ static void check_property_name_chars_strict(struct check *c,
n = strspn(name, c->data);
}
if (n < strlen(name))
- FAIL(c, dti, "Character '%c' not recommended in property name \"%s\", node %s",
- name[n], prop->name, node->fullpath);
+ FAIL(c, dti, node, "Character '%c' not recommended in property name \"%s\"",
+ name[n], prop->name);
}
}
CHECK(property_name_chars_strict, check_property_name_chars_strict, PROPNODECHARSSTRICT);
@@ -400,7 +398,7 @@ static void check_duplicate_label(struct check *c, struct dt_info *dti,
return;
if ((othernode != node) || (otherprop != prop) || (othermark != mark))
- FAIL(c, dti, "Duplicate label '%s' on " DESCLABEL_FMT
+ FAIL(c, dti, node, "Duplicate label '%s' on " DESCLABEL_FMT
" and " DESCLABEL_FMT,
label, DESCLABEL_ARGS(node, prop, mark),
DESCLABEL_ARGS(othernode, otherprop, othermark));
@@ -440,8 +438,8 @@ static cell_t check_phandle_prop(struct check *c, struct dt_info *dti,
return 0;
if (prop->val.len != sizeof(cell_t)) {
- FAIL(c, dti, "%s has bad length (%d) %s property",
- node->fullpath, prop->val.len, prop->name);
+ FAIL(c, dti, node, "bad length (%d) %s property",
+ prop->val.len, prop->name);
return 0;
}
@@ -452,8 +450,8 @@ static cell_t check_phandle_prop(struct check *c, struct dt_info *dti,
/* "Set this node's phandle equal to some
* other node's phandle". That's nonsensical
* by construction. */ {
- FAIL(c, dti, "%s in %s is a reference to another node",
- prop->name, node->fullpath);
+ FAIL(c, dti, node, "%s is a reference to another node",
+ prop->name);
}
/* But setting this node's phandle equal to its own
* phandle is allowed - that means allocate a unique
@@ -466,8 +464,8 @@ static cell_t check_phandle_prop(struct check *c, struct dt_info *dti,
phandle = propval_cell(prop);
if ((phandle == 0) || (phandle == -1)) {
- FAIL(c, dti, "%s has bad value (0x%x) in %s property",
- node->fullpath, phandle, prop->name);
+ FAIL(c, dti, node, "bad value (0x%x) in %s property",
+ phandle, prop->name);
return 0;
}
@@ -493,16 +491,16 @@ static void check_explicit_phandles(struct check *c, struct dt_info *dti,
return;
if (linux_phandle && phandle && (phandle != linux_phandle))
- FAIL(c, dti, "%s has mismatching 'phandle' and 'linux,phandle'"
- " properties", node->fullpath);
+ FAIL(c, dti, node, "mismatching 'phandle' and 'linux,phandle'"
+ " properties");
if (linux_phandle && !phandle)
phandle = linux_phandle;
other = get_node_by_phandle(root, phandle);
if (other && (other != node)) {
- FAIL(c, dti, "%s has duplicated phandle 0x%x (seen before at %s)",
- node->fullpath, phandle, other->fullpath);
+ FAIL(c, dti, node, "duplicated phandle 0x%x (seen before at %s)",
+ phandle, other->fullpath);
return;
}
@@ -526,8 +524,8 @@ static void check_name_properties(struct check *c, struct dt_info *dti,
if ((prop->val.len != node->basenamelen+1)
|| (memcmp(prop->val.val, node->name, node->basenamelen) != 0)) {
- FAIL(c, dti, "\"name\" property in %s is incorrect (\"%s\" instead"
- " of base node name)", node->fullpath, prop->val.val);
+ FAIL(c, dti, node, "\"name\" property is incorrect (\"%s\" instead"
+ " of base node name)", prop->val.val);
} else {
/* The name property is correct, and therefore redundant.
* Delete it */
@@ -561,7 +559,7 @@ static void fixup_phandle_references(struct check *c, struct dt_info *dti,
refnode = get_node_by_ref(dt, m->ref);
if (! refnode) {
if (!(dti->dtsflags & DTSF_PLUGIN))
- FAIL(c, dti, "Reference to non-existent node or "
+ FAIL(c, dti, node, "Reference to non-existent node or "
"label \"%s\"\n", m->ref);
else /* mark the entry as unresolved */
*((fdt32_t *)(prop->val.val + m->offset)) =
@@ -593,7 +591,7 @@ static void fixup_path_references(struct check *c, struct dt_info *dti,
refnode = get_node_by_ref(dt, m->ref);
if (!refnode) {
- FAIL(c, dti, "Reference to non-existent node or label \"%s\"\n",
+ FAIL(c, dti, node, "Reference to non-existent node or label \"%s\"\n",
m->ref);
continue;
}
@@ -646,12 +644,12 @@ static void check_alias_paths(struct check *c, struct dt_info *dti,
for_each_property(node, prop) {
if (!prop->val.val || !get_node_by_path(dti->dt, prop->val.val)) {
- FAIL(c, dti, "aliases property '%s' is not a valid node (%s)",
+ FAIL(c, dti, node, "aliases property '%s' is not a valid node (%s)",
prop->name, prop->val.val);
continue;
}
if (strspn(prop->name, LOWERCASE DIGITS "-") != strlen(prop->name))
- FAIL(c, dti, "aliases property name '%s' is not valid",
+ FAIL(c, dti, node, "aliases property name '%s' is not valid",
prop->name);
}
@@ -693,21 +691,21 @@ static void check_reg_format(struct check *c, struct dt_info *dti,
return; /* No "reg", that's fine */
if (!node->parent) {
- FAIL(c, dti, "Root node has a \"reg\" property");
+ FAIL(c, dti, node, "Root node has a \"reg\" property");
return;
}
if (prop->val.len == 0)
- FAIL(c, dti, "\"reg\" property in %s is empty", node->fullpath);
+ FAIL(c, dti, node, "\"reg\" property is empty");
addr_cells = node_addr_cells(node->parent);
size_cells = node_size_cells(node->parent);
entrylen = (addr_cells + size_cells) * sizeof(cell_t);
if (!entrylen || (prop->val.len % entrylen) != 0)
- FAIL(c, dti, "\"reg\" property in %s has invalid length (%d bytes) "
+ FAIL(c, dti, node, "\"reg\" property has invalid length (%d bytes) "
"(#address-cells == %d, #size-cells == %d)",
- node->fullpath, prop->val.len, addr_cells, size_cells);
+ prop->val.len, addr_cells, size_cells);
}
WARNING(reg_format, check_reg_format, NULL, &addr_size_cells);
@@ -722,7 +720,7 @@ static void check_ranges_format(struct check *c, struct dt_info *dti,
return;
if (!node->parent) {
- FAIL(c, dti, "Root node has a \"ranges\" property");
+ FAIL(c, dti, node, "Root node has a \"ranges\" property");
return;
}
@@ -734,19 +732,19 @@ static void check_ranges_format(struct check *c, struct dt_info *dti,
if (prop->val.len == 0) {
if (p_addr_cells != c_addr_cells)
- FAIL(c, dti, "%s has empty \"ranges\" property but its "
+ FAIL(c, dti, node, "empty \"ranges\" property but its "
"#address-cells (%d) differs from %s (%d)",
- node->fullpath, c_addr_cells, node->parent->fullpath,
+ c_addr_cells, node->parent->fullpath,
p_addr_cells);
if (p_size_cells != c_size_cells)
- FAIL(c, dti, "%s has empty \"ranges\" property but its "
+ FAIL(c, dti, node, "empty \"ranges\" property but its "
"#size-cells (%d) differs from %s (%d)",
- node->fullpath, c_size_cells, node->parent->fullpath,
+ c_size_cells, node->parent->fullpath,
p_size_cells);
} else if ((prop->val.len % entrylen) != 0) {
- FAIL(c, dti, "\"ranges\" property in %s has invalid length (%d bytes) "
+ FAIL(c, dti, node, "\"ranges\" property has invalid length (%d bytes) "
"(parent #address-cells == %d, child #address-cells == %d, "
- "#size-cells == %d)", node->fullpath, prop->val.len,
+ "#size-cells == %d)", prop->val.len,
p_addr_cells, c_addr_cells, c_size_cells);
}
}
@@ -769,39 +767,31 @@ static void check_pci_bridge(struct check *c, struct dt_info *dti, struct node *
if (!strprefixeq(node->name, node->basenamelen, "pci") &&
!strprefixeq(node->name, node->basenamelen, "pcie"))
- FAIL(c, dti, "Node %s node name is not \"pci\" or \"pcie\"",
- node->fullpath);
+ FAIL(c, dti, node, "node name is not \"pci\" or \"pcie\"");
prop = get_property(node, "ranges");
if (!prop)
- FAIL(c, dti, "Node %s missing ranges for PCI bridge (or not a bridge)",
- node->fullpath);
+ FAIL(c, dti, node, "missing ranges for PCI bridge (or not a bridge)");
if (node_addr_cells(node) != 3)
- FAIL(c, dti, "Node %s incorrect #address-cells for PCI bridge",
- node->fullpath);
+ FAIL(c, dti, node, "incorrect #address-cells for PCI bridge");
if (node_size_cells(node) != 2)
- FAIL(c, dti, "Node %s incorrect #size-cells for PCI bridge",
- node->fullpath);
+ FAIL(c, dti, node, "incorrect #size-cells for PCI bridge");
prop = get_property(node, "bus-range");
if (!prop) {
- FAIL(c, dti, "Node %s missing bus-range for PCI bridge",
- node->fullpath);
+ FAIL(c, dti, node, "missing bus-range for PCI bridge");
return;
}
if (prop->val.len != (sizeof(cell_t) * 2)) {
- FAIL(c, dti, "Node %s bus-range must be 2 cells",
- node->fullpath);
+ FAIL(c, dti, node, "bus-range must be 2 cells");
return;
}
cells = (cell_t *)prop->val.val;
if (fdt32_to_cpu(cells[0]) > fdt32_to_cpu(cells[1]))
- FAIL(c, dti, "Node %s bus-range 1st cell must be less than or equal to 2nd cell",
- node->fullpath);
+ FAIL(c, dti, node, "bus-range 1st cell must be less than or equal to 2nd cell");
if (fdt32_to_cpu(cells[1]) > 0xff)
- FAIL(c, dti, "Node %s bus-range maximum bus number must be less than 256",
- node->fullpath);
+ FAIL(c, dti, node, "bus-range maximum bus number must be less than 256");
}
WARNING(pci_bridge, check_pci_bridge, NULL,
&device_type_is_string, &addr_size_cells);
@@ -831,8 +821,8 @@ static void check_pci_device_bus_num(struct check *c, struct dt_info *dti, struc
max_bus = fdt32_to_cpu(cells[0]);
}
if ((bus_num < min_bus) || (bus_num > max_bus))
- FAIL(c, dti, "Node %s PCI bus number %d out of range, expected (%d - %d)",
- node->fullpath, bus_num, min_bus, max_bus);
+ FAIL(c, dti, node, "PCI bus number %d out of range, expected (%d - %d)",
+ bus_num, min_bus, max_bus);
}
WARNING(pci_device_bus_num, check_pci_device_bus_num, NULL, ®_format, &pci_bridge);
@@ -849,25 +839,22 @@ static void check_pci_device_reg(struct check *c, struct dt_info *dti, struct no
prop = get_property(node, "reg");
if (!prop) {
- FAIL(c, dti, "Node %s missing PCI reg property", node->fullpath);
+ FAIL(c, dti, node, "missing PCI reg property");
return;
}
cells = (cell_t *)prop->val.val;
if (cells[1] || cells[2])
- FAIL(c, dti, "Node %s PCI reg config space address cells 2 and 3 must be 0",
- node->fullpath);
+ FAIL(c, dti, node, "PCI reg config space address cells 2 and 3 must be 0");
reg = fdt32_to_cpu(cells[0]);
dev = (reg & 0xf800) >> 11;
func = (reg & 0x700) >> 8;
if (reg & 0xff000000)
- FAIL(c, dti, "Node %s PCI reg address is not configuration space",
- node->fullpath);
+ FAIL(c, dti, node, "PCI reg address is not configuration space");
if (reg & 0x000000ff)
- FAIL(c, dti, "Node %s PCI reg config space address register number must be 0",
- node->fullpath);
+ FAIL(c, dti, node, "PCI reg config space address register number must be 0");
if (func == 0) {
snprintf(unit_addr, sizeof(unit_addr), "%x", dev);
@@ -879,8 +866,8 @@ static void check_pci_device_reg(struct check *c, struct dt_info *dti, struct no
if (streq(unitname, unit_addr))
return;
- FAIL(c, dti, "Node %s PCI unit address format error, expected \"%s\"",
- node->fullpath, unit_addr);
+ FAIL(c, dti, node, "PCI unit address format error, expected \"%s\"",
+ unit_addr);
}
WARNING(pci_device_reg, check_pci_device_reg, NULL, ®_format, &pci_bridge);
@@ -936,7 +923,7 @@ static void check_simple_bus_reg(struct check *c, struct dt_info *dti, struct no
if (!cells) {
if (node->parent->parent && !(node->bus == &simple_bus))
- FAIL(c, dti, "Node %s missing or empty reg/ranges property", node->fullpath);
+ FAIL(c, dti, node, "missing or empty reg/ranges property");
return;
}
@@ -946,8 +933,8 @@ static void check_simple_bus_reg(struct check *c, struct dt_info *dti, struct no
snprintf(unit_addr, sizeof(unit_addr), "%"PRIx64, reg);
if (!streq(unitname, unit_addr))
- FAIL(c, dti, "Node %s simple-bus unit address format error, expected \"%s\"",
- node->fullpath, unit_addr);
+ FAIL(c, dti, node, "simple-bus unit address format error, expected \"%s\"",
+ unit_addr);
}
WARNING(simple_bus_reg, check_simple_bus_reg, NULL, ®_format, &simple_bus_bridge);
@@ -963,14 +950,12 @@ static void check_unit_address_format(struct check *c, struct dt_info *dti,
return;
if (!strncmp(unitname, "0x", 2)) {
- FAIL(c, dti, "Node %s unit name should not have leading \"0x\"",
- node->fullpath);
+ FAIL(c, dti, node, "unit name should not have leading \"0x\"");
/* skip over 0x for next test */
unitname += 2;
}
if (unitname[0] == '0' && isxdigit(unitname[1]))
- FAIL(c, dti, "Node %s unit name should not have leading 0s",
- node->fullpath);
+ FAIL(c, dti, node, "unit name should not have leading 0s");
}
WARNING(unit_address_format, check_unit_address_format, NULL,
&node_name_format, &pci_bridge, &simple_bus_bridge);
@@ -993,12 +978,10 @@ static void check_avoid_default_addr_size(struct check *c, struct dt_info *dti,
return;
if (node->parent->addr_cells == -1)
- FAIL(c, dti, "Relying on default #address-cells value for %s",
- node->fullpath);
+ FAIL(c, dti, node, "Relying on default #address-cells value");
if (node->parent->size_cells == -1)
- FAIL(c, dti, "Relying on default #size-cells value for %s",
- node->fullpath);
+ FAIL(c, dti, node, "Relying on default #size-cells value");
}
WARNING(avoid_default_addr_size, check_avoid_default_addr_size, NULL,
&addr_size_cells);
@@ -1023,8 +1006,7 @@ static void check_avoid_unnecessary_addr_size(struct check *c, struct dt_info *d
}
if (!has_reg)
- FAIL(c, dti, "unnecessary #address-cells/#size-cells without \"ranges\" or child \"reg\" property in %s",
- node->fullpath);
+ FAIL(c, dti, node, "unnecessary #address-cells/#size-cells without \"ranges\" or child \"reg\" property");
}
WARNING(avoid_unnecessary_addr_size, check_avoid_unnecessary_addr_size, NULL, &avoid_default_addr_size);
@@ -1046,7 +1028,7 @@ static void check_obsolete_chosen_interrupt_controller(struct check *c,
prop = get_property(chosen, "interrupt-controller");
if (prop)
- FAIL(c, dti, "/chosen has obsolete \"interrupt-controller\" "
+ FAIL(c, dti, node, "/chosen has obsolete \"interrupt-controller\" "
"property");
}
WARNING(obsolete_chosen_interrupt_controller,
@@ -1059,8 +1041,7 @@ static void check_chosen_node_is_root(struct check *c, struct dt_info *dti,
return;
if (node->parent != dti->dt)
- FAIL(c, dti, "chosen node '%s' must be at root node",
- node->fullpath);
+ FAIL(c, dti, node, "chosen node must be at root node");
}
WARNING(chosen_node_is_root, check_chosen_node_is_root, NULL);
@@ -1094,7 +1075,7 @@ static void check_chosen_node_stdout_path(struct check *c, struct dt_info *dti,
prop = get_property(node, "linux,stdout-path");
if (!prop)
return;
- FAIL(c, dti, "Use 'stdout-path' instead of 'linux,stdout-path'");
+ FAIL(c, dti, node, "Use 'stdout-path' instead of 'linux,stdout-path'");
}
c->data = prop->name;
@@ -1118,8 +1099,8 @@ static void check_property_phandle_args(struct check *c,
int cell, cellsize = 0;
if (prop->val.len % sizeof(cell_t)) {
- FAIL(c, dti, "property '%s' size (%d) is invalid, expected multiple of %zu in node %s",
- prop->name, prop->val.len, sizeof(cell_t), node->fullpath);
+ FAIL(c, dti, node, "property '%s' size (%d) is invalid, expected multiple of %zu",
+ prop->name, prop->val.len, sizeof(cell_t));
return;
}
@@ -1150,14 +1131,14 @@ static void check_property_phandle_args(struct check *c,
break;
}
if (!m)
- FAIL(c, dti, "Property '%s', cell %d is not a phandle reference in %s",
- prop->name, cell, node->fullpath);
+ FAIL(c, dti, node, "Property '%s', cell %d is not a phandle reference",
+ prop->name, cell);
}
provider_node = get_node_by_phandle(root, phandle);
if (!provider_node) {
- FAIL(c, dti, "Could not get phandle node for %s:%s(cell %d)",
- node->fullpath, prop->name, cell);
+ FAIL(c, dti, node, "Could not get phandle node for %s(cell %d)",
+ prop->name, cell);
break;
}
@@ -1167,16 +1148,16 @@ static void check_property_phandle_args(struct check *c,
} else if (provider->optional) {
cellsize = 0;
} else {
- FAIL(c, dti, "Missing property '%s' in node %s or bad phandle (referred from %s:%s[%d])",
+ FAIL(c, dti, node, "Missing property '%s' in node %s or bad phandle (referred from %s[%d])",
provider->cell_name,
provider_node->fullpath,
- node->fullpath, prop->name, cell);
+ prop->name, cell);
break;
}
if (prop->val.len < ((cell + cellsize + 1) * sizeof(cell_t))) {
- FAIL(c, dti, "%s property size (%d) too small for cell size %d in %s",
- prop->name, prop->val.len, cellsize, node->fullpath);
+ FAIL(c, dti, node, "%s property size (%d) too small for cell size %d",
+ prop->name, prop->val.len, cellsize);
}
}
}
@@ -1278,8 +1259,8 @@ static void check_deprecated_gpio_property(struct check *c,
if (!streq(str, "gpio"))
continue;
- FAIL(c, dti, "'[*-]gpio' is deprecated, use '[*-]gpios' instead for %s:%s",
- node->fullpath, prop->name);
+ FAIL(c, dti, node, "'[*-]gpio' is deprecated, use '[*-]gpios' instead for %s",
+ prop->name);
}
}
@@ -1313,9 +1294,8 @@ static void check_interrupts_property(struct check *c,
return;
if (irq_prop->val.len % sizeof(cell_t))
- FAIL(c, dti, "property '%s' size (%d) is invalid, expected multiple of %zu in node %s",
- irq_prop->name, irq_prop->val.len, sizeof(cell_t),
- node->fullpath);
+ FAIL(c, dti, node, "property '%s' size (%d) is invalid, expected multiple of %zu",
+ irq_prop->name, irq_prop->val.len, sizeof(cell_t));
while (parent && !prop) {
if (parent != node && node_is_interrupt_provider(parent)) {
@@ -1333,14 +1313,12 @@ static void check_interrupts_property(struct check *c,
irq_node = get_node_by_phandle(root, phandle);
if (!irq_node) {
- FAIL(c, dti, "Bad interrupt-parent phandle for %s",
- node->fullpath);
+ FAIL(c, dti, node, "Bad interrupt-parent phandle");
return;
}
if (!node_is_interrupt_provider(irq_node))
- FAIL(c, dti,
- "Missing interrupt-controller or interrupt-map property in %s",
- irq_node->fullpath);
+ FAIL(c, dti, irq_node,
+ "Missing interrupt-controller or interrupt-map property");
break;
}
@@ -1349,23 +1327,21 @@ static void check_interrupts_property(struct check *c,
}
if (!irq_node) {
- FAIL(c, dti, "Missing interrupt-parent for %s", node->fullpath);
+ FAIL(c, dti, node, "Missing interrupt-parent");
return;
}
prop = get_property(irq_node, "#interrupt-cells");
if (!prop) {
- FAIL(c, dti, "Missing #interrupt-cells in interrupt-parent %s",
- irq_node->fullpath);
+ FAIL(c, dti, irq_node, "Missing #interrupt-cells in interrupt-parent");
return;
}
irq_cells = propval_cell(prop);
if (irq_prop->val.len % (irq_cells * sizeof(cell_t))) {
- FAIL(c, dti,
- "interrupts size is (%d), expected multiple of %d in %s",
- irq_prop->val.len, (int)(irq_cells * sizeof(cell_t)),
- node->fullpath);
+ FAIL(c, dti, node,
+ "interrupts size is (%d), expected multiple of %d",
+ irq_prop->val.len, (int)(irq_cells * sizeof(cell_t)));
}
}
WARNING(interrupts_property, check_interrupts_property, &phandle_references);
--
2.14.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/3] checks: centralize printing of property names in failure messages
[not found] ` <20180131145705.21335-1-robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2018-01-31 14:57 ` [PATCH 1/3] checks: centralize printing of node path in check_msg Rob Herring
@ 2018-01-31 14:57 ` Rob Herring
[not found] ` <20180131145705.21335-3-robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2018-01-31 14:57 ` [PATCH 3/3] checks: Use source position information for check failures Rob Herring
2 siblings, 1 reply; 6+ messages in thread
From: Rob Herring @ 2018-01-31 14:57 UTC (permalink / raw)
To: David Gibson; +Cc: Julia Lawall, devicetree-compiler-u79uwXL29TY76Z2rM5mHXA
Some failure messages apply to a specific property. Add a FAIL_PROP()
macro for failure messages which are specific to a property. With that,
failure messages can print the property name in a standard way. Once
source line numbers are supported, then the file and line number of the
property can be used instead of the node file and line number.
Convert the existing messages related to properties to use the FAIL_PROP
macro and reword the messages as necessary.
Signed-off-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
---
checks.c | 148 ++++++++++++++++++++++++++++++++++-----------------------------
1 file changed, 80 insertions(+), 68 deletions(-)
diff --git a/checks.c b/checks.c
index 54df014c1c79..c07ba4da9e36 100644
--- a/checks.c
+++ b/checks.c
@@ -72,8 +72,9 @@ struct check {
#define CHECK(nm_, fn_, d_, ...) \
CHECK_ENTRY(nm_, fn_, d_, false, false, __VA_ARGS__)
-static inline void PRINTF(4, 5) check_msg(struct check *c, struct dt_info *dti,
+static inline void PRINTF(5, 6) check_msg(struct check *c, struct dt_info *dti,
struct node *node,
+ struct property *prop,
const char *fmt, ...)
{
va_list ap;
@@ -84,8 +85,12 @@ static inline void PRINTF(4, 5) check_msg(struct check *c, struct dt_info *dti,
fprintf(stderr, "%s: %s (%s): ",
strcmp(dti->outname, "-") ? dti->outname : "<stdout>",
(c->error) ? "ERROR" : "Warning", c->name);
- if (node)
- fprintf(stderr, "%s: ", node->fullpath);
+ if (node) {
+ fprintf(stderr, "%s", node->fullpath);
+ if (prop)
+ fprintf(stderr, ":%s", prop->name);
+ fputs(": ", stderr);
+ }
vfprintf(stderr, fmt, ap);
fprintf(stderr, "\n");
}
@@ -96,9 +101,17 @@ static inline void PRINTF(4, 5) check_msg(struct check *c, struct dt_info *dti,
do { \
TRACE((c), "\t\tFAILED at %s:%d", __FILE__, __LINE__); \
(c)->status = FAILED; \
- check_msg((c), dti, node, __VA_ARGS__); \
+ check_msg((c), dti, node, NULL, __VA_ARGS__); \
+ } while (0)
+
+#define FAIL_PROP(c, dti, node, prop, ...) \
+ do { \
+ TRACE((c), "\t\tFAILED at %s:%d", __FILE__, __LINE__); \
+ (c)->status = FAILED; \
+ check_msg((c), dti, node, prop, __VA_ARGS__); \
} while (0)
+
static void check_nodes_props(struct check *c, struct dt_info *dti, struct node *node)
{
struct node *child;
@@ -129,7 +142,7 @@ static bool run_check(struct check *c, struct dt_info *dti)
error = error || run_check(prq, dti);
if (prq->status != PASSED) {
c->status = PREREQ;
- check_msg(c, dti, NULL, "Failed prerequisite '%s'",
+ check_msg(c, dti, NULL, NULL, "Failed prerequisite '%s'",
c->prereq[i]->name);
}
}
@@ -174,7 +187,7 @@ static void check_is_string(struct check *c, struct dt_info *dti,
return; /* Not present, assumed ok */
if (!data_is_one_string(prop->val))
- FAIL(c, dti, node, "\"%s\" property is not a string", propname);
+ FAIL_PROP(c, dti, node, prop, "property is not a string");
}
#define WARNING_IF_NOT_STRING(nm, propname) \
WARNING(nm, check_is_string, (propname))
@@ -198,8 +211,7 @@ static void check_is_string_list(struct check *c, struct dt_info *dti,
while (rem > 0) {
l = strnlen(str, rem);
if (l == rem) {
- FAIL(c, dti, node, "\"%s\" property is not a string list",
- propname);
+ FAIL_PROP(c, dti, node, prop, "property is not a string list");
break;
}
rem -= l + 1;
@@ -222,8 +234,7 @@ static void check_is_cell(struct check *c, struct dt_info *dti,
return; /* Not present, assumed ok */
if (prop->val.len != sizeof(cell_t))
- FAIL(c, dti, node, "\"%s\" property is not a single cell",
- propname);
+ FAIL_PROP(c, dti, node, prop, "property is not a single cell");
}
#define WARNING_IF_NOT_CELL(nm, propname) \
WARNING(nm, check_is_cell, (propname))
@@ -258,8 +269,7 @@ static void check_duplicate_property_names(struct check *c, struct dt_info *dti,
if (prop2->deleted)
continue;
if (streq(prop->name, prop2->name))
- FAIL(c, dti, node, "Duplicate property name %s",
- prop->name);
+ FAIL_PROP(c, dti, node, prop, "Duplicate property name");
}
}
}
@@ -332,8 +342,8 @@ static void check_property_name_chars(struct check *c, struct dt_info *dti,
int n = strspn(prop->name, c->data);
if (n < strlen(prop->name))
- FAIL(c, dti, node, "Bad character '%c' in property name \"%s\"",
- prop->name[n], prop->name);
+ FAIL_PROP(c, dti, node, prop, "Bad character '%c' in property name",
+ prop->name[n]);
}
}
ERROR(property_name_chars, check_property_name_chars, PROPNODECHARS);
@@ -364,8 +374,8 @@ static void check_property_name_chars_strict(struct check *c,
n = strspn(name, c->data);
}
if (n < strlen(name))
- FAIL(c, dti, node, "Character '%c' not recommended in property name \"%s\"",
- name[n], prop->name);
+ FAIL_PROP(c, dti, node, prop, "Character '%c' not recommended in property name",
+ name[n]);
}
}
CHECK(property_name_chars_strict, check_property_name_chars_strict, PROPNODECHARSSTRICT);
@@ -438,8 +448,8 @@ static cell_t check_phandle_prop(struct check *c, struct dt_info *dti,
return 0;
if (prop->val.len != sizeof(cell_t)) {
- FAIL(c, dti, node, "bad length (%d) %s property",
- prop->val.len, prop->name);
+ FAIL_PROP(c, dti, node, prop, "bad length (%d) %s property",
+ prop->val.len, prop->name);
return 0;
}
@@ -464,7 +474,7 @@ static cell_t check_phandle_prop(struct check *c, struct dt_info *dti,
phandle = propval_cell(prop);
if ((phandle == 0) || (phandle == -1)) {
- FAIL(c, dti, node, "bad value (0x%x) in %s property",
+ FAIL_PROP(c, dti, node, prop, "bad value (0x%x) in %s property",
phandle, prop->name);
return 0;
}
@@ -644,14 +654,12 @@ static void check_alias_paths(struct check *c, struct dt_info *dti,
for_each_property(node, prop) {
if (!prop->val.val || !get_node_by_path(dti->dt, prop->val.val)) {
- FAIL(c, dti, node, "aliases property '%s' is not a valid node (%s)",
- prop->name, prop->val.val);
+ FAIL_PROP(c, dti, node, prop, "aliases property is not a valid node (%s)",
+ prop->val.val);
continue;
}
if (strspn(prop->name, LOWERCASE DIGITS "-") != strlen(prop->name))
- FAIL(c, dti, node, "aliases property name '%s' is not valid",
- prop->name);
-
+ FAIL(c, dti, node, "aliases property name must include only lowercase and '-'");
}
}
WARNING(alias_paths, check_alias_paths, NULL);
@@ -696,16 +704,16 @@ static void check_reg_format(struct check *c, struct dt_info *dti,
}
if (prop->val.len == 0)
- FAIL(c, dti, node, "\"reg\" property is empty");
+ FAIL_PROP(c, dti, node, prop, "property is empty");
addr_cells = node_addr_cells(node->parent);
size_cells = node_size_cells(node->parent);
entrylen = (addr_cells + size_cells) * sizeof(cell_t);
if (!entrylen || (prop->val.len % entrylen) != 0)
- FAIL(c, dti, node, "\"reg\" property has invalid length (%d bytes) "
- "(#address-cells == %d, #size-cells == %d)",
- prop->val.len, addr_cells, size_cells);
+ FAIL_PROP(c, dti, node, prop, "property has invalid length (%d bytes) "
+ "(#address-cells == %d, #size-cells == %d)",
+ prop->val.len, addr_cells, size_cells);
}
WARNING(reg_format, check_reg_format, NULL, &addr_size_cells);
@@ -720,7 +728,7 @@ static void check_ranges_format(struct check *c, struct dt_info *dti,
return;
if (!node->parent) {
- FAIL(c, dti, node, "Root node has a \"ranges\" property");
+ FAIL_PROP(c, dti, node, prop, "Root node has a \"ranges\" property");
return;
}
@@ -732,20 +740,20 @@ static void check_ranges_format(struct check *c, struct dt_info *dti,
if (prop->val.len == 0) {
if (p_addr_cells != c_addr_cells)
- FAIL(c, dti, node, "empty \"ranges\" property but its "
- "#address-cells (%d) differs from %s (%d)",
- c_addr_cells, node->parent->fullpath,
- p_addr_cells);
+ FAIL_PROP(c, dti, node, prop, "empty \"ranges\" property but its "
+ "#address-cells (%d) differs from %s (%d)",
+ c_addr_cells, node->parent->fullpath,
+ p_addr_cells);
if (p_size_cells != c_size_cells)
- FAIL(c, dti, node, "empty \"ranges\" property but its "
- "#size-cells (%d) differs from %s (%d)",
- c_size_cells, node->parent->fullpath,
- p_size_cells);
+ FAIL_PROP(c, dti, node, prop, "empty \"ranges\" property but its "
+ "#size-cells (%d) differs from %s (%d)",
+ c_size_cells, node->parent->fullpath,
+ p_size_cells);
} else if ((prop->val.len % entrylen) != 0) {
- FAIL(c, dti, node, "\"ranges\" property has invalid length (%d bytes) "
- "(parent #address-cells == %d, child #address-cells == %d, "
- "#size-cells == %d)", prop->val.len,
- p_addr_cells, c_addr_cells, c_size_cells);
+ FAIL_PROP(c, dti, node, prop, "\"ranges\" property has invalid length (%d bytes) "
+ "(parent #address-cells == %d, child #address-cells == %d, "
+ "#size-cells == %d)", prop->val.len,
+ p_addr_cells, c_addr_cells, c_size_cells);
}
}
WARNING(ranges_format, check_ranges_format, NULL, &addr_size_cells);
@@ -784,14 +792,14 @@ static void check_pci_bridge(struct check *c, struct dt_info *dti, struct node *
return;
}
if (prop->val.len != (sizeof(cell_t) * 2)) {
- FAIL(c, dti, node, "bus-range must be 2 cells");
+ FAIL_PROP(c, dti, node, prop, "value must be 2 cells");
return;
}
cells = (cell_t *)prop->val.val;
if (fdt32_to_cpu(cells[0]) > fdt32_to_cpu(cells[1]))
- FAIL(c, dti, node, "bus-range 1st cell must be less than or equal to 2nd cell");
+ FAIL_PROP(c, dti, node, prop, "1st cell must be less than or equal to 2nd cell");
if (fdt32_to_cpu(cells[1]) > 0xff)
- FAIL(c, dti, node, "bus-range maximum bus number must be less than 256");
+ FAIL_PROP(c, dti, node, prop, "maximum bus number must be less than 256");
}
WARNING(pci_bridge, check_pci_bridge, NULL,
&device_type_is_string, &addr_size_cells);
@@ -821,8 +829,8 @@ static void check_pci_device_bus_num(struct check *c, struct dt_info *dti, struc
max_bus = fdt32_to_cpu(cells[0]);
}
if ((bus_num < min_bus) || (bus_num > max_bus))
- FAIL(c, dti, node, "PCI bus number %d out of range, expected (%d - %d)",
- bus_num, min_bus, max_bus);
+ FAIL_PROP(c, dti, node, prop, "PCI bus number %d out of range, expected (%d - %d)",
+ bus_num, min_bus, max_bus);
}
WARNING(pci_device_bus_num, check_pci_device_bus_num, NULL, ®_format, &pci_bridge);
@@ -845,16 +853,16 @@ static void check_pci_device_reg(struct check *c, struct dt_info *dti, struct no
cells = (cell_t *)prop->val.val;
if (cells[1] || cells[2])
- FAIL(c, dti, node, "PCI reg config space address cells 2 and 3 must be 0");
+ FAIL_PROP(c, dti, node, prop, "PCI reg config space address cells 2 and 3 must be 0");
reg = fdt32_to_cpu(cells[0]);
dev = (reg & 0xf800) >> 11;
func = (reg & 0x700) >> 8;
if (reg & 0xff000000)
- FAIL(c, dti, node, "PCI reg address is not configuration space");
+ FAIL_PROP(c, dti, node, prop, "PCI reg address is not configuration space");
if (reg & 0x000000ff)
- FAIL(c, dti, node, "PCI reg config space address register number must be 0");
+ FAIL_PROP(c, dti, node, prop, "PCI reg config space address register number must be 0");
if (func == 0) {
snprintf(unit_addr, sizeof(unit_addr), "%x", dev);
@@ -1028,8 +1036,8 @@ static void check_obsolete_chosen_interrupt_controller(struct check *c,
prop = get_property(chosen, "interrupt-controller");
if (prop)
- FAIL(c, dti, node, "/chosen has obsolete \"interrupt-controller\" "
- "property");
+ FAIL_PROP(c, dti, node, prop,
+ "/chosen has obsolete \"interrupt-controller\" property");
}
WARNING(obsolete_chosen_interrupt_controller,
check_obsolete_chosen_interrupt_controller, NULL);
@@ -1075,7 +1083,7 @@ static void check_chosen_node_stdout_path(struct check *c, struct dt_info *dti,
prop = get_property(node, "linux,stdout-path");
if (!prop)
return;
- FAIL(c, dti, node, "Use 'stdout-path' instead of 'linux,stdout-path'");
+ FAIL_PROP(c, dti, node, prop, "Use 'stdout-path' instead");
}
c->data = prop->name;
@@ -1099,8 +1107,9 @@ static void check_property_phandle_args(struct check *c,
int cell, cellsize = 0;
if (prop->val.len % sizeof(cell_t)) {
- FAIL(c, dti, node, "property '%s' size (%d) is invalid, expected multiple of %zu",
- prop->name, prop->val.len, sizeof(cell_t));
+ FAIL_PROP(c, dti, node, prop,
+ "property size (%d) is invalid, expected multiple of %zu",
+ prop->val.len, sizeof(cell_t));
return;
}
@@ -1131,14 +1140,16 @@ static void check_property_phandle_args(struct check *c,
break;
}
if (!m)
- FAIL(c, dti, node, "Property '%s', cell %d is not a phandle reference",
- prop->name, cell);
+ FAIL_PROP(c, dti, node, prop,
+ "cell %d is not a phandle reference",
+ cell);
}
provider_node = get_node_by_phandle(root, phandle);
if (!provider_node) {
- FAIL(c, dti, node, "Could not get phandle node for %s(cell %d)",
- prop->name, cell);
+ FAIL_PROP(c, dti, node, prop,
+ "Could not get phandle node for (cell %d)",
+ cell);
break;
}
@@ -1156,8 +1167,9 @@ static void check_property_phandle_args(struct check *c,
}
if (prop->val.len < ((cell + cellsize + 1) * sizeof(cell_t))) {
- FAIL(c, dti, node, "%s property size (%d) too small for cell size %d",
- prop->name, prop->val.len, cellsize);
+ FAIL_PROP(c, dti, node, prop,
+ "property size (%d) too small for cell size %d",
+ prop->val.len, cellsize);
}
}
}
@@ -1259,8 +1271,8 @@ static void check_deprecated_gpio_property(struct check *c,
if (!streq(str, "gpio"))
continue;
- FAIL(c, dti, node, "'[*-]gpio' is deprecated, use '[*-]gpios' instead for %s",
- prop->name);
+ FAIL_PROP(c, dti, node, prop,
+ "'[*-]gpio' is deprecated, use '[*-]gpios' instead");
}
}
@@ -1294,8 +1306,8 @@ static void check_interrupts_property(struct check *c,
return;
if (irq_prop->val.len % sizeof(cell_t))
- FAIL(c, dti, node, "property '%s' size (%d) is invalid, expected multiple of %zu",
- irq_prop->name, irq_prop->val.len, sizeof(cell_t));
+ FAIL_PROP(c, dti, node, irq_prop, "size (%d) is invalid, expected multiple of %zu",
+ irq_prop->val.len, sizeof(cell_t));
while (parent && !prop) {
if (parent != node && node_is_interrupt_provider(parent)) {
@@ -1313,7 +1325,7 @@ static void check_interrupts_property(struct check *c,
irq_node = get_node_by_phandle(root, phandle);
if (!irq_node) {
- FAIL(c, dti, node, "Bad interrupt-parent phandle");
+ FAIL_PROP(c, dti, parent, prop, "Bad phandle");
return;
}
if (!node_is_interrupt_provider(irq_node))
@@ -1339,9 +1351,9 @@ static void check_interrupts_property(struct check *c,
irq_cells = propval_cell(prop);
if (irq_prop->val.len % (irq_cells * sizeof(cell_t))) {
- FAIL(c, dti, node,
- "interrupts size is (%d), expected multiple of %d",
- irq_prop->val.len, (int)(irq_cells * sizeof(cell_t)));
+ FAIL_PROP(c, dti, node, prop,
+ "size is (%d), expected multiple of %d",
+ irq_prop->val.len, (int)(irq_cells * sizeof(cell_t)));
}
}
WARNING(interrupts_property, check_interrupts_property, &phandle_references);
--
2.14.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 3/3] checks: Use source position information for check failures
[not found] ` <20180131145705.21335-1-robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2018-01-31 14:57 ` [PATCH 1/3] checks: centralize printing of node path in check_msg Rob Herring
2018-01-31 14:57 ` [PATCH 2/3] checks: centralize printing of property names in failure messages Rob Herring
@ 2018-01-31 14:57 ` Rob Herring
2 siblings, 0 replies; 6+ messages in thread
From: Rob Herring @ 2018-01-31 14:57 UTC (permalink / raw)
To: David Gibson; +Cc: Julia Lawall, devicetree-compiler-u79uwXL29TY76Z2rM5mHXA
Now that we retain source position information of nodes and properties,
make that the preferred file name (and position) to print out in check
failures. This will greatly simplify finding and fixing check errors
because most errors are in included source .dtsi files and they get
duplicated every time the source file is included.
Signed-off-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
---
checks.c | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/checks.c b/checks.c
index c07ba4da9e36..d048557ef3ae 100644
--- a/checks.c
+++ b/checks.c
@@ -19,6 +19,7 @@
*/
#include "dtc.h"
+#include "srcpos.h"
#ifdef TRACE_CHECKS
#define TRACE(c, ...) \
@@ -82,8 +83,15 @@ static inline void PRINTF(5, 6) check_msg(struct check *c, struct dt_info *dti,
if ((c->warn && (quiet < 1))
|| (c->error && (quiet < 2))) {
+ const char *file_str;
+ if (node && node->srcpos)
+ file_str = srcpos_string(node->srcpos);
+ else if (streq(dti->outname, "-"))
+ file_str = "<stdout>";
+ else
+ file_str = dti->outname;
fprintf(stderr, "%s: %s (%s): ",
- strcmp(dti->outname, "-") ? dti->outname : "<stdout>",
+ file_str,
(c->error) ? "ERROR" : "Warning", c->name);
if (node) {
fprintf(stderr, "%s", node->fullpath);
--
2.14.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 1/3] checks: centralize printing of node path in check_msg
[not found] ` <20180131145705.21335-2-robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
@ 2018-02-09 6:53 ` David Gibson
0 siblings, 0 replies; 6+ messages in thread
From: David Gibson @ 2018-02-09 6:53 UTC (permalink / raw)
To: Rob Herring; +Cc: Julia Lawall, devicetree-compiler-u79uwXL29TY76Z2rM5mHXA
[-- Attachment #1: Type: text/plain, Size: 28411 bytes --]
On Wed, Jan 31, 2018 at 08:57:03AM -0600, Rob Herring wrote:
> Most error/warning messages print the node path as part of their error
> message. Move printing of the node path into check_msg() so the
> formatting can be standardized to the form:
>
> <output file>: (ERROR|warning) (<check name>): <full node name>: <check message>
>
> Signed-off-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Applied, thanks.
> ---
> checks.c | 232 ++++++++++++++++++++++++++++-----------------------------------
> 1 file changed, 104 insertions(+), 128 deletions(-)
>
> diff --git a/checks.c b/checks.c
> index 1cded3658491..54df014c1c79 100644
> --- a/checks.c
> +++ b/checks.c
> @@ -72,7 +72,8 @@ struct check {
> #define CHECK(nm_, fn_, d_, ...) \
> CHECK_ENTRY(nm_, fn_, d_, false, false, __VA_ARGS__)
>
> -static inline void PRINTF(3, 4) check_msg(struct check *c, struct dt_info *dti,
> +static inline void PRINTF(4, 5) check_msg(struct check *c, struct dt_info *dti,
> + struct node *node,
> const char *fmt, ...)
> {
> va_list ap;
> @@ -83,17 +84,19 @@ static inline void PRINTF(3, 4) check_msg(struct check *c, struct dt_info *dti,
> fprintf(stderr, "%s: %s (%s): ",
> strcmp(dti->outname, "-") ? dti->outname : "<stdout>",
> (c->error) ? "ERROR" : "Warning", c->name);
> + if (node)
> + fprintf(stderr, "%s: ", node->fullpath);
> vfprintf(stderr, fmt, ap);
> fprintf(stderr, "\n");
> }
> va_end(ap);
> }
>
> -#define FAIL(c, dti, ...) \
> +#define FAIL(c, dti, node, ...) \
> do { \
> TRACE((c), "\t\tFAILED at %s:%d", __FILE__, __LINE__); \
> (c)->status = FAILED; \
> - check_msg((c), dti, __VA_ARGS__); \
> + check_msg((c), dti, node, __VA_ARGS__); \
> } while (0)
>
> static void check_nodes_props(struct check *c, struct dt_info *dti, struct node *node)
> @@ -126,7 +129,7 @@ static bool run_check(struct check *c, struct dt_info *dti)
> error = error || run_check(prq, dti);
> if (prq->status != PASSED) {
> c->status = PREREQ;
> - check_msg(c, dti, "Failed prerequisite '%s'",
> + check_msg(c, dti, NULL, "Failed prerequisite '%s'",
> c->prereq[i]->name);
> }
> }
> @@ -156,7 +159,7 @@ out:
> static inline void check_always_fail(struct check *c, struct dt_info *dti,
> struct node *node)
> {
> - FAIL(c, dti, "always_fail check");
> + FAIL(c, dti, node, "always_fail check");
> }
> CHECK(always_fail, check_always_fail, NULL);
>
> @@ -171,8 +174,7 @@ static void check_is_string(struct check *c, struct dt_info *dti,
> return; /* Not present, assumed ok */
>
> if (!data_is_one_string(prop->val))
> - FAIL(c, dti, "\"%s\" property in %s is not a string",
> - propname, node->fullpath);
> + FAIL(c, dti, node, "\"%s\" property is not a string", propname);
> }
> #define WARNING_IF_NOT_STRING(nm, propname) \
> WARNING(nm, check_is_string, (propname))
> @@ -196,8 +198,8 @@ static void check_is_string_list(struct check *c, struct dt_info *dti,
> while (rem > 0) {
> l = strnlen(str, rem);
> if (l == rem) {
> - FAIL(c, dti, "\"%s\" property in %s is not a string list",
> - propname, node->fullpath);
> + FAIL(c, dti, node, "\"%s\" property is not a string list",
> + propname);
> break;
> }
> rem -= l + 1;
> @@ -220,8 +222,8 @@ static void check_is_cell(struct check *c, struct dt_info *dti,
> return; /* Not present, assumed ok */
>
> if (prop->val.len != sizeof(cell_t))
> - FAIL(c, dti, "\"%s\" property in %s is not a single cell",
> - propname, node->fullpath);
> + FAIL(c, dti, node, "\"%s\" property is not a single cell",
> + propname);
> }
> #define WARNING_IF_NOT_CELL(nm, propname) \
> WARNING(nm, check_is_cell, (propname))
> @@ -242,8 +244,7 @@ static void check_duplicate_node_names(struct check *c, struct dt_info *dti,
> child2;
> child2 = child2->next_sibling)
> if (streq(child->name, child2->name))
> - FAIL(c, dti, "Duplicate node name %s",
> - child->fullpath);
> + FAIL(c, dti, node, "Duplicate node name");
> }
> ERROR(duplicate_node_names, check_duplicate_node_names, NULL);
>
> @@ -257,8 +258,8 @@ static void check_duplicate_property_names(struct check *c, struct dt_info *dti,
> if (prop2->deleted)
> continue;
> if (streq(prop->name, prop2->name))
> - FAIL(c, dti, "Duplicate property name %s in %s",
> - prop->name, node->fullpath);
> + FAIL(c, dti, node, "Duplicate property name %s",
> + prop->name);
> }
> }
> }
> @@ -276,8 +277,8 @@ static void check_node_name_chars(struct check *c, struct dt_info *dti,
> int n = strspn(node->name, c->data);
>
> if (n < strlen(node->name))
> - FAIL(c, dti, "Bad character '%c' in node %s",
> - node->name[n], node->fullpath);
> + FAIL(c, dti, node, "Bad character '%c' in node name",
> + node->name[n]);
> }
> ERROR(node_name_chars, check_node_name_chars, PROPNODECHARS "@");
>
> @@ -287,8 +288,8 @@ static void check_node_name_chars_strict(struct check *c, struct dt_info *dti,
> int n = strspn(node->name, c->data);
>
> if (n < node->basenamelen)
> - FAIL(c, dti, "Character '%c' not recommended in node %s",
> - node->name[n], node->fullpath);
> + FAIL(c, dti, node, "Character '%c' not recommended in node name",
> + node->name[n]);
> }
> CHECK(node_name_chars_strict, check_node_name_chars_strict, PROPNODECHARSSTRICT);
>
> @@ -296,8 +297,7 @@ static void check_node_name_format(struct check *c, struct dt_info *dti,
> struct node *node)
> {
> if (strchr(get_unitname(node), '@'))
> - FAIL(c, dti, "Node %s has multiple '@' characters in name",
> - node->fullpath);
> + FAIL(c, dti, node, "multiple '@' characters in node name");
> }
> ERROR(node_name_format, check_node_name_format, NULL, &node_name_chars);
>
> @@ -315,12 +315,10 @@ static void check_unit_address_vs_reg(struct check *c, struct dt_info *dti,
>
> if (prop) {
> if (!unitname[0])
> - FAIL(c, dti, "Node %s has a reg or ranges property, but no unit name",
> - node->fullpath);
> + FAIL(c, dti, node, "node has a reg or ranges property, but no unit name");
> } else {
> if (unitname[0])
> - FAIL(c, dti, "Node %s has a unit name, but no reg property",
> - node->fullpath);
> + FAIL(c, dti, node, "node has a unit name, but no reg property");
> }
> }
> WARNING(unit_address_vs_reg, check_unit_address_vs_reg, NULL);
> @@ -334,8 +332,8 @@ static void check_property_name_chars(struct check *c, struct dt_info *dti,
> int n = strspn(prop->name, c->data);
>
> if (n < strlen(prop->name))
> - FAIL(c, dti, "Bad character '%c' in property name \"%s\", node %s",
> - prop->name[n], prop->name, node->fullpath);
> + FAIL(c, dti, node, "Bad character '%c' in property name \"%s\"",
> + prop->name[n], prop->name);
> }
> }
> ERROR(property_name_chars, check_property_name_chars, PROPNODECHARS);
> @@ -366,8 +364,8 @@ static void check_property_name_chars_strict(struct check *c,
> n = strspn(name, c->data);
> }
> if (n < strlen(name))
> - FAIL(c, dti, "Character '%c' not recommended in property name \"%s\", node %s",
> - name[n], prop->name, node->fullpath);
> + FAIL(c, dti, node, "Character '%c' not recommended in property name \"%s\"",
> + name[n], prop->name);
> }
> }
> CHECK(property_name_chars_strict, check_property_name_chars_strict, PROPNODECHARSSTRICT);
> @@ -400,7 +398,7 @@ static void check_duplicate_label(struct check *c, struct dt_info *dti,
> return;
>
> if ((othernode != node) || (otherprop != prop) || (othermark != mark))
> - FAIL(c, dti, "Duplicate label '%s' on " DESCLABEL_FMT
> + FAIL(c, dti, node, "Duplicate label '%s' on " DESCLABEL_FMT
> " and " DESCLABEL_FMT,
> label, DESCLABEL_ARGS(node, prop, mark),
> DESCLABEL_ARGS(othernode, otherprop, othermark));
> @@ -440,8 +438,8 @@ static cell_t check_phandle_prop(struct check *c, struct dt_info *dti,
> return 0;
>
> if (prop->val.len != sizeof(cell_t)) {
> - FAIL(c, dti, "%s has bad length (%d) %s property",
> - node->fullpath, prop->val.len, prop->name);
> + FAIL(c, dti, node, "bad length (%d) %s property",
> + prop->val.len, prop->name);
> return 0;
> }
>
> @@ -452,8 +450,8 @@ static cell_t check_phandle_prop(struct check *c, struct dt_info *dti,
> /* "Set this node's phandle equal to some
> * other node's phandle". That's nonsensical
> * by construction. */ {
> - FAIL(c, dti, "%s in %s is a reference to another node",
> - prop->name, node->fullpath);
> + FAIL(c, dti, node, "%s is a reference to another node",
> + prop->name);
> }
> /* But setting this node's phandle equal to its own
> * phandle is allowed - that means allocate a unique
> @@ -466,8 +464,8 @@ static cell_t check_phandle_prop(struct check *c, struct dt_info *dti,
> phandle = propval_cell(prop);
>
> if ((phandle == 0) || (phandle == -1)) {
> - FAIL(c, dti, "%s has bad value (0x%x) in %s property",
> - node->fullpath, phandle, prop->name);
> + FAIL(c, dti, node, "bad value (0x%x) in %s property",
> + phandle, prop->name);
> return 0;
> }
>
> @@ -493,16 +491,16 @@ static void check_explicit_phandles(struct check *c, struct dt_info *dti,
> return;
>
> if (linux_phandle && phandle && (phandle != linux_phandle))
> - FAIL(c, dti, "%s has mismatching 'phandle' and 'linux,phandle'"
> - " properties", node->fullpath);
> + FAIL(c, dti, node, "mismatching 'phandle' and 'linux,phandle'"
> + " properties");
>
> if (linux_phandle && !phandle)
> phandle = linux_phandle;
>
> other = get_node_by_phandle(root, phandle);
> if (other && (other != node)) {
> - FAIL(c, dti, "%s has duplicated phandle 0x%x (seen before at %s)",
> - node->fullpath, phandle, other->fullpath);
> + FAIL(c, dti, node, "duplicated phandle 0x%x (seen before at %s)",
> + phandle, other->fullpath);
> return;
> }
>
> @@ -526,8 +524,8 @@ static void check_name_properties(struct check *c, struct dt_info *dti,
>
> if ((prop->val.len != node->basenamelen+1)
> || (memcmp(prop->val.val, node->name, node->basenamelen) != 0)) {
> - FAIL(c, dti, "\"name\" property in %s is incorrect (\"%s\" instead"
> - " of base node name)", node->fullpath, prop->val.val);
> + FAIL(c, dti, node, "\"name\" property is incorrect (\"%s\" instead"
> + " of base node name)", prop->val.val);
> } else {
> /* The name property is correct, and therefore redundant.
> * Delete it */
> @@ -561,7 +559,7 @@ static void fixup_phandle_references(struct check *c, struct dt_info *dti,
> refnode = get_node_by_ref(dt, m->ref);
> if (! refnode) {
> if (!(dti->dtsflags & DTSF_PLUGIN))
> - FAIL(c, dti, "Reference to non-existent node or "
> + FAIL(c, dti, node, "Reference to non-existent node or "
> "label \"%s\"\n", m->ref);
> else /* mark the entry as unresolved */
> *((fdt32_t *)(prop->val.val + m->offset)) =
> @@ -593,7 +591,7 @@ static void fixup_path_references(struct check *c, struct dt_info *dti,
>
> refnode = get_node_by_ref(dt, m->ref);
> if (!refnode) {
> - FAIL(c, dti, "Reference to non-existent node or label \"%s\"\n",
> + FAIL(c, dti, node, "Reference to non-existent node or label \"%s\"\n",
> m->ref);
> continue;
> }
> @@ -646,12 +644,12 @@ static void check_alias_paths(struct check *c, struct dt_info *dti,
>
> for_each_property(node, prop) {
> if (!prop->val.val || !get_node_by_path(dti->dt, prop->val.val)) {
> - FAIL(c, dti, "aliases property '%s' is not a valid node (%s)",
> + FAIL(c, dti, node, "aliases property '%s' is not a valid node (%s)",
> prop->name, prop->val.val);
> continue;
> }
> if (strspn(prop->name, LOWERCASE DIGITS "-") != strlen(prop->name))
> - FAIL(c, dti, "aliases property name '%s' is not valid",
> + FAIL(c, dti, node, "aliases property name '%s' is not valid",
> prop->name);
>
> }
> @@ -693,21 +691,21 @@ static void check_reg_format(struct check *c, struct dt_info *dti,
> return; /* No "reg", that's fine */
>
> if (!node->parent) {
> - FAIL(c, dti, "Root node has a \"reg\" property");
> + FAIL(c, dti, node, "Root node has a \"reg\" property");
> return;
> }
>
> if (prop->val.len == 0)
> - FAIL(c, dti, "\"reg\" property in %s is empty", node->fullpath);
> + FAIL(c, dti, node, "\"reg\" property is empty");
>
> addr_cells = node_addr_cells(node->parent);
> size_cells = node_size_cells(node->parent);
> entrylen = (addr_cells + size_cells) * sizeof(cell_t);
>
> if (!entrylen || (prop->val.len % entrylen) != 0)
> - FAIL(c, dti, "\"reg\" property in %s has invalid length (%d bytes) "
> + FAIL(c, dti, node, "\"reg\" property has invalid length (%d bytes) "
> "(#address-cells == %d, #size-cells == %d)",
> - node->fullpath, prop->val.len, addr_cells, size_cells);
> + prop->val.len, addr_cells, size_cells);
> }
> WARNING(reg_format, check_reg_format, NULL, &addr_size_cells);
>
> @@ -722,7 +720,7 @@ static void check_ranges_format(struct check *c, struct dt_info *dti,
> return;
>
> if (!node->parent) {
> - FAIL(c, dti, "Root node has a \"ranges\" property");
> + FAIL(c, dti, node, "Root node has a \"ranges\" property");
> return;
> }
>
> @@ -734,19 +732,19 @@ static void check_ranges_format(struct check *c, struct dt_info *dti,
>
> if (prop->val.len == 0) {
> if (p_addr_cells != c_addr_cells)
> - FAIL(c, dti, "%s has empty \"ranges\" property but its "
> + FAIL(c, dti, node, "empty \"ranges\" property but its "
> "#address-cells (%d) differs from %s (%d)",
> - node->fullpath, c_addr_cells, node->parent->fullpath,
> + c_addr_cells, node->parent->fullpath,
> p_addr_cells);
> if (p_size_cells != c_size_cells)
> - FAIL(c, dti, "%s has empty \"ranges\" property but its "
> + FAIL(c, dti, node, "empty \"ranges\" property but its "
> "#size-cells (%d) differs from %s (%d)",
> - node->fullpath, c_size_cells, node->parent->fullpath,
> + c_size_cells, node->parent->fullpath,
> p_size_cells);
> } else if ((prop->val.len % entrylen) != 0) {
> - FAIL(c, dti, "\"ranges\" property in %s has invalid length (%d bytes) "
> + FAIL(c, dti, node, "\"ranges\" property has invalid length (%d bytes) "
> "(parent #address-cells == %d, child #address-cells == %d, "
> - "#size-cells == %d)", node->fullpath, prop->val.len,
> + "#size-cells == %d)", prop->val.len,
> p_addr_cells, c_addr_cells, c_size_cells);
> }
> }
> @@ -769,39 +767,31 @@ static void check_pci_bridge(struct check *c, struct dt_info *dti, struct node *
>
> if (!strprefixeq(node->name, node->basenamelen, "pci") &&
> !strprefixeq(node->name, node->basenamelen, "pcie"))
> - FAIL(c, dti, "Node %s node name is not \"pci\" or \"pcie\"",
> - node->fullpath);
> + FAIL(c, dti, node, "node name is not \"pci\" or \"pcie\"");
>
> prop = get_property(node, "ranges");
> if (!prop)
> - FAIL(c, dti, "Node %s missing ranges for PCI bridge (or not a bridge)",
> - node->fullpath);
> + FAIL(c, dti, node, "missing ranges for PCI bridge (or not a bridge)");
>
> if (node_addr_cells(node) != 3)
> - FAIL(c, dti, "Node %s incorrect #address-cells for PCI bridge",
> - node->fullpath);
> + FAIL(c, dti, node, "incorrect #address-cells for PCI bridge");
> if (node_size_cells(node) != 2)
> - FAIL(c, dti, "Node %s incorrect #size-cells for PCI bridge",
> - node->fullpath);
> + FAIL(c, dti, node, "incorrect #size-cells for PCI bridge");
>
> prop = get_property(node, "bus-range");
> if (!prop) {
> - FAIL(c, dti, "Node %s missing bus-range for PCI bridge",
> - node->fullpath);
> + FAIL(c, dti, node, "missing bus-range for PCI bridge");
> return;
> }
> if (prop->val.len != (sizeof(cell_t) * 2)) {
> - FAIL(c, dti, "Node %s bus-range must be 2 cells",
> - node->fullpath);
> + FAIL(c, dti, node, "bus-range must be 2 cells");
> return;
> }
> cells = (cell_t *)prop->val.val;
> if (fdt32_to_cpu(cells[0]) > fdt32_to_cpu(cells[1]))
> - FAIL(c, dti, "Node %s bus-range 1st cell must be less than or equal to 2nd cell",
> - node->fullpath);
> + FAIL(c, dti, node, "bus-range 1st cell must be less than or equal to 2nd cell");
> if (fdt32_to_cpu(cells[1]) > 0xff)
> - FAIL(c, dti, "Node %s bus-range maximum bus number must be less than 256",
> - node->fullpath);
> + FAIL(c, dti, node, "bus-range maximum bus number must be less than 256");
> }
> WARNING(pci_bridge, check_pci_bridge, NULL,
> &device_type_is_string, &addr_size_cells);
> @@ -831,8 +821,8 @@ static void check_pci_device_bus_num(struct check *c, struct dt_info *dti, struc
> max_bus = fdt32_to_cpu(cells[0]);
> }
> if ((bus_num < min_bus) || (bus_num > max_bus))
> - FAIL(c, dti, "Node %s PCI bus number %d out of range, expected (%d - %d)",
> - node->fullpath, bus_num, min_bus, max_bus);
> + FAIL(c, dti, node, "PCI bus number %d out of range, expected (%d - %d)",
> + bus_num, min_bus, max_bus);
> }
> WARNING(pci_device_bus_num, check_pci_device_bus_num, NULL, ®_format, &pci_bridge);
>
> @@ -849,25 +839,22 @@ static void check_pci_device_reg(struct check *c, struct dt_info *dti, struct no
>
> prop = get_property(node, "reg");
> if (!prop) {
> - FAIL(c, dti, "Node %s missing PCI reg property", node->fullpath);
> + FAIL(c, dti, node, "missing PCI reg property");
> return;
> }
>
> cells = (cell_t *)prop->val.val;
> if (cells[1] || cells[2])
> - FAIL(c, dti, "Node %s PCI reg config space address cells 2 and 3 must be 0",
> - node->fullpath);
> + FAIL(c, dti, node, "PCI reg config space address cells 2 and 3 must be 0");
>
> reg = fdt32_to_cpu(cells[0]);
> dev = (reg & 0xf800) >> 11;
> func = (reg & 0x700) >> 8;
>
> if (reg & 0xff000000)
> - FAIL(c, dti, "Node %s PCI reg address is not configuration space",
> - node->fullpath);
> + FAIL(c, dti, node, "PCI reg address is not configuration space");
> if (reg & 0x000000ff)
> - FAIL(c, dti, "Node %s PCI reg config space address register number must be 0",
> - node->fullpath);
> + FAIL(c, dti, node, "PCI reg config space address register number must be 0");
>
> if (func == 0) {
> snprintf(unit_addr, sizeof(unit_addr), "%x", dev);
> @@ -879,8 +866,8 @@ static void check_pci_device_reg(struct check *c, struct dt_info *dti, struct no
> if (streq(unitname, unit_addr))
> return;
>
> - FAIL(c, dti, "Node %s PCI unit address format error, expected \"%s\"",
> - node->fullpath, unit_addr);
> + FAIL(c, dti, node, "PCI unit address format error, expected \"%s\"",
> + unit_addr);
> }
> WARNING(pci_device_reg, check_pci_device_reg, NULL, ®_format, &pci_bridge);
>
> @@ -936,7 +923,7 @@ static void check_simple_bus_reg(struct check *c, struct dt_info *dti, struct no
>
> if (!cells) {
> if (node->parent->parent && !(node->bus == &simple_bus))
> - FAIL(c, dti, "Node %s missing or empty reg/ranges property", node->fullpath);
> + FAIL(c, dti, node, "missing or empty reg/ranges property");
> return;
> }
>
> @@ -946,8 +933,8 @@ static void check_simple_bus_reg(struct check *c, struct dt_info *dti, struct no
>
> snprintf(unit_addr, sizeof(unit_addr), "%"PRIx64, reg);
> if (!streq(unitname, unit_addr))
> - FAIL(c, dti, "Node %s simple-bus unit address format error, expected \"%s\"",
> - node->fullpath, unit_addr);
> + FAIL(c, dti, node, "simple-bus unit address format error, expected \"%s\"",
> + unit_addr);
> }
> WARNING(simple_bus_reg, check_simple_bus_reg, NULL, ®_format, &simple_bus_bridge);
>
> @@ -963,14 +950,12 @@ static void check_unit_address_format(struct check *c, struct dt_info *dti,
> return;
>
> if (!strncmp(unitname, "0x", 2)) {
> - FAIL(c, dti, "Node %s unit name should not have leading \"0x\"",
> - node->fullpath);
> + FAIL(c, dti, node, "unit name should not have leading \"0x\"");
> /* skip over 0x for next test */
> unitname += 2;
> }
> if (unitname[0] == '0' && isxdigit(unitname[1]))
> - FAIL(c, dti, "Node %s unit name should not have leading 0s",
> - node->fullpath);
> + FAIL(c, dti, node, "unit name should not have leading 0s");
> }
> WARNING(unit_address_format, check_unit_address_format, NULL,
> &node_name_format, &pci_bridge, &simple_bus_bridge);
> @@ -993,12 +978,10 @@ static void check_avoid_default_addr_size(struct check *c, struct dt_info *dti,
> return;
>
> if (node->parent->addr_cells == -1)
> - FAIL(c, dti, "Relying on default #address-cells value for %s",
> - node->fullpath);
> + FAIL(c, dti, node, "Relying on default #address-cells value");
>
> if (node->parent->size_cells == -1)
> - FAIL(c, dti, "Relying on default #size-cells value for %s",
> - node->fullpath);
> + FAIL(c, dti, node, "Relying on default #size-cells value");
> }
> WARNING(avoid_default_addr_size, check_avoid_default_addr_size, NULL,
> &addr_size_cells);
> @@ -1023,8 +1006,7 @@ static void check_avoid_unnecessary_addr_size(struct check *c, struct dt_info *d
> }
>
> if (!has_reg)
> - FAIL(c, dti, "unnecessary #address-cells/#size-cells without \"ranges\" or child \"reg\" property in %s",
> - node->fullpath);
> + FAIL(c, dti, node, "unnecessary #address-cells/#size-cells without \"ranges\" or child \"reg\" property");
> }
> WARNING(avoid_unnecessary_addr_size, check_avoid_unnecessary_addr_size, NULL, &avoid_default_addr_size);
>
> @@ -1046,7 +1028,7 @@ static void check_obsolete_chosen_interrupt_controller(struct check *c,
>
> prop = get_property(chosen, "interrupt-controller");
> if (prop)
> - FAIL(c, dti, "/chosen has obsolete \"interrupt-controller\" "
> + FAIL(c, dti, node, "/chosen has obsolete \"interrupt-controller\" "
> "property");
> }
> WARNING(obsolete_chosen_interrupt_controller,
> @@ -1059,8 +1041,7 @@ static void check_chosen_node_is_root(struct check *c, struct dt_info *dti,
> return;
>
> if (node->parent != dti->dt)
> - FAIL(c, dti, "chosen node '%s' must be at root node",
> - node->fullpath);
> + FAIL(c, dti, node, "chosen node must be at root node");
> }
> WARNING(chosen_node_is_root, check_chosen_node_is_root, NULL);
>
> @@ -1094,7 +1075,7 @@ static void check_chosen_node_stdout_path(struct check *c, struct dt_info *dti,
> prop = get_property(node, "linux,stdout-path");
> if (!prop)
> return;
> - FAIL(c, dti, "Use 'stdout-path' instead of 'linux,stdout-path'");
> + FAIL(c, dti, node, "Use 'stdout-path' instead of 'linux,stdout-path'");
> }
>
> c->data = prop->name;
> @@ -1118,8 +1099,8 @@ static void check_property_phandle_args(struct check *c,
> int cell, cellsize = 0;
>
> if (prop->val.len % sizeof(cell_t)) {
> - FAIL(c, dti, "property '%s' size (%d) is invalid, expected multiple of %zu in node %s",
> - prop->name, prop->val.len, sizeof(cell_t), node->fullpath);
> + FAIL(c, dti, node, "property '%s' size (%d) is invalid, expected multiple of %zu",
> + prop->name, prop->val.len, sizeof(cell_t));
> return;
> }
>
> @@ -1150,14 +1131,14 @@ static void check_property_phandle_args(struct check *c,
> break;
> }
> if (!m)
> - FAIL(c, dti, "Property '%s', cell %d is not a phandle reference in %s",
> - prop->name, cell, node->fullpath);
> + FAIL(c, dti, node, "Property '%s', cell %d is not a phandle reference",
> + prop->name, cell);
> }
>
> provider_node = get_node_by_phandle(root, phandle);
> if (!provider_node) {
> - FAIL(c, dti, "Could not get phandle node for %s:%s(cell %d)",
> - node->fullpath, prop->name, cell);
> + FAIL(c, dti, node, "Could not get phandle node for %s(cell %d)",
> + prop->name, cell);
> break;
> }
>
> @@ -1167,16 +1148,16 @@ static void check_property_phandle_args(struct check *c,
> } else if (provider->optional) {
> cellsize = 0;
> } else {
> - FAIL(c, dti, "Missing property '%s' in node %s or bad phandle (referred from %s:%s[%d])",
> + FAIL(c, dti, node, "Missing property '%s' in node %s or bad phandle (referred from %s[%d])",
> provider->cell_name,
> provider_node->fullpath,
> - node->fullpath, prop->name, cell);
> + prop->name, cell);
> break;
> }
>
> if (prop->val.len < ((cell + cellsize + 1) * sizeof(cell_t))) {
> - FAIL(c, dti, "%s property size (%d) too small for cell size %d in %s",
> - prop->name, prop->val.len, cellsize, node->fullpath);
> + FAIL(c, dti, node, "%s property size (%d) too small for cell size %d",
> + prop->name, prop->val.len, cellsize);
> }
> }
> }
> @@ -1278,8 +1259,8 @@ static void check_deprecated_gpio_property(struct check *c,
> if (!streq(str, "gpio"))
> continue;
>
> - FAIL(c, dti, "'[*-]gpio' is deprecated, use '[*-]gpios' instead for %s:%s",
> - node->fullpath, prop->name);
> + FAIL(c, dti, node, "'[*-]gpio' is deprecated, use '[*-]gpios' instead for %s",
> + prop->name);
> }
>
> }
> @@ -1313,9 +1294,8 @@ static void check_interrupts_property(struct check *c,
> return;
>
> if (irq_prop->val.len % sizeof(cell_t))
> - FAIL(c, dti, "property '%s' size (%d) is invalid, expected multiple of %zu in node %s",
> - irq_prop->name, irq_prop->val.len, sizeof(cell_t),
> - node->fullpath);
> + FAIL(c, dti, node, "property '%s' size (%d) is invalid, expected multiple of %zu",
> + irq_prop->name, irq_prop->val.len, sizeof(cell_t));
>
> while (parent && !prop) {
> if (parent != node && node_is_interrupt_provider(parent)) {
> @@ -1333,14 +1313,12 @@ static void check_interrupts_property(struct check *c,
>
> irq_node = get_node_by_phandle(root, phandle);
> if (!irq_node) {
> - FAIL(c, dti, "Bad interrupt-parent phandle for %s",
> - node->fullpath);
> + FAIL(c, dti, node, "Bad interrupt-parent phandle");
> return;
> }
> if (!node_is_interrupt_provider(irq_node))
> - FAIL(c, dti,
> - "Missing interrupt-controller or interrupt-map property in %s",
> - irq_node->fullpath);
> + FAIL(c, dti, irq_node,
> + "Missing interrupt-controller or interrupt-map property");
>
> break;
> }
> @@ -1349,23 +1327,21 @@ static void check_interrupts_property(struct check *c,
> }
>
> if (!irq_node) {
> - FAIL(c, dti, "Missing interrupt-parent for %s", node->fullpath);
> + FAIL(c, dti, node, "Missing interrupt-parent");
> return;
> }
>
> prop = get_property(irq_node, "#interrupt-cells");
> if (!prop) {
> - FAIL(c, dti, "Missing #interrupt-cells in interrupt-parent %s",
> - irq_node->fullpath);
> + FAIL(c, dti, irq_node, "Missing #interrupt-cells in interrupt-parent");
> return;
> }
>
> irq_cells = propval_cell(prop);
> if (irq_prop->val.len % (irq_cells * sizeof(cell_t))) {
> - FAIL(c, dti,
> - "interrupts size is (%d), expected multiple of %d in %s",
> - irq_prop->val.len, (int)(irq_cells * sizeof(cell_t)),
> - node->fullpath);
> + FAIL(c, dti, node,
> + "interrupts size is (%d), expected multiple of %d",
> + irq_prop->val.len, (int)(irq_cells * sizeof(cell_t)));
> }
> }
> WARNING(interrupts_property, check_interrupts_property, &phandle_references);
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/3] checks: centralize printing of property names in failure messages
[not found] ` <20180131145705.21335-3-robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
@ 2018-02-10 1:09 ` David Gibson
0 siblings, 0 replies; 6+ messages in thread
From: David Gibson @ 2018-02-10 1:09 UTC (permalink / raw)
To: Rob Herring; +Cc: Julia Lawall, devicetree-compiler-u79uwXL29TY76Z2rM5mHXA
[-- Attachment #1: Type: text/plain, Size: 16790 bytes --]
On Wed, Jan 31, 2018 at 08:57:04AM -0600, Rob Herring wrote:
> Some failure messages apply to a specific property. Add a FAIL_PROP()
> macro for failure messages which are specific to a property. With that,
> failure messages can print the property name in a standard way. Once
> source line numbers are supported, then the file and line number of the
> property can be used instead of the node file and line number.
>
> Convert the existing messages related to properties to use the FAIL_PROP
> macro and reword the messages as necessary.
>
> Signed-off-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Applied, thanks.
> ---
> checks.c | 148 ++++++++++++++++++++++++++++++++++-----------------------------
> 1 file changed, 80 insertions(+), 68 deletions(-)
>
> diff --git a/checks.c b/checks.c
> index 54df014c1c79..c07ba4da9e36 100644
> --- a/checks.c
> +++ b/checks.c
> @@ -72,8 +72,9 @@ struct check {
> #define CHECK(nm_, fn_, d_, ...) \
> CHECK_ENTRY(nm_, fn_, d_, false, false, __VA_ARGS__)
>
> -static inline void PRINTF(4, 5) check_msg(struct check *c, struct dt_info *dti,
> +static inline void PRINTF(5, 6) check_msg(struct check *c, struct dt_info *dti,
> struct node *node,
> + struct property *prop,
> const char *fmt, ...)
> {
> va_list ap;
> @@ -84,8 +85,12 @@ static inline void PRINTF(4, 5) check_msg(struct check *c, struct dt_info *dti,
> fprintf(stderr, "%s: %s (%s): ",
> strcmp(dti->outname, "-") ? dti->outname : "<stdout>",
> (c->error) ? "ERROR" : "Warning", c->name);
> - if (node)
> - fprintf(stderr, "%s: ", node->fullpath);
> + if (node) {
> + fprintf(stderr, "%s", node->fullpath);
> + if (prop)
> + fprintf(stderr, ":%s", prop->name);
> + fputs(": ", stderr);
> + }
> vfprintf(stderr, fmt, ap);
> fprintf(stderr, "\n");
> }
> @@ -96,9 +101,17 @@ static inline void PRINTF(4, 5) check_msg(struct check *c, struct dt_info *dti,
> do { \
> TRACE((c), "\t\tFAILED at %s:%d", __FILE__, __LINE__); \
> (c)->status = FAILED; \
> - check_msg((c), dti, node, __VA_ARGS__); \
> + check_msg((c), dti, node, NULL, __VA_ARGS__); \
> + } while (0)
> +
> +#define FAIL_PROP(c, dti, node, prop, ...) \
> + do { \
> + TRACE((c), "\t\tFAILED at %s:%d", __FILE__, __LINE__); \
> + (c)->status = FAILED; \
> + check_msg((c), dti, node, prop, __VA_ARGS__); \
> } while (0)
>
> +
> static void check_nodes_props(struct check *c, struct dt_info *dti, struct node *node)
> {
> struct node *child;
> @@ -129,7 +142,7 @@ static bool run_check(struct check *c, struct dt_info *dti)
> error = error || run_check(prq, dti);
> if (prq->status != PASSED) {
> c->status = PREREQ;
> - check_msg(c, dti, NULL, "Failed prerequisite '%s'",
> + check_msg(c, dti, NULL, NULL, "Failed prerequisite '%s'",
> c->prereq[i]->name);
> }
> }
> @@ -174,7 +187,7 @@ static void check_is_string(struct check *c, struct dt_info *dti,
> return; /* Not present, assumed ok */
>
> if (!data_is_one_string(prop->val))
> - FAIL(c, dti, node, "\"%s\" property is not a string", propname);
> + FAIL_PROP(c, dti, node, prop, "property is not a string");
> }
> #define WARNING_IF_NOT_STRING(nm, propname) \
> WARNING(nm, check_is_string, (propname))
> @@ -198,8 +211,7 @@ static void check_is_string_list(struct check *c, struct dt_info *dti,
> while (rem > 0) {
> l = strnlen(str, rem);
> if (l == rem) {
> - FAIL(c, dti, node, "\"%s\" property is not a string list",
> - propname);
> + FAIL_PROP(c, dti, node, prop, "property is not a string list");
> break;
> }
> rem -= l + 1;
> @@ -222,8 +234,7 @@ static void check_is_cell(struct check *c, struct dt_info *dti,
> return; /* Not present, assumed ok */
>
> if (prop->val.len != sizeof(cell_t))
> - FAIL(c, dti, node, "\"%s\" property is not a single cell",
> - propname);
> + FAIL_PROP(c, dti, node, prop, "property is not a single cell");
> }
> #define WARNING_IF_NOT_CELL(nm, propname) \
> WARNING(nm, check_is_cell, (propname))
> @@ -258,8 +269,7 @@ static void check_duplicate_property_names(struct check *c, struct dt_info *dti,
> if (prop2->deleted)
> continue;
> if (streq(prop->name, prop2->name))
> - FAIL(c, dti, node, "Duplicate property name %s",
> - prop->name);
> + FAIL_PROP(c, dti, node, prop, "Duplicate property name");
> }
> }
> }
> @@ -332,8 +342,8 @@ static void check_property_name_chars(struct check *c, struct dt_info *dti,
> int n = strspn(prop->name, c->data);
>
> if (n < strlen(prop->name))
> - FAIL(c, dti, node, "Bad character '%c' in property name \"%s\"",
> - prop->name[n], prop->name);
> + FAIL_PROP(c, dti, node, prop, "Bad character '%c' in property name",
> + prop->name[n]);
> }
> }
> ERROR(property_name_chars, check_property_name_chars, PROPNODECHARS);
> @@ -364,8 +374,8 @@ static void check_property_name_chars_strict(struct check *c,
> n = strspn(name, c->data);
> }
> if (n < strlen(name))
> - FAIL(c, dti, node, "Character '%c' not recommended in property name \"%s\"",
> - name[n], prop->name);
> + FAIL_PROP(c, dti, node, prop, "Character '%c' not recommended in property name",
> + name[n]);
> }
> }
> CHECK(property_name_chars_strict, check_property_name_chars_strict, PROPNODECHARSSTRICT);
> @@ -438,8 +448,8 @@ static cell_t check_phandle_prop(struct check *c, struct dt_info *dti,
> return 0;
>
> if (prop->val.len != sizeof(cell_t)) {
> - FAIL(c, dti, node, "bad length (%d) %s property",
> - prop->val.len, prop->name);
> + FAIL_PROP(c, dti, node, prop, "bad length (%d) %s property",
> + prop->val.len, prop->name);
> return 0;
> }
>
> @@ -464,7 +474,7 @@ static cell_t check_phandle_prop(struct check *c, struct dt_info *dti,
> phandle = propval_cell(prop);
>
> if ((phandle == 0) || (phandle == -1)) {
> - FAIL(c, dti, node, "bad value (0x%x) in %s property",
> + FAIL_PROP(c, dti, node, prop, "bad value (0x%x) in %s property",
> phandle, prop->name);
> return 0;
> }
> @@ -644,14 +654,12 @@ static void check_alias_paths(struct check *c, struct dt_info *dti,
>
> for_each_property(node, prop) {
> if (!prop->val.val || !get_node_by_path(dti->dt, prop->val.val)) {
> - FAIL(c, dti, node, "aliases property '%s' is not a valid node (%s)",
> - prop->name, prop->val.val);
> + FAIL_PROP(c, dti, node, prop, "aliases property is not a valid node (%s)",
> + prop->val.val);
> continue;
> }
> if (strspn(prop->name, LOWERCASE DIGITS "-") != strlen(prop->name))
> - FAIL(c, dti, node, "aliases property name '%s' is not valid",
> - prop->name);
> -
> + FAIL(c, dti, node, "aliases property name must include only lowercase and '-'");
> }
> }
> WARNING(alias_paths, check_alias_paths, NULL);
> @@ -696,16 +704,16 @@ static void check_reg_format(struct check *c, struct dt_info *dti,
> }
>
> if (prop->val.len == 0)
> - FAIL(c, dti, node, "\"reg\" property is empty");
> + FAIL_PROP(c, dti, node, prop, "property is empty");
>
> addr_cells = node_addr_cells(node->parent);
> size_cells = node_size_cells(node->parent);
> entrylen = (addr_cells + size_cells) * sizeof(cell_t);
>
> if (!entrylen || (prop->val.len % entrylen) != 0)
> - FAIL(c, dti, node, "\"reg\" property has invalid length (%d bytes) "
> - "(#address-cells == %d, #size-cells == %d)",
> - prop->val.len, addr_cells, size_cells);
> + FAIL_PROP(c, dti, node, prop, "property has invalid length (%d bytes) "
> + "(#address-cells == %d, #size-cells == %d)",
> + prop->val.len, addr_cells, size_cells);
> }
> WARNING(reg_format, check_reg_format, NULL, &addr_size_cells);
>
> @@ -720,7 +728,7 @@ static void check_ranges_format(struct check *c, struct dt_info *dti,
> return;
>
> if (!node->parent) {
> - FAIL(c, dti, node, "Root node has a \"ranges\" property");
> + FAIL_PROP(c, dti, node, prop, "Root node has a \"ranges\" property");
> return;
> }
>
> @@ -732,20 +740,20 @@ static void check_ranges_format(struct check *c, struct dt_info *dti,
>
> if (prop->val.len == 0) {
> if (p_addr_cells != c_addr_cells)
> - FAIL(c, dti, node, "empty \"ranges\" property but its "
> - "#address-cells (%d) differs from %s (%d)",
> - c_addr_cells, node->parent->fullpath,
> - p_addr_cells);
> + FAIL_PROP(c, dti, node, prop, "empty \"ranges\" property but its "
> + "#address-cells (%d) differs from %s (%d)",
> + c_addr_cells, node->parent->fullpath,
> + p_addr_cells);
> if (p_size_cells != c_size_cells)
> - FAIL(c, dti, node, "empty \"ranges\" property but its "
> - "#size-cells (%d) differs from %s (%d)",
> - c_size_cells, node->parent->fullpath,
> - p_size_cells);
> + FAIL_PROP(c, dti, node, prop, "empty \"ranges\" property but its "
> + "#size-cells (%d) differs from %s (%d)",
> + c_size_cells, node->parent->fullpath,
> + p_size_cells);
> } else if ((prop->val.len % entrylen) != 0) {
> - FAIL(c, dti, node, "\"ranges\" property has invalid length (%d bytes) "
> - "(parent #address-cells == %d, child #address-cells == %d, "
> - "#size-cells == %d)", prop->val.len,
> - p_addr_cells, c_addr_cells, c_size_cells);
> + FAIL_PROP(c, dti, node, prop, "\"ranges\" property has invalid length (%d bytes) "
> + "(parent #address-cells == %d, child #address-cells == %d, "
> + "#size-cells == %d)", prop->val.len,
> + p_addr_cells, c_addr_cells, c_size_cells);
> }
> }
> WARNING(ranges_format, check_ranges_format, NULL, &addr_size_cells);
> @@ -784,14 +792,14 @@ static void check_pci_bridge(struct check *c, struct dt_info *dti, struct node *
> return;
> }
> if (prop->val.len != (sizeof(cell_t) * 2)) {
> - FAIL(c, dti, node, "bus-range must be 2 cells");
> + FAIL_PROP(c, dti, node, prop, "value must be 2 cells");
> return;
> }
> cells = (cell_t *)prop->val.val;
> if (fdt32_to_cpu(cells[0]) > fdt32_to_cpu(cells[1]))
> - FAIL(c, dti, node, "bus-range 1st cell must be less than or equal to 2nd cell");
> + FAIL_PROP(c, dti, node, prop, "1st cell must be less than or equal to 2nd cell");
> if (fdt32_to_cpu(cells[1]) > 0xff)
> - FAIL(c, dti, node, "bus-range maximum bus number must be less than 256");
> + FAIL_PROP(c, dti, node, prop, "maximum bus number must be less than 256");
> }
> WARNING(pci_bridge, check_pci_bridge, NULL,
> &device_type_is_string, &addr_size_cells);
> @@ -821,8 +829,8 @@ static void check_pci_device_bus_num(struct check *c, struct dt_info *dti, struc
> max_bus = fdt32_to_cpu(cells[0]);
> }
> if ((bus_num < min_bus) || (bus_num > max_bus))
> - FAIL(c, dti, node, "PCI bus number %d out of range, expected (%d - %d)",
> - bus_num, min_bus, max_bus);
> + FAIL_PROP(c, dti, node, prop, "PCI bus number %d out of range, expected (%d - %d)",
> + bus_num, min_bus, max_bus);
> }
> WARNING(pci_device_bus_num, check_pci_device_bus_num, NULL, ®_format, &pci_bridge);
>
> @@ -845,16 +853,16 @@ static void check_pci_device_reg(struct check *c, struct dt_info *dti, struct no
>
> cells = (cell_t *)prop->val.val;
> if (cells[1] || cells[2])
> - FAIL(c, dti, node, "PCI reg config space address cells 2 and 3 must be 0");
> + FAIL_PROP(c, dti, node, prop, "PCI reg config space address cells 2 and 3 must be 0");
>
> reg = fdt32_to_cpu(cells[0]);
> dev = (reg & 0xf800) >> 11;
> func = (reg & 0x700) >> 8;
>
> if (reg & 0xff000000)
> - FAIL(c, dti, node, "PCI reg address is not configuration space");
> + FAIL_PROP(c, dti, node, prop, "PCI reg address is not configuration space");
> if (reg & 0x000000ff)
> - FAIL(c, dti, node, "PCI reg config space address register number must be 0");
> + FAIL_PROP(c, dti, node, prop, "PCI reg config space address register number must be 0");
>
> if (func == 0) {
> snprintf(unit_addr, sizeof(unit_addr), "%x", dev);
> @@ -1028,8 +1036,8 @@ static void check_obsolete_chosen_interrupt_controller(struct check *c,
>
> prop = get_property(chosen, "interrupt-controller");
> if (prop)
> - FAIL(c, dti, node, "/chosen has obsolete \"interrupt-controller\" "
> - "property");
> + FAIL_PROP(c, dti, node, prop,
> + "/chosen has obsolete \"interrupt-controller\" property");
> }
> WARNING(obsolete_chosen_interrupt_controller,
> check_obsolete_chosen_interrupt_controller, NULL);
> @@ -1075,7 +1083,7 @@ static void check_chosen_node_stdout_path(struct check *c, struct dt_info *dti,
> prop = get_property(node, "linux,stdout-path");
> if (!prop)
> return;
> - FAIL(c, dti, node, "Use 'stdout-path' instead of 'linux,stdout-path'");
> + FAIL_PROP(c, dti, node, prop, "Use 'stdout-path' instead");
> }
>
> c->data = prop->name;
> @@ -1099,8 +1107,9 @@ static void check_property_phandle_args(struct check *c,
> int cell, cellsize = 0;
>
> if (prop->val.len % sizeof(cell_t)) {
> - FAIL(c, dti, node, "property '%s' size (%d) is invalid, expected multiple of %zu",
> - prop->name, prop->val.len, sizeof(cell_t));
> + FAIL_PROP(c, dti, node, prop,
> + "property size (%d) is invalid, expected multiple of %zu",
> + prop->val.len, sizeof(cell_t));
> return;
> }
>
> @@ -1131,14 +1140,16 @@ static void check_property_phandle_args(struct check *c,
> break;
> }
> if (!m)
> - FAIL(c, dti, node, "Property '%s', cell %d is not a phandle reference",
> - prop->name, cell);
> + FAIL_PROP(c, dti, node, prop,
> + "cell %d is not a phandle reference",
> + cell);
> }
>
> provider_node = get_node_by_phandle(root, phandle);
> if (!provider_node) {
> - FAIL(c, dti, node, "Could not get phandle node for %s(cell %d)",
> - prop->name, cell);
> + FAIL_PROP(c, dti, node, prop,
> + "Could not get phandle node for (cell %d)",
> + cell);
> break;
> }
>
> @@ -1156,8 +1167,9 @@ static void check_property_phandle_args(struct check *c,
> }
>
> if (prop->val.len < ((cell + cellsize + 1) * sizeof(cell_t))) {
> - FAIL(c, dti, node, "%s property size (%d) too small for cell size %d",
> - prop->name, prop->val.len, cellsize);
> + FAIL_PROP(c, dti, node, prop,
> + "property size (%d) too small for cell size %d",
> + prop->val.len, cellsize);
> }
> }
> }
> @@ -1259,8 +1271,8 @@ static void check_deprecated_gpio_property(struct check *c,
> if (!streq(str, "gpio"))
> continue;
>
> - FAIL(c, dti, node, "'[*-]gpio' is deprecated, use '[*-]gpios' instead for %s",
> - prop->name);
> + FAIL_PROP(c, dti, node, prop,
> + "'[*-]gpio' is deprecated, use '[*-]gpios' instead");
> }
>
> }
> @@ -1294,8 +1306,8 @@ static void check_interrupts_property(struct check *c,
> return;
>
> if (irq_prop->val.len % sizeof(cell_t))
> - FAIL(c, dti, node, "property '%s' size (%d) is invalid, expected multiple of %zu",
> - irq_prop->name, irq_prop->val.len, sizeof(cell_t));
> + FAIL_PROP(c, dti, node, irq_prop, "size (%d) is invalid, expected multiple of %zu",
> + irq_prop->val.len, sizeof(cell_t));
>
> while (parent && !prop) {
> if (parent != node && node_is_interrupt_provider(parent)) {
> @@ -1313,7 +1325,7 @@ static void check_interrupts_property(struct check *c,
>
> irq_node = get_node_by_phandle(root, phandle);
> if (!irq_node) {
> - FAIL(c, dti, node, "Bad interrupt-parent phandle");
> + FAIL_PROP(c, dti, parent, prop, "Bad phandle");
> return;
> }
> if (!node_is_interrupt_provider(irq_node))
> @@ -1339,9 +1351,9 @@ static void check_interrupts_property(struct check *c,
>
> irq_cells = propval_cell(prop);
> if (irq_prop->val.len % (irq_cells * sizeof(cell_t))) {
> - FAIL(c, dti, node,
> - "interrupts size is (%d), expected multiple of %d",
> - irq_prop->val.len, (int)(irq_cells * sizeof(cell_t)));
> + FAIL_PROP(c, dti, node, prop,
> + "size is (%d), expected multiple of %d",
> + irq_prop->val.len, (int)(irq_cells * sizeof(cell_t)));
> }
> }
> WARNING(interrupts_property, check_interrupts_property, &phandle_references);
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-02-10 1:09 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-31 14:57 [PATCH 0/3] checks: failure message improvements Rob Herring
[not found] ` <20180131145705.21335-1-robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2018-01-31 14:57 ` [PATCH 1/3] checks: centralize printing of node path in check_msg Rob Herring
[not found] ` <20180131145705.21335-2-robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2018-02-09 6:53 ` David Gibson
2018-01-31 14:57 ` [PATCH 2/3] checks: centralize printing of property names in failure messages Rob Herring
[not found] ` <20180131145705.21335-3-robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2018-02-10 1:09 ` David Gibson
2018-01-31 14:57 ` [PATCH 3/3] checks: Use source position information for check failures Rob Herring
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.