From: Marc Zyngier <marc.zyngier@arm.com> To: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu Cc: Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will.deacon@arm.com>, Peter Maydell <peter.maydell@linaro.org>, Christoffer Dall <christoffer.dall@linaro.org>, Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>, Mark Rutland <mark.rutland@arm.com>, Robin Murphy <robin.murphy@arm.com>, Ard Biesheuvel <ard.biesheuvel@linaro.org>, Andrew Jones <drjones@redhat.com>, Hanjun Guo <guohanjun@huawei.com>, Jayachandran C <jnair@caviumnetworks.com>, Jon Masters <jcm@redhat.com>, Russell King - ARM Linux <linux@armlinux.org.uk> Subject: [PATCH v3 15/18] arm/arm64: smccc: Make function identifiers an unsigned quantity Date: Thu, 1 Feb 2018 11:46:54 +0000 [thread overview] Message-ID: <20180201114657.7323-16-marc.zyngier@arm.com> (raw) In-Reply-To: <20180201114657.7323-1-marc.zyngier@arm.com> Function identifiers are a 32bit, unsigned quantity. But we never tell so to the compiler, resulting in the following: 4ac: b26187e0 mov x0, #0xffffffff80000001 We thus rely on the firmware narrowing it for us, which is not always a reasonable expectation. Cc: stable@vger.kernel.org Reported-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> Acked-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> Tested-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> Signed-off-by: Marc Zyngier <marc.zyngier@arm.com> --- include/linux/arm-smccc.h | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/include/linux/arm-smccc.h b/include/linux/arm-smccc.h index e1ef944ef1da..dd44d8458c04 100644 --- a/include/linux/arm-smccc.h +++ b/include/linux/arm-smccc.h @@ -14,14 +14,16 @@ #ifndef __LINUX_ARM_SMCCC_H #define __LINUX_ARM_SMCCC_H +#include <uapi/linux/const.h> + /* * This file provides common defines for ARM SMC Calling Convention as * specified in * http://infocenter.arm.com/help/topic/com.arm.doc.den0028a/index.html */ -#define ARM_SMCCC_STD_CALL 0 -#define ARM_SMCCC_FAST_CALL 1 +#define ARM_SMCCC_STD_CALL _AC(0,U) +#define ARM_SMCCC_FAST_CALL _AC(1,U) #define ARM_SMCCC_TYPE_SHIFT 31 #define ARM_SMCCC_SMC_32 0 -- 2.14.2
WARNING: multiple messages have this Message-ID (diff)
From: marc.zyngier@arm.com (Marc Zyngier) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v3 15/18] arm/arm64: smccc: Make function identifiers an unsigned quantity Date: Thu, 1 Feb 2018 11:46:54 +0000 [thread overview] Message-ID: <20180201114657.7323-16-marc.zyngier@arm.com> (raw) In-Reply-To: <20180201114657.7323-1-marc.zyngier@arm.com> Function identifiers are a 32bit, unsigned quantity. But we never tell so to the compiler, resulting in the following: 4ac: b26187e0 mov x0, #0xffffffff80000001 We thus rely on the firmware narrowing it for us, which is not always a reasonable expectation. Cc: stable at vger.kernel.org Reported-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> Acked-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> Tested-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> Signed-off-by: Marc Zyngier <marc.zyngier@arm.com> --- include/linux/arm-smccc.h | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/include/linux/arm-smccc.h b/include/linux/arm-smccc.h index e1ef944ef1da..dd44d8458c04 100644 --- a/include/linux/arm-smccc.h +++ b/include/linux/arm-smccc.h @@ -14,14 +14,16 @@ #ifndef __LINUX_ARM_SMCCC_H #define __LINUX_ARM_SMCCC_H +#include <uapi/linux/const.h> + /* * This file provides common defines for ARM SMC Calling Convention as * specified in * http://infocenter.arm.com/help/topic/com.arm.doc.den0028a/index.html */ -#define ARM_SMCCC_STD_CALL 0 -#define ARM_SMCCC_FAST_CALL 1 +#define ARM_SMCCC_STD_CALL _AC(0,U) +#define ARM_SMCCC_FAST_CALL _AC(1,U) #define ARM_SMCCC_TYPE_SHIFT 31 #define ARM_SMCCC_SMC_32 0 -- 2.14.2
next prev parent reply other threads:[~2018-02-01 11:48 UTC|newest] Thread overview: 127+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-02-01 11:46 [PATCH v3 00/18] arm64: Add SMCCC v1.1 support and CVE-2017-5715 (Spectre variant 2) mitigation Marc Zyngier 2018-02-01 11:46 ` Marc Zyngier 2018-02-01 11:46 ` [PATCH v3 01/18] arm64: KVM: Fix SMCCC handling of unimplemented SMC/HVC calls Marc Zyngier 2018-02-01 11:46 ` Marc Zyngier 2018-02-01 11:46 ` [PATCH v3 02/18] arm: " Marc Zyngier 2018-02-01 11:46 ` Marc Zyngier 2018-02-01 11:46 ` Marc Zyngier 2018-02-01 11:46 ` [PATCH v3 03/18] arm64: KVM: Increment PC after handling an SMC trap Marc Zyngier 2018-02-01 11:46 ` Marc Zyngier 2018-02-01 11:46 ` Marc Zyngier 2018-02-02 12:33 ` Christoffer Dall 2018-02-02 12:33 ` Christoffer Dall 2018-02-01 11:46 ` [PATCH v3 04/18] arm/arm64: KVM: Consolidate the PSCI include files Marc Zyngier 2018-02-01 11:46 ` Marc Zyngier 2018-02-02 12:33 ` Christoffer Dall 2018-02-02 12:33 ` Christoffer Dall 2018-02-01 11:46 ` [PATCH v3 05/18] arm/arm64: KVM: Add PSCI_VERSION helper Marc Zyngier 2018-02-01 11:46 ` Marc Zyngier 2018-02-01 11:46 ` Marc Zyngier 2018-02-02 12:33 ` Christoffer Dall 2018-02-02 12:33 ` Christoffer Dall 2018-02-02 12:33 ` Christoffer Dall 2018-02-01 11:46 ` [PATCH v3 06/18] arm/arm64: KVM: Add smccc accessors to PSCI code Marc Zyngier 2018-02-01 11:46 ` Marc Zyngier 2018-02-02 12:33 ` Christoffer Dall 2018-02-02 12:33 ` Christoffer Dall 2018-02-01 11:46 ` [PATCH v3 07/18] arm/arm64: KVM: Implement PSCI 1.0 support Marc Zyngier 2018-02-01 11:46 ` Marc Zyngier 2018-02-02 12:33 ` Christoffer Dall 2018-02-02 12:33 ` Christoffer Dall 2018-02-01 11:46 ` [PATCH v3 08/18] arm/arm64: KVM: Add PSCI version selection API Marc Zyngier 2018-02-01 11:46 ` Marc Zyngier 2018-02-02 20:17 ` Andrew Jones 2018-02-02 20:17 ` Andrew Jones 2018-02-02 20:17 ` Andrew Jones 2018-02-03 11:59 ` Marc Zyngier 2018-02-03 11:59 ` Marc Zyngier 2018-02-03 11:59 ` Marc Zyngier 2018-02-04 12:37 ` Christoffer Dall 2018-02-04 12:37 ` Christoffer Dall 2018-02-05 9:24 ` Marc Zyngier 2018-02-05 9:24 ` Marc Zyngier 2018-02-05 9:24 ` Marc Zyngier 2018-02-05 9:58 ` Andrew Jones 2018-02-05 9:58 ` Andrew Jones 2018-02-05 9:58 ` Andrew Jones 2018-02-05 10:42 ` Marc Zyngier 2018-02-05 10:42 ` Marc Zyngier 2018-02-05 10:50 ` Christoffer Dall 2018-02-05 10:50 ` Christoffer Dall 2018-02-05 11:08 ` Marc Zyngier 2018-02-05 11:08 ` Marc Zyngier 2018-02-05 9:47 ` Andrew Jones 2018-02-05 9:47 ` Andrew Jones 2018-02-05 9:47 ` Andrew Jones 2018-02-05 9:25 ` Andrew Jones 2018-02-05 9:25 ` Andrew Jones 2018-02-04 12:38 ` Christoffer Dall 2018-02-04 12:38 ` Christoffer Dall 2018-02-05 9:30 ` Marc Zyngier 2018-02-05 9:30 ` Marc Zyngier 2018-02-01 11:46 ` [PATCH v3 09/18] arm/arm64: KVM: Advertise SMCCC v1.1 Marc Zyngier 2018-02-01 11:46 ` Marc Zyngier 2018-02-01 11:46 ` Marc Zyngier 2018-02-04 18:38 ` Christoffer Dall 2018-02-04 18:38 ` Christoffer Dall 2018-02-01 11:46 ` [PATCH v3 10/18] arm/arm64: KVM: Turn kvm_psci_version into a static inline Marc Zyngier 2018-02-01 11:46 ` Marc Zyngier 2018-02-04 18:38 ` Christoffer Dall 2018-02-04 18:38 ` Christoffer Dall 2018-02-04 18:38 ` Christoffer Dall 2018-02-01 11:46 ` [PATCH v3 11/18] arm64: KVM: Report SMCCC_ARCH_WORKAROUND_1 BP hardening support Marc Zyngier 2018-02-01 11:46 ` Marc Zyngier 2018-02-04 18:39 ` Christoffer Dall 2018-02-04 18:39 ` Christoffer Dall 2018-02-01 11:46 ` [PATCH v3 12/18] arm64: KVM: Add SMCCC_ARCH_WORKAROUND_1 fast handling Marc Zyngier 2018-02-01 11:46 ` Marc Zyngier 2018-02-04 18:39 ` Christoffer Dall 2018-02-04 18:39 ` Christoffer Dall 2018-02-05 9:08 ` Marc Zyngier 2018-02-05 9:08 ` Marc Zyngier 2018-02-05 9:08 ` Marc Zyngier 2018-02-05 10:18 ` Christoffer Dall 2018-02-05 10:18 ` Christoffer Dall 2018-02-05 10:18 ` Christoffer Dall 2018-02-01 11:46 ` [PATCH v3 13/18] firmware/psci: Expose PSCI conduit Marc Zyngier 2018-02-01 11:46 ` Marc Zyngier 2018-02-01 12:25 ` Robin Murphy 2018-02-01 12:25 ` Robin Murphy 2018-02-01 11:46 ` [PATCH v3 14/18] firmware/psci: Expose SMCCC version through psci_ops Marc Zyngier 2018-02-01 11:46 ` Marc Zyngier 2018-02-01 12:32 ` Robin Murphy 2018-02-01 12:32 ` Robin Murphy 2018-02-01 12:48 ` Marc Zyngier 2018-02-01 12:48 ` Marc Zyngier 2018-02-01 12:48 ` Marc Zyngier 2018-02-01 21:17 ` Ard Biesheuvel 2018-02-01 21:17 ` Ard Biesheuvel 2018-02-01 11:46 ` Marc Zyngier [this message] 2018-02-01 11:46 ` [PATCH v3 15/18] arm/arm64: smccc: Make function identifiers an unsigned quantity Marc Zyngier 2018-02-01 12:40 ` Robin Murphy 2018-02-01 12:40 ` Robin Murphy 2018-02-01 12:40 ` Robin Murphy 2018-02-01 12:44 ` Ard Biesheuvel 2018-02-01 12:44 ` Ard Biesheuvel 2018-02-01 11:46 ` [PATCH v3 16/18] arm/arm64: smccc: Implement SMCCC v1.1 inline primitive Marc Zyngier 2018-02-01 11:46 ` Marc Zyngier 2018-02-01 13:34 ` Robin Murphy 2018-02-01 13:34 ` Robin Murphy 2018-02-01 13:54 ` Marc Zyngier 2018-02-01 13:54 ` Marc Zyngier 2018-02-01 14:18 ` Robin Murphy 2018-02-01 14:18 ` Robin Murphy 2018-02-01 11:46 ` [PATCH v3 17/18] arm64: Add ARM_SMCCC_ARCH_WORKAROUND_1 BP hardening support Marc Zyngier 2018-02-01 11:46 ` Marc Zyngier 2018-02-01 11:46 ` [PATCH v3 18/18] arm64: Kill PSCI_GET_VERSION as a variant-2 workaround Marc Zyngier 2018-02-01 11:46 ` Marc Zyngier 2018-02-02 4:05 ` Hanjun Guo 2018-02-02 4:05 ` Hanjun Guo 2018-02-02 4:05 ` Hanjun Guo 2018-02-02 13:17 ` Marc Zyngier 2018-02-02 13:17 ` Marc Zyngier 2018-02-02 13:17 ` Marc Zyngier 2018-02-01 13:59 ` [PATCH v3 00/18] arm64: Add SMCCC v1.1 support and CVE-2017-5715 (Spectre variant 2) mitigation Ard Biesheuvel 2018-02-01 13:59 ` Ard Biesheuvel 2018-02-01 14:20 ` Marc Zyngier 2018-02-01 14:20 ` Marc Zyngier
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20180201114657.7323-16-marc.zyngier@arm.com \ --to=marc.zyngier@arm.com \ --cc=ard.biesheuvel@linaro.org \ --cc=catalin.marinas@arm.com \ --cc=christoffer.dall@linaro.org \ --cc=drjones@redhat.com \ --cc=guohanjun@huawei.com \ --cc=jcm@redhat.com \ --cc=jnair@caviumnetworks.com \ --cc=kvmarm@lists.cs.columbia.edu \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux@armlinux.org.uk \ --cc=lorenzo.pieralisi@arm.com \ --cc=mark.rutland@arm.com \ --cc=peter.maydell@linaro.org \ --cc=robin.murphy@arm.com \ --cc=will.deacon@arm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.