All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ARM: dts: imx53: use PMIC's TSI pins in adc mode
@ 2018-01-15 14:28 Sebastian Reichel
  2018-02-02  7:00   ` Shawn Guo
  0 siblings, 1 reply; 3+ messages in thread
From: Sebastian Reichel @ 2018-01-15 14:28 UTC (permalink / raw)
  To: Shawn Guo, Sascha Hauer, Fabio Estevam
  Cc: Rob Herring, Mark Rutland, devicetree, linux-kernel, Sebastian Reichel

PPD uses the PMIC's TSI pins in general purpose ADC mode.

Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
---
 arch/arm/boot/dts/imx53-ppd.dts | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/arch/arm/boot/dts/imx53-ppd.dts b/arch/arm/boot/dts/imx53-ppd.dts
index 123297da43a7..80224fa995f9 100644
--- a/arch/arm/boot/dts/imx53-ppd.dts
+++ b/arch/arm/boot/dts/imx53-ppd.dts
@@ -132,6 +132,14 @@
 		enable-active-high;
 	};
 
+	reg_tsiref: tsiref {
+		compatible = "regulator-fixed";
+		regulator-name = "tsiref";
+		regulator-min-microvolt = <2500000>;
+		regulator-max-microvolt = <2500000>;
+		regulator-always-on;
+	};
+
 	pwm_bl: backlight {
 		compatible = "pwm-backlight";
 		pwms = <&pwm2 0 50000>;
@@ -295,6 +303,9 @@
 		interrupts = <12 0x8>;
 		spi-max-frequency = <1000000>;
 
+		dlg,tsi-as-adc;
+		tsiref-supply = <&reg_tsiref>;
+
 		regulators {
 			buck1_reg: buck1 {
 				regulator-name = "BUCKCORE";
-- 
2.15.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] ARM: dts: imx53: use PMIC's TSI pins in adc mode
@ 2018-02-02  7:00   ` Shawn Guo
  0 siblings, 0 replies; 3+ messages in thread
From: Shawn Guo @ 2018-02-02  7:00 UTC (permalink / raw)
  To: Sebastian Reichel
  Cc: Sascha Hauer, Fabio Estevam, Rob Herring, Mark Rutland,
	devicetree, linux-kernel

On Mon, Jan 15, 2018 at 03:28:20PM +0100, Sebastian Reichel wrote:
> PPD uses the PMIC's TSI pins in general purpose ADC mode.
> 
> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk>

s/imx53/imx53-ppd

> ---
>  arch/arm/boot/dts/imx53-ppd.dts | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/imx53-ppd.dts b/arch/arm/boot/dts/imx53-ppd.dts
> index 123297da43a7..80224fa995f9 100644
> --- a/arch/arm/boot/dts/imx53-ppd.dts
> +++ b/arch/arm/boot/dts/imx53-ppd.dts
> @@ -132,6 +132,14 @@
>  		enable-active-high;
>  	};
>  
> +	reg_tsiref: tsiref {

A better node name should be regulator-tsiref.

> +		compatible = "regulator-fixed";
> +		regulator-name = "tsiref";
> +		regulator-min-microvolt = <2500000>;
> +		regulator-max-microvolt = <2500000>;
> +		regulator-always-on;
> +	};
> +
>  	pwm_bl: backlight {
>  		compatible = "pwm-backlight";
>  		pwms = <&pwm2 0 50000>;
> @@ -295,6 +303,9 @@
>  		interrupts = <12 0x8>;
>  		spi-max-frequency = <1000000>;
>  

This new line can be dropped now.

I fixed up all these, and applied the patch.

Shawn 

> +		dlg,tsi-as-adc;
> +		tsiref-supply = <&reg_tsiref>;
> +
>  		regulators {
>  			buck1_reg: buck1 {
>  				regulator-name = "BUCKCORE";
> -- 
> 2.15.1
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ARM: dts: imx53: use PMIC's TSI pins in adc mode
@ 2018-02-02  7:00   ` Shawn Guo
  0 siblings, 0 replies; 3+ messages in thread
From: Shawn Guo @ 2018-02-02  7:00 UTC (permalink / raw)
  To: Sebastian Reichel
  Cc: Sascha Hauer, Fabio Estevam, Rob Herring, Mark Rutland,
	devicetree-u79uwXL29TY76Z2rM5mHXA,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA

On Mon, Jan 15, 2018 at 03:28:20PM +0100, Sebastian Reichel wrote:
> PPD uses the PMIC's TSI pins in general purpose ADC mode.
> 
> Signed-off-by: Sebastian Reichel <sebastian.reichel-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org>

s/imx53/imx53-ppd

> ---
>  arch/arm/boot/dts/imx53-ppd.dts | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/imx53-ppd.dts b/arch/arm/boot/dts/imx53-ppd.dts
> index 123297da43a7..80224fa995f9 100644
> --- a/arch/arm/boot/dts/imx53-ppd.dts
> +++ b/arch/arm/boot/dts/imx53-ppd.dts
> @@ -132,6 +132,14 @@
>  		enable-active-high;
>  	};
>  
> +	reg_tsiref: tsiref {

A better node name should be regulator-tsiref.

> +		compatible = "regulator-fixed";
> +		regulator-name = "tsiref";
> +		regulator-min-microvolt = <2500000>;
> +		regulator-max-microvolt = <2500000>;
> +		regulator-always-on;
> +	};
> +
>  	pwm_bl: backlight {
>  		compatible = "pwm-backlight";
>  		pwms = <&pwm2 0 50000>;
> @@ -295,6 +303,9 @@
>  		interrupts = <12 0x8>;
>  		spi-max-frequency = <1000000>;
>  

This new line can be dropped now.

I fixed up all these, and applied the patch.

Shawn 

> +		dlg,tsi-as-adc;
> +		tsiref-supply = <&reg_tsiref>;
> +
>  		regulators {
>  			buck1_reg: buck1 {
>  				regulator-name = "BUCKCORE";
> -- 
> 2.15.1
> 
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-02-02  7:01 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-15 14:28 [PATCH] ARM: dts: imx53: use PMIC's TSI pins in adc mode Sebastian Reichel
2018-02-02  7:00 ` Shawn Guo
2018-02-02  7:00   ` Shawn Guo

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.