* [PATCH] Fix typo IBRS_ATT, which should be IBRS_ALL
@ 2018-02-02 19:12 Darren Kenny
2018-02-02 22:19 ` [tip:x86/pti] x86/speculation: " tip-bot for Darren Kenny
2018-02-02 23:42 ` [PATCH] " David Woodhouse
0 siblings, 2 replies; 5+ messages in thread
From: Darren Kenny @ 2018-02-02 19:12 UTC (permalink / raw)
To: linux-kernel
Cc: Thomas Gleixner, Ingo Molnar, H. Peter Anvin, x86,
David Woodhouse, Arjan van de Ven, Borislav Petkov, Andi Kleen,
Tom Lendacky, Masami Hiramatsu, Darren Kenny,
Konrad Rzeszutek Wilk
Fixes a typo in commit 117cc7a908c83697b0b737d15ae1eb5943afe35b
("x86/retpoline: Fill return stack buffer on vmexit")
Signed-off-by: Darren Kenny <darren.kenny@oracle.com>
Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
---
arch/x86/include/asm/nospec-branch.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/include/asm/nospec-branch.h b/arch/x86/include/asm/nospec-branch.h
index 4ad4108..5b778d2 100644
--- a/arch/x86/include/asm/nospec-branch.h
+++ b/arch/x86/include/asm/nospec-branch.h
@@ -201,7 +201,7 @@ extern char __indirect_thunk_end[];
* On VMEXIT we must ensure that no RSB predictions learned in the guest
* can be followed in the host, by overwriting the RSB completely. Both
* retpoline and IBRS mitigations for Spectre v2 need this; only on future
- * CPUs with IBRS_ATT *might* it be avoided.
+ * CPUs with IBRS_ALL *might* it be avoided.
*/
static inline void vmexit_fill_RSB(void)
{
--
2.9.5
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [tip:x86/pti] x86/speculation: Fix typo IBRS_ATT, which should be IBRS_ALL
2018-02-02 19:12 [PATCH] Fix typo IBRS_ATT, which should be IBRS_ALL Darren Kenny
@ 2018-02-02 22:19 ` tip-bot for Darren Kenny
2018-02-02 23:42 ` [PATCH] " David Woodhouse
1 sibling, 0 replies; 5+ messages in thread
From: tip-bot for Darren Kenny @ 2018-02-02 22:19 UTC (permalink / raw)
To: linux-tip-commits
Cc: hpa, mingo, arjan, konrad.wilk, linux-kernel, darren.kenny, ak,
thomas.lendacky, tglx, bp, dwmw, mhiramat
Commit-ID: af189c95a371b59f493dbe0f50c0a09724868881
Gitweb: https://git.kernel.org/tip/af189c95a371b59f493dbe0f50c0a09724868881
Author: Darren Kenny <darren.kenny@oracle.com>
AuthorDate: Fri, 2 Feb 2018 19:12:20 +0000
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitDate: Fri, 2 Feb 2018 23:13:57 +0100
x86/speculation: Fix typo IBRS_ATT, which should be IBRS_ALL
Fixes: 117cc7a908c83 ("x86/retpoline: Fill return stack buffer on vmexit")
Signed-off-by: Darren Kenny <darren.kenny@oracle.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: Tom Lendacky <thomas.lendacky@amd.com>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Arjan van de Ven <arjan@linux.intel.com>
Cc: David Woodhouse <dwmw@amazon.co.uk>
Link: https://lkml.kernel.org/r/20180202191220.blvgkgutojecxr3b@starbug-vm.ie.oracle.com
---
arch/x86/include/asm/nospec-branch.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/include/asm/nospec-branch.h b/arch/x86/include/asm/nospec-branch.h
index d15d471..4d57894 100644
--- a/arch/x86/include/asm/nospec-branch.h
+++ b/arch/x86/include/asm/nospec-branch.h
@@ -150,7 +150,7 @@ extern char __indirect_thunk_end[];
* On VMEXIT we must ensure that no RSB predictions learned in the guest
* can be followed in the host, by overwriting the RSB completely. Both
* retpoline and IBRS mitigations for Spectre v2 need this; only on future
- * CPUs with IBRS_ATT *might* it be avoided.
+ * CPUs with IBRS_ALL *might* it be avoided.
*/
static inline void vmexit_fill_RSB(void)
{
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] Fix typo IBRS_ATT, which should be IBRS_ALL
2018-02-02 19:12 [PATCH] Fix typo IBRS_ATT, which should be IBRS_ALL Darren Kenny
2018-02-02 22:19 ` [tip:x86/pti] x86/speculation: " tip-bot for Darren Kenny
@ 2018-02-02 23:42 ` David Woodhouse
2018-02-05 11:00 ` Darren Kenny
1 sibling, 1 reply; 5+ messages in thread
From: David Woodhouse @ 2018-02-02 23:42 UTC (permalink / raw)
To: Darren Kenny, linux-kernel
Cc: Thomas Gleixner, Ingo Molnar, H. Peter Anvin, x86,
Arjan van de Ven, Borislav Petkov, Andi Kleen, Tom Lendacky,
Masami Hiramatsu, Konrad Rzeszutek Wilk
[-- Attachment #1: Type: text/plain, Size: 470 bytes --]
On Fri, 2018-02-02 at 19:12 +0000, Darren Kenny wrote:
> Fixes a typo in commit 117cc7a908c83697b0b737d15ae1eb5943afe35b
> ("x86/retpoline: Fill return stack buffer on vmexit")
>
> Signed-off-by: Darren Kenny <darren.kenny@oracle.com>
> Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Not strictly a typo; that was the original name for it. "IBRS all the
time". But yes, it should be IBRS_ALL now.
Acked-by: David Woodhouse <dwmw@amazon.co.uk>
[-- Attachment #2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 5213 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Fix typo IBRS_ATT, which should be IBRS_ALL
2018-02-02 23:42 ` [PATCH] " David Woodhouse
@ 2018-02-05 11:00 ` Darren Kenny
2018-02-05 11:15 ` David Woodhouse
0 siblings, 1 reply; 5+ messages in thread
From: Darren Kenny @ 2018-02-05 11:00 UTC (permalink / raw)
To: David Woodhouse
Cc: linux-kernel, Thomas Gleixner, Ingo Molnar, H. Peter Anvin, x86,
Arjan van de Ven, Borislav Petkov, Andi Kleen, Tom Lendacky,
Masami Hiramatsu, Konrad Rzeszutek Wilk
On Fri, Feb 02, 2018 at 11:42:12PM +0000, David Woodhouse wrote:
>On Fri, 2018-02-02 at 19:12 +0000, Darren Kenny wrote:
>> Fixes a typo in commit 117cc7a908c83697b0b737d15ae1eb5943afe35b
>> ("x86/retpoline: Fill return stack buffer on vmexit")
>>
>> Signed-off-by: Darren Kenny <darren.kenny@oracle.com>
>> Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
>
>Not strictly a typo; that was the original name for it. "IBRS all the
>time". But yes, it should be IBRS_ALL now.
>
>Acked-by: David Woodhouse <dwmw@amazon.co.uk>
Thanks David.
I'll send out another patch with this snippet of information in it
too, and including your Acked-by.
(The subject like will be slightly different)
Thanks,
Darren.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Fix typo IBRS_ATT, which should be IBRS_ALL
2018-02-05 11:00 ` Darren Kenny
@ 2018-02-05 11:15 ` David Woodhouse
0 siblings, 0 replies; 5+ messages in thread
From: David Woodhouse @ 2018-02-05 11:15 UTC (permalink / raw)
To: Darren Kenny
Cc: linux-kernel, Thomas Gleixner, Ingo Molnar, H. Peter Anvin, x86,
Arjan van de Ven, Borislav Petkov, Andi Kleen, Tom Lendacky,
Masami Hiramatsu, Konrad Rzeszutek Wilk
[-- Attachment #1: Type: text/plain, Size: 810 bytes --]
On Mon, 2018-02-05 at 11:00 +0000, Darren Kenny wrote:
> On Fri, Feb 02, 2018 at 11:42:12PM +0000, David Woodhouse wrote:
> >
> > On Fri, 2018-02-02 at 19:12 +0000, Darren Kenny wrote:
> > >
> > > Fixes a typo in commit 117cc7a908c83697b0b737d15ae1eb5943afe35b
> > > ("x86/retpoline: Fill return stack buffer on vmexit")
> > >
> > > Signed-off-by: Darren Kenny <darren.kenny@oracle.com>
> > > Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> > Not strictly a typo; that was the original name for it. "IBRS all
> > the
> > time". But yes, it should be IBRS_ALL now.
> >
> > Acked-by: David Woodhouse <dwmw@amazon.co.uk>
> Thanks David.
>
> I'll send out another patch with this snippet of information in it
> too, and including your Acked-by.
It's in Linus's tree already.
[-- Attachment #2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 5213 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-02-05 11:16 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-02 19:12 [PATCH] Fix typo IBRS_ATT, which should be IBRS_ALL Darren Kenny
2018-02-02 22:19 ` [tip:x86/pti] x86/speculation: " tip-bot for Darren Kenny
2018-02-02 23:42 ` [PATCH] " David Woodhouse
2018-02-05 11:00 ` Darren Kenny
2018-02-05 11:15 ` David Woodhouse
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.