* [U-Boot] [PATCH 0/2] ARM: omap3: evm: Fix serial driver compiler warnings
@ 2018-02-05 1:04 Derald D. Woods
2018-02-05 1:04 ` [U-Boot] [PATCH 1/2] ARM: omap3: ti_omap3_common: Fix CONFIG_SYS_NS16550_REG_SIZE compiler warning Derald D. Woods
2018-02-05 1:04 ` [U-Boot] [PATCH 2/2] ARM: omap3: evm: Remove CONFIG_SYS_NS16550_REG_SIZE undefine Derald D. Woods
0 siblings, 2 replies; 7+ messages in thread
From: Derald D. Woods @ 2018-02-05 1:04 UTC (permalink / raw)
To: u-boot
This small series resolves compiler warnings that are generated when DM_SERIAL
is enabled for OMAP3 boards using "include/configs/ti_omap3_common.h".
Derald D. Woods (2):
ARM: omap3: ti_omap3_common: Fix CONFIG_SYS_NS16550_REG_SIZE compiler warning
ARM: omap3: evm: Remove CONFIG_SYS_NS16550_REG_SIZE undefine
include/configs/omap3_evm.h | 3 ---
include/configs/ti_omap3_common.h | 10 ++++++----
2 files changed, 6 insertions(+), 7 deletions(-)
--
2.16.1
^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH 1/2] ARM: omap3: ti_omap3_common: Fix CONFIG_SYS_NS16550_REG_SIZE compiler warning
2018-02-05 1:04 [U-Boot] [PATCH 0/2] ARM: omap3: evm: Fix serial driver compiler warnings Derald D. Woods
@ 2018-02-05 1:04 ` Derald D. Woods
2018-02-05 15:50 ` Tom Rini
2018-02-08 12:27 ` [U-Boot] [U-Boot, " Tom Rini
2018-02-05 1:04 ` [U-Boot] [PATCH 2/2] ARM: omap3: evm: Remove CONFIG_SYS_NS16550_REG_SIZE undefine Derald D. Woods
1 sibling, 2 replies; 7+ messages in thread
From: Derald D. Woods @ 2018-02-05 1:04 UTC (permalink / raw)
To: u-boot
This commit fixes the following compiler warnings when DM_SERIAL is
enabled.
---8<-------------------------------------------------------------------
...
CC spl/board/ti/evm/evm.o
In file included from /solution/scm/u-boot-master/board/ti/evm/evm.c:16:0:
/solution/scm/u-boot-master/include/ns16550.h:31:0: warning: "CONFIG_SYS_NS16550_REG_SIZE" redefined
#define CONFIG_SYS_NS16550_REG_SIZE (-1)
In file included from /solution/scm/u-boot-master/include/configs/omap3_evm.h:22:0,
from include/config.h:5,
from /solution/scm/u-boot-master/include/common.h:21,
from /solution/scm/u-boot-master/board/ti/evm/evm.c:14:
/solution/scm/u-boot-master/include/configs/ti_omap3_common.h:33:0: note: this is the location of the previous definition
# define CONFIG_SYS_NS16550_REG_SIZE (-4)
LD spl/board/ti/evm/built-in.o
...
CC spl/drivers/serial/ns16550.o
In file included from /solution/scm/u-boot-master/drivers/serial/ns16550.c:11:0:
/solution/scm/u-boot-master/include/ns16550.h:31:0: warning: "CONFIG_SYS_NS16550_REG_SIZE" redefined
#define CONFIG_SYS_NS16550_REG_SIZE (-1)
In file included from /solution/scm/u-boot-master/include/configs/omap3_evm.h:22:0,
from include/config.h:5,
from /solution/scm/u-boot-master/include/common.h:21,
from /solution/scm/u-boot-master/drivers/serial/ns16550.c:7:
/solution/scm/u-boot-master/include/configs/ti_omap3_common.h:33:0: note: this is the location of the previous definition
# define CONFIG_SYS_NS16550_REG_SIZE (-4)
LD spl/drivers/serial/built-in.o
...
---8<-------------------------------------------------------------------
Signed-off-by: Derald D. Woods <woods.technical@gmail.com>
---
include/configs/ti_omap3_common.h | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/include/configs/ti_omap3_common.h b/include/configs/ti_omap3_common.h
index 72c4b184d9..cd6a9c2197 100644
--- a/include/configs/ti_omap3_common.h
+++ b/include/configs/ti_omap3_common.h
@@ -28,10 +28,12 @@
/* NS16550 Configuration */
#define V_NS16550_CLK 48000000 /* 48MHz (APLL96/2) */
#define CONFIG_SYS_NS16550_CLK V_NS16550_CLK
-#ifdef CONFIG_SPL_BUILD
-# define CONFIG_SYS_NS16550_SERIAL
-# define CONFIG_SYS_NS16550_REG_SIZE (-4)
-#endif
+#if defined(CONFIG_SPL_BUILD)
+#define CONFIG_SYS_NS16550_SERIAL
+#if !defined(CONFIG_DM_SERIAL)
+#define CONFIG_SYS_NS16550_REG_SIZE (-4)
+#endif /* !CONFIG_DM_SERIAL */
+#endif /* CONFIG_SPL_BUILD */
#define CONFIG_SYS_BAUDRATE_TABLE {4800, 9600, 19200, 38400, 57600, \
115200}
--
2.16.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH 2/2] ARM: omap3: evm: Remove CONFIG_SYS_NS16550_REG_SIZE undefine
2018-02-05 1:04 [U-Boot] [PATCH 0/2] ARM: omap3: evm: Fix serial driver compiler warnings Derald D. Woods
2018-02-05 1:04 ` [U-Boot] [PATCH 1/2] ARM: omap3: ti_omap3_common: Fix CONFIG_SYS_NS16550_REG_SIZE compiler warning Derald D. Woods
@ 2018-02-05 1:04 ` Derald D. Woods
2018-02-05 15:50 ` Tom Rini
2018-02-08 12:27 ` [U-Boot] [U-Boot, " Tom Rini
1 sibling, 2 replies; 7+ messages in thread
From: Derald D. Woods @ 2018-02-05 1:04 UTC (permalink / raw)
To: u-boot
This commit removes an attempt to workaround a previous compilation
warning that is is now fixed in "include/configs/ti_omap3_common.h".
Signed-off-by: Derald D. Woods <woods.technical@gmail.com>
---
include/configs/omap3_evm.h | 3 ---
1 file changed, 3 deletions(-)
diff --git a/include/configs/omap3_evm.h b/include/configs/omap3_evm.h
index 71d49e3cd3..c143c5af5c 100644
--- a/include/configs/omap3_evm.h
+++ b/include/configs/omap3_evm.h
@@ -40,9 +40,6 @@
#undef CONFIG_CONS_INDEX
#define CONFIG_CONS_INDEX 1
#define CONFIG_SYS_NS16550_COM1 OMAP34XX_UART1
-#if defined(CONFIG_SPL_BUILD)
-#undef CONFIG_SYS_NS16550_REG_SIZE
-#endif /* CONFIG_SPL_BUILD */
/* NAND */
#if defined(CONFIG_NAND)
--
2.16.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH 1/2] ARM: omap3: ti_omap3_common: Fix CONFIG_SYS_NS16550_REG_SIZE compiler warning
2018-02-05 1:04 ` [U-Boot] [PATCH 1/2] ARM: omap3: ti_omap3_common: Fix CONFIG_SYS_NS16550_REG_SIZE compiler warning Derald D. Woods
@ 2018-02-05 15:50 ` Tom Rini
2018-02-08 12:27 ` [U-Boot] [U-Boot, " Tom Rini
1 sibling, 0 replies; 7+ messages in thread
From: Tom Rini @ 2018-02-05 15:50 UTC (permalink / raw)
To: u-boot
On Sun, Feb 04, 2018 at 07:04:49PM -0600, Derald D. Woods wrote:
> This commit fixes the following compiler warnings when DM_SERIAL is
> enabled.
>
Reviewed-by: Tom Rini <trini@konsulko.com>
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180205/a44f8ceb/attachment.sig>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH 2/2] ARM: omap3: evm: Remove CONFIG_SYS_NS16550_REG_SIZE undefine
2018-02-05 1:04 ` [U-Boot] [PATCH 2/2] ARM: omap3: evm: Remove CONFIG_SYS_NS16550_REG_SIZE undefine Derald D. Woods
@ 2018-02-05 15:50 ` Tom Rini
2018-02-08 12:27 ` [U-Boot] [U-Boot, " Tom Rini
1 sibling, 0 replies; 7+ messages in thread
From: Tom Rini @ 2018-02-05 15:50 UTC (permalink / raw)
To: u-boot
On Sun, Feb 04, 2018 at 07:04:50PM -0600, Derald D. Woods wrote:
> This commit removes an attempt to workaround a previous compilation
> warning that is is now fixed in "include/configs/ti_omap3_common.h".
>
> Signed-off-by: Derald D. Woods <woods.technical@gmail.com>
Reviewed-by: Tom Rini <trini@konsulko.com>
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180205/52057895/attachment.sig>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [U-Boot, 1/2] ARM: omap3: ti_omap3_common: Fix CONFIG_SYS_NS16550_REG_SIZE compiler warning
2018-02-05 1:04 ` [U-Boot] [PATCH 1/2] ARM: omap3: ti_omap3_common: Fix CONFIG_SYS_NS16550_REG_SIZE compiler warning Derald D. Woods
2018-02-05 15:50 ` Tom Rini
@ 2018-02-08 12:27 ` Tom Rini
1 sibling, 0 replies; 7+ messages in thread
From: Tom Rini @ 2018-02-08 12:27 UTC (permalink / raw)
To: u-boot
On Sun, Feb 04, 2018 at 07:04:49PM -0600, Derald D. Woods wrote:
> This commit fixes the following compiler warnings when DM_SERIAL is
> enabled.
>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180208/38201a07/attachment.sig>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [U-Boot, 2/2] ARM: omap3: evm: Remove CONFIG_SYS_NS16550_REG_SIZE undefine
2018-02-05 1:04 ` [U-Boot] [PATCH 2/2] ARM: omap3: evm: Remove CONFIG_SYS_NS16550_REG_SIZE undefine Derald D. Woods
2018-02-05 15:50 ` Tom Rini
@ 2018-02-08 12:27 ` Tom Rini
1 sibling, 0 replies; 7+ messages in thread
From: Tom Rini @ 2018-02-08 12:27 UTC (permalink / raw)
To: u-boot
On Sun, Feb 04, 2018 at 07:04:50PM -0600, Derald D. Woods wrote:
> This commit removes an attempt to workaround a previous compilation
> warning that is is now fixed in "include/configs/ti_omap3_common.h".
>
> Signed-off-by: Derald D. Woods <woods.technical@gmail.com>
> Reviewed-by: Tom Rini <trini@konsulko.com>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180208/f9126099/attachment.sig>
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2018-02-08 12:27 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-05 1:04 [U-Boot] [PATCH 0/2] ARM: omap3: evm: Fix serial driver compiler warnings Derald D. Woods
2018-02-05 1:04 ` [U-Boot] [PATCH 1/2] ARM: omap3: ti_omap3_common: Fix CONFIG_SYS_NS16550_REG_SIZE compiler warning Derald D. Woods
2018-02-05 15:50 ` Tom Rini
2018-02-08 12:27 ` [U-Boot] [U-Boot, " Tom Rini
2018-02-05 1:04 ` [U-Boot] [PATCH 2/2] ARM: omap3: evm: Remove CONFIG_SYS_NS16550_REG_SIZE undefine Derald D. Woods
2018-02-05 15:50 ` Tom Rini
2018-02-08 12:27 ` [U-Boot] [U-Boot, " Tom Rini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.