* Failing scratch mounts
@ 2018-02-03 18:58 Andreas Gruenbacher
2018-02-05 18:35 ` Darrick J. Wong
0 siblings, 1 reply; 2+ messages in thread
From: Andreas Gruenbacher @ 2018-02-03 18:58 UTC (permalink / raw)
To: fstests
Hi,
we have many fstests that call _scratch_mount without checking if the
mount was successful. When the mount fails, the tests then write to
the underlying filesystem. Here's a list of fstests that do this for
gfs2:
generic/029 generic/030 generic/032 generic/037 generic/053 generic/069
generic/071 generic/084 generic/094 generic/098 generic/103 generic/105
generic/109 generic/129 generic/130 generic/132 generic/162 generic/163
generic/169 generic/204 generic/225 generic/231 generic/232 generic/233
generic/235 generic/256 generic/294 generic/306 generic/319 generic/320
generic/337 generic/361 generic/374 generic/377 generic/380 generic/390
generic/401 generic/403 generic/412 generic/416 generic/422 generic/427
generic/439 generic/449 generic/452 generic/453 generic/454 generic/460
generic/464 generic/476
This is after fixing generic/270 which even fills up the scratch mount
point completely.
Since _scratch_mount is mostly used without checking for success, can
we change it to _fail by default, and introduce _try_check_mount or
similar for those few cases where we don't want to fail implicitly?
Thanks,
Andreas
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Failing scratch mounts
2018-02-03 18:58 Failing scratch mounts Andreas Gruenbacher
@ 2018-02-05 18:35 ` Darrick J. Wong
0 siblings, 0 replies; 2+ messages in thread
From: Darrick J. Wong @ 2018-02-05 18:35 UTC (permalink / raw)
To: Andreas Gruenbacher; +Cc: fstests
On Sat, Feb 03, 2018 at 07:58:46PM +0100, Andreas Gruenbacher wrote:
> Hi,
>
> we have many fstests that call _scratch_mount without checking if the
> mount was successful. When the mount fails, the tests then write to
> the underlying filesystem. Here's a list of fstests that do this for
> gfs2:
>
> generic/029 generic/030 generic/032 generic/037 generic/053 generic/069
> generic/071 generic/084 generic/094 generic/098 generic/103 generic/105
> generic/109 generic/129 generic/130 generic/132 generic/162 generic/163
> generic/169 generic/204 generic/225 generic/231 generic/232 generic/233
> generic/235 generic/256 generic/294 generic/306 generic/319 generic/320
> generic/337 generic/361 generic/374 generic/377 generic/380 generic/390
> generic/401 generic/403 generic/412 generic/416 generic/422 generic/427
> generic/439 generic/449 generic/452 generic/453 generic/454 generic/460
> generic/464 generic/476
>
> This is after fixing generic/270 which even fills up the scratch mount
> point completely.
>
> Since _scratch_mount is mostly used without checking for success, can
> we change it to _fail by default, and introduce _try_check_mount or
> similar for those few cases where we don't want to fail implicitly?
I don't have a problem with that.
--D
>
> Thanks,
> Andreas
> --
> To unsubscribe from this list: send the line "unsubscribe fstests" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-02-05 18:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-03 18:58 Failing scratch mounts Andreas Gruenbacher
2018-02-05 18:35 ` Darrick J. Wong
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.