Re: [RFC PATCH 1/5] vfio/quirks: Add common quirk alloc helper

From: Alex Williamson <alex.williamson@redhat.com>
To: Auger Eric <eric.auger@redhat.com>
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org
Subject: Re: [RFC PATCH 1/5] vfio/quirks: Add common quirk alloc helper
Date: Thu, 8 Feb 2018 11:28:36 -0700	[thread overview]
Message-ID: <20180208112836.072766e3@w520.home> (raw)
In-Reply-To: <b48b5e4d-dc91-acc4-1e72-45c287e9a597@redhat.com>

On Thu, 8 Feb 2018 12:10:35 +0100
Auger Eric <eric.auger@redhat.com> wrote:

> Hi Alex,
> On 07/02/18 01:26, Alex Williamson wrote:
> > This will later be used to include list initialization
> > 
> > Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
> > ---
> >  hw/vfio/pci-quirks.c |   48 +++++++++++++++++++++---------------------------
> >  1 file changed, 21 insertions(+), 27 deletions(-)
> > 
> > diff --git a/hw/vfio/pci-quirks.c b/hw/vfio/pci-quirks.c
> > index e5779a7ad35b..10af23217292 100644
> > --- a/hw/vfio/pci-quirks.c
> > +++ b/hw/vfio/pci-quirks.c
> > @@ -275,6 +275,15 @@ static const MemoryRegionOps vfio_ati_3c3_quirk = {
> >      .endianness = DEVICE_LITTLE_ENDIAN,
> >  };
> >  
> > +static VFIOQuirk *vfio_quirk_alloc(int nr_mem)
> > +{
> > +    VFIOQuirk *quirk = g_malloc0(sizeof(*quirk));  
> nit: Peter advised the usage of g_new0 as well for that kind of alloc.

Not my favorite interface, but good point.  Updated and R-b added.
Thanks,

Alex