From: Vinod Koul <vinod.koul@intel.com>
To: Colin King <colin.king@canonical.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
Sriram Periyasamy <sriramx.periyasamy@intel.com>,
Stephen Boyd <sboyd@codeaurora.org>,
"Subhransu S . Prusty" <subhransu.s.prusty@intel.com>,
alsa-devel@alsa-project.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [alsa-devel] [PATCH] ASoC: Intel: Skylake: make function skl_clk_round_rate static
Date: Fri, 9 Feb 2018 10:46:48 +0530 [thread overview]
Message-ID: <20180209051647.GA3666@localhost> (raw)
In-Reply-To: <20180208143530.11450-1-colin.king@canonical.com>
On Thu, Feb 08, 2018 at 02:35:30PM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The function skl_clk_round_rate is local to the source and does not
> need to be in global scope, so make it static.
>
> Cleans up sparse warning:
> sound/soc/intel/skylake/skl-ssp-clk.c:250:6: warning: symbol
> 'skl_clk_round_rate' was not declared. Should it be static?
Acked-By: Vinod Koul <vinod.koul@intel.com>
--
~Vinod
WARNING: multiple messages have this Message-ID (diff)
From: Vinod Koul <vinod.koul@intel.com>
To: Colin King <colin.king@canonical.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
Sriram Periyasamy <sriramx.periyasamy@intel.com>,
Stephen Boyd <sboyd@codeaurora.org>,
"Subhransu S . Prusty" <subhransu.s.prusty@intel.com>,
alsa-devel@alsa-project.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [alsa-devel] [PATCH] ASoC: Intel: Skylake: make function skl_clk_round_rate static
Date: Fri, 09 Feb 2018 05:28:48 +0000 [thread overview]
Message-ID: <20180209051647.GA3666@localhost> (raw)
In-Reply-To: <20180208143530.11450-1-colin.king@canonical.com>
On Thu, Feb 08, 2018 at 02:35:30PM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The function skl_clk_round_rate is local to the source and does not
> need to be in global scope, so make it static.
>
> Cleans up sparse warning:
> sound/soc/intel/skylake/skl-ssp-clk.c:250:6: warning: symbol
> 'skl_clk_round_rate' was not declared. Should it be static?
Acked-By: Vinod Koul <vinod.koul@intel.com>
--
~Vinod
next prev parent reply other threads:[~2018-02-09 5:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-08 14:35 [PATCH] ASoC: Intel: Skylake: make function skl_clk_round_rate static Colin King
2018-02-08 14:35 ` Colin King
2018-02-09 2:07 ` Takashi Sakamoto
2018-02-09 2:07 ` Takashi Sakamoto
2018-02-09 5:16 ` Vinod Koul [this message]
2018-02-09 5:28 ` [alsa-devel] " Vinod Koul
2018-02-12 12:52 ` Applied "ASoC: Intel: Skylake: make function skl_clk_round_rate static" to the asoc tree Mark Brown
2018-02-12 12:52 ` Mark Brown
2018-02-12 12:52 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180209051647.GA3666@localhost \
--to=vinod.koul@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=colin.king@canonical.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=sboyd@codeaurora.org \
--cc=sriramx.periyasamy@intel.com \
--cc=subhransu.s.prusty@intel.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.