* linux-next: build failure after merge of the btrfs-kdave tree
@ 2018-02-08 23:40 Stephen Rothwell
2018-02-08 23:48 ` David Sterba
0 siblings, 1 reply; 11+ messages in thread
From: Stephen Rothwell @ 2018-02-08 23:40 UTC (permalink / raw)
To: David Sterba
Cc: Linux-Next Mailing List, Linux Kernel Mailing List,
Nikolay Borisov, Qu Wenruo
Hi David,
[Seems I somehow failed to actually send the following message a couple
of days ago, sorry.]
After merging the btrfs-kdave tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:
fs/btrfs/tree-checker.c:33:10: fatal error: hash.h: No such file or directory
#include "hash.h"
^~~~~~~~
Caused by commit
8bd2a9b19fd7 ("btrfs: Remove custom crc32c init code")
interacting with commit
ad7b0368f33c ("btrfs: tree-checker: Add checker for dir item")
from Linus' tree.
It should have been fixed up in commit
99ca8d38ea90 ("Merge branch 'ext/nikbor/libcrc32c' into for-next-next-v4.16-20180206")
I have used the btrfs-kdave tree from next-20180206 for today.
--
Cheers,
Stephen Rothwell
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: linux-next: build failure after merge of the btrfs-kdave tree
2018-02-08 23:40 linux-next: build failure after merge of the btrfs-kdave tree Stephen Rothwell
@ 2018-02-08 23:48 ` David Sterba
2018-02-09 0:27 ` Stephen Rothwell
0 siblings, 1 reply; 11+ messages in thread
From: David Sterba @ 2018-02-08 23:48 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Linux-Next Mailing List, Linux Kernel Mailing List,
Nikolay Borisov, Qu Wenruo
On Fri, Feb 09, 2018 at 10:40:57AM +1100, Stephen Rothwell wrote:
> Hi David,
>
> [Seems I somehow failed to actually send the following message a couple
> of days ago, sorry.]
>
> After merging the btrfs-kdave tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
>
> fs/btrfs/tree-checker.c:33:10: fatal error: hash.h: No such file or directory
> #include "hash.h"
> ^~~~~~~~
>
> Caused by commit
>
> 8bd2a9b19fd7 ("btrfs: Remove custom crc32c init code")
>
> interacting with commit
>
> ad7b0368f33c ("btrfs: tree-checker: Add checker for dir item")
>
> from Linus' tree.
>
> It should have been fixed up in commit
>
> 99ca8d38ea90 ("Merge branch 'ext/nikbor/libcrc32c' into for-next-next-v4.16-20180206")
Right, I had fixed it in my local branch but did not push the update,
sorry. Current for-next, top commit 993b08a92e32 builds fine.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: linux-next: build failure after merge of the btrfs-kdave tree
2018-02-08 23:48 ` David Sterba
@ 2018-02-09 0:27 ` Stephen Rothwell
0 siblings, 0 replies; 11+ messages in thread
From: Stephen Rothwell @ 2018-02-09 0:27 UTC (permalink / raw)
To: David Sterba
Cc: Linux-Next Mailing List, Linux Kernel Mailing List,
Nikolay Borisov, Qu Wenruo
Hi David,
On Fri, 9 Feb 2018 00:48:46 +0100 David Sterba <dsterba@suse.cz> wrote:
>
> Right, I had fixed it in my local branch but did not push the update,
> sorry. Current for-next, top commit 993b08a92e32 builds fine.
Thanks.
--
Cheers,
Stephen Rothwell
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: linux-next: build failure after merge of the btrfs-kdave tree
2018-06-28 23:58 ` Stephen Rothwell
@ 2018-06-29 11:19 ` David Sterba
0 siblings, 0 replies; 11+ messages in thread
From: David Sterba @ 2018-06-29 11:19 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Nikolay Borisov
On Fri, Jun 29, 2018 at 09:58:58AM +1000, Stephen Rothwell wrote:
> Hi David,
>
> On Thu, 28 Jun 2018 18:11:03 +0200 David Sterba <dsterba@suse.cz> wrote:
> >
> > On Wed, Jun 27, 2018 at 08:59:36AM +1000, Stephen Rothwell wrote:
> > > After merging the btrfs-kdave tree, today's linux-next build (powerpc
> > > ppc64_defconfig) failed like this:
> > >
> > > fs/btrfs/print-tree.c: In function 'print_extent_item':
> > > fs/btrfs/print-tree.c:56:3: error: implicit declaration of function 'btrfs_print_v0_err'; did you mean 'btrfs_print_tree'? [-Werror=implicit-function-declaration]
> > > btrfs_print_v0_err(eb->fs_info);
> > > ^~~~~~~~~~~~~~~~~~
> > > btrfs_print_tree
> >
> > Should be fixed in today's branch.
>
> Sorry, still broken. I fetched your tree only about 5 minutes ago.
It was a build problem that I did not recognize in my setup
immediatelly, the warning appears only withtout CONFIG_BTRFS_ASSERT.
The branch has been updated, commit 1607c1cbdaa0b6b80b0d4a, sorry for
inconvenience.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: linux-next: build failure after merge of the btrfs-kdave tree
2018-06-28 16:11 ` David Sterba
@ 2018-06-28 23:58 ` Stephen Rothwell
2018-06-29 11:19 ` David Sterba
0 siblings, 1 reply; 11+ messages in thread
From: Stephen Rothwell @ 2018-06-28 23:58 UTC (permalink / raw)
To: David Sterba
Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Nikolay Borisov
[-- Attachment #1: Type: text/plain, Size: 751 bytes --]
Hi David,
On Thu, 28 Jun 2018 18:11:03 +0200 David Sterba <dsterba@suse.cz> wrote:
>
> On Wed, Jun 27, 2018 at 08:59:36AM +1000, Stephen Rothwell wrote:
> > After merging the btrfs-kdave tree, today's linux-next build (powerpc
> > ppc64_defconfig) failed like this:
> >
> > fs/btrfs/print-tree.c: In function 'print_extent_item':
> > fs/btrfs/print-tree.c:56:3: error: implicit declaration of function 'btrfs_print_v0_err'; did you mean 'btrfs_print_tree'? [-Werror=implicit-function-declaration]
> > btrfs_print_v0_err(eb->fs_info);
> > ^~~~~~~~~~~~~~~~~~
> > btrfs_print_tree
>
> Should be fixed in today's branch.
Sorry, still broken. I fetched your tree only about 5 minutes ago.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: linux-next: build failure after merge of the btrfs-kdave tree
2018-06-26 22:59 Stephen Rothwell
@ 2018-06-28 16:11 ` David Sterba
2018-06-28 23:58 ` Stephen Rothwell
0 siblings, 1 reply; 11+ messages in thread
From: David Sterba @ 2018-06-28 16:11 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Nikolay Borisov
On Wed, Jun 27, 2018 at 08:59:36AM +1000, Stephen Rothwell wrote:
> After merging the btrfs-kdave tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
>
> fs/btrfs/print-tree.c: In function 'print_extent_item':
> fs/btrfs/print-tree.c:56:3: error: implicit declaration of function 'btrfs_print_v0_err'; did you mean 'btrfs_print_tree'? [-Werror=implicit-function-declaration]
> btrfs_print_v0_err(eb->fs_info);
> ^~~~~~~~~~~~~~~~~~
> btrfs_print_tree
Should be fixed in today's branch.
^ permalink raw reply [flat|nested] 11+ messages in thread
* linux-next: build failure after merge of the btrfs-kdave tree
@ 2018-06-26 22:59 Stephen Rothwell
2018-06-28 16:11 ` David Sterba
0 siblings, 1 reply; 11+ messages in thread
From: Stephen Rothwell @ 2018-06-26 22:59 UTC (permalink / raw)
To: David Sterba
Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Nikolay Borisov
[-- Attachment #1: Type: text/plain, Size: 1261 bytes --]
Hi all,
After merging the btrfs-kdave tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:
fs/btrfs/print-tree.c: In function 'print_extent_item':
fs/btrfs/print-tree.c:56:3: error: implicit declaration of function 'btrfs_print_v0_err'; did you mean 'btrfs_print_tree'? [-Werror=implicit-function-declaration]
btrfs_print_v0_err(eb->fs_info);
^~~~~~~~~~~~~~~~~~
btrfs_print_tree
fs/btrfs/relocation.c: In function 'find_inline_backref':
fs/btrfs/relocation.c:602:3: error: implicit declaration of function 'btrfs_print_v0_err'; did you mean 'btrfs_print_tree'? [-Werror=implicit-function-declaration]
btrfs_print_v0_err(leaf->fs_info);
^~~~~~~~~~~~~~~~~~
btrfs_print_tree
fs/btrfs/extent-tree.c: In function 'btrfs_lookup_extent_info':
fs/btrfs/extent-tree.c:871:4: error: implicit declaration of function 'btrfs_print_v0_err'; did you mean 'btrfs_print_tree'? [-Werror=implicit-function-declaration]
btrfs_print_v0_err(fs_info);
^~~~~~~~~~~~~~~~~~
btrfs_print_tree
Caused by commit
2a191bb344ee ("btrfs: Add graceful handling of V0 extents")
# CONFIG_BTRFS_ASSERT is not set
I have used the btrfs-kdave tree from next-20180626 for today.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: linux-next: build failure after merge of the btrfs-kdave tree
2016-09-07 1:22 Stephen Rothwell
@ 2016-09-09 11:11 ` David Sterba
0 siblings, 0 replies; 11+ messages in thread
From: David Sterba @ 2016-09-09 11:11 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: linux-next, linux-kernel, Josef Bacik, Jan Kara
On Wed, Sep 07, 2016 at 11:22:53AM +1000, Stephen Rothwell wrote:
> Hi David,
>
> After merging the btrfs-kdave tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> fs/ntfs/attrib.c: In function 'ntfs_attr_set':
> fs/ntfs/attrib.c:2549:35: error: implicit declaration of function 'inode_to_bdi' [-Werror=implicit-function-declaration]
> balance_dirty_pages_ratelimited(inode_to_bdi(inode),
> ^
> fs/ntfs/attrib.c:2549:35: warning: passing argument 1 of 'balance_dirty_pages_ratelimited' makes pointer from integer without a cast [-Wint-conversion]
> In file included from include/linux/memcontrol.h:30:0,
> from include/linux/swap.h:8,
> from fs/ntfs/attrib.c:26:
> include/linux/writeback.h:367:6: note: expected 'struct backing_dev_info *' but argument is of type 'int'
> void balance_dirty_pages_ratelimited(struct backing_dev_info *bdi,
> ^
> fs/ntfs/attrib.c:2591:35: warning: passing argument 1 of 'balance_dirty_pages_ratelimited' makes pointer from integer without a cast [-Wint-conversion]
> balance_dirty_pages_ratelimited(inode_to_bdi(inode),
> ^
> In file included from include/linux/memcontrol.h:30:0,
> from include/linux/swap.h:8,
> from fs/ntfs/attrib.c:26:
> include/linux/writeback.h:367:6: note: expected 'struct backing_dev_info *' but argument is of type 'int'
> void balance_dirty_pages_ratelimited(struct backing_dev_info *bdi,
> ^
> fs/ntfs/attrib.c:2609:35: warning: passing argument 1 of 'balance_dirty_pages_ratelimited' makes pointer from integer without a cast [-Wint-conversion]
> balance_dirty_pages_ratelimited(inode_to_bdi(inode),
> ^
> In file included from include/linux/memcontrol.h:30:0,
> from include/linux/swap.h:8,
> from fs/ntfs/attrib.c:26:
> include/linux/writeback.h:367:6: note: expected 'struct backing_dev_info *' but argument is of type 'int'
> void balance_dirty_pages_ratelimited(struct backing_dev_info *bdi,
> ^
>
> Caused by commit
>
> a685fa61566d ("remove mapping from balance_dirty_pages*()")
>
> I assume some forgotten include(s).
No, I picked a wrong version of the patchset. But the patchset should
not have been in for-next as it's a change to writeback (a prerequisity
for a btrfs patchset). Now removed.
^ permalink raw reply [flat|nested] 11+ messages in thread
* linux-next: build failure after merge of the btrfs-kdave tree
@ 2016-09-07 1:22 Stephen Rothwell
2016-09-09 11:11 ` David Sterba
0 siblings, 1 reply; 11+ messages in thread
From: Stephen Rothwell @ 2016-09-07 1:22 UTC (permalink / raw)
To: David Sterba; +Cc: linux-next, linux-kernel, Josef Bacik, Jan Kara
Hi David,
After merging the btrfs-kdave tree, today's linux-next build (x86_64
allmodconfig) failed like this:
fs/ntfs/attrib.c: In function 'ntfs_attr_set':
fs/ntfs/attrib.c:2549:35: error: implicit declaration of function 'inode_to_bdi' [-Werror=implicit-function-declaration]
balance_dirty_pages_ratelimited(inode_to_bdi(inode),
^
fs/ntfs/attrib.c:2549:35: warning: passing argument 1 of 'balance_dirty_pages_ratelimited' makes pointer from integer without a cast [-Wint-conversion]
In file included from include/linux/memcontrol.h:30:0,
from include/linux/swap.h:8,
from fs/ntfs/attrib.c:26:
include/linux/writeback.h:367:6: note: expected 'struct backing_dev_info *' but argument is of type 'int'
void balance_dirty_pages_ratelimited(struct backing_dev_info *bdi,
^
fs/ntfs/attrib.c:2591:35: warning: passing argument 1 of 'balance_dirty_pages_ratelimited' makes pointer from integer without a cast [-Wint-conversion]
balance_dirty_pages_ratelimited(inode_to_bdi(inode),
^
In file included from include/linux/memcontrol.h:30:0,
from include/linux/swap.h:8,
from fs/ntfs/attrib.c:26:
include/linux/writeback.h:367:6: note: expected 'struct backing_dev_info *' but argument is of type 'int'
void balance_dirty_pages_ratelimited(struct backing_dev_info *bdi,
^
fs/ntfs/attrib.c:2609:35: warning: passing argument 1 of 'balance_dirty_pages_ratelimited' makes pointer from integer without a cast [-Wint-conversion]
balance_dirty_pages_ratelimited(inode_to_bdi(inode),
^
In file included from include/linux/memcontrol.h:30:0,
from include/linux/swap.h:8,
from fs/ntfs/attrib.c:26:
include/linux/writeback.h:367:6: note: expected 'struct backing_dev_info *' but argument is of type 'int'
void balance_dirty_pages_ratelimited(struct backing_dev_info *bdi,
^
Caused by commit
a685fa61566d ("remove mapping from balance_dirty_pages*()")
I assume some forgotten include(s).
I have used the btrfs-kdave tree from next-20160906 for today.
--
Cheers,
Stephen Rothwell
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: linux-next: build failure after merge of the btrfs-kdave tree
2016-02-01 23:39 Stephen Rothwell
@ 2016-02-02 8:54 ` David Sterba
0 siblings, 0 replies; 11+ messages in thread
From: David Sterba @ 2016-02-02 8:54 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: linux-next, linux-kernel
Hi,
On Tue, Feb 02, 2016 at 10:39:04AM +1100, Stephen Rothwell wrote:
> Hi David,
>
> After merging the btrfs-kdave tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
>
> fs/btrfs/reada.c:326:29: error: invalid storage class for function 'reada_find_extent'
> static struct reada_extent *reada_find_extent(struct btrfs_root *root,
> ^
>
> and lots of others.
sorry, I've pushed 4.5-rc1 again until I fix it.
^ permalink raw reply [flat|nested] 11+ messages in thread
* linux-next: build failure after merge of the btrfs-kdave tree
@ 2016-02-01 23:39 Stephen Rothwell
2016-02-02 8:54 ` David Sterba
0 siblings, 1 reply; 11+ messages in thread
From: Stephen Rothwell @ 2016-02-01 23:39 UTC (permalink / raw)
To: David Sterba; +Cc: linux-next, linux-kernel
Hi David,
After merging the btrfs-kdave tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:
fs/btrfs/reada.c:326:29: error: invalid storage class for function 'reada_find_extent'
static struct reada_extent *reada_find_extent(struct btrfs_root *root,
^
and lots of others.
Caused by commit:
cbf8f71bc8d5 ("Merge branch 'for-next-4.6-20160201' into for-next-20160201")
The following patches appear on bothe sides of the merge and there are
following changes in the for-next-4.6-20160201. The merge resolution
is just very bad (I don't know if git did that automatically or not)
and would have shown up if it was build tested.
4c22a2ccc220 btrfs: reada: bypass adding extent when all zones failed
d34d58265213 btrfs: reada: add all reachable mirrors into reada device list
2aafd08e648c btrfs: reada: Avoid many times of empty loop
dc9529f670fd btrfs: reada: Add missed segment checking in reada_find_zone
9f2c3244dcf1 btrfs: reada: Fix in-segment calculation for reada
e47319f6119c btrfs: reada: bypass adding extent when all zones failed
440f28b7523a btrfs: reada: add all reachable mirrors into reada device list
14a5db53a0fc btrfs: reada: Avoid many times of empty loop
730af4ef7c49 btrfs: reada: Add missed segment checking in reada_find_zone
a38b691f5d07 btrfs: reada: Fix in-segment calculation for reada
Please fix this up.
I have used the btrfs-kdave tree from next-20160201 for today.
--
Cheers,
Stephen Rothwell
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2018-06-29 11:19 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-08 23:40 linux-next: build failure after merge of the btrfs-kdave tree Stephen Rothwell
2018-02-08 23:48 ` David Sterba
2018-02-09 0:27 ` Stephen Rothwell
-- strict thread matches above, loose matches on Subject: below --
2018-06-26 22:59 Stephen Rothwell
2018-06-28 16:11 ` David Sterba
2018-06-28 23:58 ` Stephen Rothwell
2018-06-29 11:19 ` David Sterba
2016-09-07 1:22 Stephen Rothwell
2016-09-09 11:11 ` David Sterba
2016-02-01 23:39 Stephen Rothwell
2016-02-02 8:54 ` David Sterba
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.