All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH igt] igt/perf_pmu: Semaphores do not exists before gen6
@ 2018-02-09 14:39 ` Chris Wilson
  0 siblings, 0 replies; 6+ messages in thread
From: Chris Wilson @ 2018-02-09 14:39 UTC (permalink / raw)
  To: intel-gfx; +Cc: igt-dev

We don't expect to be able to open the I915_SAMPLE_SEMA on gen5 and
earlier as the HW doesn't support semaphores.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
 tests/perf_pmu.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/tests/perf_pmu.c b/tests/perf_pmu.c
index a27a8a81e..c7f87d52f 100644
--- a/tests/perf_pmu.c
+++ b/tests/perf_pmu.c
@@ -74,13 +74,19 @@ static void
 init(int gem_fd, const struct intel_execution_engine2 *e, uint8_t sample)
 {
 	int fd, err = 0;
+	bool exists;
 
 	errno = 0;
 	fd = perf_i915_open(__I915_PMU_ENGINE(e->class, e->instance, sample));
 	if (fd < 0)
 		err = errno;
 
-	if (gem_has_engine(gem_fd, e->class, e->instance)) {
+	exists = gem_has_engine(gem_fd, e->class, e->instance);
+	if (intel_gen(intel_get_drm_devid(gem_fd)) < 6 &&
+	    sample == I915_SAMPLE_SEMA)
+		exists = false;
+
+	if (exists) {
 		igt_assert_eq(err, 0);
 		igt_assert_fd(fd);
 		close(fd);
-- 
2.16.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [igt-dev] [PATCH igt] igt/perf_pmu: Semaphores do not exists before gen6
@ 2018-02-09 14:39 ` Chris Wilson
  0 siblings, 0 replies; 6+ messages in thread
From: Chris Wilson @ 2018-02-09 14:39 UTC (permalink / raw)
  To: intel-gfx; +Cc: igt-dev

We don't expect to be able to open the I915_SAMPLE_SEMA on gen5 and
earlier as the HW doesn't support semaphores.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
 tests/perf_pmu.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/tests/perf_pmu.c b/tests/perf_pmu.c
index a27a8a81e..c7f87d52f 100644
--- a/tests/perf_pmu.c
+++ b/tests/perf_pmu.c
@@ -74,13 +74,19 @@ static void
 init(int gem_fd, const struct intel_execution_engine2 *e, uint8_t sample)
 {
 	int fd, err = 0;
+	bool exists;
 
 	errno = 0;
 	fd = perf_i915_open(__I915_PMU_ENGINE(e->class, e->instance, sample));
 	if (fd < 0)
 		err = errno;
 
-	if (gem_has_engine(gem_fd, e->class, e->instance)) {
+	exists = gem_has_engine(gem_fd, e->class, e->instance);
+	if (intel_gen(intel_get_drm_devid(gem_fd)) < 6 &&
+	    sample == I915_SAMPLE_SEMA)
+		exists = false;
+
+	if (exists) {
 		igt_assert_eq(err, 0);
 		igt_assert_fd(fd);
 		close(fd);
-- 
2.16.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [igt-dev] ✓ Fi.CI.BAT: success for igt/perf_pmu: Semaphores do not exists before gen6
  2018-02-09 14:39 ` [igt-dev] " Chris Wilson
  (?)
@ 2018-02-09 18:29 ` Patchwork
  -1 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2018-02-09 18:29 UTC (permalink / raw)
  To: Chris Wilson; +Cc: igt-dev

== Series Details ==

Series: igt/perf_pmu: Semaphores do not exists before gen6
URL   : https://patchwork.freedesktop.org/series/38009/
State : success

== Summary ==

IGT patchset tested on top of latest successful build
3af87d45da24015b7a6124b59b2c4b854381cab6 tools/intel_aubdump: Simulate "enhanced execlist" submission for gen11+

with latest DRM-Tip kernel build CI_DRM_3750
897018779f8b drm-tip: 2018y-02m-09d-16h-18m-21s UTC integration manifest

No testlist changes.

Test debugfs_test:
        Subgroup read_all_entries:
                incomplete -> PASS       (fi-snb-2520m) fdo#103713
Test kms_pipe_crc_basic:
        Subgroup suspend-read-crc-pipe-b:
                dmesg-warn -> PASS       (fi-cnl-y3) fdo#104951

fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713
fdo#104951 https://bugs.freedesktop.org/show_bug.cgi?id=104951

fi-bdw-5557u     total:288  pass:267  dwarn:0   dfail:0   fail:0   skip:21  time:417s
fi-bdw-gvtdvm    total:288  pass:264  dwarn:0   dfail:0   fail:0   skip:24  time:425s
fi-blb-e6850     total:288  pass:223  dwarn:1   dfail:0   fail:0   skip:64  time:377s
fi-bsw-n3050     total:288  pass:242  dwarn:0   dfail:0   fail:0   skip:46  time:500s
fi-bwr-2160      total:288  pass:183  dwarn:0   dfail:0   fail:0   skip:105 time:287s
fi-bxt-dsi       total:288  pass:258  dwarn:0   dfail:0   fail:0   skip:30  time:486s
fi-bxt-j4205     total:288  pass:259  dwarn:0   dfail:0   fail:0   skip:29  time:494s
fi-byt-j1900     total:288  pass:253  dwarn:0   dfail:0   fail:0   skip:35  time:472s
fi-byt-n2820     total:288  pass:249  dwarn:0   dfail:0   fail:0   skip:39  time:464s
fi-cfl-s2        total:288  pass:262  dwarn:0   dfail:0   fail:0   skip:26  time:568s
fi-cnl-y3        total:288  pass:262  dwarn:0   dfail:0   fail:0   skip:26  time:582s
fi-elk-e7500     total:288  pass:229  dwarn:0   dfail:0   fail:0   skip:59  time:417s
fi-gdg-551       total:288  pass:179  dwarn:0   dfail:0   fail:1   skip:108 time:287s
fi-glk-1         total:288  pass:260  dwarn:0   dfail:0   fail:0   skip:28  time:521s
fi-hsw-4770      total:288  pass:261  dwarn:0   dfail:0   fail:0   skip:27  time:391s
fi-ilk-650       total:288  pass:228  dwarn:0   dfail:0   fail:0   skip:60  time:412s
fi-ivb-3520m     total:288  pass:259  dwarn:0   dfail:0   fail:0   skip:29  time:458s
fi-ivb-3770      total:288  pass:255  dwarn:0   dfail:0   fail:0   skip:33  time:421s
fi-kbl-7500u     total:288  pass:263  dwarn:1   dfail:0   fail:0   skip:24  time:459s
fi-kbl-7560u     total:288  pass:269  dwarn:0   dfail:0   fail:0   skip:19  time:498s
fi-kbl-r         total:288  pass:261  dwarn:0   dfail:0   fail:0   skip:27  time:503s
fi-pnv-d510      total:288  pass:222  dwarn:1   dfail:0   fail:0   skip:65  time:603s
fi-skl-6260u     total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:428s
fi-skl-6600u     total:288  pass:261  dwarn:0   dfail:0   fail:0   skip:27  time:503s
fi-skl-6700hq    total:288  pass:262  dwarn:0   dfail:0   fail:0   skip:26  time:527s
fi-skl-6700k2    total:288  pass:264  dwarn:0   dfail:0   fail:0   skip:24  time:489s
fi-skl-6770hq    total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:495s
fi-skl-guc       total:288  pass:260  dwarn:0   dfail:0   fail:0   skip:28  time:415s
fi-skl-gvtdvm    total:288  pass:265  dwarn:0   dfail:0   fail:0   skip:23  time:431s
fi-snb-2520m     total:288  pass:248  dwarn:0   dfail:0   fail:0   skip:40  time:527s
fi-snb-2600      total:288  pass:248  dwarn:0   dfail:0   fail:0   skip:40  time:399s
Blacklisted hosts:
fi-glk-dsi       total:288  pass:258  dwarn:0   dfail:0   fail:0   skip:30  time:472s

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_896/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [igt-dev] ✓ Fi.CI.IGT: success for igt/perf_pmu: Semaphores do not exists before gen6
  2018-02-09 14:39 ` [igt-dev] " Chris Wilson
  (?)
  (?)
@ 2018-02-09 21:16 ` Patchwork
  -1 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2018-02-09 21:16 UTC (permalink / raw)
  To: Chris Wilson; +Cc: igt-dev

== Series Details ==

Series: igt/perf_pmu: Semaphores do not exists before gen6
URL   : https://patchwork.freedesktop.org/series/38009/
State : success

== Summary ==

Test kms_sysfs_edid_timing:
                pass       -> WARN       (shard-apl) fdo#100047
Test kms_frontbuffer_tracking:
        Subgroup fbc-1p-offscren-pri-shrfb-draw-mmap-cpu:
                pass       -> FAIL       (shard-apl) fdo#101623
Test perf:
        Subgroup enable-disable:
                pass       -> FAIL       (shard-apl) fdo#103715
Test kms_flip:
        Subgroup 2x-wf_vblank-ts-check-interruptible:
                pass       -> FAIL       (shard-hsw) fdo#103928

fdo#100047 https://bugs.freedesktop.org/show_bug.cgi?id=100047
fdo#101623 https://bugs.freedesktop.org/show_bug.cgi?id=101623
fdo#103715 https://bugs.freedesktop.org/show_bug.cgi?id=103715
fdo#103928 https://bugs.freedesktop.org/show_bug.cgi?id=103928

shard-apl        total:3390 pass:1754 dwarn:1   dfail:0   fail:22  skip:1611 time:12406s
shard-hsw        total:3444 pass:1760 dwarn:1   dfail:0   fail:11  skip:1671 time:11709s
shard-snb        total:3444 pass:1351 dwarn:1   dfail:0   fail:10  skip:2082 time:6677s
Blacklisted hosts:
shard-kbl        total:3391 pass:1877 dwarn:1   dfail:0   fail:20  skip:1492 time:9505s

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_896/shards.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [igt-dev] [PATCH igt] igt/perf_pmu: Semaphores do not exists before gen6
  2018-02-09 14:39 ` [igt-dev] " Chris Wilson
@ 2018-02-12  9:50   ` Tvrtko Ursulin
  -1 siblings, 0 replies; 6+ messages in thread
From: Tvrtko Ursulin @ 2018-02-12  9:50 UTC (permalink / raw)
  To: Chris Wilson, intel-gfx; +Cc: igt-dev


On 09/02/2018 14:39, Chris Wilson wrote:
> We don't expect to be able to open the I915_SAMPLE_SEMA on gen5 and
> earlier as the HW doesn't support semaphores.
> 
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
>   tests/perf_pmu.c | 8 +++++++-
>   1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/perf_pmu.c b/tests/perf_pmu.c
> index a27a8a81e..c7f87d52f 100644
> --- a/tests/perf_pmu.c
> +++ b/tests/perf_pmu.c
> @@ -74,13 +74,19 @@ static void
>   init(int gem_fd, const struct intel_execution_engine2 *e, uint8_t sample)
>   {
>   	int fd, err = 0;
> +	bool exists;
>   
>   	errno = 0;
>   	fd = perf_i915_open(__I915_PMU_ENGINE(e->class, e->instance, sample));
>   	if (fd < 0)
>   		err = errno;
>   
> -	if (gem_has_engine(gem_fd, e->class, e->instance)) {
> +	exists = gem_has_engine(gem_fd, e->class, e->instance);
> +	if (intel_gen(intel_get_drm_devid(gem_fd)) < 6 &&
> +	    sample == I915_SAMPLE_SEMA)
> +		exists = false;
> +
> +	if (exists) {
>   		igt_assert_eq(err, 0);
>   		igt_assert_fd(fd);
>   		close(fd);
> 

Ooopsie.. :(

Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

Regards,

Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [igt-dev] [PATCH igt] igt/perf_pmu: Semaphores do not exists before gen6
@ 2018-02-12  9:50   ` Tvrtko Ursulin
  0 siblings, 0 replies; 6+ messages in thread
From: Tvrtko Ursulin @ 2018-02-12  9:50 UTC (permalink / raw)
  To: Chris Wilson, intel-gfx; +Cc: igt-dev


On 09/02/2018 14:39, Chris Wilson wrote:
> We don't expect to be able to open the I915_SAMPLE_SEMA on gen5 and
> earlier as the HW doesn't support semaphores.
> 
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
>   tests/perf_pmu.c | 8 +++++++-
>   1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/perf_pmu.c b/tests/perf_pmu.c
> index a27a8a81e..c7f87d52f 100644
> --- a/tests/perf_pmu.c
> +++ b/tests/perf_pmu.c
> @@ -74,13 +74,19 @@ static void
>   init(int gem_fd, const struct intel_execution_engine2 *e, uint8_t sample)
>   {
>   	int fd, err = 0;
> +	bool exists;
>   
>   	errno = 0;
>   	fd = perf_i915_open(__I915_PMU_ENGINE(e->class, e->instance, sample));
>   	if (fd < 0)
>   		err = errno;
>   
> -	if (gem_has_engine(gem_fd, e->class, e->instance)) {
> +	exists = gem_has_engine(gem_fd, e->class, e->instance);
> +	if (intel_gen(intel_get_drm_devid(gem_fd)) < 6 &&
> +	    sample == I915_SAMPLE_SEMA)
> +		exists = false;
> +
> +	if (exists) {
>   		igt_assert_eq(err, 0);
>   		igt_assert_fd(fd);
>   		close(fd);
> 

Ooopsie.. :(

Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

Regards,

Tvrtko
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2018-02-12  9:50 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-09 14:39 [PATCH igt] igt/perf_pmu: Semaphores do not exists before gen6 Chris Wilson
2018-02-09 14:39 ` [igt-dev] " Chris Wilson
2018-02-09 18:29 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2018-02-09 21:16 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2018-02-12  9:50 ` [igt-dev] [PATCH igt] " Tvrtko Ursulin
2018-02-12  9:50   ` Tvrtko Ursulin

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.