[PATCH igt] igt/gem_exec_schedule: Limit smoketest to the desired engines

[PATCH igt] igt/gem_exec_schedule: Limit smoketest to the desired engines

[Chris Wilson]

We run the per-engine scheduling smoketests across all engines, the
opposite of what was intended!

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
 tests/gem_exec_schedule.c | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/tests/gem_exec_schedule.c b/tests/gem_exec_schedule.c
index b45ba1670..ec02d9943 100644
--- a/tests/gem_exec_schedule.c
+++ b/tests/gem_exec_schedule.c
@@ -208,11 +208,15 @@ static void smoketest(int fd, unsigned ring, unsigned timeout)
 	uint32_t *ptr;
 
 	nengine = 0;
-	for_each_engine(fd, engine) {
-		if (ignore_engine(fd, engine))
-			continue;
+	if (ring == -1) {
+		for_each_engine(fd, engine) {
+			if (ignore_engine(fd, engine))
+				continue;
 
-		engines[nengine++] = engine;
+			engines[nengine++] = engine;
+		}
+	} else {
+		engines[nengine++] = ring;
 	}
 	igt_require(nengine);
 
-- 
2.16.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

✓ Fi.CI.BAT: success for igt/gem_exec_schedule: Limit smoketest to the desired engines

[Patchwork]

== Series Details ==

Series: igt/gem_exec_schedule: Limit smoketest to the desired engines
URL   : https://patchwork.freedesktop.org/series/38045/
State : success

== Summary ==

IGT patchset tested on top of latest successful build
8b9f68a13442c9307ef602cb9f0282e0c4ec43e2 igt/pm_rc6_residency: Check debugfs existence before reading

with latest DRM-Tip kernel build CI_DRM_3751
2bea3467efba drm-tip: 2018y-02m-09d-22h-30m-41s UTC integration manifest

No testlist changes.

Test debugfs_test:
        Subgroup read_all_entries:
                incomplete -> PASS       (fi-snb-2520m) fdo#103713
Test kms_psr_sink_crc:
        Subgroup psr_basic:
                incomplete -> SKIP       (fi-elk-e7500)

fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713

fi-bdw-5557u     total:288  pass:267  dwarn:0   dfail:0   fail:0   skip:21  time:422s
fi-bdw-gvtdvm    total:288  pass:264  dwarn:0   dfail:0   fail:0   skip:24  time:427s
fi-blb-e6850     total:288  pass:223  dwarn:1   dfail:0   fail:0   skip:64  time:375s
fi-bsw-n3050     total:288  pass:242  dwarn:0   dfail:0   fail:0   skip:46  time:496s
fi-bwr-2160      total:288  pass:183  dwarn:0   dfail:0   fail:0   skip:105 time:288s
fi-bxt-dsi       total:288  pass:258  dwarn:0   dfail:0   fail:0   skip:30  time:482s
fi-bxt-j4205     total:288  pass:259  dwarn:0   dfail:0   fail:0   skip:29  time:489s
fi-byt-j1900     total:288  pass:253  dwarn:0   dfail:0   fail:0   skip:35  time:472s
fi-byt-n2820     total:288  pass:249  dwarn:0   dfail:0   fail:0   skip:39  time:459s
fi-cfl-s2        total:288  pass:262  dwarn:0   dfail:0   fail:0   skip:26  time:569s
fi-cnl-y3        total:288  pass:262  dwarn:0   dfail:0   fail:0   skip:26  time:578s
fi-elk-e7500     total:288  pass:229  dwarn:0   dfail:0   fail:0   skip:59  time:412s
fi-gdg-551       total:288  pass:179  dwarn:0   dfail:0   fail:1   skip:108 time:285s
fi-glk-1         total:288  pass:260  dwarn:0   dfail:0   fail:0   skip:28  time:515s
fi-hsw-4770      total:288  pass:261  dwarn:0   dfail:0   fail:0   skip:27  time:399s
fi-ilk-650       total:288  pass:228  dwarn:0   dfail:0   fail:0   skip:60  time:414s
fi-ivb-3520m     total:288  pass:259  dwarn:0   dfail:0   fail:0   skip:29  time:460s
fi-ivb-3770      total:288  pass:255  dwarn:0   dfail:0   fail:0   skip:33  time:412s
fi-kbl-7500u     total:288  pass:263  dwarn:1   dfail:0   fail:0   skip:24  time:464s
fi-kbl-7560u     total:288  pass:269  dwarn:0   dfail:0   fail:0   skip:19  time:500s
fi-kbl-r         total:288  pass:261  dwarn:0   dfail:0   fail:0   skip:27  time:503s
fi-pnv-d510      total:288  pass:222  dwarn:1   dfail:0   fail:0   skip:65  time:610s
fi-skl-6260u     total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:431s
fi-skl-6600u     total:288  pass:261  dwarn:0   dfail:0   fail:0   skip:27  time:506s
fi-skl-6700hq    total:288  pass:262  dwarn:0   dfail:0   fail:0   skip:26  time:528s
fi-skl-6700k2    total:288  pass:264  dwarn:0   dfail:0   fail:0   skip:24  time:487s
fi-skl-6770hq    total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:474s
fi-skl-guc       total:288  pass:260  dwarn:0   dfail:0   fail:0   skip:28  time:415s
fi-skl-gvtdvm    total:288  pass:265  dwarn:0   dfail:0   fail:0   skip:23  time:430s
fi-snb-2520m     total:288  pass:248  dwarn:0   dfail:0   fail:0   skip:40  time:527s
fi-snb-2600      total:288  pass:248  dwarn:0   dfail:0   fail:0   skip:40  time:399s
Blacklisted hosts:
fi-glk-dsi       total:288  pass:258  dwarn:0   dfail:0   fail:0   skip:30  time:472s

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_898/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

✗ Fi.CI.IGT: warning for igt/gem_exec_schedule: Limit smoketest to the desired engines

[Patchwork]

== Series Details ==

Series: igt/gem_exec_schedule: Limit smoketest to the desired engines
URL   : https://patchwork.freedesktop.org/series/38045/
State : warning

== Summary ==

Test kms_vblank:
        Subgroup pipe-b-accuracy-idle:
                fail       -> PASS       (shard-snb)
Test kms_plane:
        Subgroup plane-panning-bottom-right-suspend-pipe-a-planes:
                skip       -> PASS       (shard-snb) fdo#102365
        Subgroup plane-panning-bottom-right-suspend-pipe-c-planes:
                incomplete -> PASS       (shard-hsw) fdo#103375
Test gem_exec_schedule:
        Subgroup preempt-other-render:
                pass       -> FAIL       (shard-apl) fdo#102848
Test drv_suspend:
        Subgroup forcewake:
                pass       -> SKIP       (shard-snb)
Test kms_cursor_legacy:
        Subgroup flip-vs-cursor-varying-size:
                fail       -> PASS       (shard-hsw) fdo#102670
Test kms_flip:
        Subgroup modeset-vs-vblank-race-interruptible:
                pass       -> DMESG-FAIL (shard-hsw) fdo#103060 +1
Test perf:
        Subgroup enable-disable:
                pass       -> FAIL       (shard-apl) fdo#103715

fdo#102365 https://bugs.freedesktop.org/show_bug.cgi?id=102365
fdo#103375 https://bugs.freedesktop.org/show_bug.cgi?id=103375
fdo#102848 https://bugs.freedesktop.org/show_bug.cgi?id=102848
fdo#102670 https://bugs.freedesktop.org/show_bug.cgi?id=102670
fdo#103060 https://bugs.freedesktop.org/show_bug.cgi?id=103060
fdo#103715 https://bugs.freedesktop.org/show_bug.cgi?id=103715

shard-apl        total:3393 pass:1756 dwarn:1   dfail:0   fail:22  skip:1613 time:12478s
shard-hsw        total:3444 pass:1758 dwarn:1   dfail:1   fail:11  skip:1672 time:11741s
shard-snb        total:3444 pass:1350 dwarn:1   dfail:0   fail:10  skip:2083 time:6664s
Blacklisted hosts:
shard-kbl        total:3444 pass:1916 dwarn:1   dfail:0   fail:21  skip:1506 time:9773s

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_898/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH igt] igt/gem_exec_schedule: Limit smoketest to the desired engines

[Belgaumkar, Vinay]

On 2/10/2018 1:00 AM, Chris Wilson wrote:
> We run the per-engine scheduling smoketests across all engines, the
> opposite of what was intended!
> 
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
>   tests/gem_exec_schedule.c | 12 ++++++++----
>   1 file changed, 8 insertions(+), 4 deletions(-)
> 
> diff --git a/tests/gem_exec_schedule.c b/tests/gem_exec_schedule.c
> index b45ba1670..ec02d9943 100644
> --- a/tests/gem_exec_schedule.c
> +++ b/tests/gem_exec_schedule.c
> @@ -208,11 +208,15 @@ static void smoketest(int fd, unsigned ring, unsigned timeout)
>   	uint32_t *ptr;
>   
>   	nengine = 0;
> -	for_each_engine(fd, engine) {
> -		if (ignore_engine(fd, engine))
> -			continue;
> +	if (ring == -1) {
> +		for_each_engine(fd, engine) {
> +			if (ignore_engine(fd, engine))
> +				continue;
>   
> -		engines[nengine++] = engine;
> +			engines[nengine++] = engine;
> +		}
> +	} else {
> +		engines[nengine++] = ring;
>   	}
>   	igt_require(nengine);

LGTM. However, do we need the random number generation(from 0 to 
nengine) in the following code if a single engine is selected?

Reviewed-by: vinay.belgaumkar@intel.com

>   
> 
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH igt] igt/gem_exec_schedule: Limit smoketest to the desired engines

[Chris Wilson]

Quoting Belgaumkar, Vinay (2018-02-12 18:20:31)
> 
> 
> On 2/10/2018 1:00 AM, Chris Wilson wrote:
> > We run the per-engine scheduling smoketests across all engines, the
> > opposite of what was intended!
> > 
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > ---
> >   tests/gem_exec_schedule.c | 12 ++++++++----
> >   1 file changed, 8 insertions(+), 4 deletions(-)
> > 
> > diff --git a/tests/gem_exec_schedule.c b/tests/gem_exec_schedule.c
> > index b45ba1670..ec02d9943 100644
> > --- a/tests/gem_exec_schedule.c
> > +++ b/tests/gem_exec_schedule.c
> > @@ -208,11 +208,15 @@ static void smoketest(int fd, unsigned ring, unsigned timeout)
> >       uint32_t *ptr;
> >   
> >       nengine = 0;
> > -     for_each_engine(fd, engine) {
> > -             if (ignore_engine(fd, engine))
> > -                     continue;
> > +     if (ring == -1) {
> > +             for_each_engine(fd, engine) {
> > +                     if (ignore_engine(fd, engine))
> > +                             continue;
> >   
> > -             engines[nengine++] = engine;
> > +                     engines[nengine++] = engine;
> > +             }
> > +     } else {
> > +             engines[nengine++] = ring;
> >       }
> >       igt_require(nengine);
> 
> LGTM. However, do we need the random number generation(from 0 to 
> nengine) in the following code if a single engine is selected?

It's just a few instructions, if the bottleneck was in userspace then
yes, removing them would be useful. As it is, the test is an exercise in
struct_mutex contention.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx