* [PATCH] staging: vt6656: Fix "Possible unnecessary 'out of memory' message" checkpatch.pl warning
@ 2018-02-10 16:16 Dileep Sankhla
2018-02-12 7:02 ` Dan Carpenter
0 siblings, 1 reply; 3+ messages in thread
From: Dileep Sankhla @ 2018-02-10 16:16 UTC (permalink / raw)
To: Forest Bond, Greg Kroah-Hartman, Malcolm Priestley,
Arushi Singhal, Simon Sandström, Dileep Sankhla,
Jitendra Kumar Khasdev, devel, linux-kernel
Signed-off-by: Dileep Sankhla <sankhla.dileep96@gmail.com>
---
drivers/staging/vt6656/usbpipe.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/vt6656/usbpipe.c b/drivers/staging/vt6656/usbpipe.c
index 273176386a51..5bbc56f8779e 100644
--- a/drivers/staging/vt6656/usbpipe.c
+++ b/drivers/staging/vt6656/usbpipe.c
@@ -194,9 +194,6 @@ static void vnt_submit_rx_urb_complete(struct urb *urb)
if (vnt_rx_data(priv, rcb, urb->actual_length)) {
rcb->skb = dev_alloc_skb(priv->rx_buf_sz);
if (!rcb->skb) {
- dev_dbg(&priv->usb->dev,
- "Failed to re-alloc rx skb\n");
-
rcb->in_use = false;
return;
}
--
2.15.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: vt6656: Fix "Possible unnecessary 'out of memory' message" checkpatch.pl warning
2018-02-10 16:16 [PATCH] staging: vt6656: Fix "Possible unnecessary 'out of memory' message" checkpatch.pl warning Dileep Sankhla
@ 2018-02-12 7:02 ` Dan Carpenter
2018-02-12 11:34 ` [PATCH v2] staging: vt6656: Remove unnecessary 'out of memory' message Dileep Sankhla
0 siblings, 1 reply; 3+ messages in thread
From: Dan Carpenter @ 2018-02-12 7:02 UTC (permalink / raw)
To: Dileep Sankhla
Cc: Arushi Singhal, devel, Malcolm Priestley, Greg Kroah-Hartman,
linux-kernel, Forest Bond, Simon Sandström,
Jitendra Kumar Khasdev
On Sat, Feb 10, 2018 at 09:46:18PM +0530, Dileep Sankhla wrote:
> Signed-off-by: Dileep Sankhla <sankhla.dileep96@gmail.com>
The subject is too long and you need to have a changelog.
regards,
dan carpenter
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH v2] staging: vt6656: Remove unnecessary 'out of memory' message
2018-02-12 7:02 ` Dan Carpenter
@ 2018-02-12 11:34 ` Dileep Sankhla
0 siblings, 0 replies; 3+ messages in thread
From: Dileep Sankhla @ 2018-02-12 11:34 UTC (permalink / raw)
To: Forest Bond, Greg Kroah-Hartman, Malcolm Priestley,
Jitendra Kumar Khasdev, Dileep Sankhla, Arushi Singhal,
Simon Sandström, devel, linux-kernel
This patch removes the unnecessary out of memory message fixing the
following checkpatch.pl warning in usbpipe.c:
WARNING: Possible unnecessary 'out of memory' message
Signed-off-by: Dileep Sankhla <sankhla.dileep96@gmail.com>
---
Change in v2:
- changed commit message
---
drivers/staging/vt6656/usbpipe.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/vt6656/usbpipe.c b/drivers/staging/vt6656/usbpipe.c
index 273176386a51..5bbc56f8779e 100644
--- a/drivers/staging/vt6656/usbpipe.c
+++ b/drivers/staging/vt6656/usbpipe.c
@@ -194,9 +194,6 @@ static void vnt_submit_rx_urb_complete(struct urb *urb)
if (vnt_rx_data(priv, rcb, urb->actual_length)) {
rcb->skb = dev_alloc_skb(priv->rx_buf_sz);
if (!rcb->skb) {
- dev_dbg(&priv->usb->dev,
- "Failed to re-alloc rx skb\n");
-
rcb->in_use = false;
return;
}
--
2.15.1
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-02-12 11:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-10 16:16 [PATCH] staging: vt6656: Fix "Possible unnecessary 'out of memory' message" checkpatch.pl warning Dileep Sankhla
2018-02-12 7:02 ` Dan Carpenter
2018-02-12 11:34 ` [PATCH v2] staging: vt6656: Remove unnecessary 'out of memory' message Dileep Sankhla
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.